Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
83ddd988
Commit
83ddd988
authored
Apr 10, 2019
by
Sam Rawlins
Committed by
Michael Goderbauer
Apr 10, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix additional @mustCallSuper indirect overrides and mixins (#30667)
parent
49900477
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
12 additions
and
2 deletions
+12
-2
object.dart
packages/flutter/lib/src/rendering/object.dart
+1
-0
view.dart
packages/flutter/lib/src/rendering/view.dart
+1
-0
semantics.dart
packages/flutter/lib/src/semantics/semantics.dart
+1
-0
diagnostics_test.dart
packages/flutter/test/foundation/diagnostics_test.dart
+1
-0
tabs_test.dart
packages/flutter/test/material/tabs_test.dart
+1
-0
painting_utils.dart
packages/flutter/test/painting/painting_utils.dart
+1
-0
list_view_test.dart
packages/flutter/test/widgets/list_view_test.dart
+4
-2
semantics_keep_alive_offstage_test.dart
...tter/test/widgets/semantics_keep_alive_offstage_test.dart
+1
-0
binding.dart
packages/flutter_test/lib/src/binding.dart
+1
-0
No files found.
packages/flutter/lib/src/rendering/object.dart
View file @
83ddd988
...
...
@@ -2663,6 +2663,7 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im
@protected
@override
void
debugFillProperties
(
DiagnosticPropertiesBuilder
properties
)
{
super
.
debugFillProperties
(
properties
);
properties
.
add
(
DiagnosticsProperty
<
dynamic
>(
'creator'
,
debugCreator
,
defaultValue:
null
,
level:
DiagnosticLevel
.
debug
));
properties
.
add
(
DiagnosticsProperty
<
ParentData
>(
'parentData'
,
parentData
,
tooltip:
_debugCanParentUseSize
==
true
?
'can use size'
:
null
,
missingIfNull:
true
));
properties
.
add
(
DiagnosticsProperty
<
Constraints
>(
'constraints'
,
constraints
,
missingIfNull:
true
));
...
...
packages/flutter/lib/src/rendering/view.dart
View file @
83ddd988
...
...
@@ -250,6 +250,7 @@ class RenderView extends RenderObject with RenderObjectWithChildMixin<RenderBox>
}
@override
// ignore: MUST_CALL_SUPER
void
debugFillProperties
(
DiagnosticPropertiesBuilder
properties
)
{
// call to ${super.debugFillProperties(description)} is omitted because the
// root superclasses don't include any interesting information for this
...
...
packages/flutter/lib/src/semantics/semantics.dart
View file @
83ddd988
...
...
@@ -2048,6 +2048,7 @@ class SemanticsNode extends AbstractNode with DiagnosticableTreeMixin {
@override
void
debugFillProperties
(
DiagnosticPropertiesBuilder
properties
)
{
super
.
debugFillProperties
(
properties
);
bool
hideOwner
=
true
;
if
(
_dirty
)
{
final
bool
inDirtyNodes
=
owner
!=
null
&&
owner
.
_dirtyNodes
.
contains
(
this
);
...
...
packages/flutter/test/foundation/diagnostics_test.dart
View file @
83ddd988
...
...
@@ -35,6 +35,7 @@ class TestTree extends Object with DiagnosticableTreeMixin {
@override
void
debugFillProperties
(
DiagnosticPropertiesBuilder
properties
)
{
super
.
debugFillProperties
(
properties
);
if
(
style
!=
null
)
properties
.
defaultDiagnosticsTreeStyle
=
style
;
...
...
packages/flutter/test/material/tabs_test.dart
View file @
83ddd988
...
...
@@ -61,6 +61,7 @@ class AlwaysKeepAliveState extends State<AlwaysKeepAliveWidget>
@override
Widget
build
(
BuildContext
context
)
{
super
.
build
(
context
);
return
Text
(
AlwaysKeepAliveWidget
.
text
);
}
}
...
...
packages/flutter/test/painting/painting_utils.dart
View file @
83ddd988
...
...
@@ -20,6 +20,7 @@ class PaintingBindingSpy extends BindingBase with ServicesBinding, PaintingBindi
}
@override
// ignore: MUST_CALL_SUPER
void
initLicenses
()
{
// Do not include any licenses, because we're a test, and the LICENSE file
// doesn't get generated for tests.
...
...
packages/flutter/test/widgets/list_view_test.dart
View file @
83ddd988
...
...
@@ -35,8 +35,10 @@ class AliveState extends State<Alive> with AutomaticKeepAliveClientMixin {
bool
get
wantKeepAlive
=>
widget
.
alive
;
@override
Widget
build
(
BuildContext
context
)
=>
Text
(
'
${widget.index}
:
$wantKeepAlive
'
);
Widget
build
(
BuildContext
context
)
{
super
.
build
(
context
);
return
Text
(
'
${widget.index}
:
$wantKeepAlive
'
);
}
}
typedef
WhetherToKeepAlive
=
bool
Function
(
int
);
...
...
packages/flutter/test/widgets/semantics_keep_alive_offstage_test.dart
View file @
83ddd988
...
...
@@ -127,6 +127,7 @@ class ProblemWidget extends StatefulWidget {
class
ProblemWidgetState
extends
State
<
ProblemWidget
>
with
AutomaticKeepAliveClientMixin
<
ProblemWidget
>
{
@override
Widget
build
(
BuildContext
context
)
{
super
.
build
(
context
);
Widget
child
=
Semantics
(
container:
true
,
child:
Text
(
widget
.
text
),
...
...
packages/flutter_test/lib/src/binding.dart
View file @
83ddd988
...
...
@@ -168,6 +168,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
}
@override
// ignore: MUST_CALL_SUPER
void
initLicenses
()
{
// Do not include any licenses, because we're a test, and the LICENSE file
// doesn't get generated for tests.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment