https://github.com/flutter/engine/compare/5fbde6c0fc57...8fe8e94c02fc

2023-04-25 jonahwilliams@google.com Revert "[impeller] convert src over to src for solid color" (flutter/engine#41466)
2023-04-24 godofredoc@google.com Remove empty tests properties. (flutter/engine#41461)
2023-04-24 skia-flutter-autoroll@skia.org Roll Skia from 0ec4c84abd0b to 5f4dd36a69f9 (21 revisions) (flutter/engine#41462)
2023-04-24 godofredoc@google.com Reland "Upload windows arm artifacts to production bucket." (flutter/engine#41409)
2023-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from c7042dc03f43 to c3afc3507b4f (1 revision) (flutter/engine#41458)
2023-04-24 54558023+keyonghan@users.noreply.github.com Add 16.2 runtime to Mac unopt (flutter/engine#41456)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EEdHfWcEn3fHwQj46... to gxpKJcSBfY7AuR_Ur... (flutter/engine#41453)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fJ7ysM-O4VYAGeBDc... to 8TJtGsJTpIHk5-Ss5... (flutter/engine#41451)
2023-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from a1c1e0d3bb18 to c7042dc03f43 (2 revisions) (flutter/engine#41452)
2023-04-24 skia-flutter-autoroll@skia.org Roll Skia from 1f84e5060646 to 0ec4c84abd0b (6 revisions) (flutter/engine#41449)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from fJ7ysM-O4VYA to 8TJtGsJTpIHk
  fuchsia/sdk/core/mac-amd64 from EEdHfWcEn3fH to gxpKJcSBfY7A

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This adds a performance test for `Slider` and `RangeSlider` to run on Android.
This is to measure upcoming changes to these widgets and compare their performance. 

https://user-images.githubusercontent.com/48603081/233633349-0bcad3c3-04a9-42dd-acd0-46b76ce51178.mp4

Reimplements what we reverted here: #125233.

Split from https://github.com/flutter/flutter/pull/122664 so it gets easier to review, as this is now unrelated to the `preferRound`. I'm one step from adding a width attribute, lol.

<img width="474" alt="image" src="https://user-images.githubusercontent.com/351125/226083798-71e529e9-4ae9-41de-a500-0412b989a273.png">

cc @Piinks

Types are being reified in the JS backends, so these need to be
addressed. Fixes two issues:

- @staticInterop types need to be casted to JS types
- JS functions need to be cast to JSFunction before conversion

Enables landing of https://dart-review.googlesource.com/c/sdk/+/295105.

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

Fix `OutlinedButton`, `TextButton`, and `IconButton`  throw exception when passing only one cursor to `styleFrom` (#125204)

fixes https://github.com/flutter/flutter/issues/118071

Temporarily remove myself from `TESTOWNER` and reassign to others.  Please let me know if you'd rather not "own" these and I'll find someone else 🙂.  I intend to take these back later.

Plugins -> @stuartmorgan 
iOS-specific tooling -> @vashworth 
Benchmark and app extension test -> @cyanglaz 
iOS artifact checking -> @christopherfujino

Before this change on a quick touch drag the cursor, where the touch is not on the previous collapsed selection, the cursor would move to the tapped position.

After this change on a quick touch drag the cursor does not move unless the touch is on the previously collapsed selection. This is inline with native behavior.

Before|After|Native
--|--|--
<video src="https://user-images.githubusercontent.com/948037/233224775-f33b42b5-5638-416c-9278-39ecd964e3bb.mov" />|<video src="https://user-images.githubusercontent.com/948037/233224760-2d1af657-8d99-45fc-8499-9567f17d533e.mov" />|<video src="https://user-images.githubusercontent.com/948037/233224790-f5997cfa-7370-4891-8952-11ef8057a729.mov" />

https://github.com/flutter/flutter/issues/125425

Related https://github.com/flutter/flutter/issues/100624

The goal is to make sure the engine can send a location string in either the existing format or a complete uri string to the framework, and the framework will still work as usual.

Introduced in https://github.com/flutter/flutter/pull/99564.  Checked with @jonahwilliams and this should not be running in presubmit.

Just a one-word super tiny change, which I encounter today when playing with RawGestureDetector :)

The original doc says:

> For common gestures, use a [GestureRecognizer](https://api.flutter.dev/flutter/gestures/GestureRecognizer-class.html). [RawGestureDetector](https://api.flutter.dev/flutter/widgets/RawGestureDetector-class.html) is useful primarily when developing your own gesture recognizers.

However, for "common gestures", IMHO the doc wants to say `GestureDetector` (because that one has easy-to-use onTap, onLongPress etc). On the other hand, GestureRecognizer should be used together with RawGestureDetector and is a quite low-level thing, and for common gestures people seldom use it. So I guess here it is a typo.

The spell check menu now appears directly below the misspelled word on Android.

https://github.com/flutter/engine/compare/fcf46af2d38c...5fbde6c0fc57

2023-04-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-python from 4.5.0 to 4.6.0 (flutter/engine#41444)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from kZQW1hC63MessR4gl... to EEdHfWcEn3fHwQj46... (flutter/engine#41441)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1RnHwa4NRXqe4iS6H... to fJ7ysM-O4VYAGeBDc... (flutter/engine#41440)
2023-04-23 skia-flutter-autoroll@skia.org Roll Skia from b9c90858cdd8 to 1f84e5060646 (1 revision) (flutter/engine#41432)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 1RnHwa4NRXqe to fJ7ysM-O4VYA
  fuchsia/sdk/core/mac-amd64 from kZQW1hC63Mes to EEdHfWcEn3fH

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Updates the cherry-pick template to add @itsjustkevin as primary and
@CaseyHillers as secondary assignees to all cherry-pick requests.

https://github.com/flutter/engine/compare/0e329d5e2196...fcf46af2d38c

2023-04-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from KWUhrqWF9DaVpikxZ... to kZQW1hC63MessR4gl... (flutter/engine#41430)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from KWUhrqWF9DaV to kZQW1hC63Mes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/f364492e2010...0e329d5e2196

2023-04-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from I9z-K7N5PdhXN-5SG... to 1RnHwa4NRXqe4iS6H... (flutter/engine#41428)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from I9z-K7N5PdhX to 1RnHwa4NRXqe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/b6749106a482...f364492e2010

2023-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from fd4797c1464b to a1c1e0d3bb18 (1 revision) (flutter/engine#41427)
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qLDaxNMysjqL-IcPn... to KWUhrqWF9DaVpikxZ... (flutter/engine#41426)
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RdOaZ2-aDsn_64hk5... to I9z-K7N5PdhXN-5SG... (flutter/engine#41424)
2023-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from be6db2b60a41 to fd4797c1464b (2 revisions) (flutter/engine#41422)
2023-04-22 skia-flutter-autoroll@skia.org Roll Skia from 9912500bcca3 to b9c90858cdd8 (2 revisions) (flutter/engine#41421)
2023-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from b6de2d42e58d to be6db2b60a41 (2 revisions) (flutter/engine#41416)
2023-04-22 skia-flutter-autoroll@skia.org Roll Skia from 36a6690cd1f1 to 9912500bcca3 (2 revisions) (flutter/engine#41415)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from RdOaZ2-aDsn_ to I9z-K7N5PdhX
  fuchsia/sdk/core/mac-amd64 from qLDaxNMysjqL to KWUhrqWF9DaV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://github.com/flutter/engine/compare/d96a09559ebf...b6749106a482

2023-04-22 skia-flutter-autoroll@skia.org Roll Skia from aa592c60846d to 36a6690cd1f1 (11 revisions) (flutter/engine#41413)
2023-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fMOcI5zn1z0nOrV7s... to qLDaxNMysjqL-IcPn... (flutter/engine#41412)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from fMOcI5zn1z0n to qLDaxNMysjqL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes https://github.com/flutter/flutter/issues/119919

<details>
<summary>Preview</summary>

![image](https://user-images.githubusercontent.com/50555895/232455733-2c2cba5e-6a35-4e4a-b911-e0ef80746905.png)

</details>

Include rects with any overlap instead of only when top-left or bottom-right included. The previous criteria didn't send any selection rects when text was taller than the text box and scroll offset was not zero.

Part of #30476

The latest version of `test_api` removed the deprecated annotation for a couple libraries. The deprecations had been a hack to avoid usage from inappropriate places, but they cause trouble and likely weren't effective for that goal.

Remove separate import for `registerException` since that was also moved to be available from the top level `scaffolding.dart` library.

https://github.com/flutter/engine/compare/462e9bbb8469...d96a09559ebf

2023-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Edv0I0o8GQ7c0z8XK... to RdOaZ2-aDsn_64hk5... (flutter/engine#41407)
2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from fabaeef00dfb to b6de2d42e58d (2 revisions) (flutter/engine#41401)
2023-04-21 jason-simmons@users.noreply.github.com [Impeller] Add a CommandBuffer::WaitUntilScheduled API (flutter/engine#41303)
2023-04-21 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned off the TextRotated golden test again (flutter/engine#41399)
2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from 5754b81988b8 to aa592c60846d (11 revisions) (flutter/engine#41398)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Edv0I0o8GQ7c to RdOaZ2-aDsn_

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Addresses part of https://github.com/flutter/flutter/issues/125164

Visual fidelity of the right-click context menu on MacOS.

fixes https://github.com/flutter/flutter/issues/99360

`flutter_tool_startup__windows/linux/macos` were identical. Use the same task for all three.

Remove self from `CODEOWNERS` file for `flutter_tools`. Now that we have the PR cocoon labeler the tools team should see any PRs that change these files, and tag the right people to review.

Also remove ownership of the `CODEOWNERS` file itself.

Remove myself as a the CocoaPods gem [dependabot](https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/) reviewer and add @christopherfujino and @vashworth instead for Ruby gem bumps:
https://github.com/flutter/flutter/blob/3a436f47f5fe58fbe2a212717754a7992bbd60f5/dev/ci/mac/Gemfile

This is low traffic (one review every few months): https://github.com/flutter/flutter/pulls?q=is%3Apr+dependabot+cocoapods+is%3Aclosed

Note the last minor version was ignored https://github.com/flutter/flutter/pull/122051 due to https://github.com/flutter/flutter/issues/122057.

We have pretty good plugins/CocoaPods test coverage, so if that infra issue were fixed we should feel pretty safe about bumping this if all the tests pass.

Will fix transient network failures as in: https://github.com/flutter/flutter/issues/125108#issuecomment-1516519929

In the specific implementation, the Divider uses the "space" field as the height for horizontal dividers, and the "space" field as the width for VerticalDivider , which is different from the documentation description.

https://github.com/flutter/engine/compare/dd67063fc921...462e9bbb8469

2023-04-21 30870216+gaaclarke@users.noreply.github.com [impeller] fixed flake where blit wasn't tracking its texture (flutter/engine#41347)
2023-04-21 121665385+andoriyaprashant@users.noreply.github.com removing the check_gn_format.py file from ci/  (flutter/engine#41397)
2023-04-21 ditman@gmail.com [web] Fix HashUrlStrategy.addPopStateListener (flutter/engine#41384)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description

Adding some see also links to connect `defaultTargetPlatform` and `kIsWeb` docs.

https://github.com/flutter/engine/compare/3f7e12b8e656...dd67063fc921

2023-04-21 bdero@google.com [Impeller] Fix division by zero for transparent shadows (flutter/engine#41391)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

iOS now hides the selection handles and shows red selection when tapping a misspelled word, like native.

https://github.com/flutter/engine/compare/a7899c45791c...3f7e12b8e656

2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from fbfed7c82918 to 5754b81988b8 (1 revision) (flutter/engine#41395)
2023-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 4cc2e637a315 to fabaeef00dfb (1 revision) (flutter/engine#41394)
2023-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PqBDstaESE_l77k1e... to Edv0I0o8GQ7c0z8XK... (flutter/engine#41393)
2023-04-21 bdero@google.com [Impeller] Fix SupportsReadFromOnscreenTexture capability check (flutter/engine#41386)
2023-04-21 bdero@google.com [Impeller] Always use BGRA10_XR for wide gamut (flutter/engine#41385)
2023-04-21 skia-flutter-autoroll@skia.org Roll Skia from 90a93bb0990f to fbfed7c82918 (2 revisions) (flutter/engine#41392)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from PqBDstaESE_l to Edv0I0o8GQ7c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md