Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7d9f2082
Unverified
Commit
7d9f2082
authored
Apr 24, 2023
by
Kevin Moore
Committed by
GitHub
Apr 24, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
tool: Move cdKey to CustomDimensionsEnum (#125335)
parent
9e9ac77d
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
71 additions
and
68 deletions
+71
-68
custom_dimensions.dart
...es/flutter_tools/lib/src/reporting/custom_dimensions.dart
+66
-63
usage.dart
packages/flutter_tools/lib/src/reporting/usage.dart
+3
-3
analytics_test.dart
...ages/flutter_tools/test/general.shard/analytics_test.dart
+2
-2
No files found.
packages/flutter_tools/lib/src/reporting/custom_dimensions.dart
View file @
7d9f2082
This diff is collapsed.
Click to expand it.
packages/flutter_tools/lib/src/reporting/usage.dart
View file @
7d9f2082
...
...
@@ -192,12 +192,12 @@ class _DefaultUsage implements Usage {
if
(!
skipAnalyticsSessionSetup
)
{
// Report a more detailed OS version string than package:usage does by default.
analytics
.
setSessionValue
(
cdKey
(
CustomDimensionsEnum
.
sessionHostOsDetails
)
,
CustomDimensionsEnum
.
sessionHostOsDetails
.
cdKey
,
globals
.
os
.
name
,
);
// Send the branch name as the "channel".
analytics
.
setSessionValue
(
cdKey
(
CustomDimensionsEnum
.
sessionChannelName
)
,
CustomDimensionsEnum
.
sessionChannelName
.
cdKey
,
flutterVersion
.
getBranchName
(
redactUnknownBranches:
true
),
);
// For each flutter experimental feature, record a session value in a comma
...
...
@@ -210,7 +210,7 @@ class _DefaultUsage implements Usage {
.
map
((
Feature
feature
)
=>
feature
.
configSetting
)
.
join
(
','
);
analytics
.
setSessionValue
(
cdKey
(
CustomDimensionsEnum
.
enabledFlutterFeatures
)
,
CustomDimensionsEnum
.
enabledFlutterFeatures
.
cdKey
,
enabledFeatures
,
);
...
...
packages/flutter_tools/test/general.shard/analytics_test.dart
View file @
7d9f2082
...
...
@@ -114,7 +114,7 @@ void main() {
final
Usage
usage
=
Usage
(
runningOnBot:
true
);
usage
.
sendCommand
(
'test'
);
final
String
featuresKey
=
cdKey
(
CustomDimensionsEnum
.
enabledFlutterFeatures
)
;
final
String
featuresKey
=
CustomDimensionsEnum
.
enabledFlutterFeatures
.
cdKey
;
expect
(
globals
.
fs
.
file
(
'test'
).
readAsStringSync
(),
contains
(
'
$featuresKey
: enable-web'
));
},
overrides:
<
Type
,
Generator
>{
...
...
@@ -134,7 +134,7 @@ void main() {
final
Usage
usage
=
Usage
(
runningOnBot:
true
);
usage
.
sendCommand
(
'test'
);
final
String
featuresKey
=
cdKey
(
CustomDimensionsEnum
.
enabledFlutterFeatures
)
;
final
String
featuresKey
=
CustomDimensionsEnum
.
enabledFlutterFeatures
.
cdKey
;
expect
(
globals
.
fs
.
file
(
'test'
).
readAsStringSync
(),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment