Unverified Commit 7d9f2082 authored by Kevin Moore's avatar Kevin Moore Committed by GitHub

tool: Move cdKey to CustomDimensionsEnum (#125335)

parent 9e9ac77d
...@@ -192,12 +192,12 @@ class _DefaultUsage implements Usage { ...@@ -192,12 +192,12 @@ class _DefaultUsage implements Usage {
if (!skipAnalyticsSessionSetup) { if (!skipAnalyticsSessionSetup) {
// Report a more detailed OS version string than package:usage does by default. // Report a more detailed OS version string than package:usage does by default.
analytics.setSessionValue( analytics.setSessionValue(
cdKey(CustomDimensionsEnum.sessionHostOsDetails), CustomDimensionsEnum.sessionHostOsDetails.cdKey,
globals.os.name, globals.os.name,
); );
// Send the branch name as the "channel". // Send the branch name as the "channel".
analytics.setSessionValue( analytics.setSessionValue(
cdKey(CustomDimensionsEnum.sessionChannelName), CustomDimensionsEnum.sessionChannelName.cdKey,
flutterVersion.getBranchName(redactUnknownBranches: true), flutterVersion.getBranchName(redactUnknownBranches: true),
); );
// For each flutter experimental feature, record a session value in a comma // For each flutter experimental feature, record a session value in a comma
...@@ -210,7 +210,7 @@ class _DefaultUsage implements Usage { ...@@ -210,7 +210,7 @@ class _DefaultUsage implements Usage {
.map((Feature feature) => feature.configSetting) .map((Feature feature) => feature.configSetting)
.join(','); .join(',');
analytics.setSessionValue( analytics.setSessionValue(
cdKey(CustomDimensionsEnum.enabledFlutterFeatures), CustomDimensionsEnum.enabledFlutterFeatures.cdKey,
enabledFeatures, enabledFeatures,
); );
......
...@@ -114,7 +114,7 @@ void main() { ...@@ -114,7 +114,7 @@ void main() {
final Usage usage = Usage(runningOnBot: true); final Usage usage = Usage(runningOnBot: true);
usage.sendCommand('test'); usage.sendCommand('test');
final String featuresKey = cdKey(CustomDimensionsEnum.enabledFlutterFeatures); final String featuresKey = CustomDimensionsEnum.enabledFlutterFeatures.cdKey;
expect(globals.fs.file('test').readAsStringSync(), contains('$featuresKey: enable-web')); expect(globals.fs.file('test').readAsStringSync(), contains('$featuresKey: enable-web'));
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
...@@ -134,7 +134,7 @@ void main() { ...@@ -134,7 +134,7 @@ void main() {
final Usage usage = Usage(runningOnBot: true); final Usage usage = Usage(runningOnBot: true);
usage.sendCommand('test'); usage.sendCommand('test');
final String featuresKey = cdKey(CustomDimensionsEnum.enabledFlutterFeatures); final String featuresKey = CustomDimensionsEnum.enabledFlutterFeatures.cdKey;
expect( expect(
globals.fs.file('test').readAsStringSync(), globals.fs.file('test').readAsStringSync(),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment