- 25 Jan, 2024 1 commit
-
-
Nate authored
Refactors code to use the new `switch` expressions.
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries. Each of them only had a few, so I lumped them together. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 17 Aug, 2023 1 commit
-
-
LouiseHsu authored
In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc. https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765 This PR is the framework portion of the changes that will allow Share to be implemented. The corresponding merged engine PR is [here](https://github.com/flutter/engine/pull/44554) This PR addresses https://github.com/flutter/flutter/issues/107578 More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls)
-
- 08 Aug, 2023 1 commit
-
-
LouiseHsu authored
This PR adds framework support for the Search Web feature in iOS. https://github.com/flutter/flutter/assets/36148254/c159f0d9-8f14-45e7-b295-e065b0826fab The corresponding merged engine PR can be found [here](https://github.com/flutter/engine/pull/43324). This PR addresses https://github.com/flutter/flutter/issues/82907 More details are available in this [design doc](https://docs.google.com/document/d/1QizXwBiO-2REIcEovl5pK06BaLPOWYmNwOE5jactJZA/edit?resourcekey=0-1pb9mJiAq29Gesmt25GAug)
-
- 02 Aug, 2023 1 commit
-
-
LouiseHsu authored
This PR adds framework support for the Look Up feature in iOS. https://github.com/flutter/flutter/assets/36148254/d301df79-4e23-454f-8742-2f8e39c2960c The corresponding merged engine PR can be found [here](https://github.com/flutter/engine/pull/43308). This PR addresses https://github.com/flutter/flutter/issues/82907 More details are available in this [design doc.](flutter.dev/go/add-missing-features-to-selection-controls) This is the same PR as https://github.com/flutter/flutter/pull/130532, this is an attempt to fix the Google Testing issue
-
- 06 Jul, 2023 1 commit
-
-
luckysmg authored
iOS OCR keyboard input support.
-
- 27 Jun, 2023 1 commit
-
-
Luccas Clezar authored
CupertinoTextSelectionToolbar is different from the native one, with some UI and UX issues. More details on the linked issue. https://github.com/flutter/flutter/issues/127756 Currently the only problem that I listed on the linked issue that I couldn't fix was the horizontal scrolling, but to workaround this I added a GestureDetector to change pages when swiping the toolbar. It's not exactly the same as native as there is no scroll animation, but it works. I'm creating this PR a little early to have some feedback as these changes were more complex than the ones in my last PR. Probably best if @justinmc is involved ð |Version|Video| |-|-| |Flutter Old|<video src="https://github.com/flutter/flutter/assets/12024080/7cf81075-46ec-4970-b118-cc27b60ddac0"></video>| |Flutter New|<video src="https://github.com/flutter/flutter/assets/12024080/c9e27a53-f94c-4cb0-9b76-e47b73841dcb"></video>| |Native|<video src="https://github.com/flutter/flutter/assets/12024080/468c7d5b-ba93-4bd4-8f6e-8ec2644b9866"></video>|
-
- 21 Apr, 2023 1 commit
-
-
Luccas Clezar authored
Visual fidelity of the right-click context menu on MacOS.
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 22 Dec, 2022 1 commit
-
-
Justin McCandless authored
Updates the iOS text selection toolbar to look like iOS 16 (reland)
-
- 20 Dec, 2022 1 commit
-
-
Camille Simon authored
* Add spell check suggestions toolbar * Fix test and move menu * Cleanup * Cleanup and fix bug * More cleanup * Make height dynamic and use localized delete * Begin adding tests * Create var checking for results * Add tests * Fix analyze (sorta) * Add back hideToolbar call for testing * Add back hidetoolbar in ts and delete one in et * Remove unecessary calls to hidToolbar * Fix analyze and docs * Test fix * Fix container issue * Clean up * Fix analyze * Move delegate * Fix typos * Start addressing review * Continue addressing review * Add assert * Some refactoring * Add test for button behavior * Undo test change * Make spell check results public * Rearrange test * Add comment * Address review * Finish addressing review * remove unused imports * Address nits * Address review * Fix formatting * Refactor findsuggestionspanatcursorindex and textselectiontoolbar constraints * Fix analyze:
-
- 01 Dec, 2022 1 commit
-
-
Justin McCandless authored
This reverts commit 1cb16a1e.
-
- 29 Nov, 2022 1 commit
-
-
Justin McCandless authored
Updates the text selection toolbar on iOS light mode to match changes in native iOS 16.
-
- 28 Oct, 2022 1 commit
-
-
Justin McCandless authored
* Can show context menus anywhere in the app, not just on text. * Unifies all desktop/mobile context menus to go through one class (ContextMenuController). * All context menus are now just plain widgets that can be fully customized. * Existing default context menus can be customized and reused.
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 20 Jan, 2021 1 commit
-
-
Justin McCandless authored
A very minimal right-click menu for Mac desktop.
-
- 13 Jan, 2021 1 commit
-
-
Justin McCandless authored
* Making a custom iOS-style text selection menu is now much easier. * Exposes a new widget for the toolbar, a new widget for the buttons, and a new widget for the layout.
-