1. 25 Jan, 2024 1 commit
  2. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must not be null' comments from various libraries. (#134984) · 8cda3bea
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the animation, cupertino, foundation, gestures, semantics, and services libraries.  Each of them only had a few, so I lumped them together.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134991
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      8cda3bea
  3. 17 Aug, 2023 1 commit
  4. 08 Aug, 2023 1 commit
  5. 02 Aug, 2023 1 commit
  6. 06 Jul, 2023 1 commit
  7. 27 Jun, 2023 1 commit
  8. 21 Apr, 2023 1 commit
  9. 24 Jan, 2023 1 commit
  10. 22 Dec, 2022 1 commit
  11. 20 Dec, 2022 1 commit
    • Camille Simon's avatar
      [Android] Add spell check suggestions toolbar (#114460) · e0742ebb
      Camille Simon authored
      * Add spell check suggestions toolbar
      
      * Fix test and move menu
      
      * Cleanup
      
      * Cleanup and fix bug
      
      * More cleanup
      
      * Make height dynamic and use localized delete
      
      * Begin adding tests
      
      * Create var checking for results
      
      * Add tests
      
      * Fix analyze (sorta)
      
      * Add back hideToolbar call for testing
      
      * Add back hidetoolbar in ts and delete one in et
      
      * Remove unecessary calls to hidToolbar
      
      * Fix analyze and docs
      
      * Test fix
      
      * Fix container issue
      
      * Clean up
      
      * Fix analyze
      
      * Move delegate
      
      * Fix typos
      
      * Start addressing review
      
      * Continue addressing review
      
      * Add assert
      
      * Some refactoring
      
      * Add test for button behavior
      
      * Undo test change
      
      * Make spell check results public
      
      * Rearrange test
      
      * Add comment
      
      * Address review
      
      * Finish addressing review
      
      * remove unused imports
      
      * Address nits
      
      * Address review
      
      * Fix formatting
      
      * Refactor findsuggestionspanatcursorindex and textselectiontoolbar constraints
      
      * Fix analyze:
      e0742ebb
  12. 01 Dec, 2022 1 commit
  13. 29 Nov, 2022 1 commit
  14. 28 Oct, 2022 1 commit
    • Justin McCandless's avatar
      Context Menus (#107193) · 0b451b6d
      Justin McCandless authored
      * Can show context menus anywhere in the app, not just on text.
      * Unifies all desktop/mobile context menus to go through one class (ContextMenuController).
      * All context menus are now just plain widgets that can be fully customized.
      * Existing default context menus can be customized and reused.
      0b451b6d
  15. 14 Apr, 2022 1 commit
  16. 20 Jan, 2021 1 commit
  17. 13 Jan, 2021 1 commit