Commits · d0287cc1c03bec0381c54c24c609355deec82af8 · abdullh.alsoleman / Front-End

07 Mar, 2024 16 commits

Marks Mac_x64 module_test_ios to be flaky (#144681) · d0287cc1

Flutter GitHub Bot authored Mar 07, 2024

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_x64 module_test_ios"
}
-->
Issue link: https://github.com/flutter/flutter/issues/144680

d0287cc1

[flutter_tools] add custom tool analysis to analyze.dart, lint Future.catchError (#140122) · 2dd06d10

Christopher Fujino authored Mar 07, 2024

Ensure tool code does not use Future.catchError or Future.onError, because it is not statically safe: https://github.com/dart-lang/sdk/issues/51248.

This was proposed upstream in dart-lang/linter in https://github.com/dart-lang/linter/issues/4071 and https://github.com/dart-lang/linter/pull/4068, but not accepted.

2dd06d10

Roll Flutter Engine from f8c3b2db8cd1 to 12828950890a (1 revision) (#144775) · 2ea5ca03

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/f8c3b2db8cd1...12828950890a

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from bf028d05b7fd to bbf21a08a92d (1 revision) (flutter/engine#51254)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ea5ca03

[flutter_test] Use defaultTargetPlatform for key events simulation (#143579) · 471a8285

Bruno Leroux authored Mar 07, 2024

## Description

This PRs changes the default value for the `platform` parameter used to simulate key events.

With this PR, the default value is "web" on web, otherwise it is the operating system name retrieved from `defaultTargetPlatform`.

Previously, for methods in `WidgetController`, it defaulted to âwebâ on web, and âandroidâ everywhere else. And for methods in `KeyEventSimulator` it defaulted to âwebâ on web, and the operating system that the test was running on everywhere else. Because the operating system was based on `Platform.operatingSystem`, it usually differed from the target platform the test was running on.

AFAIK, the `platform` parameter is only meaningful for simulating `RawKeyEvent`. Once `RawKeyboard` will be fully removed, the `platform` parameter wonât be needed. 
@gspencergoog  In the meantime, do you think it is worth merging this fix?

## Related Issue

Fixes to https://github.com/flutter/flutter/issues/133955

## Tests

Adds one test.

471a8285

Roll Packages from 9b88dbc53992 to 6701c9e61804 (3 revisions) (#144772) · 4e63a6a2

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/packages/compare/9b88dbc53992...6701c9e61804

2024-03-06 tugorez@users.noreply.github.com [rfw] Add support for widget builders (flutter/packages#5907)
2024-03-06 gabriel@terwesten.net [in_app_purchase_storekit] Handle translation of errors nested in dictionaries (flutter/packages#6277)
2024-03-06 engine-flutter-autoroll@skia.org Roll Flutter from 3b5a2ecf to 8f84f3f3 (18 revisions) (flutter/packages#6276)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4e63a6a2

Fix frameworks added to bundle multiple times instead of lipo (#144688) · de728320

Matej Knopp authored Mar 07, 2024

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

de728320

Roll Flutter Engine from 40a42796b129 to f8c3b2db8cd1 (1 revision) (#144766) · 4d446622

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/40a42796b129...f8c3b2db8cd1

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 3538739eeea9 to bf028d05b7fd (1 revision) (flutter/engine#51252)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d446622

Roll Flutter Engine from 0246484d2bae to 40a42796b129 (1 revision) (#144765) · 3aa89b39

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/0246484d2bae...40a42796b129

2024-03-07 kustermann@google.com Make @keepToString annotation work for web and non-web (flutter/engine#51251)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3aa89b39

Roll Flutter Engine from 6c1751bd774e to 0246484d2bae (1 revision) (#144756) · 4d3e26fa

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/6c1751bd774e...0246484d2bae

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 2cdf8f23c55f to 3538739eeea9 (1 revision) (flutter/engine#51249)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4d3e26fa

[flutter_test] Change KeyEventSimulator default transit mode (#143847) · 8ade81fb

Bruno Leroux authored Mar 07, 2024

## Description

This PRs changes the default value transit mode for key event simulation.

The default transit mode for key event simulation is currently `KeyDataTransitMode.rawKeyData` while on the framework side `KeyDataTransitMode.keyDataThenRawKeyData` is the preferred transit mode.

`KeyDataTransitMode.keyDataThenRawKeyData` is more accurate and can help detect issues.

For instance the following test will fail with `KeyDataTransitMode.rawKeyData` because raw keyboard logic for modifier keys is less accurate:

```dart
  testWidgets('Press control left once', (WidgetTester tester) async {
    debugKeyEventSimulatorTransitModeOverride = KeyDataTransitMode.keyDataThenRawKeyData;

    final List<KeyEvent> events = <KeyEvent>[];
    final FocusNode focusNode = FocusNode();
    addTearDown(focusNode.dispose);

    await tester.pumpWidget(
      Focus(
        focusNode: focusNode,
        autofocus: true,
        onKeyEvent: (_, KeyEvent event) {
          events.add(event);
          return KeyEventResult.handled;
        },
        child: Container(),
      ),
    );

    await simulateKeyDownEvent(LogicalKeyboardKey.controlLeft);

    // This will fail when transit mode is KeyDataTransitMode.rawKeyData
    // because a down event for controlRight is synthesized.
    expect(events.length, 1);

    debugKeyEventSimulatorTransitModeOverride = null;
  });
```

And the following this test is ok with `KeyDataTransitMode.rawKeyData` but rightly fails with `KeyDataTransitMode.keyDataThenRawKeyData`:

```dart
  testWidgets('Simulates consecutive key down events', (WidgetTester tester) async {
    debugKeyEventSimulatorTransitModeOverride = KeyDataTransitMode.rawKeyData;

    // Simulating several key down events without key up in between is tolerated
    // when transit mode is KeyDataTransitMode.rawKeyData, it will trigger an
    // assert on KeyDataTransitMode.keyDataThenRawKeyData.
    await simulateKeyDownEvent(LogicalKeyboardKey.arrowDown);
    await simulateKeyDownEvent(LogicalKeyboardKey.arrowDown);

    debugKeyEventSimulatorTransitModeOverride = null;
  });
```

## Related Issue

Related to https://github.com/flutter/flutter/issues/143845

## Tests

Adds two tests.

8ade81fb

Roll Flutter Engine from 03ebd6460b83 to 6c1751bd774e (2 revisions) (#144747) · f6770276

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/03ebd6460b83...6c1751bd774e

2024-03-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 3ad64881a209 to 2cdf8f23c55f (2 revisions) (flutter/engine#51247)
2024-03-07 dkwingsmt@users.noreply.github.com Reland 5: Multiview pipeline (flutter/engine#51186)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6770276

Roll Flutter Engine from 8a859c5b3a2d to 03ebd6460b83 (2 revisions) (#144746) · 95bf597a

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/8a859c5b3a2d...03ebd6460b83

2024-03-07 jonahwilliams@google.com [Impeller] add a per-frame trace event for heap usage on Vulkan. (flutter/engine#51246)
2024-03-07 chris@bracken.jp Move Abseil from src to flutter third_party dir (flutter/engine#51245)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

95bf597a

Roll Flutter Engine from 4f6ea31d1f25 to 8a859c5b3a2d (2 revisions) (#144743) · 894620b8

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/4f6ea31d1f25...8a859c5b3a2d

2024-03-07 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 9ea8813ab4d4 to 3ad64881a209 (5 revisions) (flutter/engine#51242)
2024-03-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] disable blending in gaussian intermediate steps. (#51118)" (flutter/engine#51244)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

894620b8

Fix memory leak in `editable_gesture_test.dart` (#144691) · 96dd1984
Valentin Vignal authored Mar 07, 2024

96dd1984

Roll Flutter Engine from 53ddbdfc24e5 to 4f6ea31d1f25 (2 revisions) (#144741) · 3e63c738

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/53ddbdfc24e5...4f6ea31d1f25

2024-03-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] fold memory check into allocator_vk (#51187)" (flutter/engine#51243)
2024-03-06 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 50464546d92d to 9ea8813ab4d4 (5 revisions) (flutter/engine#51239)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e63c738

Roll Flutter Engine from b2adf7471d3d to 53ddbdfc24e5 (1 revision) (#144735) · 4413f5bc

engine-flutter-autoroll authored Mar 07, 2024

https://github.com/flutter/engine/compare/b2adf7471d3d...53ddbdfc24e5

2024-03-06 jesus_sguerrero@hotmail.com Skip impeller goldens on release branches (flutter/engine#51237)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4413f5bc

06 Mar, 2024 20 commits

Roll Flutter Engine from 31bbe61dfa0d to b2adf7471d3d (1 revision) (#144732) · 1cbabd71

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/31bbe61dfa0d...b2adf7471d3d

2024-03-06 737941+loic-sharma@users.noreply.github.com [Windows] Allow plugins to get views (flutter/engine#51096)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1cbabd71

Roll Flutter Engine from 5bbac1a5c576 to 31bbe61dfa0d (3 revisions) (#144724) · 052eb521

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/5bbac1a5c576...31bbe61dfa0d

2024-03-06 flar@google.com add new builder benchmark with a global saveLayer (flutter/engine#51236)
2024-03-06 bdero@google.com [Flutter GPU] Move method tests to flutter_tester. (flutter/engine#51223)
2024-03-06 zanderso@users.noreply.github.com Disable flaky linux desktop test (flutter/engine#51231)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

052eb521

Run macOS test on `dev/integration_tests/ui` (#142735) · aedce673
Jenn Magder authored Mar 06, 2024
```
https://github.com/flutter/flutter/issues/87508 is complete, swap integration_test and remove TODO.
```
aedce673
Use wasm-compatible conditional import in timeline.dart, avoid emitting... · aba7bc3f
Martin Kustermann authored Mar 06, 2024
```
Use wasm-compatible conditional import in timeline.dart, avoid emitting timeline events in SchedulerBinding (#144682)
```
aba7bc3f

Roll Flutter Engine from 44405aedba13 to 5bbac1a5c576 (2 revisions) (#144714) · 7a88767a

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/44405aedba13...5bbac1a5c576

2024-03-06 jonahwilliams@google.com [Impeller] fold memory check into allocator_vk (flutter/engine#51187)
2024-03-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ujOkbeYbrC8loPbfR... to y67DIBX84h7pAekIp... (flutter/engine#51233)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ujOkbeYbrC8l to y67DIBX84h7p

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7a88767a

Bring back firebase tests to prod (#144703) · bc867ec7
keyonghan authored Mar 06, 2024
```
Context: https://github.com/flutter/flutter/issues/144183
```
bc867ec7

Roll Flutter Engine from 20037e385bda to 44405aedba13 (3 revisions) (#144710) · f7aade93

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/20037e385bda...44405aedba13

2024-03-06 bdero@google.com [Impeller] Append fewer redundant points when bridging triangle strips between contours. (flutter/engine#51232)
2024-03-06 jason-simmons@users.noreply.github.com [Impeller] Apply padding for alignment when doing HostBuffer::Emplace with a callback (flutter/engine#51221)
2024-03-06 jason-simmons@users.noreply.github.com [Impeller] Create a new render target with the specified attachment configs when reusing cached render target textures (flutter/engine#51208)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f7aade93

Fix code sample failing in smoke test (#144709) · 9e46c67e

Michael Goderbauer authored Mar 06, 2024

This fixes the silent failure reported in https://github.com/flutter/flutter/issues/144353. I am experimenting in https://github.com/flutter/flutter/pull/144706 with whether the failure should have been non-silent.

9e46c67e

Remove deprecated `errorColor` from `ThemeData` (#144078) · f38c5ad4

Qun Cheng authored Mar 06, 2024

This PR is to remove deprecated `ThemeData.errorColor`.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162.
Part of https://github.com/flutter/flutter/issues/143956

f38c5ad4

make DevFSContent descendants immutable (#144664) · cc33f44e

Andrew Kolos authored Mar 06, 2024

`DevFSBytesContent` (and it's descendant `DevFSStringContent`) have setters that change the underlying content. These are unused outside of tests, so this PR removes them. Amongst other things, this could help me refactor https://github.com/flutter/flutter/pull/144660 into something that has fewer pitfalls.

This is purely a refactoring.

cc33f44e

[Impeller] measure GPU memory usage. (#144575) · 2ebd7f0d

Jonah Williams authored Mar 06, 2024

Framework side to https://github.com/flutter/engine/pull/51187

Part of https://github.com/flutter/flutter/issues/144617

2ebd7f0d

Roll Flutter Engine from 9aad0e93899b to 20037e385bda (1 revision) (#144707) · 0df2200b

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/9aad0e93899b...20037e385bda

2024-03-06 matanlurey@users.noreply.github.com Re-stamp skia_gold_client e2e tests. (flutter/engine#51220)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0df2200b

Roll Flutter Engine from b6efe0dd88fe to 9aad0e93899b (2 revisions) (#144702) · 6cda972c

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/b6efe0dd88fe...9aad0e93899b

2024-03-06 737941+loic-sharma@users.noreply.github.com [et] Allow users to update dependencies (flutter/engine#51177)
2024-03-06 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 728fcf0bcbca to 50464546d92d (5 revisions) (flutter/engine#51228)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cda972c

Update android templates to use target sdk 34 (#144641) · 9973771c

Gray Mackall authored Mar 06, 2024

We should always target the newest, and 34 is the newest. This isn't a requirement yet (like it is for 33+) but presumably it will be made required in the nearish future.

9973771c

Roll Packages from 2aa6e3f6bafe to 9b88dbc53992 (8 revisions) (#144693) · 8f84f3f3

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/packages/compare/2aa6e3f6bafe...9b88dbc53992

2024-03-06 balvindersi2@gmail.com [image_picker_for_web] migrates to package:web (flutter/packages#5799)
2024-03-06 balvindersi2@gmail.com [video_player_web] migrates to package:web (flutter/packages#5800)
2024-03-06 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20240205 to 20240303 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6253)
2024-03-05 ian@hixie.ch [rfw] Change test coverage logic to enforce 100% coverage (flutter/packages#6272)
2024-03-05 louisehsu@google.com [in_app_purchase_storekit] backfill native tests for more complete test coverage (flutter/packages#6209)
2024-03-05 stuartmorgan@google.com [tool] Add features to support GCB auto-publish flow (flutter/packages#6218)
2024-03-05 ditman@gmail.com [web] Use TrustedTypes from pkg web. (flutter/packages#6273)
2024-03-05 engine-flutter-autoroll@skia.org Roll Flutter from 65cd84b5 to 3b5a2ecf (26 revisions) (flutter/packages#6269)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8f84f3f3

Roll Flutter Engine from 370e7d5866d9 to b6efe0dd88fe (1 revision) (#144668) · d0c8ad28

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/370e7d5866d9...b6efe0dd88fe

2024-03-06 skia-flutter-autoroll@skia.org Roll Skia from db3a36120ae2 to f17ec7494469 (3 revisions) (flutter/engine#51226)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d0c8ad28

Roll Flutter Engine from d374c78bcf52 to 370e7d5866d9 (1 revision) (#144661) · e1013f26

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/d374c78bcf52...370e7d5866d9

2024-03-06 skia-flutter-autoroll@skia.org Roll Skia from 1d1fd7fe1a89 to db3a36120ae2 (1 revision) (flutter/engine#51222)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1013f26

Roll Flutter Engine from effcf97a1f7c to d374c78bcf52 (5 revisions) (#144659) · 2ab00ee6

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/effcf97a1f7c...d374c78bcf52

2024-03-06 matanlurey@users.noreply.github.com Revamp the `scenario_app/../README.md` to encourage self-sustenance (flutter/engine#51196)
2024-03-06 jonahwilliams@google.com [Impeller] disable blending in gaussian intermediate steps. (flutter/engine#51118)
2024-03-06 bdero@google.com [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51219)
2024-03-06 skia-flutter-autoroll@skia.org Roll Skia from 37947aec8c5c to 1d1fd7fe1a89 (1 revision) (flutter/engine#51216)
2024-03-06 bdero@google.com [Impeller] Fix path winding when bridging from contours with an odd number of points. (flutter/engine#51218)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2ab00ee6

Fill in SliverConstraints fields missing from ==, hashCode, toString (#143661) · 6b9d3ea4

Greg Price authored Mar 06, 2024

I was doing some debugging on a RenderSliver subclass, and found
that SliverConstraints.toString was missing the precedingScrollExtent
field.

Add that, and add both that field and userScrollDirection to the
`==` and hashCode implementations, which had been skipping them,
so that all three methods now handle all the class's fields.

6b9d3ea4

Roll Flutter Engine from 49bc1577f317 to effcf97a1f7c (10 revisions) (#144653) · a431dee5

engine-flutter-autoroll authored Mar 06, 2024

https://github.com/flutter/engine/compare/49bc1577f317...effcf97a1f7c

2024-03-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (#51209)" (flutter/engine#51217)
2024-03-05 30870216+gaaclarke@users.noreply.github.com [Impeller] implement blur style solid (flutter/engine#50892)
2024-03-05 xilaizhang@google.com [g3 roll] Revert "Remove unused drone_dimension field" (flutter/engine#51214)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 17677914dabf to 37947aec8c5c (5 revisions) (flutter/engine#51211)
2024-03-05 737941+loic-sharma@users.noreply.github.com Fix git hooks on Windows (flutter/engine#51203)
2024-03-05 bdero@google.com [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51209)
2024-03-05 bdero@google.com [Impeller] Fix convex triangulation winding bug for multi-contour paths. (flutter/engine#51198)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 875b356e4d96 to 17677914dabf (2 revisions) (flutter/engine#51207)
2024-03-05 gspencergoog@users.noreply.github.com Skip configuration dependency if unit tests are disabled (flutter/engine#51179)
2024-03-05 chinmaygarde@google.com [Impeller] Implement YUV texture import and sampling for video player frames. (flutter/engine#50730)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a431dee5

05 Mar, 2024 4 commits

Bump codecov/codecov-action from 4.0.2 to 4.1.0 (#144174) · bbb00529

dependabot[bot] authored Mar 05, 2024

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.0.2 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<ul>
<li>fix: set safe directory by <a href="https://github.com/thomasrockhu-codecov"><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1304">codecov/codecov-action#1304</a></li>
<li>build(deps): bump github/codeql-action from 3.24.3 to 3.24.5 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1306">codecov/codecov-action#1306</a></li>
<li>build(deps-dev): bump eslint from 8.56.0 to 8.57.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1305">codecov/codecov-action#1305</a></li>
<li>chore(release): v4.1.0 by <a href="https://github.com/thomasrockhu-codecov"><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1307">codecov/codecov-action#1307</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.0.2...v4.1.0">https://github.com/codecov/codecov-action/compare/v4.0.2...v4.1.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/codecov/codecov-action/commit/54bcd8715eee62d40e33596ef5e8f0f48dbbccab"><code>54bcd87</code></a> chore(release): v4.1.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1307">#1307</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/8ba77ef8d7b55bda0f69297c841058adf8459f89"><code>8ba77ef</code></a> build(deps-dev): bump eslint from 8.56.0 to 8.57.0 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1305">#1305</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/c60aa801e394788e00c8c837b5e250085fbe5df8"><code>c60aa80</code></a> build(deps): bump github/codeql-action from 3.24.3 to 3.24.5 (<a href="https://redirect.github.com/codecov/codecov-action/issues/1306">#1306</a>)</li>
<li><a href="https://github.com/codecov/codecov-action/commit/2fc4847d3f22c2ca7f5bab5504f530b55d4a9768"><code>2fc4847</code></a> fix: set safe directory (<a href="https://redirect.github.com/codecov/codecov-action/issues/1304">#1304</a>)</li>
<li>See full diff in <a href="https://github.com/codecov/codecov-action/compare/0cfda1dd0a4ad9efc75517f399d859cd1ea4ced1...54bcd8715eee62d40e33596ef5e8f0f48dbbccab">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.0.2&new-version=4.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

bbb00529

Fix embedding FlutterMacOS.framework for macOS add2app via cocoapods (#144248) · 7e05bc4b
Victoria Ashworth authored Mar 05, 2024
```
Fixes https://github.com/flutter/flutter/issues/144244.
```
7e05bc4b

Enable asset transformation feature in hot reload workflow (excluding Web) (#144161) · ff3b6dc0

Andrew Kolos authored Mar 05, 2024

Partial implementation of https://github.com/flutter/flutter/issues/143348

This enables asset transformation during hot reload (except for web, because that has its own implementation of `DevFS` ð). Asset transformers will be reapplied after changing any asset and performing a hot reload during `flutter run`.

ff3b6dc0

Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (#144639) · 15e8d324

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/engine/compare/3e8b0deffe4e...49bc1577f317

2024-03-05 zanderso@users.noreply.github.com Fix typo in githook message (flutter/engine#51205)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 453cb0d04584 to 875b356e4d96 (2 revisions) (flutter/engine#51202)
2024-03-05 john@johnmccutchan.com Add device selection to `et run` (flutter/engine#51184)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from de108a9c8b54 to 453cb0d04584 (2 revisions) (flutter/engine#51201)
2024-03-05 zanderso@users.noreply.github.com Adds githooks that reminds to run `gclient sync -D` (flutter/engine#51156)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15e8d324