1. 16 Sep, 2015 10 commits
    • Hixie's avatar
      Refactor rendering_tester · cd6c4da3
      Hixie authored
      RenderView has to be a singleton for sanity during tests, otherwise they
      all end up in the dirty lists and we end up pumping all of them each frame.
      cd6c4da3
    • Ian Hickson's avatar
      Merge pull request #1188 from Hixie/animatedcontainer · 4c79cc22
      Ian Hickson authored
      AnimatedContainer isn't an AnimatedComponent.
      4c79cc22
    • Hixie's avatar
      AnimatedContainer isn't an AnimatedComponent. · 46234aeb
      Hixie authored
      Turns out it gets nothing out of inheriting from AnimatedComponent.
      46234aeb
    • Adam Barth's avatar
      Remove MimicOverlay · 6e410fd8
      Adam Barth authored
      This widget has no client.
      6e410fd8
    • Adam Barth's avatar
      Fix analyzer warnings · ac266c67
      Adam Barth authored
      ac266c67
    • Ian Hickson's avatar
      Merge pull request #1182 from Hixie/ancestor · 6b4352bb
      Ian Hickson authored
      Clarify why we don't assert that ancestor != null.
      6b4352bb
    • Ian Hickson's avatar
      Merge pull request #1183 from Hixie/dismissable · 63d3b6db
      Ian Hickson authored
      Be more explicit about what's state in dismissable
      63d3b6db
    • Hixie's avatar
      Be more explicit about what's state in dismissable · adf7c48d
      Hixie authored
      Move _activeCardDragEndPoint near build() so it's more obvious that it
      is part of the build state.
      
      Make a couple of functions use setState() since they modify variables
      that are used by build().
      
      Add a more detailed comment to the empty setState() call, since those
      are dubious in general and need explaining when they occur, lest people
      start using them as magic incantations to Make Things Work.
      adf7c48d
    • Hixie's avatar
      Clarify why we don't assert that ancestor != null. · 8b538540
      Hixie authored
      Follow-up for #1140.
      8b538540
    • Hixie's avatar
      "newChild == oldChild || !newChild.mounted" assert · 12a09822
      Hixie authored
      If a StatefulComponent marks itself dirty, gets rebuilt, then its parent
      gets rebuilt, its parent will find that its child is from a newer
      generation and hasn't changed. Previously, we considered two stateful
      nodes to not be syncable even if they were the same; combined with the
      way the "old" node looks like it's been put elsewhere (since it's
      already been synced), we end up confused as to why the new node is
      already mounted.
      
      This fixes the problem by making the canSync logic consider two
      identical nodes as syncable (since they are; syncChild() short-circuits
      that case), and by changing syncChildren to consider identical nodes as
      matches even if they are already synced.
      12a09822
  2. 15 Sep, 2015 3 commits
    • Hixie's avatar
      Improve exception reporting in Widgets framework · daf5c312
      Hixie authored
      This specifically improves the reporting of exceptions in syncChild(),
      and makes the way we've been adding information to toStringName() less
      ad-hoc and easier to extend.
      daf5c312
    • Hixie's avatar
      Ignore generation of child if child is unchanged · dfd821e5
      Hixie authored
      Also:
      
       - don't mark a node as from the new generation if it is dirty, since we
         know it still has to be built.
      
       - establish the rule that you can't call setState() during initState()
         or build().
      
       - make syncChild() return early for unchanged children.
      
       - update the tests, including adding a new one.
      dfd821e5
    • Adam Barth's avatar
      Rev pub package · 2cb58ebf
      Adam Barth authored
      2cb58ebf
  3. 14 Sep, 2015 11 commits
  4. 12 Sep, 2015 1 commit
  5. 11 Sep, 2015 15 commits