Commit 6b4352bb authored by Ian Hickson's avatar Ian Hickson

Merge pull request #1182 from Hixie/ancestor

Clarify why we don't assert that ancestor != null.
parents 63d3b6db 8b538540
......@@ -1176,8 +1176,13 @@ abstract class RenderObjectWrapper extends Widget {
assert(() {
if (current is ParentDataNode) {
Widget ancestor = current.parent;
while (ancestor != null && ancestor is Component)
while (ancestor is Component)
ancestor = ancestor.parent;
// ancestor might be null in two cases:
// - asking for the ancestor of a Widget that has no non-Component
// ancestors between itself and its AbstractWidgetRoot ancestor
// - if the node is just being synced to get its intrinsic
// dimensions, as e.g. MixedViewport does.
if (ancestor != null)
current.debugValidateAncestor(ancestor);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment