1. 30 Sep, 2019 1 commit
  2. 29 Apr, 2019 1 commit
  3. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  4. 27 Feb, 2019 1 commit
    • liyuqian's avatar
      Add LICENSE test to presubmit checks (#28369) · dd5559a5
      liyuqian authored
      ## Description
      
      Also update the existing dart files with missing licenses.
      
      Without the fix, we'll emit the following error message
      ```
      License headers cannot be found at the beginning of the following files.
      
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/lib/src/animation/tween_sequence.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/material/raw_material_button_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/async_lifecycle_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/sliver_constraints_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/app_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/test_border.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/physical_model_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/inherited_model.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/lib/src/base/user_messages.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/src/pubspec_schema.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/ios/simulators_test.dart
      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
      ```
      
      ## Related Issues
      
      Fixes https://github.com/flutter/flutter/issues/28368
      
      ## Checklist
      
      Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
      
      - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
      - [x] My PR includes tests for *all* changed/updated/fixed behaviors (See [Test Coverage]).
      - [x] All existing and new tests are passing.
      - [x] I updated/added relevant documentation (doc comments with `///`).
      - [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
      - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
      - [x] I signed the [CLA].
      - [x] I am willing to follow-up on review comments in a timely manner.
      
      ## Breaking Change
      
      Does your PR require Flutter developers to manually update their apps to accommodate your change?
      
      - [ ] Yes, this is a breaking change (Please read [Handling breaking changes]).
      - [x] No, this is *not* a breaking change.
      
      <!-- Links -->
      [issue database]: https://github.com/flutter/flutter/issues
      [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
      [Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
      [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
      [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
      [CLA]: https://cla.developers.google.com/
      [Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
      dd5559a5
  5. 02 Nov, 2018 1 commit
  6. 12 Sep, 2018 1 commit
  7. 02 Aug, 2018 1 commit
  8. 27 Jul, 2018 1 commit
  9. 23 Jul, 2018 1 commit
  10. 16 Jul, 2018 2 commits
  11. 10 May, 2018 1 commit
  12. 07 Mar, 2018 1 commit
    • Josh Soref's avatar
      Spelling (#15229) · c5a5945e
      Josh Soref authored
      * spelling: accommodate
      
      * spelling: allotted
      
      * spelling: anonymous
      
      * spelling: artificial
      
      * spelling: associated
      
      * spelling: asset
      
      * spelling: button
      
      * spelling: canvas
      
      * spelling: compatibility
      
      * spelling: coverage
      
      * spelling: condition
      
      * spelling: decoration
      
      * spelling: deferring
      
      * spelling: diameter
      
      * spelling: direction
      
      * spelling: displacement
      
      * spelling: dropdown
      
      * spelling: needing
      
      * spelling: environment
      
      * spelling: exited
      
      * spelling: expansion
      
      * spelling: explore
      
      * spelling: families
      
      * spelling: horizontal
      
      * spelling: increment
      
      * spelling: indices
      
      * spelling: internationalization
      
      * spelling: labrador
      
      * spelling: localizations
      
      * spelling: midflight
      
      * spelling: milliseconds
      
      * spelling: minimum
      
      * spelling: multiple
      
      * spelling: multiplication
      
      * spelling: navigator
      
      * spelling: overridden
      
      * spelling: package
      
      * spelling: performance
      
      * spelling: platform
      
      * spelling: porsche
      
      * spelling: position
      
      * spelling: preceded
      
      * spelling: precede
      
      * spelling: precedence
      
      * spelling: print
      
      * spelling: property
      
      * spelling: readily
      
      * spelling: reproducibility
      
      * spelling: rounded
      
      * spelling: scroll
      
      * spelling: separate
      
      * spelling: separator
      
      * spelling: services
      
      * spelling: specific
      
      * spelling: specify
      
      * spelling: synchronously
      
      * spelling: through
      
      * spelling: timeout
      
      * spelling: triangle
      
      * spelling: trivial
      
      * spelling: unusual
      
      * spelling: then
      
      * spelling: vertically
      
      * spelling: visible
      
      * spelling: visited
      
      * spelling: voice
      c5a5945e
  13. 01 Feb, 2018 1 commit
  14. 11 Jan, 2018 1 commit
  15. 03 May, 2017 1 commit
  16. 27 Apr, 2017 1 commit
  17. 23 Apr, 2017 1 commit
  18. 21 Apr, 2017 1 commit
  19. 04 Mar, 2017 1 commit
  20. 25 Jan, 2017 1 commit
    • Ian Hickson's avatar
      Factor out debugPaintPadding and test it (#7598) · 58348612
      Ian Hickson authored
      I plan to use this to implement similar logic in SliverPadding.
      
      To make this easier to test I extended the paints matcher to accept a
      function that takes a canvas. While I was at it I also made it accept
      a Finder, it'll go and find the render object for you.
      
      Also added support for paints..path and fixed some grammar in the
      error messages.
      
      Also improved the docs for debugPaint*.
      58348612
  21. 24 Jan, 2017 1 commit
    • Adam Barth's avatar
      Add SingleChildScrollView (#7620) · 559621ca
      Adam Barth authored
      This widget is a replacement for ScrollableViewport that uses the new
      Scrollable2 machinery. The widget is not based on Slivers but does use the new
      scroll behavior classes.
      559621ca
  22. 20 Jan, 2017 1 commit
  23. 05 Jan, 2017 1 commit
    • Adam Barth's avatar
      Slider shouldn't be open at min (#7342) · 0c6dc598
      Adam Barth authored
      This patch changes the default appearance of Slider to not have the
      thumb be an open circle at its minimum position. The `thumbOpenAtMin`
      property can enable drawing an open thumb at the min position, which was
      the previous behavior.
      
      Fixes #6941
      0c6dc598
  24. 09 Dec, 2016 1 commit
  25. 14 Sep, 2016 1 commit
  26. 08 Sep, 2016 1 commit
    • Ian Hickson's avatar
      Make tests more realistic (#5762) · 5bc8888e
      Ian Hickson authored
      Previously, pumpWidget() would do a partial pump (it didn't trigger
      Ticker callbacks or post-frame callbacks), and pump() would do a full
      pump. This patch brings them closer together. It also makes runApp run a
      full actual frame, rather than skipping the transient callback part of
      the frame logic. Having "half-frames" in the system was confusing and
      could lead to bugs where code expecting to run before the next layout
      pass didn't because a "half-frame" ran first.
      
      Also, make Tickers start ticking in the frame that they were started in,
      if they were started during a frame. This means we no longer spin a
      frame for t=0, we jump straight to the first actual frame.
      
      Other changes in this patch:
      
      * rename WidgetsBinding._runApp to WidgetsBinding.attachRootWidget, so
        that tests can use it to more accurately mock out runApp.
      
      * allow loadStructuredData to return synchronously.
      
      * make handleBeginFrame handle not being given a time stamp.
      
      * make DataPipeImageProvider.loadAsync protected (rather than private),
        and document it. There wasn't really a reason for it to be private.
      
      * fix ImageConfiguration.toString.
      
      * introduce debugPrintBuildScope and debugPrintScheduleBuildForStacks,
        which can help debug problems with widgets getting marked as dirty but
        not cleaned.
      
      * make debugPrintRebuildDirtyWidgets say "Building" the first time and
        "Rebuilding" the second, to make it clearer when a widget is first
        created. This makes debugging widget lifecycle issues much easier.
      
      * make debugDumpApp more resilient.
      
      * debugPrintStack now takes a label that is printed before the stack.
      
      * improve the banner shown for debugPrintBeginFrameBanner.
      
      * various and sundry documentation fixes
      5bc8888e
  27. 17 Aug, 2016 1 commit
  28. 11 Aug, 2016 1 commit