Commits · cc9a3d9d95ca2cf3c616c3e1731a11adcf299d07 · abdullh.alsoleman / Front-End

02 May, 2023 20 commits

Mark microbenchmarks_ios unflaky (#125332) · cc9a3d9d
Jenn Magder authored May 02, 2023
```
This hasn't flaked for > 50 commits which is our threshhold.  Marking as unflaky.
```
cc9a3d9d

Roll Flutter Engine from 6fe3f5079792 to cd989fbc80bf (1 revision) (#125894) · c5183601

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/6fe3f5079792...cd989fbc80bf

2023-05-02 godofredoc@google.com Migrate Linux Android AOT Engine to engine V2. (flutter/engine#41638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c5183601

Mark build_test builds as bringup. (#125898) · d0069bec

godofredoc authored May 02, 2023

They require an additional dimension to be passed as part of the
.ci.yaml configuration.

Bug: https://github.com/flutter/flutter/issues/125897

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

d0069bec

Align the Popup Menu under its child (#125534) · 00cd3eda

Valentin Vignal authored May 02, 2023

Align the `PopupMenu` under its child.

Before:

![image](https://user-images.githubusercontent.com/32538273/234468262-beddb257-5f5a-422f-a678-c26efc52dc07.png)

After:

![image](https://user-images.githubusercontent.com/32538273/234468233-3ea4d741-b04c-4012-bdd7-a36ecedc029c.png)

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/125474

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

00cd3eda

Roll Flutter Engine from 53c192f41f96 to 6fe3f5079792 (2 revisions) (#125888) · 25bbe5c5

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/53c192f41f96...6fe3f5079792

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from c574ba686a93 to 644e199b6832 (1 revision) (flutter/engine#41666)
2023-05-02 jason-simmons@users.noreply.github.com Clone the parent Android engine's asset provider into a spawned engine (flutter/engine#41642)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

25bbe5c5

Clean up in memory_allocations_test.dart. (#125777) · 209865ae
Polina Cherkasova authored May 02, 2023

209865ae

[framework] delete physical model layer. (#125719) · 12b3023e

Jonah Williams authored May 02, 2023

Engine PR: https://github.com/flutter/engine/pull/41593

This must land first

We should remove these, as they've been deprecated for a while. On the engine side of things, the physical model layer is the only one which requires the device pixel ratio, so deleting it will allow us to simplify the layer tree code in https://github.com/flutter/engine/pull/41559

12b3023e

Roll Packages from de6131dbe4f7 to f163786731b8 (6 revisions) (#125884) · e51b6167

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/packages/compare/de6131dbe4f7...f163786731b8

2023-05-01 43054281+camsim99@users.noreply.github.com [camerax] Retrieve exposure and zoom camera information (flutter/packages#3798)
2023-05-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 66fa4c5d to 828a0404 (79 revisions) (flutter/packages#3874)
2023-05-01 vashworth@google.com [video_player, google_sign_in] Updates functions without a prototype to avoid deprecation warning (flutter/packages#3873)
2023-05-01 reidbaker@google.com [various] Speed up build-examples (flutter/packages#3849)
2023-05-01 stuartmorgan@google.com [file_selector] Remove uses of `macUTIs` (flutter/packages#3859)
2023-05-01 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for macOS (flutter/packages#3703)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e51b6167

Add debugPrintKeyboardEvents flag (#125629) · e435b1ae

Bruno Leroux authored May 02, 2023

## Description

This PR adds a new debug flag named `debugPrintKeyboardEvents` to help debugging keyboard issues.

Keyboard code has some useful asserts but sometimes an assertion failure is related to the handling of previous key events. This debug flag will help understanding the flow of key events which leads to an assertion failure.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/125627

## Tests

Adds 1 test.

e435b1ae

Roll Flutter Engine from 44376e8cd3de to 53c192f41f96 (2 revisions) (#125880) · 794c2e0a

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/44376e8cd3de...53c192f41f96

2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 0c4f93a82e0b to 84f3080c3165 (1 revision) (flutter/engine#41665)
2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from e71bd40af2bb to c574ba686a93 (1 revision) (flutter/engine#41664)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

794c2e0a

Roll Flutter Engine from 46d5ce4784b8 to 44376e8cd3de (1 revision) (#125876) · db6074ad

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/46d5ce4784b8...44376e8cd3de

2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ur2ymZJCZSj64s6Q2... to g_6rn9e-GBQGQGwgt... (flutter/engine#41663)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ur2ymZJCZSj6 to g_6rn9e-GBQG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

db6074ad

Roll Flutter Engine from a687d62ff631 to 46d5ce4784b8 (1 revision) (#125874) · 61c8291f

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/a687d62ff631...46d5ce4784b8

2023-05-02 zhongwuzw@qq.com [macOS] Add lookupKeyForAsset to FlutterPluginRegistrar (flutter/engine#37421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61c8291f

Roll Flutter Engine from d0ed35b7bf67 to a687d62ff631 (1 revision) (#125871) · 005ad93d

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/d0ed35b7bf67...a687d62ff631

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from d2c85cb8aa2f to e71bd40af2bb (1 revision) (flutter/engine#41662)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

005ad93d

Roll Flutter Engine from c0d68c36c376 to d0ed35b7bf67 (1 revision) (#125870) · d82e6974

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/c0d68c36c376...d0ed35b7bf67

2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from u7iIoiSX4y8WV6Of1... to moQlKaNgpc0WD3sjC... (flutter/engine#41661)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from u7iIoiSX4y8W to moQlKaNgpc0W

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d82e6974

Roll Flutter Engine from a9e38dd0510d to c0d68c36c376 (1 revision) (#125868) · 55061e46

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/a9e38dd0510d...c0d68c36c376

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from e18b7415188c to d2c85cb8aa2f (2 revisions) (flutter/engine#41660)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55061e46

Roll Flutter Engine from 024bf946232d to a9e38dd0510d (2 revisions) (#125866) · 59653136

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/024bf946232d...a9e38dd0510d

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from c9e0992be00b to e18b7415188c (1 revision) (flutter/engine#41659)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 25c29435f73e to 0c4f93a82e0b (2 revisions) (flutter/engine#41657)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

59653136

Make `future` and `stream` required arguments in their respective builder widgets (#125838) · 4d86f5d0

Casey Rogers authored May 02, 2023

cc'ing existing conversation participants: @domesticmouse @srawlins
cc'ing to request review: @goderbauer

This PR makes the following constructor arguments required:
1. `FutureBuilder.future`
2. `StreamBuilderBase.stream`
3. `StreamBuilder.stream`

This fixes:
https://github.com/flutter/flutter/issues/83081
https://github.com/flutter/flutter/issues/125188 (dupe of 83081)

This obviates:
https://github.com/dart-lang/linter/issues/4309
(I suggest we skip straight to merging this PR as this should be a low impact breaking change-assuming few to no devs are intentionally using the builders without their relevant arguments, however we could always merge 4309 first and then this)
https://github.com/flutter/flutter/pull/83101
(The above PR required that at least one of future and initial data be non-null, this is undesirable as there are plenty of valid reasons to have both arguments be null)

See above issues for a deeper dive, but here is a summary:
It is very easy for a developer to forget to specify `future` or `stream` when using the respective `*Builder` widgets. This produces a non-obvious failure where the UI sits in a "no data yet received" state. It is easy for a dev to misinterpret this as the async work backing the future/stream hanging and they thus waste a lot of time trying to debug the async work.
As such, we should require these two constructor arguments to make it impossible/much harder for devs to make this time-wasting mistake.

This is a breaking change. However, it should break only a small number of active projects given that using a builder without specifying `future` or `stream` seems highly niche.
The only place I've found non-accidental examples of this is in widget tests where you're calling `pumpWidget` with and without these arguments to test `*Builder.didUpdateWidget`'s behavior. In this and similar cases, it is a trivial fix to add `future: null`/`stream: null`.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

4d86f5d0

Roll Flutter Engine from 7d87410a51d5 to 024bf946232d (6 revisions) (#125858) · 7907f931

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/7d87410a51d5...024bf946232d

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from 38e56b6da8f9 to c9e0992be00b (3 revisions) (flutter/engine#41655)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from dc4a048e3cf7 to 25c29435f73e (1 revision) (flutter/engine#41654)
2023-05-01 flar@google.com [Impeller] take advantage of DisplayList culling (flutter/engine#41606)
2023-05-01 godofredoc@google.com Use os_dimension in framework tests. (flutter/engine#41649)
2023-05-01 58529443+srujzs@users.noreply.github.com Turn @staticInterop tear-off into closure (flutter/engine#41643)
2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SJOgKviZ-kwWd1Z1u... to ur2ymZJCZSj64s6Q2... (flutter/engine#41648)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SJOgKviZ-kwW to ur2ymZJCZSj6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7907f931

Roll Flutter Engine from 3fa6084dfb36 to 7d87410a51d5 (4 revisions) (#125845) · d304545d

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/3fa6084dfb36...7d87410a51d5

2023-05-01 ychris@google.com Update xcode to 14e222b (flutter/engine#41640)
2023-05-01 aam@google.com Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646)
2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645)
2023-05-01 ychris@google.com Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d304545d

Migrate Xcode projects last version checks to Xcode 14.3 (#125827) · 1861ac47

Jenn Magder authored May 02, 2023

1. Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent `Update to recommended settings` warning.
2. Update iOS and macOS templates to same.
3. Update iOS template to set `BuildIndependentTargetsInParallel` to YES as suggested. I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration.
4. Run all example/integration test project to see migrator work.
5. Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside `SHARD=build_tests`.

Fixes https://github.com/flutter/flutter/issues/125817
See https://github.com/flutter/flutter/pull/90304 for Xcode 13 example.

1861ac47

01 May, 2023 17 commits

Roll Flutter Engine from 58cc54197a54 to 3fa6084dfb36 (1 revision) (#125839) · 635337ca

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/58cc54197a54...3fa6084dfb36

2023-05-01 timmaffett@gmail.com Fixes font-subset to not drop GSUB/GPOS/GDEF tables for variable fonts where they are needed Fixes #125704 (flutter/engine#41592)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

635337ca

Roll Flutter Engine from 687f4c761db1 to 58cc54197a54 (6 revisions) (#125833) · 050e4ade

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/687f4c761db1...58cc54197a54

2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from NBgD7NzOpwnAULR_g... to u7iIoiSX4y8WV6Of1... (flutter/engine#41641)
2023-05-01 godofredoc@google.com Add the verify exported symbols to linux builds. (flutter/engine#41635)
2023-05-01 30870216+gaaclarke@users.noreply.github.com [Impeller] Turns on the Metal validator for impeller_unittests. (flutter/engine#40998)
2023-05-01 dnfield@google.com [Impeller] Remove duplicate component in path.h (flutter/engine#41639)
2023-05-01 whesse@google.com Forward fix for roll of Dart SDK to version with new checked-in SDK (flutter/engine#41634)
2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 1a6a1e905518 to 82d1ef7a833e (5 revisions) (flutter/engine#41637)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from NBgD7NzOpwnA to u7iIoiSX4y8W

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

050e4ade

Roll Flutter Engine from 666bc34c61aa to 687f4c761db1 (2 revisions) (#125818) · 828a0404

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/666bc34c61aa...687f4c761db1

2023-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from a433ca08e7e2 to dc4a048e3cf7 (1 revision) (flutter/engine#41636)
2023-05-01 xilaizhang@google.com [flutter roll] Revert "Determine lifecycle by looking at window focus also" (flutter/engine#41626)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

828a0404

Revert "Add migrator to upgrade gradle version when conflict with And… (#125813) · db7196c5
gmackall authored May 01, 2023
```
â¦roid Studio bundled Java version is detected (#124085)"

This reverts commit eba2a520.
```
db7196c5
Roll pub packages (#125801) · b2f22321
Flutter GitHub Bot authored May 01, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
b2f22321
[tools] fix `expect` calls in `FakeCommand` (#125783) · a27cb145
Andrew Kolos authored May 01, 2023
```
Fixes #125782.

Would be nice to figure out a way to put this under test.
```
a27cb145

Roll Packages from 7e3f5da42e81 to de6131dbe4f7 (41 revisions) (#125811) · ff248d23

engine-flutter-autoroll authored May 01, 2023

Roll Packages from 7e3f5da42e81 to de6131dbe4f7 (41 revisions)

https://github.com/flutter/packages/compare/7e3f5da42e81...de6131dbe4f7

2023-05-01 reidbaker@google.com I122213 update non examples (flutter/packages#3846)
2023-04-29 47866232+chunhtai@users.noreply.github.com [go_router] Cleans up route match API and introduces dart fix (flutter/packages#3819)
2023-04-29 43054281+camsim99@users.noreply.github.com [camerax] Add `LifecycleOwner` Proxy (flutter/packages#3837)
2023-04-29 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for Windows (flutter/packages#3704)
2023-04-29 stuartmorgan@google.com [various] Update Android example min SDKs (flutter/packages#3847)
2023-04-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.12 to 2.3.2 (flutter/packages#3838)
2023-04-28 43054281+camsim99@users.noreply.github.com [camerax] Implement Image Streaming (flutter/packages#3454)
2023-04-28 reidbaker@google.com [various] update agp and gradle for all examples in packages (flutter/packages#3822)
2023-04-28 54558023+keyonghan@users.noreply.github.com Update xcode to 14c18 (flutter/packages#3774)
2023-04-28 andrewjohncoutts@gmail.com [camera_android] Add NV21 as an image stream format #3277 (flutter/packages#3639)
2023-04-28 gautier.bayzelon@gmail.com [go_router] Remove unused navigator keys (flutter/packages#3708)
2023-04-28 JeroenWeener@users.noreply.github.com [image_picker] Move I/O operations to a separate thread (flutter/packages#3506)
2023-04-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.20 to 1.8.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3824)
2023-04-28 stuartmorgan@google.com [pigeon] Reland: Add an initial example app (flutter/packages#3832)
2023-04-28 engine-flutter-autoroll@skia.org Roll Flutter from c9004ff8 to 66fa4c5d (68 revisions) (flutter/packages#3830)
2023-04-28 stuartmorgan@google.com [various] Conditionalize the namespace in all Android plugins (flutter/packages#3836)
2023-04-27 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 5.1.0 to 5.2.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3672)
2023-04-27 ychris@google.com [auick_action_ios] Retries multiple times to not fail ci when there is a flake (flutter/packages#3823)
2023-04-26 magder@google.com Swap some iOS package CODEOWNERS (flutter/packages#3793)
2023-04-26 stuartmorgan@google.com [various] Add `targetCompatibility` to build.gradle (flutter/packages#3825)
2023-04-26 stuartmorgan@google.com [various] Set cmake_policy versions (flutter/packages#3828)
2023-04-26 stuartmorgan@google.com [path_provider] Allow `win32` up to version 4.x (flutter/packages#3820)
2023-04-26 stuartmorgan@google.com [tool] Move Android lint checks (flutter/packages#3816)
2023-04-25 evace93@gmail.com [google_maps_flutter_android] Fix Android lint warnings (flutter/packages#3751)
2023-04-25 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3381)
2023-04-25 jason-simmons@users.noreply.github.com Update test golden images for the latest Skia roll (flutter/packages#3787)
2023-04-25 stuartmorgan@google.com [various] Adds Android namespace (flutter/packages#3791)
2023-04-25 reidbaker@google.com [shared_preferences] Update gradle/agp in example apps (flutter/packages#3809)
2023-04-24 43640732+dancamdev@users.noreply.github.com [go_router] Adds name to TypedGoRoute (flutter/packages#3702)
2023-04-22 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to receive permission requests (flutter/packages#3543)
2023-04-21 stuartmorgan@google.com [google_sign_in] Fix Android Java warnings (flutter/packages#3762)
2023-04-21 stuartmorgan@google.com [local_auth] Fix enum return on Android (flutter/packages#3780)
2023-04-21 stuartmorgan@google.com [pigeon] Warn when trying to use enums in collections (flutter/packages#3782)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [webview_flutter_wkwebview] Platform implementations for supporting permission requests (flutter/packages#3792)
2023-04-21 scheglov@google.com [pigeon] Update for compatibility with a future change to the analyzer. (flutter/packages#3789)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [camera_android] Fix Android lint warnings (flutter/packages#3716)
2023-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds method to receive permission requests (flutter/packages#3767)
2023-04-21 magder@google.com [image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property (flutter/packages#3783)
2023-04-21 widrans@gmail.com [go_router_builder] Fixed the return value of the generated push method (flutter/packages#3650)
2023-04-21 JeroenWeener@users.noreply.github.com [image_picker] Mention `launchMode: singleInstance` in README (flutter/packages#3759)
2023-04-21 stuartmorgan@google.com Revert "[pigeon] Add an initial example app" (flutter/packages#3785)

ff248d23

Introduce `TabBar.tabAlignment` (#125036) · a732a748

Taha Tesser authored May 01, 2023

fixes https://github.com/flutter/flutter/issues/124195

This introduces `TabBar.tabAlignment` while keeping the default alignment for both M2 and M3.

a732a748

Roll Flutter Engine from b0da68e7e024 to 666bc34c61aa (1 revision) (#125805) · e2ddf563

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/b0da68e7e024...666bc34c61aa

2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from a7f887f344c6 to 1a6a1e905518 (1 revision) (flutter/engine#41633)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e2ddf563

add support to customize Slider interacivity (#121483) · 293715a6

Viren Khatri authored May 01, 2023

design doc: https://docs.flutter.dev/go/permissible-slider-interaction

closes #113370

open questions:
  - No, as `SliderInteraction.none` doesn't exist anymore.
  - Yes (done)
  - Yes.
    - SliderInteraction
    - SliderAction
    - Slider.allowedInteraction
    - Slider.permissibleInteraction
    - Slider.interaction
    - Slider.allowedAction
    - Slider.permittedAction

293715a6

Roll Flutter Engine from b4551c72487c to b0da68e7e024 (1 revision) (#125800) · d9ea36cc

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/b4551c72487c...b0da68e7e024

2023-05-01 kjlubick@users.noreply.github.com Reland image encoder (flutter/engine#41632)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9ea36cc

Roll Flutter Engine from 605528f293d0 to b4551c72487c (1 revision) (#125795) · 3380c398

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/605528f293d0...b4551c72487c

2023-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 823a69e2a34d to a433ca08e7e2 (3 revisions) (flutter/engine#41631)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3380c398

Roll Flutter Engine from bba66b658cee to 605528f293d0 (2 revisions) (#125793) · fed8cc4a

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/bba66b658cee...605528f293d0

2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FV1Uu3faXL2llmvaU... to SJOgKviZ-kwWd1Z1u... (flutter/engine#41630)
2023-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.1 to 2.3.2 (flutter/engine#41629)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FV1Uu3faXL2l to SJOgKviZ-kwW

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fed8cc4a

Roll Flutter Engine from 2fa61b91d7c2 to bba66b658cee (1 revision) (#125791) · bf6f0af2

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/2fa61b91d7c2...bba66b658cee

2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from fe0977a822a4 to a7f887f344c6 (1 revision) (flutter/engine#41628)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bf6f0af2

Roll Flutter Engine from 30c91b8180e7 to 2fa61b91d7c2 (1 revision) (#125789) · 8ecc3d92

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/30c91b8180e7...2fa61b91d7c2

2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 5a7d7da47c10 to fe0977a822a4 (5 revisions) (flutter/engine#41627)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8ecc3d92

Roll Flutter Engine from d76a22e67eea to 30c91b8180e7 (1 revision) (#125787) · cbdeec91

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/d76a22e67eea...30c91b8180e7

2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from uU98Ene2OeSVt21X_... to NBgD7NzOpwnAULR_g... (flutter/engine#41625)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from uU98Ene2OeSV to NBgD7NzOpwnA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cbdeec91

[tools] Apply Android Studio version detection logic to explicitly configured... · 9dbd6e61

Andrew Kolos authored May 01, 2023

[tools] Apply Android Studio version detection logic to explicitly configured installation directory (`flutter config --android-studio-dir`) (#125596)

Fixes #121468 (when considered along with https://github.com/flutter/flutter/pull/125247).

This applies the pre-existing Android Studio version detection logic to the install configured with `flutter config android-studio-dir`.

9dbd6e61

30 Apr, 2023 3 commits

Roll Flutter Engine from f234d5e1dd26 to d76a22e67eea (1 revision) (#125776) · 4b74232a

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/f234d5e1dd26...d76a22e67eea

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RzN-C9ZpB2ZsMq9Sn... to FV1Uu3faXL2llmvaU... (flutter/engine#41624)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from RzN-C9ZpB2Zs to FV1Uu3faXL2l

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b74232a

Roll Flutter Engine from c796390d14cb to f234d5e1dd26 (1 revision) (#125773) · e9b9d0fb

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/c796390d14cb...f234d5e1dd26

2023-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from R1rpDA1v0caZl5BFC... to uU98Ene2OeSVt21X_... (flutter/engine#41623)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from R1rpDA1v0caZ to uU98Ene2OeSV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9b9d0fb

Roll Flutter Engine from e99f31f4437d to c796390d14cb (1 revision) (#125762) · 9241329b

engine-flutter-autoroll authored Apr 30, 2023

https://github.com/flutter/engine/compare/e99f31f4437d...c796390d14cb

2023-04-30 skia-flutter-autoroll@skia.org Roll Skia from e98b3f40fbf2 to 5a7d7da47c10 (1 revision) (flutter/engine#41622)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9241329b