1. 21 Mar, 2019 1 commit
  2. 20 Mar, 2019 1 commit
  3. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  4. 15 Feb, 2019 1 commit
  5. 30 Jan, 2019 1 commit
  6. 01 Oct, 2018 2 commits
    • Jonah Williams's avatar
      224f91e3
    • Chris Bracken's avatar
      Eliminate snapshot, depfile opts from bundle cmd (#22495) · b07d986f
      Chris Bracken authored
      Eliminates the --snapshot and --depfile parameters from the flutter
      bundle command. The snapshot parameter is unused in Dart 2 -- code is
      built to kernel .dill files and for profile/release builds, then AOT
      compiled.
      
      While depfiles are still used in Dart 2 (e.g. by the kernel compiler),
      there are enough assumptions in the code that they lie in the default
      location (e.g. in the Gradle build) and no reasons to support
      user-cusomisation that it makes sense to eliminate the --depfile option
      as well, and always use the default location.
      
      This commit also renames 'depFilePath' to 'depfilePath' for consistency
      across the codebase.
      b07d986f
  7. 12 Sep, 2018 1 commit
  8. 07 Sep, 2018 2 commits
    • Chris Bracken's avatar
      Revert "Eliminate snapshot/depfile options to build bundle (#21507)" (#21563) · 5ab9e707
      Chris Bracken authored
      This tickled a bug in KernelCompiler.compile() where the fingerprinter
      doesn't include the outputFilePath in its list of dependencies. As such,
      if the output .dill file is missing or corrupted, the fingerprint still
      matches and re-compile is skipped, even though it shouldn't be. I'll fix
      that in a followup, then look at how this triggered that issue. My
      hypothesis is that that it's due to the aot kernel compile and bundle
      kernel compile have separate output directories for the .dill files
      (build/ vs build/aot) but the same output directory for the associated
      depfiles (due to this patch).
      
      This reverts commit 43a106e9.
      5ab9e707
    • Chris Bracken's avatar
      Eliminate snapshot/depfile options to build bundle (#21507) · 43a106e9
      Chris Bracken authored
      The --snapshot argument was only necessary in Dart 1. The --depfile
      argument was only used in Dart 2 mode to pass to the kernel compiler,
      but was inconsistent with the 'build aot' command, where the depfile was
      always set to build/kernel_compile.d.
      
      This patch updates 'build bundle' to emit the depfile to a location
      consistent with the 'build aot' command; since it's not intended to be
      user-configurable and flutter.gradle hardcodes the location to
      build/kernel_compile.d either way, this patch also eliminates the
      ability to configure the filename altogether.
      43a106e9
  9. 04 Sep, 2018 1 commit
  10. 31 Aug, 2018 1 commit
  11. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  12. 20 Jul, 2018 1 commit
  13. 19 Jul, 2018 1 commit
    • Danny Tuppeny's avatar
      Add `--machine` support for `flutter attach` (#19077) · ed9afbbc
      Danny Tuppeny authored
      * Extract some of startApp into a reusable method
      
      * Get basic attach --machine working
      
      * Attach --machine tweaks
      
      Move validation to validate method and create daemon early so we get the startup event before trying to get a connection.
      
      * Bump daemon version so we know whether it's valid to flutter attach
      
      * Tweak output text
      
      * Swap package imports for relative
      
      * Review tweaks (naming, formatting, typedefs)
      
      * Separate arguments from process spawning
      
      This will make calling attach easier
      
      * Add a basic test for flutter attach --machine
      
      * Fix crash if port unforward modifies the list of forwarded ports
      
      * Add a no-op port forwarder for flutter-tester
      
      * Switch to using BasicProject instead of our own inline code
      
      * Fix expectation in test now we have a portForwarder
      
      * Remove stale TODO (this is done)
      
      * Tweak formatting
      
      * Change some Completers to void to fix Dart 2 issues
      ed9afbbc
  14. 16 Jul, 2018 2 commits
  15. 20 Jun, 2018 1 commit
  16. 19 Jun, 2018 1 commit
  17. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  18. 11 Jun, 2018 1 commit
  19. 08 Jun, 2018 3 commits
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05
    • Chris Bracken's avatar
      Revert "It's time to #deleteDart1 (#18293)" (#18313) · 9495df4b
      Chris Bracken authored
      Several benchmarks started failing during kernel compile:
      1. Timeouts:
         * commands_test
         * hot_mode_dev_cycle__benchmark
         * run_machine_concurrent_hot_reload
         * service_extensions_test
      
      2. Kernel compiler crash:
         * hot_mode_dev_cycle_linux__benchmark
         * routing_test
      
      3. Unexpected termination:
         * hot_mode_dev_cycle_win__benchmark
      
      This reverts commit ed63e708.
      9495df4b
    • Chris Bracken's avatar
      It's time to #deleteDart1 (#18293) · ed63e708
      Chris Bracken authored
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      ed63e708
  20. 10 Apr, 2018 1 commit