1. 21 Dec, 2022 25 commits
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from 84ba80331ffe to a90c45db3f13 (2 revisions) (#117499) · ca7ca3b8
      engine-flutter-autoroll authored
      * afa2975aa Roll Skia from 239a9199a3d9 to cd149aaa33bd (2 revisions) (flutter/engine#38451)
      
      * a90c45db3 Roll Dart SDK from 62ea309071c6 to fc0a3217b39a (2 revisions) (flutter/engine#38452)
      ca7ca3b8
    • Michael Goderbauer's avatar
    • Renzo Olivares's avatar
    • Justin McCandless's avatar
      Handle the case of no selection rects (#117419) · 2931e50c
      Justin McCandless authored
      Fixes an error that can occur when selection contains a partial glyph.
      2931e50c
    • Justin McCandless's avatar
      Fix Scaffold bottomSheet null exceptions (#117008) · 8ff1b6eb
      Justin McCandless authored
      * Prevent possibility of null exceptions on widget.bottomSheet
      
      * New approach that fixes bug in updating the bottomSheet
      
      * Real-world test for bottomSheet error
      
      * Allow bottomSheet to animate out after being killed, even if it was rebuilt
      
      * Go back to the simple solution of SizedBox.shrink
      8ff1b6eb
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from da77d1a3abb8 to 84ba80331ffe (2 revisions) (#117489) · ddb7e43d
      engine-flutter-autoroll authored
      * 23a56ee9d Roll Skia from 7ad6f27aff57 to 239a9199a3d9 (5 revisions) (flutter/engine#38450)
      
      * 84ba80331 [Impeller Scene] Make Geometry/Materials own command binding behavior (flutter/engine#38437)
      ddb7e43d
    • Taha Tesser's avatar
    • alanwutang11's avatar
      cacheWidth cacheHeight support for canvaskit on web (#117423) · 1970bc91
      alanwutang11 authored
      * cacheWidth cacheHeight support for web canvaskit
      
      * comments
      
      * clarifying comment for loadTestImageProvider class
      Co-authored-by: 's avataralanwutang11 <alpwu@google.com>
      1970bc91
    • stuartmorgan's avatar
      Add native unit tests to iOS and macOS templates (#117147) · 2a502363
      stuartmorgan authored
      * Improve Swift plugin implementation
      
      * Add iOS tests
      
      * Review feedback on structure
      
      * Remove duplicate scheme file
      
      * Add macOS
      
      * Add iOS
      
      * swift test tweaks
      
      * unit tests
      
      * Whitespace
      
      * Add e2e tests
      2a502363
    • hangyu's avatar
      Support safe area and scrolling in the NavigationDrawer (#116995) · 9a347fb0
      hangyu authored
      * Update navigation_drawer.dart
      
      * Update navigation_drawer_test.dart
      
      * Update navigation_drawer_test.dart
      
      * update tests
      
      * Update navigation_drawer_test.dart
      
      * Update navigation_drawer_test.dart
      9a347fb0
    • Michael Thomsen's avatar
      Manual package roll (#117439) · 400b05ac
      Michael Thomsen authored
      400b05ac
    • engine-flutter-autoroll's avatar
    • engine-flutter-autoroll's avatar
      1e695f453 Roll Dart SDK from 778a29535ab5 to 62ea309071c6 (1 revision)... · 51a3e3a3
      engine-flutter-autoroll authored
      1e695f453 Roll Dart SDK from 778a29535ab5 to 62ea309071c6 (1 revision) (flutter/engine#38445) (#117459)
      
      51a3e3a3
    • engine-flutter-autoroll's avatar
      Roll Plugins from 840a04954fa0 to 54fc2066d636 (6 revisions) (#117456) · a7a5d14d
      engine-flutter-autoroll authored
      * 697c8b3ee [image_picker_ios] Pass through error message from image saving (flutter/plugins#6858)
      
      * 72f810851 [local_auth] Bump `intl` from ^0.17.0 to ">=0.17.0 <0.19.0" (flutter/plugins#6848)
      
      * acbe9b452 [gh_actions]: Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter/plugins#6860)
      
      * 3d8b73bf0 [camera] Remove deprecated Optional type (flutter/plugins#6870)
      
      * c5220efae [in_app_purchase] Add support for macOS (flutter/plugins#6519)
      
      * 54fc2066d Roll Flutter from 028c6e29 to dbc93063 (11 revisions) (flutter/plugins#6849)
      a7a5d14d
    • engine-flutter-autoroll's avatar
      4910ff889 Roll Fuchsia Mac SDK from nJJfWIwH5zElheIX8... to... · f5c07165
      engine-flutter-autoroll authored
      4910ff889 Roll Fuchsia Mac SDK from nJJfWIwH5zElheIX8... to UsYNZnnfR_s0OGQoX... (flutter/engine#38444) (#117454)
      
      f5c07165
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from c9ee05b68e6e to 2404db80ae80 (3 revisions) (#117443) · 6819f72a
      engine-flutter-autoroll authored
      * a68f09ac6 Roll Skia from a60f3f6214d3 to f8b6ec14e83f (4 revisions) (flutter/engine#38438)
      
      * 227541ad5 Roll Dart SDK from 8078926ca996 to 778a29535ab5 (6 revisions) (flutter/engine#38439)
      
      * 2404db80a Roll Skia from f8b6ec14e83f to 2e3ee507e838 (1 revision) (flutter/engine#38440)
      6819f72a
    • engine-flutter-autoroll's avatar
    • engine-flutter-autoroll's avatar
      28f344ceb Roll Dart SDK from 1530a824fd5f to 8078926ca996 (1 revision)... · 9024c954
      engine-flutter-autoroll authored
      28f344ceb Roll Dart SDK from 1530a824fd5f to 8078926ca996 (1 revision) (flutter/engine#38434) (#117435)
      
      9024c954
    • engine-flutter-autoroll's avatar
      4724a91af Roll Skia from 09d796c0a728 to a60f3f6214d3 (5 revisions)... · 16993516
      engine-flutter-autoroll authored
      4724a91af Roll Skia from 09d796c0a728 to a60f3f6214d3 (5 revisions) (flutter/engine#38432) (#117433)
      
      16993516
    • engine-flutter-autoroll's avatar
      de59f842a Roll Dart SDK from 35f6108ef685 to 1530a824fd5f (6 revisions)... · a3e7fe3f
      engine-flutter-autoroll authored
      de59f842a Roll Dart SDK from 35f6108ef685 to 1530a824fd5f (6 revisions) (flutter/engine#38431) (#117429)
      
      a3e7fe3f
    • engine-flutter-autoroll's avatar
      c7eae2901 [Impeller] Remove depth/stencil attachments from imgui pipeline... · e8e26b68
      engine-flutter-autoroll authored
      c7eae2901 [Impeller] Remove depth/stencil attachments from imgui pipeline (flutter/engine#38427) (#117425)
      
      e8e26b68
    • Renzo Olivares's avatar
      Add support for double tap and drag for text selection (#109573) · cd0f15a7
      Renzo Olivares authored
      * Replace PanGestureRecognizer in TextSelection with TapAndDragGestureRecognizer
      
      * add tracking of _DragState to new tap_and_drag recognizer and remove some legacy double tap code from text_selection.dart and add logs"
      
      * add dragTapCount, a tap count that is persistent for an entire drag and is set to null on drag end vs the regular tap count which is reset on a timer
      
      * basic double tap to drag functionality and add a local dragTapCount in text_selection.dart to use with the timer callback
      
      * Add offsetFromOrigin and localOffsetFromOrigin to DragUpdateDetails similar to LongPressMoveUpdateDetails, eliminates the need to hold the state of lastDragStartDetails
      
      * make a generic baselongpressgesturerecognizer
      
      * Revert "make a generic baselongpressgesturerecognizer"
      
      This reverts commit aad8f7433bd01e4cd016d527af832c3b1f15fac5.
      
      * rename tap_and_drag to selection_recognizers
      
      * add mixin for consecutivetap
      
      * tap and long press gesture recognizer
      
      * Revert "Revert "make a generic baselongpressgesturerecognizer""
      
      This reverts commit 181350c36718f644eada3e45c1b7b5939f90a340.
      
      * Revert "Revert "Revert "make a generic baselongpressgesturerecognizer"""
      
      This reverts commit 4d69775967858dfd66dd9429e1713da598908a85.
      
      * Add support for secondary button clicks on drag gesture recognizer and separate drag end and tap up callback
      
      * get test running
      
      * rename tapCount to consecutiveTapCount
      
      * dispose timer properly
      
      * add some comments to tests
      
      * Add comments
      
      * Make ConsecutiveTapMixin private and move logic to increment tap count into mixin
      
      * stop tracking pointer when gesture is rejected and detect drags on touch devices
      
      * onCancel for TapAndDrag
      
      * have the TapAndDragGestureRecognizer handle tap downs and tap ups on touch and mouse devices
      
      * add drag to move cursor for android and iOS, and pointer device kind to DragUpdateDetails
      
      * get tests running
      
      * refactor TapAndDragGestureRecognizer moving some logic into _check methods
      
      * Handle cancel properly on TapAndDragGestureRecognizer, having both onTapCancel and onDragCancel, also fix tests
      
      * Fix test mouse drag selects and cannot drag cursor, save _initialPosition based on dragStartBehavior (either on tapDown or dragStart)
      
      * determine if drag has a sufficient global distance to accept and fix some cancel behavior, making _checkCancel clearer
      
      * give up pointer on drag end
      
      * properly stop tracking pointer, fixes test for right click on Apple and non-apple platforms
      
      * clean up some comments from last commit
      
      * remove drag on touch for now
      
      * fix Can select text by dragging with a mouse due to dragStart only being fired on the first PointerMoveEvent, the previous pan gesture recognizer would fire both dragStart and dragUpdate
      
      * Revert "fix Can select text by dragging with a mouse due to dragStart only being fired on the first PointerMoveEvent, the previous pan gesture recognizer would fire both dragStart and dragUpdate"
      
      This reverts commit 124dc79bc3389672c76d7c014ce04edab297abc6.
      
      * correctly use _initialPosition for checkStart and call _checkUpdate after _checkStart if localDelta is not zero
      
      * updates
      
      * fix double tap chains
      
      * Add docs
      
      * Address analyzer
      
      * more analyzer, only issues left are with print statements
      
      * add deadlineTimer to fix conflict with ForcePressGestureRecognizer
      
      * Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer"
      
      This reverts commit 3b29ddfff4cde4845edd481ecefb789fea2a0781.
      
      * remove unecessary changes to tests
      
      * secondaryButton should not drag
      
      * Revert "Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer""
      
      This reverts commit 0a008f029f5796acd48c17c1897c0b700d5ef3a7.
      
      * updates
      
      * Revert "updates"
      
      This reverts commit 4803b8443a2b67f0b8d29e9a01f712dfcb0f588c.
      
      * Revert "Revert "Revert "add deadlineTimer to fix conflict with ForcePressGestureRecognizer"""
      
      This reverts commit 79251a7af88d5dbb1460a960afc77e65dea18bff.
      
      * fix shift + tap + drag tests, this was happening because a double tap + drag was being registered and not a single tap, added a duration to pumpAndSettle to fix this
      
      * remove TapAndLongPressGestureRecognizer
      
      * fix cupertino text field tests related to shift + tap + drag
      
      * deadline timer try 2
      
      * more logs
      
      * Should reset taps when tap cancel is called, and should wait until gesture is accepted to initiate a drag
      
      * should clear _down and _up when gesture is rejected
      
      * remove erroneous log
      
      * fix selectable text double tap chains test
      
      * dont restart timer until tap up
      
      * reset consecutiveTapCount on drag end
      
      * fix selectableText test
      
      * fix material text field tests
      
      * reject TapAndDragGestureRecognizer when it is neither a tap nor a drag
      
      * remove prints
      
      * clean up
      
      * shift aware
      
      * clean up
      
      * fix cupertino test
      
      * fix text field focus tests
      
      * Add 100ms delay to cupertino test, to prevent a double tap
      
      * clean up test comments
      
      * add comment to test
      
      * uncomment test
      
      * remove longpress changes
      
      * Fix drag on mobile
      
      * remove debug
      
      * Fix drag to move cursor on iOS
      
      * left over from drag fix
      
      * add tests for drag on touch devices
      
      * add test for double tap + drag mouse devices
      
      * add tests
      
      * Fix bug where initialPosition was used before it was set
      
      * Address some review comments and fix issue where if double tap was held too long then long press gesture recognizer would take over
      
      * remove _isDoubleTap flag since it is no longer needed due to previous commit
      
      * Add docs for onTapCancel and onDragCancel
      
      * analyzer fixes
      
      * Do not test selection handles on macOS, since macOS does not support touch
      
      * Add assert for dragStartBehavior
      
      * add double tap + drag tests to cupertino
      
      * use kDoubleTapTimeout instead of const Duration(milliseconds: 300) for readability
      
      * analyzer issues
      
      * update docs
      
      * update more docs
      
      * address comments
      
      * more doc updates
      
      * fix docs
      
      * unused import
      
      * fix docs
      
      * Add more tests
      
      * Add more tests and reject a tap up if we have exceeded the tap tolerance
      
      * updates
      
      * Address comments
      
      * fix test naming
      
      * update documentation
      
      * move selection_recognizers to selection_gestures
      
      * fix analyzer
      
      * fix analyzer
      
      * keysPressedOnDown instead of isShiftPressed
      
      * update docs
      
      * update docs
      
      * Add drag update throttle to TapAndDragGestureRecognizer
      
      * update comments
      
      * missed from merge
      
      * Replace _ConsecutiveTapMixin with _TapStatusTrackerMixin
      
      * updates
      
      * correctly cancel tap when when past tap tolerance with new implementation
      
      * Should call tap and drag cancel if we are giving up a pointer without succesfully tracking a PointerUpEvent
      
      * comments
      
      * move pastTapTolerance to tap tracker
      
      * move pastTapTolerance to tap tracker
      
      * clean up check for nulls and remove use of consecutiveTapCountWhileDragging
      
      * move call to super.acceptGesture to top
      
      * remove print
      
      * clean up
      
      * Fix tests where both PanGestureRecognizer and TapAndDragGestureRecognizer lost
      
      * clean up
      
      * _GestureState -> _DragState
      
      * more docs clean up
      
      * more clean up
      
      * Add onSecondaryTapCancel
      
      * Add docs
      
      * more docs
      
      * Fix broken isPointerAllowed when attempting a right click drag - the _initialButtons is never reset
      
      * revert debug flag
      
      * make primaryPointer private
      
      * Add support for upper count limit in TapAndDragGestureRecognizer, the tap counter should not be allowed to grow infinitely unless that is desired
      
      * fix analyzer
      
      * Use new TapDrag details objects and callbacks
      
      * clean up docs
      
      * clean up and add test for upperLimit
      
      * Add docs for TapAndDragGestureRecognizer and remove some ambiguity of onStart onUpdate and onEnd parameters
      
      * Address review comments
      
      * analyzer fixes
      
      * Call cancel before rejecting the gesture so we can still access _initialButtons
      
      * Recognizer should reject any pointer differing from the original
      
      * Revert "Recognizer should reject any pointer differing from the original"
      
      This reverts commit afd9807480bd11e119bdd2b7d520631511973bab.
      
      * Address reviewer comments
      
      * Correct cancel behavior
      
      * Fix consecutive tap + drag because _dragStart state was not being set when consecutive tap is greater than one
      
      * Add more tests
      
      * Add documentation on behavior with TapGestureRecognizer and DragGestureRecognizer
      
      * more docs
      
      * more docs
      
      * remove comments
      
      * updates
      
      * fix multiple pointer behavior
      
      * only handle the primary pointer
      
      * Clean up dangerous assumptions in gesture details objects
      
      * forgot from rebase
      
      * update docs
      
      * updates
      
      * Clean up some redundant code
      
      * remove whitespace
      
      * fix tests as a result of #115849
      
      * update test docs
      
      * Fix same test from last commit for material variants
      
      * More clean up of redundant code and update docs
      
      * Clean up didStopTrackingLastPointer and untie TapAndDragGestureRecognizer cancel behavior from TapStatusTrackerMixin.currentUp state
      
      * untie pastTapTolerance
      
      * updates
      
      * Add slopTolerance
      
      * update docs
      
      * Have secondary tap handled by TapGestureRecognizer
      
      * update docs
      
      * fix analyzer and address comments
      
      * Add more docs
      
      * Update cancel behavior tol not call on tap cancel when a drag has been accepted
      
      * Change cancel behavior to only cancel if the tap down callback has been sent and merge tapcancel and dragcancel
      
      * update docs;
      
      * Rename selection_gestures to tap_and_drag_gestures
      
      * Address some reviewer comments
      
      * make deadline and slopTolerance private
      
      * updates
      
      * updates
      
      * Address review comments
      
      * remove _initialButtons
      
      * fix docs
      
      * trackTrap -> trackTap
      
      * fix analyzer
      
      * Add test to verify that tap up is called when recognizer accepts before handleEvent is called
      
      * implement Diagnosticable for Details objects;
      
      * sentTapDown == wonArenaForPrimaryPointer, so the implementation now only uses sentTapDown
      
      * Count user tap up immediately and do not wait to win the arena
      
      * Do not need to call super from TapAndDragGestureRecognizer.acceptGesture anymore because mixin implementation is gone
      
      * Do not start selection drag on Android, iOS, and Fuchshsia touch devices if renderEditable does not have focus, this fixes many scubas
      
      * Address reviewer comments
      
      * fix test
      
      * TapAndDragGestureRecognizer should wait for other recognizer to lose before winning the arena
      
      * Address review comments
      
      * Dont check for drag if the start was already found
      
      * Only check for a drag if it has not already been found"
      
      * fix from rebase
      Co-authored-by: 's avatarRenzo Olivares <roliv@google.com>
      cd0f15a7
    • engine-flutter-autoroll's avatar
      Roll Flutter Engine from 7ee3bf518036 to 75d75575d0ea (12 revisions) (#117421) · 014b8f73
      engine-flutter-autoroll authored
      * 2dd2afb49 Roll Skia from e8c3fa6d7d2f to c42beb57e108 (2 revisions) (flutter/engine#38416)
      
      * 333741df5 Roll Fuchsia Mac SDK from NS4fVXM2KhKcZ1uyD... to ev2n-_c3kgBw1h4RG... (flutter/engine#38418)
      
      * 73801d376 Roll Skia from c42beb57e108 to 557183808708 (2 revisions) (flutter/engine#38419)
      
      * 6b7ed7802 Use DisplayListMatrixClipTracker in DisplayListBuilder (flutter/engine#38349)
      
      * e3e288be8 Roll Skia from 557183808708 to 68dbdbdc2e49 (1 revision) (flutter/engine#38420)
      
      * 8e8d7b5d2 Roll Fuchsia Linux SDK from uKNwsaf92uZcX_QiY... to iQT5jpUhipvetxSiH... (flutter/engine#38421)
      
      * c08907c38 Roll Skia from 68dbdbdc2e49 to a8378cd12673 (1 revision) (flutter/engine#38422)
      
      * cf69289fb Roll Skia from a8378cd12673 to eca2fed907ac (3 revisions) (flutter/engine#38423)
      
      * bd4a60454 [Impeller] RRect blur improvements (flutter/engine#38417)
      
      * d4929a7a7 Roll Fuchsia Mac SDK from ev2n-_c3kgBw1h4RG... to nJJfWIwH5zElheIX8... (flutter/engine#38424)
      
      * 91dc9645f Roll Skia from eca2fed907ac to 34fb45763ef7 (3 revisions) (flutter/engine#38425)
      
      * 75d75575d Roll Skia from 34fb45763ef7 to 09d796c0a728 (8 revisions) (flutter/engine#38428)
      014b8f73
    • Siva's avatar
      enable test_ownership in presubmit (#117414) · b3c7fe32
      Siva authored
      b3c7fe32
    • Michael Goderbauer's avatar
  2. 20 Dec, 2022 15 commits