- 17 Aug, 2023 4 commits
-
-
Kate Lovett authored
Found in https://github.com/flutter/packages/pull/4536 The max x and max y index should allow for a case where there are no children in the viewport. This should be CP'd into stable once it lands.
-
Ian Hickson authored
-
Matan Lurey authored
Partial work towards https://github.com/flutter/flutter/issues/132245. The goal here is to "sniff" out any missing pieces that would block engine builds, rolls, benchmarks and so on before requiring humans to provide the parameter. The implementation is based on a [short discussion with @christopherfujino](https://discord.com/channels/608014603317936148/608022056616853515/1141503921546875110): @matanlurey: > Not sure whether to post here or â hackers-infra-ð¡ , but is there a way to (and is it advisable to) detect whether the tool is running in a CI environment? I'd like to "soft enforce" --local-engine-host being provided strictly on CI, make sure that lands well, and then "upgrade" it to being non-CI invocations as well (re: https://github.com/flutter/flutter/issues/132245). > > Also happy to get talked out of this idea ð @christopherfujino: > we have a check, lemme find it > whether or not it is advisable, idk > https://github.com/flutter/flutter/blob/flutter-3.14-candidate.0/packages/flutter_tools/lib/src/base/bot_detector.dart#L30 > > (...) > > is your desire to get early signal before enforcing t his for humans to prevent functionality churn of landing and reverting and re-landing? > > (yes) > > uhh, sure, that's advisable ð
-
Kate Lovett authored
Fixes some poor tests choices in the 2D tests that were identified in https://github.com/flutter/packages/pull/4536
-
- 16 Aug, 2023 24 commits
-
-
Polina Cherkasova authored
-
Renzo Olivares authored
This PR makes sure we do not select beyond the text boundary at the tapped position unless, we tap at the end of the text which in that case we should select the previous text boundary. ```dart // if x is a boundary defined by `textBoundary`, most textBoundaries (except // LineBreaker) guarantees `x == textBoundary.getLeadingTextBoundaryAt(x)`. // Use x - 1 here to make sure we don't get stuck at the fixed point x. final int start = textBoundary.getLeadingTextBoundaryAt(extent.offset - 1) ?? 0; ``` This was originally carried over from https://github.com/flutter/flutter/blob/f468f3366c26a5092eb964a230ce7892fda8f2f8/packages/flutter/lib/src/widgets/editable_text.dart#L4167-L4179 which used this `x - 1` to be able to move to the previous word boundary when navigating with a keyboard. When selecting by tapping/clicking we do not want to move past the text boundary at the tapped position so this adjustment is not needed. Fixes #132126 -
Faisal Ansari authored
In the documentation of _Shaker in InputDecoration "Used to "shake" the floating label to the left and right" to the left was twice I have removed it.
-
Polina Cherkasova authored
Fixes: https://github.com/flutter/flutter/issues/132620
-
Matan Lurey authored
Partial work towards https://github.com/flutter/flutter/issues/132245. I also couldn't help myself to do a very minor refactor and add some comments to `LocalEngineInfo` because I was getting confused myself implementing it.
-
Michael Goderbauer authored
Fixes TODO in the analyzer script :)
-
yaakovschectman authored
Reverts flutter/flutter#132677 Causes failure for `Linux firebase_abstract_method_smoke_test`
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/dbfe71c898b6...12cafaeb9e31 2023-08-16 john@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8f5f8b34c374...dbfe71c898b6 2023-08-16 zanderso@users.noreply.github.com Adds runIf to linux_clang_tidy (flutter/engine#44759) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
Contributes to https://github.com/flutter/flutter/issues/130467 Filed issue: https://github.com/flutter/flutter/issues/132620
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/70b5700b79f6...8f5f8b34c374 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from f30893561924 to d029f149a806 (1 revision) (flutter/engine#44764) 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 3ab12f40c2a4 to f30893561924 (1 revision) (flutter/engine#44761) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
chunhtai authored
see [go/flutter-gar-reporting-q3-2023](http://go/flutter-gar-reporting-q3-2023)
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/84218b9d834c...9bf208f4beb6 2023-08-16 engine-flutter-autoroll@skia.org Manual roll Flutter from 9b6945b4 to f0e7c518 (63 revisions) (flutter/packages#4719) 2023-08-15 31859944+LongCatIsLooong@users.noreply.github.com Update palette_generator_test.dart (flutter/packages#4720) 2023-08-15 mit@google.com [pigeon] Fix typo in README.md (flutter/packages#4707) 2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Explicitly remove READ_EXTERNAL_STORAGE permission (flutter/packages#4716) 2023-08-15 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds support for retrieving user agent (flutter/packages#4563) 2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for video capture (flutter/packages#4620) 2023-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.3 to 2.21.4 (flutter/packages#4706) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f186f1e9dc88...70b5700b79f6 2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 80b9a90ae563 to cc5eeac65f89 (1 revision) (flutter/engine#44758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e8670f03a9b1...f186f1e9dc88 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from cb3451491f11 to 3ab12f40c2a4 (1 revision) (flutter/engine#44756) 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 586a6309e3a1 to cb3451491f11 (2 revisions) (flutter/engine#44755) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
William Hesse authored
PR #132346 added the use of --local-engine-host to flutter_tools internals, and had an error on one line. Fix that error, to use the correct field name. The error occurs when building plugins with the changed tools.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7cc6a5832a0e...e8670f03a9b1 2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from e6bf503b36fe to 80b9a90ae563 (2 revisions) (flutter/engine#44753) 2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from orVLXMF7ak2qfFkGs... to GpKKtPGPMiRcY0kcz... (flutter/engine#44751) 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 8f0238837ee4 to 586a6309e3a1 (2 revisions) (flutter/engine#44752) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from orVLXMF7ak2q to GpKKtPGPMiRc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/decaccfc421d...7cc6a5832a0e 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 3d2b84e28e79 to 8f0238837ee4 (1 revision) (flutter/engine#44748) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/659cdfc5a568...decaccfc421d 2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7iuIq3PsSkuCmuEMr... to Zp9or9YwxZHHPeQbA... (flutter/engine#44747) 2023-08-16 godofredoc@google.com Move cache builders to prod. (flutter/engine#44739) 2023-08-16 26625149+0xZOne@users.noreply.github.com Enabling the host application to control the timing of attaching the |FlutterView| to the engine (flutter/engine#43595) 2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 9fc1c628456a to 3d2b84e28e79 (1 revision) (flutter/engine#44746) 2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from b36934aae968 to e6bf503b36fe (1 revision) (flutter/engine#44745) 2023-08-16 matanlurey@users.noreply.github.com [Skia] Only respect ui.Paint.dither when the colorSource is a gradient (flutter/engine#44730) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from 7iuIq3PsSkuC to Zp9or9YwxZHH If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7409ce4ba0a8...659cdfc5a568 2023-08-16 jonahwilliams@google.com [Impeller] Cache render target texture allocations across frames. (flutter/engine#44527) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
Reverts flutter/flutter#132353 Educated guess that this is causing the docs failures: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8772644466113801713/+/u/Docs/Deploy_docs/Firebase_deploy/stdout
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a9da7212eacf...7409ce4ba0a8 2023-08-16 amirpanahandeh@yahoo.com Add more tests for CompositionAwareMixin (flutter/engine#44717) 2023-08-15 john@johnmccutchan.com Fix clang_tidy lints (flutter/engine#44740) 2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from b07a6964a1cf to 9fc1c628456a (5 revisions) (flutter/engine#44737) 2023-08-15 godofredoc@google.com Add SLSA L1 badge (flutter/engine#44731) 2023-08-15 john@johnmccutchan.com Add support for SurfaceTexture based external textures on Android under Impeller/GLES. (flutter/engine#44734) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/22f03ffdc290...a9da7212eacf 2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from c7c9e85a8657 to b07a6964a1cf (2 revisions) (flutter/engine#44733) 2023-08-15 jonahwilliams@google.com [Impeller] Make porter duff blended atlas calls faster. (flutter/engine#44059) 2023-08-15 skia-flutter-autoroll@skia.org Roll Skia from 4beb6fd05f4f to c7c9e85a8657 (7 revisions) (flutter/engine#44729) 2023-08-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 19c87486f0a9 to b36934aae968 (1 revision) (flutter/engine#44728) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
This relands https://github.com/flutter/flutter/pull/131609 --- fixes [`PopupMenuItem` adds redundant padding when using `ListItem`](https://github.com/flutter/flutter/issues/128553)
-
- 15 Aug, 2023 12 commits
-
-
Tong Mu authored
Fixes https://github.com/flutter/flutter/issues/132433
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/130685 This fixes an issue where a GridView/SliverGrid with a SliverChildBuilderDelegate would still reflect a max scroll extent of infinity after returning null from the builder. This change incorporates the same way we handle this case in SliverList: https://github.com/flutter/flutter/blob/6d87a23b3722e4fb2e2db993322d5be4adf04fb5/packages/flutter/lib/src/rendering/sliver_list.dart#L305-L307
-
Greg Spencer authored
## Description This cleans up a lot of issues with the API doc generation. Here are the main changes: - Rename `dartdoc.dart` to `create_api_docs.dart` - Move the bulk of the operations out of `dev/bots/docs.sh` into `create_api_docs.dart`. - Delete `dashing_postprocess.dart` and `java_and_objc.dart` and incorporate those operations into `create_api_docs.dart`. - Refactor the doc generation into more understandable classes - Bump the snippets tool version to 0.4.0 (the latest one) - Centralize the information gathering about the Flutter repo into the new `FlutterInformation` class. - Clean up the directory handling, and convert to using the `file` package for all file and directory paths. - Add an `--output` option to docs.sh that specifies the location of the output ZIP file containing the docs. - Defaults to placing the output in `dev/docs/api_docs.zip` (i.e. where the previous code generates the file). - Moved all document generation into a temporary folder that is removed once the documents are generated, to avoid VSCode and other IDEs trying to index the thousands of HTML and JS files in the docs output. - Updated pubspec dependencies. ## Tests - Added tests for doc generation.
-
Greg Spencer authored
## Description Fix three memory leaks detected by `about_test.dart`, but were really in the `Route` and `OverlayEntry` classes. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/130354 ## Tests - Updates about_test.dart to not ignore the leaks anymore.
-
Polina Cherkasova authored
-
Gray Mackall authored
Fixes https://github.com/flutter/flutter/issues/126690. Encountered while testing https://github.com/flutter/flutter/pull/132406. Updates the signature to be in line with the [current typedef](https://github.com/flutter/flutter/blob/b3096225e0ebc005ed678fa7a9f03164caba1d73/packages/integration_test/lib/common.dart#L26).
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0760b5589c71...22f03ffdc290 2023-08-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -16K9GvYE3a4Bqs0G... to orVLXMF7ak2qfFkGs... (flutter/engine#44726) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from -16K9GvYE3a4 to orVLXMF7ak2q If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Srujan Gaddam authored
Function.toJS will start requiring that the function accept and return JS types only. Allows https://dart-review.googlesource.com/c/sdk/+/316867 to land.
-
Michael Goderbauer authored
-
keyonghan authored
This is to avoid old docs published by backfilling.
-
Ian Hickson authored
Further follow-up for https://github.com/flutter/flutter/issues/122421.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/08080abd9cbb...84218b9d834c 2023-08-14 stuartmorgan@google.com [file_selector] Fix default accept types on iOS (flutter/packages#4691) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
