- 17 Oct, 2016 9 commits
-
-
Adam Barth authored
Also, update the docs to point to the correct property. Fixes #6224
-
Adam Barth authored
Developers need to get the size of the BuildContext sufficiently often that we should provide a convenient getter for the value. Having this getter is also an opportunity to catch common mistakes and provide useful error messages that guide developers towards better patterns. Fixes #2321
-
Adam Barth authored
Fixes #6245
-
Adam Barth authored
Fixes #6209
-
Adam Barth authored
Fixes #773
-
Phil Quitslund authored
-
Adam Barth authored
Previously, we were nulling out the ArenaEntry in MultiDragPointerState too early, which was prevent MultiDragPointerState from rejecting the gesture in `dispose` if we hadn't accepted by the time the pointer went up. Now we properly reject the gesture, which causes the tap gesture to win during `sweep` in the arena. Also, add a bunch of docs and annotations based on information I learned while studying this issue. Finally, rename a private member of tap recognizer to a name that would have confused me less in my investigation. Fixes #1186
-
Adam Barth authored
When I changed how routes complete their futures, I broke the Dropdown button because it was still waiting for its own Completer to complete instead of using the Future returned by push. This patch fixes that issue. I've also removed the previous behavior of the DropdownButton forwarding its text style to its route. The mechansim that we were using doesn't work properly in all cases. For example, if the DropdownButton is a child of a LayoutBuilder, then the route will have already built by the time the DropdownButton gets a chance to forward its text style, causing an assert in setState. Finally, I've tweaked PopupMenuButton to work the same way as DropdownButton in a couple corner cases (e.g., not calling the changed callback if the button was removed from the tree before the menu completed its Future). Fixes #6352
-
Adam Barth authored
Fixes #6351
-
- 16 Oct, 2016 3 commits
-
-
Devon Carew authored
-
Adam Barth authored
Previously we would maroon the feedback in the overlay. Now we let the drag proceed and only tear down the gesture recognizer when all the drags it spawns have been resolved. Fixes #6151
-
Adam Barth authored
This patch also makes it possible for a single DragTarget to handle multiple draggables with the same data without asserting. Fixes #6086
-
- 15 Oct, 2016 5 commits
-
-
Adam Barth authored
Fixes #6084
-
Adam Barth authored
Previously we were relying on the gesture arena to call us back to cancel our timer. However, in the case where we've already been accepted, asking the gesture arena to reject us doesn't lead to a callback and we fail to stop the timer (and hence trigger an assert). Fixes #6156
-
Adam Barth authored
-
Hans Muller authored
-
Adam Barth authored
-
- 14 Oct, 2016 11 commits
-
-
Adam Barth authored
These futures complete when the route is popped off the navigator. This generalizes and simplifies a mechanism already in place for dialogs and menus. Fixes #5283
-
Todd Volkert authored
-
Adam Barth authored
When not dismissing, the Dismissable widget should cull its background. When a dismiss is in progress, it should clip the background to just the part that is revealed. Fixes #6127
-
Chris Bracken authored
Ensure that any new/changed doctor checks are evaluated and reported post upgrade.
-
Adam Barth authored
Fixes #6311
-
Adam Barth authored
-
Adam Barth authored
Previously we assumed the dial was square, which isn't always the case. Fixes #6315
-
Ian Hickson authored
I added some documentation to Input as I was learning how it worked (and some minor tweaks, like handling reparenting better).
-
Matt Perry authored
* Add a maxLines parameter for multiline Input. If maxLines is 1, it's a single line Input that scrolls horizontally. Otherwise, overflowed text wraps and scrolls vertically, taking up at most `maxLines`. Also fixed scrolling behavior so that the Input scrolls ensuring the cursor is always visible. Fixes https://github.com/flutter/flutter/issues/6271 * oops * comments * import * test and RO.update fix * constant * fix.caretRect
-
Ian Hickson authored
Previously it implied that you had to always say lib/main.dart in the "flutter run" command.
-
Adam Barth authored
-
- 13 Oct, 2016 12 commits
-
-
Adam Barth authored
-
Todd Volkert authored
Fixes #6283
-
Adam Barth authored
Instead, we now interact with the system navigator via SystemNavigator.
-
Ian Hickson authored
Previously, if you focused a field, fields below it would shift down by one pixel. This change tries to guarantee that that won't happen.
-
Adam Barth authored
We weren't computing the bounds for composited transforms correctly. We need to conjugate the transform by the offset in order to get the correct paint bounds for the composited layer. We now also use the same math in the non-composited case for consistency. Also, don't scale the z-coordinate in RenderFittedBox. Fixes #6293
-
Jason Simmons authored
This is needed to update an app's layout when a soft keyboard is shown
-
Adam Barth authored
-
Adam Barth authored
-
Phil Quitslund authored
Sets a minimal baseline version for IDEs to verify a hot-reload supporting SDK. Fixes: https://github.com/flutter/flutter-intellij/issues/293
-
Dan Rubel authored
* cleanup obtaining user home directory path * refactor doctor and detect IntelliJ on Mac * fix detect Flutter plugin for IntelliJ
-
Adam Barth authored
* Switch to using PlatformPlugin instead of mojom * Update engine.version
-
Devon Carew authored
-