1. 06 Feb, 2019 2 commits
  2. 30 Jan, 2019 1 commit
  3. 24 Jan, 2019 1 commit
  4. 16 Jan, 2019 1 commit
  5. 15 Jan, 2019 1 commit
  6. 19 Dec, 2018 1 commit
  7. 11 Nov, 2018 1 commit
  8. 06 Nov, 2018 1 commit
  9. 22 Oct, 2018 1 commit
  10. 05 Oct, 2018 1 commit
  11. 19 Sep, 2018 1 commit
  12. 18 Sep, 2018 3 commits
    • Chris Bracken's avatar
      Use Xcode legacy build system for iOS builds (#21901) (#21994) · f8c50ea1
      Chris Bracken authored
      Xcode 10 introduces a new build system which includes stricter checks on
      duplicate build outputs.
      
      When plugins are in use, there are two competing build actions that copy
      Flutter.framework into the build application Frameworks directory:
      
        1. The Embed Frameworks build phase for the Runner project
        2. The [CP] Embed Pods Frameworks build phase that pod install creates
           in the project.
      
      Item (1) is there to ensure the framework is copied into the built app
      in the case where there are no plugins (and therefore no CocoaPods
      integration in the Xcode project). Item (2) is there because Flutter's
      podspec declares Flutter.framework as a vended_framework, and CocoaPods
      automatically adds a copy step for each such vended_framework in the
      transitive closure of CocoaPods dependencies.
      
      As an immediate fix, we opt back into the build system used by Xcode 9
      and earlier. Longer term, we need to update our templates and
      flutter_tools to correctly handle this situation.
      
      See: https://github.com/flutter/flutter/issues/20685
      f8c50ea1
    • Chris Bracken's avatar
      Revert "Use Xcode legacy build system for iOS builds (#21901)" (#21966) · 4c045e79
      Chris Bracken authored
      This caused issues for projects without an Xcode workspace. Almost all
      Flutter projects in the wild will have a workspace, but this patch needs
      to add a check to catch any that lack one.
      
      This reverts commit 021f472e.
      4c045e79
    • Chris Bracken's avatar
      Use Xcode legacy build system for iOS builds (#21901) · 021f472e
      Chris Bracken authored
      Xcode 10 introduces a new build system which includes stricter checks on
      duplicate build outputs.
      
      When plugins are in use, there are two competing build actions that copy
      Flutter.framework into the build application Frameworks directory:
      
        1. The Embed Frameworks build phase for the Runner project
        2. The [CP] Embed Pods Frameworks build phase that pod install creates
           in the project.
      
      Item (1) is there to ensure the framework is copied into the built app
      in the case where there are no plugins (and therefore no CocoaPods
      integration in the Xcode project). Item (2) is there because Flutter's
      podspec declares Flutter.framework as a vended_framework, and CocoaPods
      automatically adds a copy step for each such vended_framework in the
      transitive closure of CocoaPods dependencies.
      
      As an immediate fix, we opt back into the build system used by Xcode 9
      and earlier. Longer term, we need to update our templates and
      flutter_tools to correctly handle this situation.
      
      See: https://github.com/flutter/flutter/issues/20685
      021f472e
  13. 12 Sep, 2018 1 commit
  14. 05 Sep, 2018 1 commit
    • tonyzhao1's avatar
      Create categories for doctor validators (#20758) · 58d98ce3
      tonyzhao1 authored
      * First step in Flutter Doctor refactor. Assigns categories to all validators.
      
      * Revert "Roll engine e54bc4ea1832..a84b210b3d26 (6 commits) (#20453)"
      
      This reverts commit 05c2880a.
      
      * Split iOS and Android workflows into workflow and validator classes.
      
      * Change ValidatorCategory to handle standalone validators that share a
      category (e.g. IntelliJ).
      
      Also make Android Studio and Android toolchain use separate categories.
      
      At this stage, flutter doctor output matches what it was previously.
      (The summary() method itself has not yet been changed )
      
      * Change doctor summary code to support validator categories.
      
      Output is still unchanged.
      
      * Handle small formatting issues.
      
      * Flip Flutter category's isGroup field to false until it's actually
      needed.
      
      * Revert auto-generated formatting changes to keep those lines from
      muddying the pull.
      
      * Small fixes pointed out by analyzer.
      
      * Properly fix analyzer issues around const constructors.
      
      * Small changes to address comments.
      
      * Add tests to verify grouped validator behavior and validationtype
      merging.
      
      * Update doctor.dart
      
      * Add comments for clarification.
      58d98ce3
  15. 24 Jul, 2018 1 commit
  16. 27 Jun, 2018 1 commit
  17. 15 Jun, 2018 2 commits
  18. 09 May, 2018 1 commit
  19. 08 May, 2018 1 commit
  20. 04 May, 2018 2 commits
  21. 01 May, 2018 1 commit
    • Chris Bracken's avatar
      Simplify iOS debug build (#17145) · 68a1e2f7
      Chris Bracken authored
      iOS debug builds always run in interpreted mode whether on device or on
      simulator. In both cases, we can skip snapshotting and link against an
      empty App.framework. Previously, we did this for iOS simulator builds.
      This does the same for device builds.
      
      Previously, debug iOS builds used gen_snapshot to generate a core
      snapshot, then used 'xxd' to generate C files containing the snapshot
      data in buffers named kDartVmSnapshotData and kDartIsolateSnapshotData,
      which are then compiled/linked into App.framework. This is unnecessary
      since the VM compiled into Flutter.framework already contains this data.
      68a1e2f7
  22. 30 Apr, 2018 2 commits
  23. 26 Apr, 2018 1 commit
  24. 25 Apr, 2018 1 commit
  25. 24 Apr, 2018 1 commit
    • Chris Bracken's avatar
      Extract KernelCompiler class (#16937) · 7ffcd3d2
      Chris Bracken authored
      Wraps the compile function in a class injected via the global context,
      which makes it easier to mock in unit tests -- specifically tests for
      AOT snapshotting, which already require pretty significant amounts of
      mock inputs.
      7ffcd3d2
  26. 28 Mar, 2018 2 commits
  27. 21 Feb, 2018 1 commit
  28. 14 Feb, 2018 1 commit