1. 02 May, 2023 1 commit
    • Casey Rogers's avatar
      Make `future` and `stream` required arguments in their respective builder widgets (#125838) · 4d86f5d0
      Casey Rogers authored
      cc'ing existing conversation participants: @domesticmouse @srawlins
      cc'ing to request review: @goderbauer 
      
      This PR makes the following constructor arguments required:
      1. `FutureBuilder.future`
      2. `StreamBuilderBase.stream`
      3. `StreamBuilder.stream`
      
      This fixes:
      https://github.com/flutter/flutter/issues/83081
      https://github.com/flutter/flutter/issues/125188 (dupe of 83081)
      
      This obviates:
      https://github.com/dart-lang/linter/issues/4309
      (I suggest we skip straight to merging this PR as this should be a low impact breaking change-assuming few to no devs are intentionally using the builders without their relevant arguments, however we could always merge 4309 first and then this)
      https://github.com/flutter/flutter/pull/83101 
      (The above PR required that at least one of future and initial data be non-null, this is undesirable as there are plenty of valid reasons to have both arguments be null)
      
      See above issues for a deeper dive, but here is a summary:
      It is very easy for a developer to forget to specify `future` or `stream` when using the respective `*Builder` widgets. This produces a non-obvious failure where the UI sits in a "no data yet received" state. It is easy for a dev to misinterpret this as the async work backing the future/stream hanging and they thus waste a lot of time trying to debug the async work.
      As such, we should require these two constructor arguments to make it impossible/much harder for devs to make this time-wasting mistake.
      
      This is a breaking change. However, it should break only a small number of active projects given that using a builder without specifying `future` or `stream` seems highly niche.
      The only place I've found non-accidental examples of this is in widget tests where you're calling `pumpWidget` with and without these arguments to test `*Builder.didUpdateWidget`'s behavior. In this and similar cases, it is a trivial fix to add `future: null`/`stream: null`.
      
      *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
      4d86f5d0
  2. 22 Mar, 2023 1 commit
  3. 17 Mar, 2023 1 commit
  4. 25 Jan, 2023 1 commit
  5. 24 Jan, 2023 1 commit
  6. 21 Dec, 2022 1 commit
  7. 03 Dec, 2022 1 commit
  8. 12 Nov, 2022 1 commit
  9. 26 May, 2022 1 commit
  10. 14 Apr, 2022 1 commit
  11. 01 Mar, 2022 1 commit
  12. 07 Dec, 2021 1 commit
  13. 11 Oct, 2021 1 commit
  14. 04 Oct, 2021 1 commit
    • Greg Spencer's avatar
      Clean up examples, remove section markers and --template args (#91133) · fd9ce277
      Greg Spencer authored
      This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder.
      
      I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed.
      
      I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
      fd9ce277
  15. 25 Aug, 2021 1 commit
    • Greg Spencer's avatar
      Extract Sample code into examples/api (#87280) · 33403bd2
      Greg Spencer authored
      This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
      33403bd2
  16. 13 Jul, 2021 1 commit
  17. 03 May, 2021 1 commit
  18. 12 Mar, 2021 1 commit
  19. 24 Dec, 2020 1 commit
  20. 16 Dec, 2020 1 commit
  21. 11 Dec, 2020 1 commit
  22. 14 Nov, 2020 1 commit
  23. 08 Oct, 2020 1 commit
  24. 24 Sep, 2020 1 commit
  25. 15 Sep, 2020 1 commit
    • Alexandre Ardhuin's avatar
      Reland "Nnbd widgets" (#65528) · b007a81a
      Alexandre Ardhuin authored
      * Reland "Nnbd widgets (#64672)"
      
      This reverts commit 127e6790.
      
      * remove non-nullable enforcement on AsyncSnapshot
      
      * make data param non-nullable for AsyncSnapshot.withData
      
      * make some Text params non-nullable
      b007a81a
  26. 09 Sep, 2020 2 commits
    • Michael Goderbauer's avatar
      Revert "Nnbd widgets (#64672)" (#65488) · 127e6790
      Michael Goderbauer authored
      This reverts commit e682ec71.
      127e6790
    • Alexandre Ardhuin's avatar
      Nnbd widgets (#64672) · e682ec71
      Alexandre Ardhuin authored
      * migrate widget to nullsafety
      
      * remove double blank line after license
      
      * address review comments in actions.dart
      
      * nullable ObjectKey.value
      
      * use local variable oldElement
      
      * make State.build non-nullable
      
      * make State.context non-nullable
      
      * newline at eof
      
      * make ProxyWidget.child non-nullable
      
      * make _InactiveElements.debugContains non-nullable
      
      * make Element.depth non-nullable
      
      * make ProxyElement.build non-nullable
      
      * make StatefulElement.state non-nullable
      
      * remove 'Notice that'
      
      * avoid cast of list in RenderObjectElement.updateChildren
      
      * make IndexedSlot.value non-nullable
      
      * avoid cast of list in MultiChildRenderObjectElement.mount
      
      * make some WidgetsApp parameters non-nullable
      
      * hitTest take non-nullable position
      
      * make ScrollableState.position non-nullable
      
      * use _pixels instead of pixels
      
      * make ViewportOffset.pixels non-nullable
      
      * make param and return type of IndexedWidgetBuilder non-nullable
      
      * unused_import
      
      * make context param non-nullable for Builder in animated_list.dart
      
      * make ScrollMetrics.viewportDimension non-nullable
      
      * make ScrollMetrics.{min,max}ScrollExtent non-nullable
      
      * make _Location.file non-nullable
      
      * _WidgetForTypeTests.createElement throw UnimplementedError
      
      * update _NullWidget.build error message
      
      * make _ShortcutsState.manager non-nullable
      
      * Fix childCount issues for NNBD
      
      * fix childCount computation on web
      
      * increase max value on js side to compute childCount
      
      * make aspect parameter of dependOnInheritedWidgetOfExactType nullable
      
      * merge has{min,max}ScrollExtent into hasScrollExtents
      
      * update focus_manager.dart
      
      * address review comments in icon.dart
      
      * address review comments in image.dart
      
      * address review comments in routes.dart
      
      * address review comments in scroll_activity.dart
      
      * update doc comments
      
      * make UserScrollNotification.direction non-nullable and required
      
      * rename hasScrollExtents to hasContentDimensions
      
      * unnecessary late
      Co-authored-by: 's avatarIan Hickson <ian@hixie.ch>
      e682ec71
  27. 10 Aug, 2020 1 commit
  28. 29 Jul, 2020 1 commit
  29. 11 Jun, 2020 1 commit
  30. 04 Jun, 2020 1 commit
  31. 06 May, 2020 1 commit
  32. 10 Feb, 2020 1 commit
    • Greg Spencer's avatar
      Update samples to work with Dartpad, and convert all that make… (#50377) · 9fb781a5
      Greg Spencer authored
      This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site.
      
      It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally.
      
      I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level).
      
      I modified a few of the examples so that they looked nicer, and fit better on the page.
      
      I added the sample description text above each DartPad instance, since that often defines the context of the example.
      
      I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
      9fb781a5
  33. 15 Jan, 2020 1 commit
  34. 09 Jan, 2020 1 commit
  35. 08 Jan, 2020 1 commit
  36. 04 Dec, 2019 2 commits
  37. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  38. 17 Sep, 2019 1 commit