1. 04 Oct, 2019 4 commits
  2. 02 Oct, 2019 3 commits
    • Shi-Hao Hong's avatar
      Update DefaultTabController to allow for zero tabs (#41625) · 27a12efa
      Shi-Hao Hong authored
      * Update DefaultTabController to allow for zero tabs
      27a12efa
    • Shi-Hao Hong's avatar
      [Material] Fix Tooltip to respect ambient Directionality (#41629) · 913aca22
      Shi-Hao Hong authored
      * Fix Tooltip Directionality
      
      * Add regression test comment for tooltip directionality fix
      913aca22
    • Greg Spencer's avatar
      Add an ActivateAction to controls that use InkWell. (#41220) · 4512a1c1
      Greg Spencer authored
      Adds an ActivateAction to controls that use InkWell. Make InkWell host the Focus for those controls, and add the top level binding to the ENTER key. This will make it possible to trigger a button using the enter key, and to get an ink response when the button is triggered.
      
      This is a breaking change because it moves the Focus widget into the InkWell. If you have a component that uses the InkWell directly and you used to wrap that InkWell in a Focus widget to give it its notion of focus, it will now not look for that Focus ancestor for its focus state anymore. In order to control focus on the InkWell, you need to give it a FocusNode directly, via the new focusNode parameter. This should not affect users of widgets like OutlineButton or FloatingActionButton and the like, since those have been modified in this PR.
      4512a1c1
  3. 01 Oct, 2019 1 commit
    • Slade Capasso's avatar
      range_slider_test.dart diagnostics property tests (#40291) · a9c28d5f
      Slade Capasso authored
      * Updates to slider_test.dart
      
      Fixed error that required onChanged.
      
      * Updated slider.dart and slider_test.dart debugFillProperties
      
      Updated slider.dart debugFillProperties to include all properties and slider_test debugFillProperties to test all properties
      
      * Updated Slider onChanged property
      
      * Updated debugFillProperties to ignore testing methods that are null in test
      
      Per feedback from Hans/Anthony on Flutter Material
      
      * Updated spacing in debugFillProperties
      
      Per feedback from Hans
      
      * Updated range_slider.dart and range_slider_test.dart to have DiagnosticProperties tests for all properties
      
      * Updated range_slider.dart and range_slider_test.dart per feedback
      
      Preventing null labels from creating an error.
      
      Added made RangeLabels and RangeValues constants in instantiation of Range Slider.
      
      Fixed spacing.
      
      * Updates to start and end labels in diagnostic property tests
      
      Updated per feedback from @clocksmith
      a9c28d5f
  4. 30 Sep, 2019 2 commits
  5. 28 Sep, 2019 1 commit
  6. 27 Sep, 2019 3 commits
  7. 26 Sep, 2019 3 commits
    • Greg Spencer's avatar
      Added proper focus handling when pushing and popping routes (#40166) · 1a7bb1f5
      Greg Spencer authored
      The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped.
      
      This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node.
      
      This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
      1a7bb1f5
    • Greg Spencer's avatar
      Fix mouse hover to not schedule a frame for every mouse move. (#41014) · 05097916
      Greg Spencer authored
      This fixes the mouse hover code to not schedule frames with every mouse move.
      
      Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame.
      
      The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
      05097916
    • Hans Muller's avatar
  8. 24 Sep, 2019 5 commits
  9. 18 Sep, 2019 1 commit
  10. 17 Sep, 2019 6 commits
  11. 16 Sep, 2019 1 commit
  12. 14 Sep, 2019 1 commit
  13. 13 Sep, 2019 2 commits
  14. 10 Sep, 2019 3 commits
  15. 06 Sep, 2019 1 commit
  16. 05 Sep, 2019 2 commits
  17. 04 Sep, 2019 1 commit