- 04 Oct, 2019 4 commits
-
-
Rody Davis authored
-
krisgiesing authored
This reverts commit 2b138fd7.
-
Alexandre Ardhuin authored
-
Greg Spencer authored
-
- 02 Oct, 2019 3 commits
-
-
Shi-Hao Hong authored
* Update DefaultTabController to allow for zero tabs
-
Shi-Hao Hong authored
* Fix Tooltip Directionality * Add regression test comment for tooltip directionality fix
-
Greg Spencer authored
Adds an ActivateAction to controls that use InkWell. Make InkWell host the Focus for those controls, and add the top level binding to the ENTER key. This will make it possible to trigger a button using the enter key, and to get an ink response when the button is triggered. This is a breaking change because it moves the Focus widget into the InkWell. If you have a component that uses the InkWell directly and you used to wrap that InkWell in a Focus widget to give it its notion of focus, it will now not look for that Focus ancestor for its focus state anymore. In order to control focus on the InkWell, you need to give it a FocusNode directly, via the new focusNode parameter. This should not affect users of widgets like OutlineButton or FloatingActionButton and the like, since those have been modified in this PR.
-
- 01 Oct, 2019 1 commit
-
-
Slade Capasso authored
* Updates to slider_test.dart Fixed error that required onChanged. * Updated slider.dart and slider_test.dart debugFillProperties Updated slider.dart debugFillProperties to include all properties and slider_test debugFillProperties to test all properties * Updated Slider onChanged property * Updated debugFillProperties to ignore testing methods that are null in test Per feedback from Hans/Anthony on Flutter Material * Updated spacing in debugFillProperties Per feedback from Hans * Updated range_slider.dart and range_slider_test.dart to have DiagnosticProperties tests for all properties * Updated range_slider.dart and range_slider_test.dart per feedback Preventing null labels from creating an error. Added made RangeLabels and RangeValues constants in instantiation of Range Slider. Fixed spacing. * Updates to start and end labels in diagnostic property tests Updated per feedback from @clocksmith
-
- 30 Sep, 2019 2 commits
-
-
Alexandre Ardhuin authored
* add missing trailing commas * add more missing trailing commas * add more and more missing trailing commas
-
Erick Ghaumez authored
* set the copyWith toggleButtonsTheme argument type to ToggleButtonsThemeData * add a ThemeData.copyWith test
-
- 28 Sep, 2019 1 commit
-
-
MH Johnson authored
* remove splash logic * update tests
-
- 27 Sep, 2019 3 commits
-
-
krisgiesing authored
ReorderableListView was constructing a GlobalObjectKey using the child key as the value. This only had the intended behavior if the child key was identical across build method invocations. The new strategy is to scope the child key's value to the State object's identity, allowing child keys to have value compare semantics while disambiguating among different list view instances.
-
Alexandre Ardhuin authored
-
Hans Muller authored
This reverts commit e47a1dc2.
-
- 26 Sep, 2019 3 commits
-
-
Greg Spencer authored
The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped. This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node. This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
-
Greg Spencer authored
This fixes the mouse hover code to not schedule frames with every mouse move. Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame. The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
-
Hans Muller authored
-
- 24 Sep, 2019 5 commits
-
-
imzyy authored
-
Hans Muller authored
-
Alexandre Ardhuin authored
-
Greg Spencer authored
There were four or five different implementations in various tests for sendFakeKeyEvent, which roughly all did the same thing. I was going to add yet another one, and decided that it needed to be generalized and centralized. This replaces those instances with something that just takes a LogicalKeyboardKey so that it's self-documenting, and can be used with multiple platforms. This adds two functions to widget tester: sendKeyDownEvent and sendKeyUpEvent which simulate key up/down from a physical keyboard. It also adds global functions simulateKeyDownEvent and simulateKeyUpEvent that can be called without a widget tester. All are async functions protected by the async guard.
-
Alexandre Ardhuin authored
-
- 18 Sep, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 17 Sep, 2019 6 commits
-
-
Michael Goderbauer authored
This reverts commit 6ad88bd5.
-
Michael Goderbauer authored
-
Anthony authored
Add the option to configure a chip check mark color
-
xster authored
-
Hans Muller authored
-
Alexandre Ardhuin authored
-
- 16 Sep, 2019 1 commit
-
-
Hans Muller authored
-
- 14 Sep, 2019 1 commit
-
-
Shi-Hao Hong authored
* Implement DropdownButton.selectedItemBuilder
-
- 13 Sep, 2019 2 commits
-
-
Michael Goderbauer authored
-
Shi-Hao Hong authored
* Add constraints property, updated default constraints for ToggleButtons to 48x48 * Add kMinInteractiveDimension constant to ToggleButtons
-
- 10 Sep, 2019 3 commits
-
-
Greg Spencer authored
Fixed passing autofocus to MaterialButton, and when rebuilding Focus widget, and added a test for Focus and MaterialButton to test that it works properly.
-
Sarbagya Dhaubanjar authored
* Added properties in DropdownFormField to match DropdownButton * Minor style guide related changes
-
Slade Capasso authored
-
- 06 Sep, 2019 1 commit
-
-
lisa-liao authored
-
- 05 Sep, 2019 2 commits
-
-
Shi-Hao Hong authored
* Improve finders throughout toggle_buttons_test.dart * Improve Material finders * Update toggle_buttons_theme_test.dart finders to be more precise * Refactor out textStyle and iconTheme finders * Refactor iconTheme and buttonTextTheme logic
-
- 04 Sep, 2019 1 commit
-
-
rami-a authored
-