1. 27 Jul, 2016 1 commit
    • Ian Hickson's avatar
      Fix DatePicker (#5061) · 1097d92a
      Ian Hickson authored
      Fundamentally the core problem was that we were not saying how wide a
      date picker should be. It should be 330 pixels, if I'm measuring the
      spec's mocks correctly.
      1097d92a
  2. 07 Jul, 2016 1 commit
    • Adam Barth's avatar
      Cleanup axis-aligned padding (#4845) · 9e111d18
      Adam Barth authored
      We now have an EdgeInsets.along function that projects the padding onto the
      given Axis rather than repeating this function in several places.
      9e111d18
  3. 14 Jun, 2016 2 commits
    • pq's avatar
      Added asserts. · f5a4e632
      pq authored
      f5a4e632
    • pq's avatar
      Add missing returns. · 7a955487
      pq authored
      As of `1.18.0-dev-0`, these cases will get flagged.  In the meantime, the
      7a955487
  4. 08 Jun, 2016 1 commit
  5. 07 Jun, 2016 1 commit
  6. 03 Jun, 2016 1 commit
  7. 02 Jun, 2016 1 commit
  8. 01 Jun, 2016 1 commit
  9. 31 May, 2016 1 commit
  10. 29 May, 2016 1 commit
    • Adam Barth's avatar
      Remove OverlayPainter mechanism (#4264) · 76772608
      Adam Barth authored
      We used to use this mechanism to paint scrollbars, but it's awkward. The
      new approach to scrollbars is much cleaner. This mechanism has no other
      clients, so we should remove it.
      76772608
  11. 27 May, 2016 1 commit
  12. 26 May, 2016 1 commit
  13. 12 May, 2016 1 commit
  14. 11 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Add even more careful checks around BoxConstraints (#3243) · 47f5c6f2
      Ian Hickson authored
      I ran into a case where I was setting minHeight=∞ and then calling
      layout() with that constraint, which is all kinds of bad. To try to
      catch this earlier, this patch now provides a way to catch constraints
      that are requiring infinite values.
      
      We don't _always_ check this because there are valid uses for
      BoxConstraints.biggest, e.g. as an additionalConstraint.
      47f5c6f2
  15. 09 Apr, 2016 1 commit
  16. 06 Apr, 2016 1 commit
    • Adam Barth's avatar
      LazyBlock docs and physics · 6fd68597
      Adam Barth authored
      This patch adds dartdoc to LazyBlock. Also, this patch fixes the scrolling
      physics of LazyBlock. Previously, we updated a running simulation only when the
      change in scroll behavior changed the current scroll offset. Now we update
      running simulations every time the behavior changes because the simulation
      might depend on quantities other than the current scroll offset.
      6fd68597
  17. 28 Mar, 2016 1 commit
  18. 24 Mar, 2016 1 commit
  19. 14 Mar, 2016 1 commit
  20. 12 Mar, 2016 3 commits
  21. 07 Mar, 2016 1 commit
  22. 04 Mar, 2016 1 commit
  23. 25 Feb, 2016 1 commit
    • Hixie's avatar
      Remove size observers from scrollables. · f8080557
      Hixie authored
      Also:
       - add operator==/hashCode/toString to ViewportDimensions
       - add toString to BindingBase
       - add toString and debugFillDescription to ScrollBehavior
       - fix a bug in the RawGestureDetectorState's replaceGestureRecognizers
       - rename MixedViewport's onExtentsUpdate to onExtentChanged
       - replace ExtentsUpdateCallback with ValueChanged<double>
       - remove a microtask for dispatching scroll start, since it
         did not appear to have any purpose
       - added dartdocs to Instrumentation until I understood it
       - made all event dispatch in Instrumentation drain microtasks
      f8080557
  24. 11 Feb, 2016 1 commit
    • Ian Hickson's avatar
      Clean up imports and exports. · a94999ba
      Ian Hickson authored
      Each layer is supposed to reexport the parts of the previous layer
      that are part of its API.
      
      - In painting.dart, export from dart:ui all the Canvas-related APIs
        that make sense to be used at higher levels, e.g. PaintingStyle.
      
      - Delete painting/shadows.dart. It was dead code.
      
      - In rendering/object.dart, export all of painting.dart.
      
      - In widgets/basic.dart, export all of painting.dart and
        animation.dart. Some classes in animation/ are renamed to make this
        less disruptive and confusing to the namespace.
      
      - Split out Stocks back into an import model rather than a part model,
        so that it's easier to manage its dependencies on a per-file basis.
      
      - Move Ticker to scheduler library.
      
      - Remove as many redundant imports as possible now.
      
      - Some minor nit picking cleanup in various files.
      a94999ba
  25. 10 Feb, 2016 1 commit
    • Hixie's avatar
      More BoxConstraints asserts · 29654016
      Hixie authored
      The asserting will continue until morale improves!
      
      * Convert all assert(*.isNormalized) checks to use the new
        debugAssertIsNormalized technology.
      * Convert CustomMultiChildLayout to use the new RenderingError
        technology to greatly improve the detail in errors you get when
        writing CustomMultiChildLayout delegates.
      * Add BoxConstraints.copyWith().
      * Indent the descendants in the rendering exception data dump so that
        when you have multiple children it's clearer what's going on.
      29654016
  26. 09 Feb, 2016 3 commits
  27. 06 Feb, 2016 2 commits
    • Adam Barth's avatar
      Add more dartdoc to widgets.dart · 9251504a
      Adam Barth authored
      This patch includes documentation for transitions.dart and for
      scrollable.dart.
      9251504a
    • Adam Barth's avatar
      Remove HomogeneousViewport · 5b896694
      Adam Barth authored
      The virtual viewport machinery now handles all of these use cases.
      Previous clients of ScrollableWidgetList can use ScrollableLazyList
      instead.
      5b896694
  28. 27 Jan, 2016 1 commit
  29. 18 Jan, 2016 1 commit
    • Ian Hickson's avatar
      Fix some intrinsic constraints contract violations. · 60d9ab7e
      Ian Hickson authored
      RenderBlock wasn't constraining the results.
      RenderPadding wasn't constraining the results (which matters
      especially when the constraints can't fit the padding in the first
      place).
      RenderViewport wasn't constraining the results.
      
      Add a test for the block case.
      
      To catch this kind of thing in the future, add some asserts to
      debugDoesMeetConstraints() that all four intrinsic functions return
      values that are within the constraints.
      
      RenderBlockViewport doesn't support returning intrinsics, so turn off
      the "no intrinsic support" asserts (and return zero) when we're doing
      this new assert.
      
      This new assert screwed up the custom layout classes' tests, so adjust
      those tests to ignore the callbacks invoked from these asserts.
      
      Add to the _debugReportException() method a short summary of the
      descendants of this node. It's important to have this information when
      debugging errors like these intrinsic constraints contract violations
      because often nodes just pass the values through to their child so you
      have to go several steps down to find the actual problem.
      
      Fixes https://github.com/flutter/flutter/issues/1210
      60d9ab7e
  30. 11 Jan, 2016 1 commit
  31. 06 Jan, 2016 1 commit
    • Adam Barth's avatar
      Switch clients of ScrollableList to ScrollableList2 · b1f9138f
      Adam Barth authored
      This patch also changed ScrollableList2 to use an Iterable instead of an
      List for its children. This change lets clients map their underlying
      data lazily. If the clients actually have a concrete list, we skip the
      extra copy and grab the child list directly.
      b1f9138f
  32. 05 Jan, 2016 3 commits
    • Adam Barth's avatar
      Complete features of ScrollableList2 · 37106ea6
      Adam Barth authored
      This patch implements the remaining missing features of ScrollableList2.
      It should now be nearly a drop-in replacement for ScrollableList. The
      next patch will switch callers over to the new machinery.
      37106ea6
    • Adam Barth's avatar
      Remove ScrollDirection.both · 7aa575b0
      Adam Barth authored
      Almost none of the clients of ScrollDirection can handle scrolling in both
      directions.
      
      Fixes #151
      7aa575b0
    • Adam Barth's avatar
      Introduce ScrollableList2 · 99bca282
      Adam Barth authored
      ScrollableList2 uses the same pattern as ScrollableGrid, which requires the
      client to allocate widgets for every list item but doesn't inflate them unless
      they're actually needed for the view. It improves on the original
      ScrollableList by not requiring a rebuild of the whole visible portion of the
      list when scrolling. In fact, small scrolls can often be handled entirely by
      repainting.
      99bca282