Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
b5923f92
Commit
b5923f92
authored
Mar 12, 2016
by
Adam Barth
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[rename fixit] Painter -> RenderObjectPainter
Fixes #774
parent
d78b78c4
Changes
10
Hide whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
21 additions
and
21 deletions
+21
-21
block.dart
packages/flutter/lib/src/rendering/block.dart
+4
-4
grid.dart
packages/flutter/lib/src/rendering/grid.dart
+1
-1
list.dart
packages/flutter/lib/src/rendering/list.dart
+1
-1
object.dart
packages/flutter/lib/src/rendering/object.dart
+1
-1
viewport.dart
packages/flutter/lib/src/rendering/viewport.dart
+6
-6
basic.dart
packages/flutter/lib/src/widgets/basic.dart
+2
-2
pageable_list.dart
packages/flutter/lib/src/widgets/pageable_list.dart
+1
-1
scrollable.dart
packages/flutter/lib/src/widgets/scrollable.dart
+1
-1
scrollable_list.dart
packages/flutter/lib/src/widgets/scrollable_list.dart
+3
-3
block_test.dart
packages/flutter/test/rendering/block_test.dart
+1
-1
No files found.
packages/flutter/lib/src/rendering/block.dart
View file @
b5923f92
...
...
@@ -239,7 +239,7 @@ class RenderBlockViewport extends RenderBlockBase {
ExtentCallback
totalExtentCallback
,
ExtentCallback
maxCrossAxisDimensionCallback
,
ExtentCallback
minCrossAxisDimensionCallback
,
Painter
overlayPainter
,
RenderObject
Painter
overlayPainter
,
Axis
mainAxis:
Axis
.
vertical
,
double
itemExtent
,
double
minExtent:
0.0
,
...
...
@@ -309,9 +309,9 @@ class RenderBlockViewport extends RenderBlockBase {
markNeedsLayout
();
}
Painter
get
overlayPainter
=>
_overlayPainter
;
Painter
_overlayPainter
;
void
set
overlayPainter
(
Painter
value
)
{
RenderObject
Painter
get
overlayPainter
=>
_overlayPainter
;
RenderObject
Painter
_overlayPainter
;
void
set
overlayPainter
(
RenderObject
Painter
value
)
{
if
(
_overlayPainter
==
value
)
return
;
if
(
attached
)
...
...
packages/flutter/lib/src/rendering/grid.dart
View file @
b5923f92
...
...
@@ -358,7 +358,7 @@ class RenderGrid extends RenderVirtualViewport<GridParentData> {
int
virtualChildBase:
0
,
int
virtualChildCount
,
Offset
paintOffset:
Offset
.
zero
,
Painter
overlayPainter
,
RenderObject
Painter
overlayPainter
,
LayoutCallback
callback
})
:
_delegate
=
delegate
,
_virtualChildBase
=
virtualChildBase
,
super
(
virtualChildCount:
virtualChildCount
,
...
...
packages/flutter/lib/src/rendering/list.dart
View file @
b5923f92
...
...
@@ -20,7 +20,7 @@ class RenderList extends RenderVirtualViewport<ListParentData> {
Offset
paintOffset:
Offset
.
zero
,
Axis
mainAxis:
Axis
.
vertical
,
ViewportAnchor
anchor:
ViewportAnchor
.
start
,
Painter
overlayPainter
,
RenderObject
Painter
overlayPainter
,
LayoutCallback
callback
})
:
_itemExtent
=
itemExtent
,
_padding
=
padding
,
...
...
packages/flutter/lib/src/rendering/object.dart
View file @
b5923f92
...
...
@@ -323,7 +323,7 @@ class PaintingContext {
///
/// A renderer may allow its paint() method to be augmented or redefined by
/// providing a Painter. See for example overlayPainter in BlockViewport.
abstract
class
Painter
{
abstract
class
RenderObject
Painter
{
RenderObject
get
renderObject
=>
_renderObject
;
RenderObject
_renderObject
;
...
...
packages/flutter/lib/src/rendering/viewport.dart
View file @
b5923f92
...
...
@@ -86,7 +86,7 @@ class RenderViewportBase extends RenderBox implements HasMainAxis {
Offset
paintOffset
,
Axis
mainAxis
,
ViewportAnchor
anchor
,
Painter
overlayPainter
RenderObject
Painter
overlayPainter
)
:
_paintOffset
=
paintOffset
,
_mainAxis
=
mainAxis
,
_anchor
=
anchor
,
...
...
@@ -150,9 +150,9 @@ class RenderViewportBase extends RenderBox implements HasMainAxis {
markNeedsSemanticsUpdate
();
}
Painter
get
overlayPainter
=>
_overlayPainter
;
Painter
_overlayPainter
;
void
set
overlayPainter
(
Painter
value
)
{
RenderObject
Painter
get
overlayPainter
=>
_overlayPainter
;
RenderObject
Painter
_overlayPainter
;
void
set
overlayPainter
(
RenderObject
Painter
value
)
{
if
(
_overlayPainter
==
value
)
return
;
if
(
attached
)
...
...
@@ -220,7 +220,7 @@ class RenderViewport extends RenderViewportBase with RenderObjectWithChildMixin<
Offset
paintOffset:
Offset
.
zero
,
Axis
mainAxis:
Axis
.
vertical
,
ViewportAnchor
anchor:
ViewportAnchor
.
start
,
Painter
overlayPainter
,
RenderObject
Painter
overlayPainter
,
this
.
onPaintOffsetUpdateNeeded
})
:
super
(
paintOffset
,
mainAxis
,
anchor
,
overlayPainter
)
{
this
.
child
=
child
;
...
...
@@ -340,7 +340,7 @@ abstract class RenderVirtualViewport<T extends ContainerBoxParentDataMixin<Rende
Offset
paintOffset:
Offset
.
zero
,
Axis
mainAxis:
Axis
.
vertical
,
ViewportAnchor
anchor:
ViewportAnchor
.
start
,
Painter
overlayPainter
RenderObject
Painter
overlayPainter
})
:
_virtualChildCount
=
virtualChildCount
,
_callback
=
callback
,
super
(
paintOffset
,
mainAxis
,
anchor
,
overlayPainter
);
...
...
packages/flutter/lib/src/widgets/basic.dart
View file @
b5923f92
...
...
@@ -28,7 +28,7 @@ export 'package:flutter/rendering.dart' show
MaxTileWidthGridDelegate
,
MultiChildLayoutDelegate
,
OneChildLayoutDelegate
,
Painter
,
RenderObject
Painter
,
PaintingContext
,
PlainTextSpan
,
PointerCancelEvent
,
...
...
@@ -859,7 +859,7 @@ class Viewport extends OneChildRenderObjectWidget {
/// Paints an overlay over the viewport.
///
/// Often used to paint scroll bars.
final
Painter
overlayPainter
;
final
RenderObject
Painter
overlayPainter
;
final
ViewportDimensionsChangeCallback
onPaintOffsetUpdateNeeded
;
...
...
packages/flutter/lib/src/widgets/pageable_list.dart
View file @
b5923f92
...
...
@@ -239,7 +239,7 @@ class PageViewport extends VirtualViewportFromIterable {
final
Axis
mainAxis
;
final
ViewportAnchor
anchor
;
final
bool
itemsWrap
;
final
Painter
overlayPainter
;
final
RenderObject
Painter
overlayPainter
;
final
Iterable
<
Widget
>
children
;
RenderList
createRenderObject
(
BuildContext
context
)
=>
new
RenderList
();
...
...
packages/flutter/lib/src/widgets/scrollable.dart
View file @
b5923f92
...
...
@@ -706,7 +706,7 @@ class Block extends StatelessComponent {
}
}
abstract
class
ScrollableListPainter
extends
Painter
{
abstract
class
ScrollableListPainter
extends
RenderObject
Painter
{
void
attach
(
RenderObject
renderObject
)
{
assert
(
renderObject
is
RenderBox
);
assert
(
renderObject
is
HasMainAxis
);
...
...
packages/flutter/lib/src/widgets/scrollable_list.dart
View file @
b5923f92
...
...
@@ -111,7 +111,7 @@ class _VirtualListViewport extends VirtualViewport {
final
double
itemExtent
;
final
bool
itemsWrap
;
final
EdgeDims
padding
;
final
Painter
overlayPainter
;
final
RenderObject
Painter
overlayPainter
;
double
get
_leadingPadding
{
switch
(
mainAxis
)
{
...
...
@@ -251,7 +251,7 @@ class ListViewport extends _VirtualListViewport with VirtualViewportFromIterable
double
itemExtent
,
bool
itemsWrap:
false
,
EdgeDims
padding
,
Painter
overlayPainter
,
RenderObject
Painter
overlayPainter
,
this
.
children
})
:
super
(
onExtentsChanged
,
...
...
@@ -360,7 +360,7 @@ class LazyListViewport extends _VirtualListViewport with VirtualViewportFromBuil
ViewportAnchor
anchor:
ViewportAnchor
.
start
,
double
itemExtent
,
EdgeDims
padding
,
Painter
overlayPainter
,
RenderObject
Painter
overlayPainter
,
this
.
itemCount
,
this
.
itemBuilder
})
:
super
(
...
...
packages/flutter/test/rendering/block_test.dart
View file @
b5923f92
...
...
@@ -8,7 +8,7 @@ import 'package:test/test.dart';
import
'rendering_tester.dart'
;
class
TestBlockPainter
extends
Painter
{
class
TestBlockPainter
extends
RenderObject
Painter
{
void
paint
(
PaintingContext
context
,
Offset
offset
)
{
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment