1. 23 Feb, 2023 1 commit
  2. 22 Feb, 2023 1 commit
  3. 21 Feb, 2023 1 commit
  4. 17 Feb, 2023 1 commit
  5. 08 Feb, 2023 1 commit
    • Greg Price's avatar
      Add test for RenderProxyBoxMixin; clarify doc, resolve TODO (#117664) · cd125e1f
      Greg Price authored
      * Add test for RenderProxyBoxMixin; clarify doc, resolve TODO
      
      The TODO comment suggested this mixin would no longer be needed once
      a Dart issue on inherited constructors was fixed:
        https://github.com/dart-lang/sdk/issues/31543
      That issue is now long since fixed, so I went to go carry out the TODO.
      
      But in doing so, I realized that the mixin's documentation was more
      right than the TODO comment: even with that issue fixed, there is a
      legitimate use case for this mixin, namely to reuse the implementation
      of RenderProxyBox in a class that also inherits from some other base
      class.  Moreover, searching GitHub I found an example of a library
      that makes real use of that capability.
      
      So I think the right resolution is to accept that this separation
      is useful and delete the TODO.
      
      Then, add a test with an extremely simplified sketch of that
      real-world example.  In case someone in the future attempts to
      simplify this mixin away, the test will point us at the use case
      that would be broken by such a change.
      
      Also remove the only in-tree use of the mixin, which was redundant;
      and expand the mixin's documentation to advise about that case.
      
      * Tweak formatting
      Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>
      
      * Cut comments
      
      ---------
      Co-authored-by: 's avatarMichael Goderbauer <goderbauer@google.com>
      cd125e1f
  6. 03 Feb, 2023 1 commit
  7. 02 Feb, 2023 1 commit
  8. 31 Jan, 2023 1 commit
  9. 27 Jan, 2023 1 commit
  10. 20 Jan, 2023 1 commit
  11. 05 Jan, 2023 1 commit
  12. 04 Jan, 2023 1 commit
  13. 21 Dec, 2022 1 commit
  14. 20 Dec, 2022 2 commits
  15. 17 Dec, 2022 1 commit
  16. 16 Dec, 2022 1 commit
  17. 10 Dec, 2022 1 commit
  18. 17 Nov, 2022 1 commit
  19. 07 Nov, 2022 1 commit
  20. 04 Nov, 2022 1 commit
  21. 26 Oct, 2022 1 commit
  22. 25 Oct, 2022 1 commit
  23. 28 Sep, 2022 1 commit
  24. 20 Sep, 2022 2 commits
  25. 19 Sep, 2022 1 commit
  26. 08 Sep, 2022 1 commit
  27. 30 Aug, 2022 1 commit
  28. 29 Aug, 2022 1 commit
  29. 22 Aug, 2022 1 commit
  30. 20 Aug, 2022 1 commit
  31. 16 Aug, 2022 1 commit
  32. 03 Aug, 2022 1 commit
  33. 29 Jul, 2022 1 commit
  34. 28 Jul, 2022 1 commit
  35. 27 Jul, 2022 1 commit
  36. 22 Jul, 2022 1 commit
  37. 18 Jul, 2022 1 commit
  38. 13 Jul, 2022 1 commit