- 09 Oct, 2018 1 commit
-
-
Stanislav Baranov authored
-
- 01 Oct, 2018 3 commits
-
-
Alexandre Ardhuin authored
-
Jonah Williams authored
This reverts commit b07d986f.
-
Chris Bracken authored
Eliminates the --snapshot and --depfile parameters from the flutter bundle command. The snapshot parameter is unused in Dart 2 -- code is built to kernel .dill files and for profile/release builds, then AOT compiled. While depfiles are still used in Dart 2 (e.g. by the kernel compiler), there are enough assumptions in the code that they lie in the default location (e.g. in the Gradle build) and no reasons to support user-cusomisation that it makes sense to eliminate the --depfile option as well, and always use the default location. This commit also renames 'depFilePath' to 'depfilePath' for consistency across the codebase.
-
- 28 Sep, 2018 1 commit
-
-
Stanislav Baranov authored
This also involves switching from Core JIT to App JIT snapshot, and replacing per-isolate VM snapshot with the shared VM snapshot. For now there is no separate update bundle file, as the generated update gets packaged directly into the APK for testing purposes.
-
- 20 Sep, 2018 1 commit
-
-
Stanislav Baranov authored
Use "product" mode VM snapshot when running dynamic "release" mode flutter with cached engine. (#22043) Dynamic "release" mode requires "product" (not "release") mode VM, so we must point it to the correct cached snapshot. Generation and caching of this snapshot happens the following corresponding change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1232134
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 2 commits
-
-
Chris Bracken authored
This tickled a bug in KernelCompiler.compile() where the fingerprinter doesn't include the outputFilePath in its list of dependencies. As such, if the output .dill file is missing or corrupted, the fingerprint still matches and re-compile is skipped, even though it shouldn't be. I'll fix that in a followup, then look at how this triggered that issue. My hypothesis is that that it's due to the aot kernel compile and bundle kernel compile have separate output directories for the .dill files (build/ vs build/aot) but the same output directory for the associated depfiles (due to this patch). This reverts commit 43a106e9.
-
Chris Bracken authored
The --snapshot argument was only necessary in Dart 1. The --depfile argument was only used in Dart 2 mode to pass to the kernel compiler, but was inconsistent with the 'build aot' command, where the depfile was always set to build/kernel_compile.d. This patch updates 'build bundle' to emit the depfile to a location consistent with the 'build aot' command; since it's not intended to be user-configurable and flutter.gradle hardcodes the location to build/kernel_compile.d either way, this patch also eliminates the ability to configure the filename altogether.
-
- 04 Sep, 2018 2 commits
-
-
Chris Bracken authored
Script snapshots were only every used in Dart 1 mode, which is no longer supported.
-
Chris Bracken authored
This patch eliminates the --preview-dart-2/--no-preview-dart-2 flag, hardcoding all uses to true. It also defaults all previewDart2 method parameters to true, where they hadn't yet been. A series of subsequent patches will eliminate all previewDart2 parameters and the associated code from within the codebase.
-
- 16 Aug, 2018 2 commits
-
-
Stanislav Baranov authored
-
Stanislav Baranov authored
-
- 15 Aug, 2018 5 commits
-
-
Martin Kustermann authored
* Reland "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)" This is a re-land with downgraded `package:flutter_gallery_assets` version. * Downgrade package:flutter_gallery_assets to 0.1.4 * Change engine.version to 81baff97c29bb08cbf8453a3f9042c5813f84ad3 (which contains an additional fix) * Change engine.version to e3687f70c7ece72000b32ee1b3c02755ba5361ac (since mac tarballs are corrupted on earlier commit)
-
Jonah Williams authored
* Revert "iOS Dialog blur, brightness, and layout (#18381)" This reverts commit 21bc9f1b. * Revert "Flutter tool support for dynamic code. (#20543)" This reverts commit 25ba90aa.
-
Stanislav Baranov authored
-
Martin Kustermann authored
Reason for revert: The package:flutter_gallery_assets has removed some images which are required for the examples/flutter_gallery, so the gallery build is failing (only discovered after landing, since gallery doesn't seem to get built during github PR presubmit checks)
-
Martin Kustermann authored
This CL * rolls `engine.version` to flutter/engine@b148e628 (which includes dart sdk 2.1.0-dev) * rolls `goldens.version` to flutter/goldens@6c45fafdf (which includes updates due to skia changes in engine) * changes `platform.dill` to `platform_strong.dill` in various places due to flutter/engine@a84b210b * adds explicit `environment: sdk: ">=2.0.0-dev.68 < 3.0.0"` constraints to `pubspec.yaml` and `pubspec.yaml.tmpl` files (since pub defaults to `<2.0.0` if omitted) * upgrades to newer versions of various 3rd party packages (to ensure transitive dependencies have `<3.0.0` sdk constraint)
-
- 15 Jun, 2018 1 commit
-
-
Stanislav Baranov authored
Add flutter tool support for creating app-specific VM snapshots.
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 08 Jun, 2018 3 commits
-
-
Chris Bracken authored
* It's time to #deleteDart1 (#18293) Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1 benchmarks. All commands now run in Dart 1 mode only. Eliminates --preview-dart-2 / --no-preview-dart-2 support. * Fix indentation, remove no longer necessary .toList() * Only push udpated kernel if >0 invalidated srcs
-
Chris Bracken authored
Several benchmarks started failing during kernel compile: 1. Timeouts: * commands_test * hot_mode_dev_cycle__benchmark * run_machine_concurrent_hot_reload * service_extensions_test 2. Kernel compiler crash: * hot_mode_dev_cycle_linux__benchmark * routing_test 3. Unexpected termination: * hot_mode_dev_cycle_win__benchmark This reverts commit ed63e708.
-
Chris Bracken authored
Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1 benchmarks. All commands now run in Dart 1 mode only. Eliminates --preview-dart-2 / --no-preview-dart-2 support.
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 May, 2018 1 commit
-
-
Ryan Macnak authored
Allows one to use a different core snapshot without a custom engine build by just packaging a different one in the APK.
-
- 14 May, 2018 1 commit
-
-
Alexander Markov authored
-
- 09 May, 2018 1 commit
-
-
Chris Bracken authored
We've always cached kernel compiles during bundle builds. This adds caching for kernel compiles during AOT builds by moving caching into the KernelCompiler.compile() method rather than around each invocation of it. This also filters buildbot paths included by the kernel compile that are not present on the local machine at paths /b/build/slave/Linux_Engine/... The kernel compiler should probably include an option to not emit these paths in the depfile, since these are used both by Gradle and the Fingerprinter class.
-
- 08 May, 2018 1 commit
-
-
Chris Bracken authored
Updates the message emitted when a kernel compile is skipped in the build bundle action. Since we now use fingerprinting to enable performance of script snapshots, AOT snapshots, and kernel compiles, this helps a bit with debugging. Also switches to trace level logging.
-
- 04 May, 2018 1 commit
-
-
Chris Bracken authored
Adds a Fingerprinter utility class that can be used to compute unique fingerprints for a set of input paths and build options, compare to the output of a previous run, and skip the build action if no inputs or options have changed. The existing Fingerprint class still does all the heavy lifting. Fingerprinter adds common operations such as reading/writing/comparing fingerprints and parsing depfiles. This migrates existing uses of Fingerprint over to Fingerprinter. This also adds better fingerprinting to AOT snapshotting, which previously failed to include several options in its fingerprint (--preview-dart-2, --prefer-shared-library).
-
- 01 May, 2018 1 commit
-
-
Chris Bracken authored
There's very little code-sharing between the two, and what little there is is concentrated in the GenSnapshotClass and the fingerprint reading/writing utility methods.
-
- 24 Apr, 2018 2 commits
-
-
Chris Bracken authored
Wraps the compile function in a class injected via the global context, which makes it easier to mock in unit tests -- specifically tests for AOT snapshotting, which already require pretty significant amounts of mock inputs.
-
Alexander Aprelev authored
-
- 12 Apr, 2018 3 commits
-
-
Alexander Aprelev authored
* Handle error count reported by frontend. Extend compilation result from single string to a structure(string filename and integer error count). * Use ?. * Include engine roll with dart sdk roll. * parse(onError) -> tryParse * Make '?? throw' more readable and avoid issue with analyzer * Fix test so it mocks compiler output including errors count
-
Sarah Zakarias authored
-
Alexander Aprelev authored
* Introduce fingerprint check for preview-dart-2 build flx. * Don't count outputs into fingerpint. Refactor compilation code.
-
- 17 Mar, 2018 3 commits
-
-
Alexander Aprelev authored
* Revert "Revert "Reland pass filesystem options (#15622)" (#15651)" This reverts commit 0f3eada0. * Fix for windows failing test * !isEmpty -> isNotEmpty
-
Alexander Aprelev authored
This reverts commit bbcf55a5 as it breaks hot reload on Windows.
-
Alexander Aprelev authored
* Revert "Revert "Pass filesystem-root, filesystem-scheme options through `flutter run, build` and gradle. (#15592)" (#15621)" This reverts commit c663e336. * Check whether filesystem-root is emtpy. * Restore broken merge * Fix windows test * Adjust regex in test. Invalidate files by file path.
-
- 16 Mar, 2018 2 commits
-
-
Alexander Aprelev authored
Revert "Pass filesystem-root, filesystem-scheme options through `flutter run, build` and gradle. (#15592)" (#15621) This reverts commit 0f659fb1 as it breaks bin/tasks/gradle_plugin_test.dart.
-
Alexander Aprelev authored
* Pass filesystem-root, filesystem-scheme options through flutter run/build/gradle.
-