Commits · b03d6d65b84532b18d31a07cf03aace5f83c89c6 · abdullh.alsoleman / Front-End

26 Apr, 2023 16 commits

Roll Flutter Engine from 40187bb9afac to f2882afe0ec3 (1 revision) (#125576) · b03d6d65

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/40187bb9afac...f2882afe0ec3

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from a0e3fa5aa947 to 3fea88565a83 (3 revisions) (flutter/engine#41516)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b03d6d65

Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present... · 5c44b1df

Tae Hyung Kim authored Apr 26, 2023

Refactor "gen-l10n" command to use same code path when "l10n.yaml" is present or not present (#125429)

I think this is a long needed change to the `gen-l10n` command.
Essentially, the arguments to `flutter gen-l10n` can be provided by two
different methods: via command line arguments or via the `l10n.yaml`
file. The existence of a `l10n.yaml` file causes the latter approach to
take precedence.

However, currently, there's several differences in how the two
approaches are handled, and most of the default arguments are all over
the place, causing unexpected issues such as #120457 or #120023.

This PR refactors the command so that
* `LocalizationOptions` are more consistent with the actual argument
names/yaml options.
* All default values are determined in `LocalizationOptions`'s
constructor (or in `argParser.addOption(...)` in the case a boolean
value needs to be explicitly true).
* New `parseLocalizationsOptionsFromCommand` function to parse
arguments.
* Parse `LocalizationOptions` at the beginning of `runCommand()` and
pass it to `generateLocalizations`.

Fixes #120023.

5c44b1df

Roll Flutter Engine from f125a54f5a57 to 40187bb9afac (1 revision) (#125566) · 89c76989

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/f125a54f5a57...40187bb9afac

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 47cfc5a2f0a0 to a0e3fa5aa947 (1 revision) (flutter/engine#41514)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

89c76989

Remove web compile benchmarks that specify an attached device (#125559) · 66fa4c5d
Zachary Anderson authored Apr 26, 2023
```
Fixes https://github.com/flutter/flutter/issues/125492
```
66fa4c5d

Roll Flutter Engine from f75908135e10 to f125a54f5a57 (1 revision) (#125560) · c9d7bed4

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/f75908135e10...f125a54f5a57

2023-04-26 skia-flutter-autoroll@skia.org Roll Dart SDK from b0dacad08d62 to 3d444bc30fc4 (1 revision) (flutter/engine#41513)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c9d7bed4

Roll Flutter Engine from c9db1587f207 to f75908135e10 (1 revision) (#125558) · b0ae2e81

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/c9db1587f207...f75908135e10

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 5085ba92075b to 47cfc5a2f0a0 (4 revisions) (flutter/engine#41512)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b0ae2e81

Roll Flutter Engine from 58a5a1e3f2c1 to c9db1587f207 (1 revision) (#125555) · 00d231c0

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/58a5a1e3f2c1...c9db1587f207

2023-04-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JKHSUjf-qEr0ZMdEi... to rM9DAwmAeMc8pV11x... (flutter/engine#41511)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JKHSUjf-qEr0 to rM9DAwmAeMc8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

00d231c0

Roll Flutter Engine from 321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (#125552) · 709d431f

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/321f8015b9c2...58a5a1e3f2c1

2023-04-26 skia-flutter-autoroll@skia.org Roll Dart SDK from f9d4d255c6e7 to b0dacad08d62 (4 revisions) (flutter/engine#41510)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

709d431f

Roll Flutter Engine from 87f5f4e939cf to 321f8015b9c2 (1 revision) (#125549) · 11734dd9

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/87f5f4e939cf...321f8015b9c2

2023-04-26 jiahaog@users.noreply.github.com Log dlopen errors in opt builds (flutter/engine#41477)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

11734dd9

Update prefer_final_parameters comment (#125465) · f6b9c4da
Michael Goderbauer authored Apr 26, 2023
```
Per discusion in https://github.com/flutter/flutter/pull/125061.
```
f6b9c4da

Roll Flutter Engine from 706c023df44b to 87f5f4e939cf (1 revision) (#125539) · 14be1af7

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/706c023df44b...87f5f4e939cf

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 0f3c8eaf60b2 to 5085ba92075b (1 revision) (flutter/engine#41504)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14be1af7

Roll Flutter Engine from 7b385abd18a2 to 706c023df44b (1 revision) (#125536) · 75dd5da9

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/7b385abd18a2...706c023df44b

2023-04-26 dnfield@google.com Roll vulkan-deps and vs_toolchain (flutter/engine#41455)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

75dd5da9

Roll Flutter Engine from 610c57781b47 to 7b385abd18a2 (1 revision) (#125533) · b379af8b

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/610c57781b47...7b385abd18a2

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 22132575fceb to 0f3c8eaf60b2 (1 revision) (flutter/engine#41499)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b379af8b

Roll Flutter Engine from b3cbf0678487 to 610c57781b47 (1 revision) (#125531) · 8de77e89

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/b3cbf0678487...610c57781b47

2023-04-26 skia-flutter-autoroll@skia.org Roll Skia from 809bf518d4ab to 22132575fceb (2 revisions) (flutter/engine#41497)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8de77e89

Add hostonly web compile size benchmarks (#125518) · 53cba8fd
Zachary Anderson authored Apr 26, 2023
```
First part of https://github.com/flutter/flutter/issues/125492
```
53cba8fd

Roll Flutter Engine from 34ece7a4abac to b3cbf0678487 (6 revisions) (#125529) · 062f6c1d

engine-flutter-autoroll authored Apr 26, 2023

https://github.com/flutter/engine/compare/34ece7a4abac...b3cbf0678487

2023-04-25 godofredoc@google.com Migrate windows host engine to engine v2. (flutter/engine#41487)
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from f6f0c4b5ee98 to 809bf518d4ab (3 revisions) (flutter/engine#41494)
2023-04-25 30870216+gaaclarke@users.noreply.github.com Made sure not to turn on wide gamut support without impeller. (flutter/engine#41460)
2023-04-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 5bc9_eyVcLoMrWvdO... to JKHSUjf-qEr0ZMdEi... (flutter/engine#41493)
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 1bed4228ea3b to f6f0c4b5ee98 (7 revisions) (flutter/engine#41492)
2023-04-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Fixed blit command missing tracking and added mock vulkan for tests (flutter/engine#41408)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 5bc9_eyVcLoM to JKHSUjf-qEr0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

062f6c1d

25 Apr, 2023 19 commits

Handle dollar signs properly when generating localizations (#125514) · 8be335f2

Tae Hyung Kim authored Apr 25, 2023

Currently, the code doesn't properly handle strings which contain dollar signs. The return expression for the generated localization function is computed by `generateReturnExpr` which concatenates several strings, which are either interpolated placeholders, interpolated function calls, or normal strings, but we didn't properly escape dollar signs before sending normal strings to `generateReturnExpr`.

Fixes #125461.

8be335f2

Roll Flutter Engine from 6d798393a15a to 34ece7a4abac (1 revision) (#125516) · 9a28f56e

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/6d798393a15a...34ece7a4abac

2023-04-25 godofredoc@google.com Double zip FlutterMacOS.dSYM.zip. (flutter/engine#41425)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a28f56e

Roll Flutter Engine from 469e5b409686 to 6d798393a15a (2 revisions) (#125513) · 426e32fa

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/469e5b409686...6d798393a15a

2023-04-25 flar@google.com hide DisplayList::DisposeOps and other lint suggestions (flutter/engine#41464)
2023-04-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 170137fc759b to f9d4d255c6e7 (1 revision) (flutter/engine#41486)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

426e32fa

Adds selected semantics flag to radio button for Apple devices (#125499) · ef82f97f

chunhtai authored Apr 25, 2023

fixes https://github.com/flutter/flutter/issues/125495

The iOS will announce 'Selected, \<label\>, button' for selected radio button after this change

ef82f97f

Roll Flutter Engine from 0e236982086b to 469e5b409686 (1 revision) (#125510) · 9bf2cd3c

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/0e236982086b...469e5b409686

2023-04-25 58529443+srujzs@users.noreply.github.com Remove package:js references and move to dart:js_interop (flutter/engine#41212)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9bf2cd3c

Relabel JSFunction as JSExportedDartFunction (#125453) · 829a2d07

Srujan Gaddam authored Apr 25, 2023

toDart exists on the latter, not the former.

Fixing https://github.com/flutter/flutter/pull/125220.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

829a2d07

Roll Flutter Engine from 60c4e61416cd to 0e236982086b (2 revisions) (#125504) · 4dddac97

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/60c4e61416cd...0e236982086b

2023-04-25 linxunfeng@yeah.net [ios] Fix hold and drag spacebar does not move cursor when obscureText is true. (flutter/engine#40216)
2023-04-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 337365e42613 to 170137fc759b (2 revisions) (flutter/engine#41483)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4dddac97

iOS TextField spell check style (#125432) · 85ec8742

Justin McCandless authored Apr 25, 2023

When using a Material TextField on iOS, the spell check selection style now defaults to the red iOS-style, not Android's blue.

85ec8742

Roll Flutter Engine from 308bce499087 to 60c4e61416cd (1 revision) (#125490) · 8cd11e91

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/308bce499087...60c4e61416cd

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from c44f06399619 to 1bed4228ea3b (1 revision) (flutter/engine#41482)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8cd11e91

Roll Flutter Engine from 54ddef68b124 to 308bce499087 (1 revision) (#125485) · 932faedc

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/54ddef68b124...308bce499087

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 7a0879961df5 to c44f06399619 (1 revision) (flutter/engine#41479)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

932faedc

Roll Flutter Engine from 307416f43b5a to 54ddef68b124 (1 revision) (#125481) · aad9fd2d

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/307416f43b5a...54ddef68b124

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 571074c14049 to 7a0879961df5 (1 revision) (flutter/engine#41478)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

aad9fd2d

Roll Flutter Engine from 232810b36671 to 307416f43b5a (1 revision) (#125475) · 160ecade

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/232810b36671...307416f43b5a

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 9b1b2a5dd899 to 571074c14049 (1 revision) (flutter/engine#41476)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

160ecade

Roll Flutter Engine from 1c4b6c0cb862 to 232810b36671 (2 revisions) (#125472) · 2afa98ed

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/1c4b6c0cb862...232810b36671

2023-04-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c3afc3507b4f to 337365e42613 (1 revision) (flutter/engine#41475)
2023-04-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8TJtGsJTpIHk5-Ss5... to xfKYQ2vkoLvxhBHIf... (flutter/engine#41474)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 8TJtGsJTpIHk to xfKYQ2vkoLvx

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2afa98ed

Roll Flutter Engine from a26a479e86b3 to 1c4b6c0cb862 (1 revision) (#125463) · 5903a8cf

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/a26a479e86b3...1c4b6c0cb862

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 2c0f33c7ec04 to 9b1b2a5dd899 (2 revisions) (flutter/engine#41473)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5903a8cf

Fix `SliverAppBar.medium` & `SliverAppBar.large` text scale (#125038) · 6e1d4f9f

Taha Tesser authored Apr 25, 2023

fixes https://github.com/flutter/flutter/issues/114340

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

/// Flutter code sample for [SliverAppBar.medium].

void main() {
  runApp(const AppBarMediumApp());
}

class AppBarMediumApp extends StatelessWidget {
  const AppBarMediumApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        useMaterial3: true,
      ),
      home: MediaQuery(
        data: MediaQuery.of(context).copyWith(textScaleFactor: 3.0),
        child: Material(
          child: CustomScrollView(
            slivers: <Widget>[
              SliverAppBar.medium(
                leading:
                    IconButton(icon: const Icon(Icons.menu), onPressed: () {}),
                title: const Text('Medium App Bar'),
                actions: <Widget>[
                  IconButton(icon: const Icon(Icons.more_vert), onPressed: () {}),
                ],
              ),
              // SliverAppBar.large(
              //   leading:
              //       IconButton(icon: const Icon(Icons.menu), onPressed: () {}),
              //   title: const Text('Large App Bar'),
              //   actions: <Widget>[
              //     IconButton(
              //         icon: const Icon(Icons.more_vert), onPressed: () {}),
              //   ],
              // ),
              // Just some content big enough to have something to scroll.
              SliverToBoxAdapter(
                child: Card(
                  child: SizedBox(
                    height: 1200,
                    child: Padding(
                      padding: const EdgeInsets.fromLTRB(8, 100, 8, 100),
                      child: Text(
                        'Here be scrolling content...',
                        style: Theme.of(context).textTheme.headlineSmall,
                      ),
                    ),
                  ),
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

``` 
	
</details>

### Before
|  Medium App Bar - `textScaleFactor: 3.0` |   Large App Bar - `textScaleFactor.30` |
| --------------- | --------------- |
| <img src="https://user-images.githubusercontent.com/48603081/232815191-ab42523b-d710-4c93-a889-e9c92ca472c8.png" height="450" /> | <img src="https://user-images.githubusercontent.com/48603081/232815232-104c208d-f1dd-404e-9218-5dfb61244d56.png" height="450" /> |

### After
|  Medium App Bar - `textScaleFactor: 3.0` |   Large App Bar - `textScaleFactor.30` |
| --------------- | --------------- |
| <img src="https://user-images.githubusercontent.com/48603081/232815733-8b8af94f-197f-427a-bbb9-bc6cd0173658.png" height="450" /> | <img src="https://user-images.githubusercontent.com/48603081/232815758-2c336d14-085b-4e91-8b93-748a40822ea6.png" height="450" /> |

6e1d4f9f

Roll Flutter Engine from 3f4116c225e8 to a26a479e86b3 (1 revision) (#125459) · 8395a2b2

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/3f4116c225e8...a26a479e86b3

2023-04-25 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gxpKJcSBfY7AuR_Ur... to 5bc9_eyVcLoMrWvdO... (flutter/engine#41471)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from gxpKJcSBfY7A to 5bc9_eyVcLoM

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8395a2b2

Roll Flutter Engine from 64882f4b7371 to 3f4116c225e8 (2 revisions) (#125458) · 597cc8f9

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/64882f4b7371...3f4116c225e8

2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 8822608fcb4d to 2c0f33c7ec04 (1 revision) (flutter/engine#41470)
2023-04-25 skia-flutter-autoroll@skia.org Roll Skia from 5f4dd36a69f9 to 8822608fcb4d (2 revisions) (flutter/engine#41469)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

597cc8f9

Roll Flutter Engine from 8fe8e94c02fc to 64882f4b7371 (1 revision) (#125454) · 5817ed47

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/8fe8e94c02fc...64882f4b7371

2023-04-25 godofredoc@google.com [Cleanup] remove type=local from local test/generators. (flutter/engine#41465)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5817ed47

Roll Flutter Engine from 5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (#125452) · d23dba22

engine-flutter-autoroll authored Apr 25, 2023

https://github.com/flutter/engine/compare/5fbde6c0fc57...8fe8e94c02fc

2023-04-25 jonahwilliams@google.com Revert "[impeller] convert src over to src for solid color" (flutter/engine#41466)
2023-04-24 godofredoc@google.com Remove empty tests properties. (flutter/engine#41461)
2023-04-24 skia-flutter-autoroll@skia.org Roll Skia from 0ec4c84abd0b to 5f4dd36a69f9 (21 revisions) (flutter/engine#41462)
2023-04-24 godofredoc@google.com Reland "Upload windows arm artifacts to production bucket." (flutter/engine#41409)
2023-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from c7042dc03f43 to c3afc3507b4f (1 revision) (flutter/engine#41458)
2023-04-24 54558023+keyonghan@users.noreply.github.com Add 16.2 runtime to Mac unopt (flutter/engine#41456)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EEdHfWcEn3fHwQj46... to gxpKJcSBfY7AuR_Ur... (flutter/engine#41453)
2023-04-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fJ7ysM-O4VYAGeBDc... to 8TJtGsJTpIHk5-Ss5... (flutter/engine#41451)
2023-04-24 skia-flutter-autoroll@skia.org Roll Dart SDK from a1c1e0d3bb18 to c7042dc03f43 (2 revisions) (flutter/engine#41452)
2023-04-24 skia-flutter-autoroll@skia.org Roll Skia from 1f84e5060646 to 0ec4c84abd0b (6 revisions) (flutter/engine#41449)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fJ7ysM-O4VYA to 8TJtGsJTpIHk
fuchsia/sdk/core/mac-amd64 from EEdHfWcEn3fH to gxpKJcSBfY7A

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d23dba22

24 Apr, 2023 5 commits

Add Sliders to `macrobenchmarks` (#125296) · 457e98a1

Taha Tesser authored Apr 24, 2023

This adds a performance test for `Slider` and `RangeSlider` to run on Android.
This is to measure upcoming changes to these widgets and compare their performance.

https://user-images.githubusercontent.com/48603081/233633349-0bcad3c3-04a9-42dd-acd0-46b76ce51178.mp4

457e98a1

[date_picker] [date_range_picker] add properties to change switch-to icons (#124881) · 9525934e
Tirth authored Apr 24, 2023

9525934e
Sliver Constrained Cross Axis (#125239) · 482d1aaf
Tae Hyung Kim authored Apr 24, 2023
```
Reimplements what we reverted here: #125233.
```
482d1aaf
tool: Move cdKey to CustomDimensionsEnum (#125335) · 7d9f2082
Kevin Moore authored Apr 24, 2023

7d9f2082

Add `borderRadius` to LinearProgressIndicator (#123517) · 9e9ac77d

Bernardo Ferrari authored Apr 24, 2023

Split from https://github.com/flutter/flutter/pull/122664 so it gets easier to review, as this is now unrelated to the `preferRound`. I'm one step from adding a width attribute, lol.

<img width="474" alt="image" src="https://user-images.githubusercontent.com/351125/226083798-71e529e9-4ae9-41de-a500-0412b989a273.png">

cc @Piinks

9e9ac77d