1. 19 Apr, 2023 1 commit
  2. 18 Apr, 2023 1 commit
  3. 05 Apr, 2023 1 commit
    • Reid Baker's avatar
      Add Java-Gradle-AGP validation to flutter analyze (#123916) · 2383400f
      Reid Baker authored
      https://github.com/flutter/flutter/issues/123917
      
      Doc covering a broad set of issues related to android studio updating. 
      
      https://docs.google.com/document/d/1hTXkjbUrBnXgu8NQsth1c3aEqo77rWoEj8CcsQ39wwQ/edit?pli=1#
      
      Specifically this pr: 
      - Adds new functions to find a projects AGP, Gradle and java versions,
      and tests.
      - Adds new functions that take versions and parse if the versions are
      compatible with each other, and tests.
      - Adds validator for `flutter analyze --suggestions` that evaluates the
      java/gradle/agp versions and checks if they are compatible, and
      integration test.
      - Updates the version of gradle used by
      dev/integration_tests/flutter_gallery/ to the minimum supported by java
      18 so that the integration tests pass (It is unknown why the java
      version is 18.9 instead of 11)
      - Moves `isWithinVersionRange` to version.dart, and tests. 
      - Adds FakeAndroidStudio to fakes to be used in multiple tests but does
      not remove existing copies.
      
      Metrics will be included as part of the definition of done for this bug
      but not as part of this cl. It is already too big.
      
      Known work still left in this pr: 
      * Understand why analyze integration tests are failing. 
      
      
      Example output if Java and gradle are not compatible: 
      ```
      ┌───────────────────────────────────────────────────────────────────┐
      │ General Info                                                      │
      │ [✓] App Name: espresso_example                                    │
      │ [✓] Supported Platforms: android                                  │
      │ [✓] Is Flutter Package: yes                                       │
      │ [✓] Uses Material Design: yes                                     │
      │ [✓] Is Plugin: no                                                 │
      │ [✗] Java/Gradle/Android Gradle Plugin:                            │
      │                                                                   │
      │ Incompatible Java/Gradle versions.                                │
      │                                                                   │
      │ Java Version: 17.0.6, Gradle Version: 7.0.2                       │
      │                                                                   │
      │ See the link below for more information.                          │
      │ https://docs.gradle.org/current/userguide/compatibility.html#java │
      │                                                                   │
      └───────────────────────────────────────────────────────────────────┘
      ```
      Example output if Gradle and AGP are not compatible
      ```
      ┌─────────────────────────────────────────────────────────────────────────────┐
      │ General Info                                                                │
      │ [✓] App Name: espresso_example                                              │
      │ [✓] Supported Platforms: android                                            │
      │ [✓] Is Flutter Package: yes                                                 │
      │ [✓] Uses Material Design: yes                                               │
      │ [✓] Is Plugin: no                                                           │
      │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions.    │
      │                                                                             │
      │ Gradle Version: 7.0.2, AGP Version: 7.4.2                                   │
      │                                                                             │
      │ Update gradle to at least "7.5".                                            │
      │ See the link below for more information:                                    │
      │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │
      │                                                                             │
      │ Incompatible Java/Gradle versions.                                          │
      │                                                                             │
      │ Java Version: 17.0.6, Gradle Version: 7.0.2                                 │
      │                                                                             │
      │ See the link below for more information:                                    │
      │ https://docs.gradle.org/current/userguide/compatibility.html#java           │
      │                                                                             │
      └─────────────────────────────────────────────────────────────────────────────┘
      ```
      Example output if Java/Gradle/Agp are not compatible. 
      ```
      
      ┌─────────────────────────────────────────────────────────────────────────────┐
      │ General Info                                                                │
      │ [✓] App Name: espresso_example                                              │
      │ [✓] Supported Platforms: android                                            │
      │ [✓] Is Flutter Package: yes                                                 │
      │ [✓] Uses Material Design: yes                                               │
      │ [✓] Is Plugin: no                                                           │
      │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions.    │
      │                                                                             │
      │ Gradle Version: 7.0.2, AGP Version: 7.4.2                                   │
      │                                                                             │
      │ Update gradle to at least "7.5".                                            │
      │ See the link below for more information:                                    │
      │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │
      │                                                                             │
      │ Incompatible Java/Gradle versions.                                          │
      │                                                                             │
      │ Java Version: 17.0.6, Gradle Version: 7.0.2                                 │
      │                                                                             │
      │ See the link below for more information:                                    │
      │ https://docs.gradle.org/current/userguide/compatibility.html#java           │
      │                                                                             │
      └─────────────────────────────────────────────────────────────────────────────┘
      ```
      
      Commit messages
      - Add function to gradle_utils.dart that gets the gradle version from
      wrapper or system and add a test for each situation
      - Add method to get agp version, add method to validate agp against
      gradle version, update documentation, add tests for agp validation.
      - Update dart doc for validateGradleAndAgp to describe where the info
      came from and corner case behavior, create function to validate java and
      gradle and hardcode return to false
      - Fill out and test java gradle compatibility function in gradle_utils
      - Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with
      hardcoded java version
      - Add java --version output parsing and tests
      - Add getJavaBinary test
      - Update comment in android_sdk for mac behavior with java_home -v
      
      ## Pre-launch Checklist
      
      - [x] I read the [Contributor Guide] and followed the process outlined
      there for submitting PRs.
      - [x] I read the [Tree Hygiene] wiki page, which explains my
      responsibilities.
      - [x] I read and followed the [Flutter Style Guide], including [Features
      we expect every widget to implement].
      - [x] I signed the [CLA].
      - [x] I listed at least one issue that this PR fixes in the description
      above.
      - [x] I updated/added relevant documentation (doc comments with `///`).
      - [x] I added new tests to check the change I am making, or this PR is
      [test-exempt].
      - [ ] All existing and new tests are passing.
      2383400f
  4. 09 Mar, 2023 1 commit
  5. 23 Feb, 2023 1 commit
  6. 23 Jan, 2023 1 commit
  7. 25 Oct, 2022 1 commit
  8. 29 Jul, 2022 1 commit
  9. 13 Jul, 2022 1 commit
  10. 12 Jul, 2022 1 commit
  11. 02 Jul, 2022 1 commit
  12. 12 May, 2022 1 commit
  13. 26 Apr, 2022 1 commit
  14. 07 Apr, 2022 1 commit
  15. 31 Mar, 2022 1 commit
  16. 29 Mar, 2022 1 commit
  17. 21 Mar, 2022 1 commit
  18. 16 Mar, 2022 1 commit
  19. 02 Mar, 2022 1 commit
    • gaaclarke's avatar
      Starts using the `--source` flag to compile the dart registrant. (#98046) · fdcd1446
      gaaclarke authored
      * Starts using the `--source` flag to compile the dart registrant.
      
      * updated general.shard tests
      
      * Fixed the resident compiler flow
      
      * added integration test
      
      * made the integration test self contained
      
      * renamed generated_main to dart_plugin_registrant
      
      * cleaned up for review
      
      * added task runner for ci
      
      * added bringup and TESTOWNERS
      
      * updated failure message
      fdcd1446
  20. 08 Feb, 2022 1 commit
  21. 25 Jan, 2022 1 commit
    • stuartmorgan's avatar
      Don't use example folder as a project type signal (#97157) · 2dd8cb1c
      stuartmorgan authored
      The code to generate platform files used to use the presence of an
      'example' folder to determine whether or not a project was a plugin (in
      which case that generation is bypassed). Later, robust detection was
      added based on the pubspec.yaml `plugin` key, but the old check was left
      in place. This creates false positives where people who add an example
      folder to their app project start getting mysterious failures.
      
      Since the pubspec check is definitive, there's no reason to continue to
      use the presence of `example` as an indicator at all.
      
      Fixes https://github.com/flutter/flutter/issues/87007
      2dd8cb1c
  22. 05 Jan, 2022 1 commit
  23. 15 Dec, 2021 1 commit
  24. 07 Dec, 2021 1 commit
  25. 06 Dec, 2021 1 commit
  26. 12 Nov, 2021 2 commits
  27. 11 Nov, 2021 2 commits
  28. 10 Nov, 2021 2 commits
  29. 02 Nov, 2021 1 commit
  30. 08 Oct, 2021 4 commits
  31. 01 Oct, 2021 1 commit
    • stuartmorgan's avatar
      Fix Dart plugin registrant interaction with 'flutter test' (#90288) · 97fb8c05
      stuartmorgan authored
      Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR:
      - Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins.
      - Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future.
      
      Fixes https://github.com/flutter/flutter/issues/88794
      97fb8c05
  32. 26 Aug, 2021 1 commit
  33. 28 Jun, 2021 1 commit
  34. 24 Jun, 2021 1 commit