1. 20 Sep, 2023 1 commit
    • Greg Spencer's avatar
      Remove 'must be non-null' and 'must not be null' comments from material. (#134991) · a1e49be2
      Greg Spencer authored
      ## Description
      
      This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values.
      
      This PR removes them from the material library.
      
      This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some.
      
      In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow.
      
      This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases.  I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these).
      
      ## Related PRs
      - https://github.com/flutter/flutter/pull/134984
      - https://github.com/flutter/flutter/pull/134992
      - https://github.com/flutter/flutter/pull/134993
      - https://github.com/flutter/flutter/pull/134994
      
      ## Tests
       - Documentation only change.
      a1e49be2
  2. 24 Jan, 2023 1 commit
  3. 22 Aug, 2022 1 commit
  4. 10 Aug, 2022 1 commit
  5. 15 Apr, 2022 1 commit
  6. 14 Apr, 2022 1 commit
  7. 21 Mar, 2022 1 commit
  8. 14 Jan, 2022 1 commit
  9. 13 May, 2021 1 commit
  10. 10 May, 2021 1 commit
  11. 03 May, 2021 1 commit
  12. 29 Jan, 2021 1 commit
  13. 15 Dec, 2020 1 commit
  14. 08 Dec, 2020 1 commit
  15. 02 Nov, 2020 2 commits
  16. 27 Oct, 2020 1 commit
  17. 23 Oct, 2020 1 commit
  18. 08 Oct, 2020 1 commit
  19. 29 Sep, 2020 1 commit
  20. 11 Jun, 2020 1 commit
  21. 06 May, 2020 1 commit
  22. 25 Jan, 2020 1 commit
  23. 13 Dec, 2019 1 commit
  24. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  25. 22 Nov, 2019 1 commit
    • Alexandre Ardhuin's avatar
      make some BuildContext methods generics (#44189) · fcb40a05
      Alexandre Ardhuin authored
      * make BuildContext.{ancestorStateOfType,ancestorRenderObjectOfType,rootAncestorStateOfType} generic
      
      * make BuildContext.inheritFromWidgetOfExactType generic
      
      * make BuildContext.ancestorInheritedElementForWidgetOfExactType generic
      
      * make BuildContext.ancestorWidgetOfExactType generic
      
      * fix snippet
      
      * bump scoped_model on temp version
      
      * update names
      
      * Revert "bump scoped_model on temp version"
      
      This reverts commit d1fcbba028cdb07f44738d1652391692d1ea5ec0.
      
      * address review comments
      
      * fix ci
      
      * address review comments
      
      * repeat the deprecation notice
      
      * fix uppercase
      
      * use of recommanded deprecation syntax
      
      * address review comment
      fcb40a05
  26. 24 Sep, 2019 1 commit
  27. 18 Sep, 2019 1 commit
  28. 21 Aug, 2019 1 commit
  29. 05 Apr, 2019 1 commit
    • LongCatIsLooong's avatar
      Provide a default IconTheme in CupertinoTheme (#30521) · e153883d
      LongCatIsLooong authored
      -* Inserted an `IconTheme` widget under `CupertinoTheme` to provide a default icon color when using `CupertinoTheme`.
      * Changed `CupertinoTheme` to a `StatelessWidget`, to match the implementation of `Theme`
      * Changed the nesting order of `Theme`'s sub widgets, to let `Theme.iconTheme` take precedence, so that `Theme`'s behavior is kept as is.
      e153883d
  30. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  31. 19 Dec, 2018 1 commit
  32. 12 Oct, 2018 2 commits
    • matthew-carroll's avatar
      Revert "Reversion for roll (#22984)" (#23029) · 04a26778
      matthew-carroll authored
      This reverts commit 80f80ab0.
      04a26778
    • matthew-carroll's avatar
      Reversion for roll (#22984) · 80f80ab0
      matthew-carroll authored
      For G3 Roll:
      
      * Revert "MaterialButton must honor its minWidth and height parameters (#22919)"
      
      This reverts commit a0233233.
      
      * Revert "Update uses of ButtonTheme.bar: pass along the current Theme's colorScheme (#22827)"
      
      This reverts commit 655bf6a2.
      
      * Revert "ButtonTheme.of().colorScheme defers to Theme (#22880)"
      
      This reverts commit a590940e.
      
      * Revert "Bring TextTheme into alignment with the current Material spec (#22330)"
      
      This reverts commit 8bfb4b3e.
      
      * Revert "Added ColorScheme, updated ThemeData, ButtonTheme, material buttons (#22013)"
      
      This reverts commit eea3465a.
      
      * Manual adjustments to fix reversion issues.
      80f80ab0
  33. 10 Oct, 2018 1 commit
  34. 12 Sep, 2018 1 commit
  35. 07 Sep, 2018 1 commit
  36. 30 Aug, 2018 1 commit
  37. 02 Aug, 2018 1 commit
  38. 27 Jul, 2018 1 commit