Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ed5229e5
Unverified
Commit
ed5229e5
authored
4 years ago
by
Michael Goderbauer
Committed by
GitHub
4 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove isMaterialAppTheme property (#71861)
parent
5bae3b5d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
19 deletions
+0
-19
app.dart
packages/flutter/lib/src/material/app.dart
+0
-1
theme.dart
packages/flutter/lib/src/material/theme.dart
+0
-17
text_selection_test.dart
packages/flutter/test/material/text_selection_test.dart
+0
-1
No files found.
packages/flutter/lib/src/material/app.dart
View file @
ed5229e5
...
...
@@ -739,7 +739,6 @@ class _MaterialAppState extends State<MaterialApp> {
key:
widget
.
scaffoldMessengerKey
,
child:
AnimatedTheme
(
data:
theme
,
isMaterialAppTheme:
true
,
child:
widget
.
builder
!=
null
?
Builder
(
builder:
(
BuildContext
context
)
{
...
...
This diff is collapsed.
Click to expand it.
packages/flutter/lib/src/material/theme.dart
View file @
ed5229e5
...
...
@@ -40,7 +40,6 @@ class Theme extends StatelessWidget {
const
Theme
({
Key
?
key
,
required
this
.
data
,
this
.
isMaterialAppTheme
=
false
,
required
this
.
child
,
})
:
assert
(
child
!=
null
),
assert
(
data
!=
null
),
...
...
@@ -49,17 +48,6 @@ class Theme extends StatelessWidget {
/// Specifies the color and typography values for descendant widgets.
final
ThemeData
data
;
/// True if this theme was installed by the [MaterialApp].
///
/// When an app uses the [Navigator] to push a route, the route's widgets
/// will only inherit from the app's theme, even though the widget that
/// triggered the push may inherit from a theme that "shadows" the app's
/// theme because it's deeper in the widget tree. Apps can find the shadowing
/// theme with `Theme.of(context, shadowThemeOnly: true)` and pass it along
/// to the class that creates a route's widgets. Material widgets that push
/// routes, like [PopupMenuButton] and [DropdownButton], do this.
final
bool
isMaterialAppTheme
;
/// The widget below this widget in the tree.
///
/// {@macro flutter.widgets.ProxyWidget.child}
...
...
@@ -209,7 +197,6 @@ class AnimatedTheme extends ImplicitlyAnimatedWidget {
const
AnimatedTheme
({
Key
?
key
,
required
this
.
data
,
this
.
isMaterialAppTheme
=
false
,
Curve
curve
=
Curves
.
linear
,
Duration
duration
=
kThemeAnimationDuration
,
VoidCallback
?
onEnd
,
...
...
@@ -221,9 +208,6 @@ class AnimatedTheme extends ImplicitlyAnimatedWidget {
/// Specifies the color and typography values for descendant widgets.
final
ThemeData
data
;
/// True if this theme was created by the [MaterialApp]. See [Theme.isMaterialAppTheme].
final
bool
isMaterialAppTheme
;
/// The widget below this widget in the tree.
///
/// {@macro flutter.widgets.ProxyWidget.child}
...
...
@@ -245,7 +229,6 @@ class _AnimatedThemeState extends AnimatedWidgetBaseState<AnimatedTheme> {
@override
Widget
build
(
BuildContext
context
)
{
return
Theme
(
isMaterialAppTheme:
widget
.
isMaterialAppTheme
,
child:
widget
.
child
,
data:
_data
!.
evaluate
(
animation
!),
);
...
...
This diff is collapsed.
Click to expand it.
packages/flutter/test/material/text_selection_test.dart
View file @
ed5229e5
...
...
@@ -556,7 +556,6 @@ void main() {
selectionHandleColor:
Color
(
0x550000AA
),
),
),
isMaterialAppTheme:
true
,
child:
Builder
(
builder:
(
BuildContext
context
)
{
return
Container
(
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment