- 26 May, 2023 3 commits
-
-
Nate Bosch authored
Replace imports of `src/remote_listener.dart` with `backend.dart` which exports `RemoteListener`. Remove the unused imports of `src/backend/stack_trace_formatter.dart` (no uses of `StackTraceFormatter`) and `src/backend/suite_channel_manager.dart` (no uses of `SuiteChannelManager`).
-
Phil Quitslund authored
The newly updated lint will soon flag for-each in collections. See discussion: https://github.com/dart-lang/linter/pull/4383 /cc @goderbauer
-
Victoria Ashworth authored
This reverts commit a19b3436. We added this logging to try and determine if the reason for Dart VM errors (https://github.com/flutter/flutter/issues/121231) was caused by some issue with the streams. A recent test proves that is not the case: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_view_ios__start_up/11046/overview The test shows the Dart VM url in the device log. However, the test log does NOT show a log for the Dart VM url but does show the stack trace, which all come from the main stream, which means it's not an issue with the secondary streams not receiving the log. So reverting the debugging we added.
-
- 24 May, 2023 2 commits
-
-
Victoria Ashworth authored
Reland https://github.com/flutter/flutter/pull/127222 that was reverted in https://github.com/flutter/flutter/pull/127405. Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.
-
Victoria Ashworth authored
This reverts commit 2b3cd7f4. Fixes https://github.com/flutter/flutter/issues/127281.
-
- 23 May, 2023 4 commits
-
-
Ian Hickson authored
Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936) ## How we determine the channel name Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time. I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird. This PR changes the logic to uses the current branch as the channel name. ## How we display channels The main reason this PR exists is to add channel descriptions to the `flutter channel` list: ``` ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel Flutter channels: master (tip of tree, for contributors) main (tip of tree, follows master channel) beta (updated monthly, recommended for experienced users) stable (updated quarterly, for new users and for production app releases) * foo_bar Currently not on an official channel. ianh@burmese:~/dev/flutter/packages/flutter_tools$ ``` ## Other changes I made a few other changes while I was at it: * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on. * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`. * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context. * Simplified some of the code. * Made some of the tests more strict (checking all output rather than just some aspects of it). * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly. * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy). * Tweaked the help text for the `downgrade` command to be clearer. * Removed some misleading text in some error messages. * Made the `.metadata` generator consistent with the template file. * Removed some obsolete code to do with the `dev` branch. ## Reviewer notes I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/126705 Follow up fix after https://github.com/flutter/flutter/pull/126875 did NOT work.
-
Victoria Ashworth authored
Reverts flutter/flutter#127222
-
Victoria Ashworth authored
Log all output of `ios-deploy` to try and determine if the issue of https://github.com/flutter/flutter/issues/121231 is with stream or with `ios-deploy`. Note: This will cause some duplicate logs like example below but only in verbose mode ``` (lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend. (lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend. 2023-05-19 13:48:19.156866-0500 Runner[2521:390612] flutter: The Dart VM service is listening on http://127.0.0.1:63508/IsFnhXJykCM=/ VM Service URL on device: http://127.0.0.1:63508/IsFnhXJykCM=/ ```
-
- 22 May, 2023 4 commits
-
-
Jackson Gardner authored
We were looking up the wrong path for `wasm-opt` previously when using the `local-web-sdk` flag.
-
LouiseHsu authored
Show warning when attempting to flutter run on an ios device with developer mode turned off (#125710) This PR adds a warning when a user attempt to `flutter run -d <device id>` on a device without developer mode enabled. <img width="738" alt="Screenshot 2023-05-09 at 3 53 18 AM" src="https://github.com/flutter/flutter/assets/36148254/6f473a6a-5a0d-438b-9e6f-06d09eb1f3a9"> Also handles multiple partial matches. <img width="788" alt="Screenshot 2023-05-09 at 3 52 24 AM" src="https://github.com/flutter/flutter/assets/36148254/60c82b3c-d501-4a01-95ad-d6309fe39576"> Fixes https://github.com/flutter/flutter/issues/111988
-
Ian Hickson authored
Similar to https://github.com/flutter/flutter/pull/126972 but for master upgrades. Co-authored-by:
Tim Sneath <timsneath@google.com>
-
-
- 20 May, 2023 1 commit
-
-
Andrew Kolos authored
Relands #126086, which was reverted by #126569.
-
- 19 May, 2023 6 commits
-
-
Loïc Sharma authored
## Background The Windows runner has a race at startup: 1. **Platform thread**: creates a hidden window 2. **Platform thread**: launches the Flutter engine 3. **UI/Raster threads**: renders the first frame 4. **Platform thread**: Registers a callback to show the window once the next frame has been rendered. Steps 3 and 4 happen in parallel and it is possible for step 3 to complete before step 4 starts. In this scenario, the next frame callback is never called and the window is never shown. As a result the `windows_startup_test`'s test, which [verifies that the "show window" callback is called](https://github.com/flutter/flutter/blob/1f09a8662dad3bb1959b24e9124e05e2b9dbff1d/dev/integration_tests/windows_startup_test/windows/runner/flutter_window.cpp#L60-L64), can flake if the first frame is rendered before the show window callback has been registered. ## Solution This change makes the runner schedule a frame after it registers the next frame callback. If step 3 hasn't completed yet, this no-ops as a frame is already scheduled. If step 3 has already completed, a new frame will be rendered, which will call the next frame callback and show the window. Part of https://github.com/flutter/flutter/issues/119415 See this thread for alternatives that were considered: https://github.com/flutter/engine/pull/42061#issuecomment-1550080722
-
Phil Quitslund authored
The upcoming linter release notices null literals as unnecessary argument values and flags more `type_literal_in_constant_pattern` cases. See breakages: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8780744067138629361/+/u/analyze_flutter_flutter/stdout
-
Christopher Fujino authored
[flutter_tools] only try to take a screenshot from flutter drive if the --screenshot flag is passed (#127150) Fixes https://github.com/flutter/flutter/issues/123621
-
Chris Yang authored
xcodebuild command generates a xcresult bundle file on each run, however, it doesn't delete the file generated from previous run and will throw an error if the exact file already exists. In tool, we manually delete the file after each `flutter build` or `flutter run` command. However, there are some internal logic where xcodebuild retries multiple times. This PR deletes the xcresult bundle file at the start of each retry if it exists. Fixes https://github.com/flutter/flutter/issues/127119
-
Victoria Ashworth authored
When tests run in our CI using `flutter drive`, if there is a failure it will loop and try again. https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/drive/drive_service.dart#L177-L186 However, it's using the same `device` instance for each iteration. So what was happening was when it would fail to launch, it would tell its listeners that it was cancelled. https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/ios_deploy.dart#L486-L489 Then when the next iteration started, the `vmServiceDiscovery` would immediately return with null because the `deviceLogReader` would be cached from the previous iteration and would already be cancelled. Therefore, bypassing and cancelling the timer. https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/devices.dart#L585-L591 https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/devices.dart#L627 In addition, it seems like sometimes the stop would fail and therefore the the drain would never get the signal that it was done and therefore would hang forever. There was no indication that the stop had failed though because the logs were going to the stream that had no listeners since `deviceLogReader` was already cancelled. https://github.com/flutter/flutter/blob/434b81f1a58b8528299a63ae7c3ded2aa519e3c9/packages/flutter_tools/lib/src/ios/ios_deploy.dart#L563-L576 Fixes https://github.com/flutter/flutter/issues/127141
-
Felix Angelov authored
Fixes the `findBundleFile` method in `gradle.dart` to correctly locate app bundles generated from multiple flavor dimensions. - closes https://github.com/flutter/flutter/issues/92316 - closes https://github.com/flutter/flutter/issues/65264
-
- 17 May, 2023 2 commits
-
-
Loïc Sharma authored
This also migrates the platform channel example to stamp version information on Windows.
-
Christopher Fujino authored
camera_android was pinned because of https://github.com/flutter/flutter/issues/126710, which was fixed upstream in release 0.10.8+1.
-
- 16 May, 2023 3 commits
-
-
Victoria Ashworth authored
Instead of using rsync, which has caused errors in the past (https://github.com/flutter/flutter/issues/99785), delete the file/directory/link prior to moving it. Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files Part of https://github.com/flutter/flutter/issues/126016.
-
Michael Goderbauer authored
-
- 15 May, 2023 3 commits
-
-
Victoria Ashworth authored
Check what is available in the device's iOS DeviceSupport folder to check if symbols were properly fetched. Also, add some logging to track what status the debugger is in. Debugging for https://github.com/flutter/flutter/issues/121231.
-
Andrew Kolos authored
Fixes #124883. Will require a g3fix. Renames `AssetManifest.bin` to `AssetManifest.smcbin` (madeup extension for "Standard Message Codec binary").
-
Tomasz Gucio authored
-
- 11 May, 2023 3 commits
-
-
Andrew Kolos authored
Reverts flutter/flutter#126086. This PR changed the interfaces of some classes, namely `AndroidSdk`, and deleted a global. These classes had custom overrides in g3 that were not updated with a g3fix, so this PR has broken tests. See https://b.corp.google.com/issues/281945232 (non-public link)
-
Michael Goderbauer authored
Sync lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml and enable `implicit_reopen` and `type_literal_in_constant_pattern` (which have no violations). Also contains some clean-up work towards enabling `matching_super_parameters`, which is not quite ready yet due to its handling of "private" arguments.
-
Andrew Kolos authored
This is the first step in unifying Java-finding logic across the tool. If curious, see #126029 for an example of what all the changes will probably entail. Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`. See tracking issue https://github.com/flutter/flutter/issues/126126 for more.
-
- 10 May, 2023 1 commit
-
-
Kevin Moore authored
Filtering on 'true' omitted non-bool values
-
- 08 May, 2023 6 commits
-
-
Kevin Moore authored
Missing "tick"
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/125940 I will add tests if this PR looks roughly OK :) The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument. p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.
-
Loïc Sharma authored
This change makes `flutter pub` show the help usage: ``` PS > flutter pub Commands for managing Flutter packages. Global options: -h, --help Print this usage information. -v, --verbose Noisy logging, including all shell commands executed. If used with "--help", shows hidden options. If used with "flutter doctor", shows additional diagnostic information. (Use "-vv" to force verbose logging in those cases.) -d, --device-id Target device id or name (prefixes allowed). --version Reports the version of this tool. --suppress-analytics Suppress analytics reporting for the current CLI invocation. --disable-telemetry Disable telemetry reporting when this command runs. Usage: flutter pub <subcommand> [arguments] -h, --help Print this usage information. Available subcommands: add Add a dependency to pubspec.yaml. cache Work with the Pub system cache. deps Print package dependencies. downgrade Downgrade packages in a Flutter project. get Get the current package's dependencies. global Work with Pub global packages. login Log into pub.dev. logout Log out of pub.dev. outdated Analyze dependencies to find which ones can be upgraded. pub Pass the remaining arguments to Dart's "pub" tool. publish Publish the current package to pub.dartlang.org. remove Removes a dependency from the current package. run Run an executable from a package. test Run the "test" package. token Manage authentication tokens for hosted pub repositories. upgrade Upgrade the current package's dependencies to latest versions. uploader Manage uploaders for a package on pub.dev. version Print Pub version. Run "flutter help" to see global options. ``` Previously it showed an error message: ``` PS > flutter pub Missing subcommand for "flutter pub". Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options. ``` Addresses https://github.com/flutter/flutter/issues/110025
-
Jackson Gardner authored
This should fix https://github.com/flutter/flutter/issues/126178 When we don't pass a `--concurrency` flag to the test package, it uses a default based on the number of cores that are on the machine. However, the web test platform itself serializes all these requests anyway, which can lead to the test package timing out. This is because from the test package's perspective, it has already started the loading process on a number of suites which are simply waiting for other test suites to compile and run. The ones that wait the longest can run up against the test packages 12 minute timeout for loading a given suite, even though they haven't actually started to try to load. Instead, we should always pass `--concurrency=1` to the test package so that it doesn't attempt to start loads concurrently in the first place.
-
Elias Yishak authored
Fixes: - https://github.com/flutter/flutter/issues/124411 This PR is cleaning up the `--disable-telemetry` help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag `--enable-telemetry` which will enable telemetry collection
-
Pierre-Louis authored
In particular, update pin for `material_color_utilities` to `0.5.0`.
-
- 05 May, 2023 2 commits
-
-
Kevin Moore authored
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
chunhtai authored
as title
-