1. 26 May, 2023 3 commits
  2. 24 May, 2023 2 commits
  3. 23 May, 2023 4 commits
    • Ian Hickson's avatar
      Give channel descriptions in `flutter channel`, use branch instead of upstream... · 9c7a9e77
      Ian Hickson authored
      Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936)
      
      ## How we determine the channel name
      
      Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time.
      
      I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird.
      
      This PR changes the logic to uses the current branch as the channel name.
      
      ## How we display channels
      
      The main reason this PR exists is to add channel descriptions to the `flutter channel` list:
      
      ```
      ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel
      Flutter channels:
        master (tip of tree, for contributors)
        main (tip of tree, follows master channel)
        beta (updated monthly, recommended for experienced users)
        stable (updated quarterly, for new users and for production app releases)
      * foo_bar
      
      Currently not on an official channel.
      ianh@burmese:~/dev/flutter/packages/flutter_tools$
      ```
      
      ## Other changes
      
      I made a few other changes while I was at it:
      
      * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on.
      * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`.
      * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context.
      * Simplified some of the code.
      * Made some of the tests more strict (checking all output rather than just some aspects of it).
      * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly.
      * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy).
      * Tweaked the help text for the `downgrade` command to be clearer.
      * Removed some misleading text in some error messages.
      * Made the `.metadata` generator consistent with the template file.
      * Removed some obsolete code to do with the `dev` branch.
      
      ## Reviewer notes
      
      I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
      9c7a9e77
    • Christopher Fujino's avatar
    • Victoria Ashworth's avatar
      Revert "Log all output of ios-deploy" (#127405) · d452ce96
      Victoria Ashworth authored
      Reverts flutter/flutter#127222
      d452ce96
    • Victoria Ashworth's avatar
      Log all output of ios-deploy (#127222) · 7fa45ea4
      Victoria Ashworth authored
      Log all output of `ios-deploy` to try and determine if the issue of https://github.com/flutter/flutter/issues/121231 is with stream or with `ios-deploy`.
      
      Note: This will cause some duplicate logs like example below but only in verbose mode
      
      ```
      (lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend.
      (lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend.
      2023-05-19 13:48:19.156866-0500 Runner[2521:390612] flutter: The Dart VM service is listening on http://127.0.0.1:63508/IsFnhXJykCM=/
      VM Service URL on device: http://127.0.0.1:63508/IsFnhXJykCM=/
      ```
      7fa45ea4
  4. 22 May, 2023 4 commits
  5. 20 May, 2023 1 commit
  6. 19 May, 2023 6 commits
  7. 17 May, 2023 2 commits
  8. 16 May, 2023 3 commits
  9. 15 May, 2023 3 commits
  10. 11 May, 2023 3 commits
  11. 10 May, 2023 1 commit
  12. 08 May, 2023 6 commits
    • Kevin Moore's avatar
      tool/web: tiniest tweak to wasm help content (#126284) · 8c5a1ea7
      Kevin Moore authored
      Missing "tick"
      8c5a1ea7
    • fzyzcjy's avatar
      Fix that `flutter test` does not understand `concurrency` (#125942) · 742a1b49
      fzyzcjy authored
      Close https://github.com/flutter/flutter/issues/125940
      
      I will add tests if this PR looks roughly OK :)
      
      The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument.
      
      p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.
      742a1b49
    • Loïc Sharma's avatar
      [Tool] Output help on 'flutter pub' (#126211) · 472a0ab3
      Loïc Sharma authored
      This change makes `flutter pub` show the help usage:
      
      ```
      PS > flutter pub
      Commands for managing Flutter packages.
      
      Global options:
      -h, --help                  Print this usage information.
      -v, --verbose               Noisy logging, including all shell commands executed.
                                  If used with "--help", shows hidden options. If used with "flutter
                                  doctor", shows additional diagnostic information. (Use "-vv" to force
                                  verbose logging in those cases.)
      -d, --device-id             Target device id or name (prefixes allowed).
          --version               Reports the version of this tool.
          --suppress-analytics    Suppress analytics reporting for the current CLI invocation.
          --disable-telemetry     Disable telemetry reporting when this command runs.
      
      Usage: flutter pub <subcommand> [arguments]
      -h, --help    Print this usage information.
      
      Available subcommands:
        add         Add a dependency to pubspec.yaml.
        cache       Work with the Pub system cache.
        deps        Print package dependencies.
        downgrade   Downgrade packages in a Flutter project.
        get         Get the current package's dependencies.
        global      Work with Pub global packages.
        login       Log into pub.dev.
        logout      Log out of pub.dev.
        outdated    Analyze dependencies to find which ones can be upgraded.
        pub         Pass the remaining arguments to Dart's "pub" tool.
        publish     Publish the current package to pub.dartlang.org.
        remove      Removes a dependency from the current package.
        run         Run an executable from a package.
        test        Run the "test" package.
        token       Manage authentication tokens for hosted pub repositories.
        upgrade     Upgrade the current package's dependencies to latest versions.
        uploader    Manage uploaders for a package on pub.dev.
        version     Print Pub version.
      
      Run "flutter help" to see global options.
      ```
      
      Previously it showed an error message:
      
      ```
      PS > flutter pub
      Missing subcommand for "flutter pub".
      
      Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
      ```
      
      Addresses https://github.com/flutter/flutter/issues/110025
      472a0ab3
    • Jackson Gardner's avatar
      Always use `--concurrency=1` for web tests. (#126179) · 4439fd41
      Jackson Gardner authored
      This should fix https://github.com/flutter/flutter/issues/126178
      
      When we don't pass a `--concurrency` flag to the test package, it uses a default based on the number of cores that are on the machine. However, the web test platform itself serializes all these requests anyway, which can lead to the test package timing out. This is because from the test package's perspective, it has already started the loading process on a number of suites which are simply waiting for other test suites to compile and run. The ones that wait the longest can run up against the test packages 12 minute timeout for loading a given suite, even though they haven't actually started to try to load.
      
      Instead, we should always pass `--concurrency=1` to the test package so that it doesn't attempt to start loads concurrently in the first place.
      4439fd41
    • Elias Yishak's avatar
      Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (#125995) · 0d587527
      Elias Yishak authored
      Fixes:
      - https://github.com/flutter/flutter/issues/124411
      
      This PR is cleaning up the `--disable-telemetry` help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag `--enable-telemetry` which will enable telemetry collection
      0d587527
    • Pierre-Louis's avatar
      Update packages (#126140) · 65dfb555
      Pierre-Louis authored
      In particular, update pin for `material_color_utilities` to `0.5.0`.
      65dfb555
  13. 05 May, 2023 2 commits