- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 22 Mar, 2023 1 commit
-
-
Ian Hickson authored
Documentation improvements
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 31 Oct, 2022 1 commit
-
-
Greg Spencer authored
-
- 23 Sep, 2022 2 commits
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 08 Feb, 2022 1 commit
-
-
Jonah Williams authored
-
- 08 Jun, 2021 1 commit
-
-
Dan Field authored
-
- 02 Jun, 2021 2 commits
-
-
Dan Field authored
- 21 May, 2021 1 commit
-
-
nt4f04uNd authored
-
- 30 Apr, 2021 1 commit
-
-
Kate Lovett authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 24 Mar, 2021 1 commit
-
-
xubaolin authored
-
- 15 Sep, 2020 1 commit
-
-
Alexandre Ardhuin authored
* Reland "Nnbd widgets (#64672)" This reverts commit 127e6790. * remove non-nullable enforcement on AsyncSnapshot * make data param non-nullable for AsyncSnapshot.withData * make some Text params non-nullable
-
- 09 Sep, 2020 2 commits
-
-
Michael Goderbauer authored
This reverts commit e682ec71.
-
Alexandre Ardhuin authored
* migrate widget to nullsafety * remove double blank line after license * address review comments in actions.dart * nullable ObjectKey.value * use local variable oldElement * make State.build non-nullable * make State.context non-nullable * newline at eof * make ProxyWidget.child non-nullable * make _InactiveElements.debugContains non-nullable * make Element.depth non-nullable * make ProxyElement.build non-nullable * make StatefulElement.state non-nullable * remove 'Notice that' * avoid cast of list in RenderObjectElement.updateChildren * make IndexedSlot.value non-nullable * avoid cast of list in MultiChildRenderObjectElement.mount * make some WidgetsApp parameters non-nullable * hitTest take non-nullable position * make ScrollableState.position non-nullable * use _pixels instead of pixels * make ViewportOffset.pixels non-nullable * make param and return type of IndexedWidgetBuilder non-nullable * unused_import * make context param non-nullable for Builder in animated_list.dart * make ScrollMetrics.viewportDimension non-nullable * make ScrollMetrics.{min,max}ScrollExtent non-nullable * make _Location.file non-nullable * _WidgetForTypeTests.createElement throw UnimplementedError * update _NullWidget.build error message * make _ShortcutsState.manager non-nullable * Fix childCount issues for NNBD * fix childCount computation on web * increase max value on js side to compute childCount * make aspect parameter of dependOnInheritedWidgetOfExactType nullable * merge has{min,max}ScrollExtent into hasScrollExtents * update focus_manager.dart * address review comments in icon.dart * address review comments in image.dart * address review comments in routes.dart * address review comments in scroll_activity.dart * update doc comments * make UserScrollNotification.direction non-nullable and required * rename hasScrollExtents to hasContentDimensions * unnecessary late Co-authored-by:
Ian Hickson <ian@hixie.ch>
-
- 29 Aug, 2020 1 commit
-
-
LongCatIsLooong authored
Reland "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" reverted in #64091 (#64513)
-
- 20 Aug, 2020 3 commits
-
-
Todd Volkert authored
This reverts commit ce40de69. (this re-applies #64189 by reverting #64249)
-
Mehmet Fidanboylu authored
This reverts commit 21cfed34.
-
Todd Volkert authored
* (insert|move|remove)ChildRenderObject Deprecation: Step 1 This deprecates the following methods: * RenderObjectElement.insertChildRenderObject * RenderObjectElement.moveChildRenderObject * RenderObjectElement.removeChildRenderObject ...and replaces them with the following methods: * RenderObjectElement.insertRenderObjectChild * RenderObjectElement.moveRenderObjectChild * RenderObjectElement.removeRenderObjectChild The reason for the deprecation is to provide the `oldSlot` argument to the `moveRenderObjectChild` method (such an argument was missing from the now-deprecated `moveChildRenderObject` method) and the `slot` argument to the `removeRenderObjectChild` method (such an argument was missing from the now-deprecated `removeChildRenderObject` method). While no argument was added to `insertRenderObjectChild`, the name change (and corresponding deprecation) was made to maintain naming parity with the other two methods. This initial step does not update or remove any of the `slotToChild` patterns that exist in the framework. This work is being separated into two commits in case something needs to be reverted to minimize the scope of each commit. See https://github.com/flutter/flutter/issues/63269 for more info
-
- 18 Aug, 2020 1 commit
-
-
Mehmet Fidanboylu authored
Revert "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" (#64091) This reverts commit 64d76f2f.
-
- 14 Aug, 2020 1 commit
-
-
LongCatIsLooong authored
Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 31 Jan, 2020 2 commits
-
-
Jonah Williams authored
This reverts commit 340b193f.
- 30 Jan, 2020 1 commit
-
-
chunhtai authored
-
- 06 Dec, 2019 1 commit
-
-
Tom Robinson authored
-
- 04 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/widgets * address review comments * address review comment
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 05 Nov, 2019 1 commit
-
-
Kate Lovett authored
SliverAppBar - Configurable overscroll stretch with callback feature & FlexibleSpaceBar support (#42250)
-
- 17 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 10 Jul, 2019 1 commit
-
-
Tom Robinson authored
* Remove extra classes. Now that https://github.com/dart-lang/sdk/issues/31543 is fixed, we can remove extra classes. * Add snapConfiguration to parameters for _RenderSliverFloatingPersistentHeaderForWidgets and _RenderSliverFloatingPinnedPersistentHeaderForWidgets constructors.
-
- 17 Oct, 2018 1 commit
-
- 16 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
* Future<void> main * Future<void>.delayed * prefer_void_to_Null * address review comments
-
- 05 Oct, 2018 2 commits
-
-
Yegor authored
* first pass * revert WidgetsBindingObserver * disable prefer_mixin * docs and more mixins * newer engine; binding fixes * upgrade dependencies * fix test binding * remove whitespace * remove the obsolete `enableSuperMixins: true` * upgrade dartdoc to 0.22.0 * temporarily use git version of dartdoc * fix pub global activate syntax * use dartdoc 0.23.0
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-