Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
340b193f
Unverified
Commit
340b193f
authored
Jan 30, 2020
by
chunhtai
Committed by
GitHub
Jan 30, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactors global key duplication detection (#46183)
parent
423459da
Changes
14
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
14 changed files
with
756 additions
and
84 deletions
+756
-84
action_sheet.dart
packages/flutter/lib/src/cupertino/action_sheet.dart
+1
-0
dialog.dart
packages/flutter/lib/src/cupertino/dialog.dart
+1
-0
chip.dart
packages/flutter/lib/src/material/chip.dart
+1
-0
input_decorator.dart
packages/flutter/lib/src/material/input_decorator.dart
+1
-0
list_tile.dart
packages/flutter/lib/src/material/list_tile.dart
+1
-0
binding.dart
packages/flutter/lib/src/widgets/binding.dart
+1
-0
framework.dart
packages/flutter/lib/src/widgets/framework.dart
+161
-72
layout_builder.dart
packages/flutter/lib/src/widgets/layout_builder.dart
+1
-0
list_wheel_scroll_view.dart
packages/flutter/lib/src/widgets/list_wheel_scroll_view.dart
+1
-0
sliver.dart
packages/flutter/lib/src/widgets/sliver.dart
+1
-0
sliver_persistent_header.dart
...ges/flutter/lib/src/widgets/sliver_persistent_header.dart
+1
-0
table.dart
packages/flutter/lib/src/widgets/table.dart
+1
-0
diagnostics_json_test.dart
packages/flutter/test/foundation/diagnostics_json_test.dart
+0
-5
framework_test.dart
packages/flutter/test/widgets/framework_test.dart
+584
-7
No files found.
packages/flutter/lib/src/cupertino/action_sheet.dart
View file @
340b193f
...
...
@@ -469,6 +469,7 @@ class _CupertinoAlertRenderElement extends RenderObjectElement {
}
else
if
(
_actionsElement
==
child
)
{
_actionsElement
=
null
;
}
super
.
forgetChild
(
child
);
}
@override
...
...
packages/flutter/lib/src/cupertino/dialog.dart
View file @
340b193f
...
...
@@ -464,6 +464,7 @@ class _CupertinoDialogRenderElement extends RenderObjectElement {
assert
(
_actionsElement
==
child
);
_actionsElement
=
null
;
}
super
.
forgetChild
(
child
);
}
@override
...
...
packages/flutter/lib/src/material/chip.dart
View file @
340b193f
...
...
@@ -2072,6 +2072,7 @@ class _RenderChipElement extends RenderObjectElement {
final
_ChipSlot
slot
=
childToSlot
[
child
];
childToSlot
.
remove
(
child
);
slotToChild
.
remove
(
slot
);
super
.
forgetChild
(
child
);
}
void
_mountChild
(
Widget
widget
,
_ChipSlot
slot
)
{
...
...
packages/flutter/lib/src/material/input_decorator.dart
View file @
340b193f
...
...
@@ -1511,6 +1511,7 @@ class _RenderDecorationElement extends RenderObjectElement {
final
_DecorationSlot
slot
=
childToSlot
[
child
];
childToSlot
.
remove
(
child
);
slotToChild
.
remove
(
slot
);
super
.
forgetChild
(
child
);
}
void
_mountChild
(
Widget
widget
,
_DecorationSlot
slot
)
{
...
...
packages/flutter/lib/src/material/list_tile.dart
View file @
340b193f
...
...
@@ -992,6 +992,7 @@ class _ListTileElement extends RenderObjectElement {
final
_ListTileSlot
slot
=
childToSlot
[
child
];
childToSlot
.
remove
(
child
);
slotToChild
.
remove
(
slot
);
super
.
forgetChild
(
child
);
}
void
_mountChild
(
Widget
widget
,
_ListTileSlot
slot
)
{
...
...
packages/flutter/lib/src/widgets/binding.dart
View file @
340b193f
...
...
@@ -1016,6 +1016,7 @@ class RenderObjectToWidgetElement<T extends RenderObject> extends RootRenderObje
void
forgetChild
(
Element
child
)
{
assert
(
child
==
_child
);
_child
=
null
;
super
.
forgetChild
(
child
);
}
@override
...
...
packages/flutter/lib/src/widgets/framework.dart
View file @
340b193f
This diff is collapsed.
Click to expand it.
packages/flutter/lib/src/widgets/layout_builder.dart
View file @
340b193f
...
...
@@ -60,6 +60,7 @@ class _LayoutBuilderElement<ConstraintType extends Constraints> extends RenderOb
void
forgetChild
(
Element
child
)
{
assert
(
child
==
_child
);
_child
=
null
;
super
.
forgetChild
(
child
);
}
@override
...
...
packages/flutter/lib/src/widgets/list_wheel_scroll_view.dart
View file @
340b193f
...
...
@@ -924,6 +924,7 @@ class ListWheelElement extends RenderObjectElement implements ListWheelChildMana
@override
void
forgetChild
(
Element
child
)
{
_childElements
.
remove
(
child
.
slot
);
super
.
forgetChild
(
child
);
}
}
...
...
packages/flutter/lib/src/widgets/sliver.dart
View file @
340b193f
...
...
@@ -1160,6 +1160,7 @@ class SliverMultiBoxAdaptorElement extends RenderObjectElement implements Render
assert
(
child
.
slot
!=
null
);
assert
(
_childElements
.
containsKey
(
child
.
slot
));
_childElements
.
remove
(
child
.
slot
);
super
.
forgetChild
(
child
);
}
@override
...
...
packages/flutter/lib/src/widgets/sliver_persistent_header.dart
View file @
340b193f
...
...
@@ -230,6 +230,7 @@ class _SliverPersistentHeaderElement extends RenderObjectElement {
void
forgetChild
(
Element
child
)
{
assert
(
child
==
this
.
child
);
this
.
child
=
null
;
super
.
forgetChild
(
child
);
}
@override
...
...
packages/flutter/lib/src/widgets/table.dart
View file @
340b193f
...
...
@@ -344,6 +344,7 @@ class _TableElement extends RenderObjectElement {
@override
bool
forgetChild
(
Element
child
)
{
_forgottenChildren
.
add
(
child
);
super
.
forgetChild
(
child
);
return
true
;
}
}
...
...
packages/flutter/test/foundation/diagnostics_json_test.dart
View file @
340b193f
...
...
@@ -221,11 +221,6 @@ void main() {
class
_TestElement
extends
Element
{
_TestElement
()
:
super
(
const
Placeholder
());
@override
void
forgetChild
(
Element
child
)
{
// Intentionally left empty.
}
@override
void
performRebuild
()
{
// Intentionally left empty.
...
...
packages/flutter/test/widgets/framework_test.dart
View file @
340b193f
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment