1. 11 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Re-land text wrapping/color PR (#22831) · 081d2a7a
      Greg Spencer authored
      This attempts to re-land #22656.
      
      There are two changes from the original:
      
      I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.
      
      I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.
      
      As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.
      
      *     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
          This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
          Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
          Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
          Since wrapping is now turned on, also removed many redundant '\n's in the code.
      081d2a7a
  2. 06 Oct, 2018 2 commits
    • Greg Spencer's avatar
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to... · 2d81adf7
      Greg Spencer authored
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759)
      
      This reverts commit e4386321
      because it breaks 160 benchmarks, and several devicelab tests,
      due to changing the format of the output.
      2d81adf7
    • Greg Spencer's avatar
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor... · e4386321
      Greg Spencer authored
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
      This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
      Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
      Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
      Since wrapping is now turned on, also removed many redundant '\n's in the code.
      e4386321
  3. 05 Oct, 2018 1 commit
  4. 12 Sep, 2018 1 commit
  5. 27 Jun, 2018 1 commit
  6. 15 Jun, 2018 2 commits
  7. 12 Mar, 2018 1 commit
  8. 10 Nov, 2017 1 commit
  9. 08 Nov, 2017 1 commit
  10. 26 Sep, 2017 1 commit
    • Todd Volkert's avatar
      Run command validation on all commands. (#12246) · a08b5e00
      Todd Volkert authored
      This makes command validation happen as part of `verifyThenRunCommand()`,
      using a newly introduced protected method (`validateCommand()`) rather than
      a `commandValidator` property (that subclasses were responsible for manually
      invoking).
      a08b5e00
  11. 22 Mar, 2017 1 commit
  12. 04 Mar, 2017 1 commit
  13. 23 Feb, 2017 1 commit
  14. 15 Feb, 2017 1 commit
  15. 14 Feb, 2017 1 commit
  16. 07 Jan, 2017 1 commit
    • Todd Volkert's avatar
      Update flutter_tools to use package:file throughout (#7385) · 8bb27034
      Todd Volkert authored
      This removes direct file access from within flutter_tools
      in favor of using `package:file` via a `FileSystem` that's
      accessed via the `ApplicationContext`.
      
      This lays the groundwork for us to be able to easily swap
      out the underlying file system when running Flutter tools,
      which will be used to provide a record/replay file system,
      analogous to what we have for process invocations.
      8bb27034
  17. 01 Dec, 2016 1 commit
  18. 28 Nov, 2016 2 commits
  19. 14 Nov, 2016 1 commit
    • Dan Rubel's avatar
      Refactor flutter command exit code - part 3 of 3 (#6838) · 34e466f1
      Dan Rubel authored
      * Remove the workaround that pinned args to v0.13.6
      This reverts most of the changes in commit 6331b6c8
      * throw exception if exit code is not an integer
      * rework command infrastructure to throw ToolExit when non-zero exitCode
      * convert commands to return Future<Null>
      * cleanup remaining commands to use throwToolExit for non-zero exit code
      * remove isUnusual exception message
      * add type annotations for updated args package
      34e466f1
  20. 16 Sep, 2016 1 commit
    • Dan Rubel's avatar
      Refactor flutter command execution (#5892) · 18212382
      Dan Rubel authored
      * refactor _run to runCmd
      
      * replace requiresProjectRoot getter with call to commandValidator
      
      * replace requiresDevice getter with call to findTargetDevice
      
      * trace command requires a debug connection, not a device
      
      * inline androidOnly getter
      
      * rename command methods to verifyTheRunCmd and runCmd
      
      * move common verification into BuildSubCommand
      
      * rename deviceForCommand to device
      
      * rename methods to verifyThenRunCommand and runCommand
      18212382
  21. 25 Aug, 2016 1 commit
    • Chris Bracken's avatar
      Support a configurable build directory (#5601) · b5f763b4
      Chris Bracken authored
      This change adds a top-level getBuildDirectory func and funcs for
      android, aot, asset, ios build products.
      
      Developers may now add a "build-dir" mapping to their
      ~/.flutter_settings (JSON format) config file. Output directory is
      relative to the main flutter application directory.
      
      This change also changes the default build directory for iOS builds to a
      subdirectory of the configured build directory, 'build/ios' by default.
      b5f763b4
  22. 24 Aug, 2016 1 commit
  23. 17 Aug, 2016 1 commit
  24. 11 Aug, 2016 1 commit
  25. 09 Aug, 2016 1 commit
  26. 14 Jun, 2016 1 commit
    • Ian Hickson's avatar
      Lock flutter tool while updating artifacts (#4476) · f92f71fe
      Ian Hickson authored
      This prevents multiple simultaneous runs of the analyzer from stomping
      over each other (e.g. multiple runs of 'update-packages'). Certain
      long-lived commands (like analyze, run, logs) are exempted once they've
      done enough work to be safe from most stomping action.
      
      This still doesn't make us entirely safe from craziness, e.g. if you're
      half way through an 'update-packages' run and you call 'git pull', who
      knows what state you'll end up in. But there's only so much one can do.
      
      Fixes https://github.com/flutter/flutter/issues/2762
      f92f71fe
  27. 07 Jun, 2016 1 commit
    • Devon Carew's avatar
      add a restart command to the daemon protocol (#4385) · 3ba17136
      Devon Carew authored
      * refactor the --resident run option into a separate file
      
      * update daemon to run --resident apps
      
      * re-plumbing daemon start
      
      * send app logs
      
      * update tests
      
      * review changes
      
      * fix test runner
      
      * remove PackageMap.createGlobalInstance; rely on the ctor
      
      * review comments
      3ba17136
  28. 19 May, 2016 1 commit
  29. 13 May, 2016 1 commit
    • Devon Carew's avatar
      Consolidate observatory code (#3892) · 40c0d6ea
      Devon Carew authored
      * rename service_protocol.dart to protocol_discovery.dart
      
      * add a wrapper around the obs. protocol
      
      * use json-rpc in run
      
      * consolidate obs. code; implement flutter run --benchmark
      
      * review comments
      40c0d6ea
  30. 10 May, 2016 1 commit
  31. 28 Apr, 2016 1 commit
  32. 27 Apr, 2016 1 commit
    • Devon Carew's avatar
      Flutter run (#3553) · b0dca796
      Devon Carew authored
      * rework flutter run
      
      * fix npe with --debug-port
      
      * connect to obs and exit when that conneciton closes
      
      * update todos
      b0dca796
  33. 19 Apr, 2016 1 commit
  34. 04 Apr, 2016 1 commit
  35. 21 Mar, 2016 1 commit
  36. 14 Mar, 2016 2 commits