- 09 May, 2023 3 commits
-
-
Bruno Leroux authored
## Description This PR adds some details in FocusNode documentation to explain more precisely when listeners are notified. ## Related Issue Fixes https://github.com/flutter/flutter/issues/126149 ## Tests Documentation only.
-
Michael Goderbauer authored
Dead code was flagged by `unreachable_from_main` lint, which is still experimental and not ready to be enabled yet.
-
Viren Khatri authored
-
- 08 May, 2023 18 commits
-
-
Kevin Moore authored
Missing "tick"
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d9184ce4ffa0...8d3a8162b3ab 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 30a368d502bf to 951eb9653163 (4 revisions) (flutter/engine#41820) 2023-05-08 jacksongardner@google.com Reland "Skwasm Font Loading (flutter/engine#41756) 2023-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from KZrdNPIOcs5m2MqV_... to oGF4h14qc40l5ANL3... (flutter/engine#41819) 2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 855e2764c295 to a8b6687327d6 (1 revision) (flutter/engine#41817) 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 64ba57381c94 to 30a368d502bf (1 revision) (flutter/engine#41816) 2023-05-08 godofredoc@google.com Add linux license engine v2 build. (flutter/engine#41797) 2023-05-08 godofredoc@google.com Windows unopt configuration. (flutter/engine#41785) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from KZrdNPIOcs5m to oGF4h14qc40l If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/125940 I will add tests if this PR looks roughly OK :) The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument. p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/125940 I will add tests if this PR looks roughly OK :) The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument. p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.
-
Alex Li authored
Just found these extra intents and the very long line which might be improved. Related git blame: https://github.com/flutter/flutter/blame/master/packages/flutter/lib/src/services/asset_bundle.dart#L337.
-
fzyzcjy authored
Close https://github.com/flutter/flutter/issues/125724 > The `navigator.dart` has ~10 repeats of things like: > > ```dart > final _RouteEntry? currentRouteEntry = _navigator!._history.cast<_RouteEntry?>().lastWhere( > (_RouteEntry? e) => e != null && _RouteEntry.isPresentPredicate(e), > orElse: () => null, > ); > ``` > > while it can be greatly simplified as: > > ```dart > final _RouteEntry? currentRouteEntry = _navigator!._history.lastWhereOrNull(_RouteEntry.isPresentPredicate); > ``` > > Thus, it seems that we can beautify the code a little bit. Same as https://github.com/flutter/flutter/pull/125099, but without external dependency For more detailed explanation why it does not introduce external dependency: https://github.com/flutter/flutter/pull/125099#discussion_r1174230502
-
Yu authored
Replaces #125616 I just fixed "IMAGES" to "images" in examples/image_list. Currently, "PREFER uses the lower case of the constant name ".
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a8e9ac63fd95...d9184ce4ffa0 2023-05-08 godofredoc@google.com Linux fuchsia engine v2 config. (flutter/engine#41759) 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 5f7e572995b1 to 64ba57381c94 (1 revision) (flutter/engine#41814) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Loïc Sharma authored
This change makes `flutter pub` show the help usage: ``` PS > flutter pub Commands for managing Flutter packages. Global options: -h, --help Print this usage information. -v, --verbose Noisy logging, including all shell commands executed. If used with "--help", shows hidden options. If used with "flutter doctor", shows additional diagnostic information. (Use "-vv" to force verbose logging in those cases.) -d, --device-id Target device id or name (prefixes allowed). --version Reports the version of this tool. --suppress-analytics Suppress analytics reporting for the current CLI invocation. --disable-telemetry Disable telemetry reporting when this command runs. Usage: flutter pub <subcommand> [arguments] -h, --help Print this usage information. Available subcommands: add Add a dependency to pubspec.yaml. cache Work with the Pub system cache. deps Print package dependencies. downgrade Downgrade packages in a Flutter project. get Get the current package's dependencies. global Work with Pub global packages. login Log into pub.dev. logout Log out of pub.dev. outdated Analyze dependencies to find which ones can be upgraded. pub Pass the remaining arguments to Dart's "pub" tool. publish Publish the current package to pub.dartlang.org. remove Removes a dependency from the current package. run Run an executable from a package. test Run the "test" package. token Manage authentication tokens for hosted pub repositories. upgrade Upgrade the current package's dependencies to latest versions. uploader Manage uploaders for a package on pub.dev. version Print Pub version. Run "flutter help" to see global options. ``` Previously it showed an error message: ``` PS > flutter pub Missing subcommand for "flutter pub". Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options. ``` Addresses https://github.com/flutter/flutter/issues/110025
-
Jackson Gardner authored
This should fix https://github.com/flutter/flutter/issues/126178 When we don't pass a `--concurrency` flag to the test package, it uses a default based on the number of cores that are on the machine. However, the web test platform itself serializes all these requests anyway, which can lead to the test package timing out. This is because from the test package's perspective, it has already started the loading process on a number of suites which are simply waiting for other test suites to compile and run. The ones that wait the longest can run up against the test packages 12 minute timeout for loading a given suite, even though they haven't actually started to try to load. Instead, we should always pass `--concurrency=1` to the test package so that it doesn't attempt to start loads concurrently in the first place.
-
Elias Yishak authored
Related to: - https://github.com/flutter/flutter/issues/125512 Adding verbose flags to get printed out on error to help debug the cause of the flakey test
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/a0f8fd89af1a...4800d6512ebb 2023-05-08 102626803+drewroengoogle@users.noreply.github.com Update .cirrus.yml (flutter/packages#3916) 2023-05-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 0b657236 to 43ac23b4 (30 revisions) (flutter/packages#3922) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Reid Baker authored
- Update Gradle/AGP version and add namespace plus dependencies. https://github.com/flutter/flutter/issues/125181
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c42dd23e29f6...a8e9ac63fd95 2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from ab64c4a56e2c to 855e2764c295 (1 revision) (flutter/engine#41813) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Elias Yishak authored
Fixes: - https://github.com/flutter/flutter/issues/124411 This PR is cleaning up the `--disable-telemetry` help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag `--enable-telemetry` which will enable telemetry collection
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/23f730efbff7...c42dd23e29f6 2023-05-08 goderbauer@google.com Fix doc to fix engine roll (flutter/engine#41812) 2023-05-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.2 to 2.3.3 (flutter/engine#41811) 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 802eb7f66fc5 to 5f7e572995b1 (1 revision) (flutter/engine#41809) 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from f9bef8f7bdb5 to 802eb7f66fc5 (1 revision) (flutter/engine#41807) 2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 148ebc0596b7 to f9bef8f7bdb5 (1 revision) (flutter/engine#41806) 2023-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VD0zJZ-ezOAfA9O1s... to KZrdNPIOcs5m2MqV_... (flutter/engine#41805) 2023-05-07 skia-flutter-autoroll@skia.org Roll Skia from 642ba306e140 to 148ebc0596b7 (1 revision) (flutter/engine#41804) 2023-05-07 skia-flutter-autoroll@skia.org Roll Skia from 8a93b289c2ed to 642ba306e140 (1 revision) (flutter/engine#41802) 2023-05-07 skia-flutter-autoroll@skia.org Roll ICU from d8daa943f64c to a2961dc659b4 (2 revisions) (flutter/engine#41801) 2023-05-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from k4NzlntuagXZIlCJg... to VD0zJZ-ezOAfA9O1s... (flutter/engine#41800) 2023-05-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from FFOWihz4lzOeDHmNj... to k4NzlntuagXZIlCJg... (flutter/engine#41799) 2023-05-06 skia-flutter-autoroll@skia.org Roll Dart SDK from d04e8b571819 to ab64c4a56e2c (1 revision) (flutter/engine#41798) 2023-05-06 dnfield@google.com Add a `Display` API to dart:ui that reports the physical size, DPR, and refresh rate of the main display (flutter/engine#41685) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from FFOWihz4lzOe to KZrdNPIOcs5m If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/126096. Fixes https://github.com/flutter/flutter/issues/126097. Fixes https://github.com/flutter/flutter/issues/126102. Fixes https://github.com/flutter/flutter/issues/126098. Fixes https://github.com/flutter/flutter/issues/126147. Work towards https://github.com/flutter/flutter/issues/126100. Does not fix the OverlyEntry/ModalRoute leak (https://github.com/flutter/flutter/issues/126100).
-
Pierre-Louis authored
In particular, update pin for `material_color_utilities` to `0.5.0`.
-
- 06 May, 2023 11 commits
-
-
Tirth authored
Adds `materialGapSize` property to `ExpansionPanelList` widget. | `materialGapSize: 0` | `materialGapSize: 16` (default) | `materialGapSize: 30` | | --- | --- | --- | | ![screenshot_1680450783](https://user-images.githubusercontent.com/13456345/229366131-8dd105cd-6371-4852-b57b-5900e3dbd203.png) | ![screenshot_1680453525](https://user-images.githubusercontent.com/13456345/229366640-e2ae5f95-0cd6-4694-b8ff-0de7fb7c8554.png) | ![screenshot_1680450910](https://user-images.githubusercontent.com/13456345/229366742-3121331b-b22e-46a1-bdfa-20b5663cbe2b.png) | | ![screenshot_1680450785](https://user-images.githubusercontent.com/13456345/229366133-bf345914-9d74-4dcc-afc4-a6a9ccca13ab.png) | ![screenshot_1680453527](https://user-images.githubusercontent.com/13456345/229366644-bfff8e4f-8a66-4419-90b8-6a16442b7157.png) | ![screenshot_1680450912](https://user-images.githubusercontent.com/13456345/229366745-364b1a1e-ed2c-4463-a74d-d8e94bf509b9.png) | | ![screenshot_1680450787](https://user-images.githubusercontent.com/13456345/229366138-3f6280f0-e58a-4621-aced-c7eee2077ef8.png) | ![screenshot_1680453530](https://user-images.githubusercontent.com/13456345/229366648-3805db23-29b0-46a3-82ce-92688e65f0fd.png) | ![screenshot_1680450914](https://user-images.githubusercontent.com/13456345/229366747-73d46f9c-3edc-4197-8f02-651ff8499323.png) | | ![screenshot_1680450789](https://user-images.githubusercontent.com/13456345/229366140-4ff8572c-8d06-4985-a697-3af0ce0e5743.png) | ![screenshot_1680453532](https://user-images.githubusercontent.com/13456345/229366651-88af37ac-7503-4abc-b6a6-d8556a583871.png) | ![screenshot_1680450916](https://user-images.githubusercontent.com/13456345/229366749-0db156b0-6b53-4ef2-9699-0d3e8704433b.png) | Fixes: #118167
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/eedcee66a710...23f730efbff7 2023-05-06 skia-flutter-autoroll@skia.org Roll Skia from e7de10e25736 to 8a93b289c2ed (1 revision) (flutter/engine#41796) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/393b5649e7b4...eedcee66a710 2023-05-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from S3gPFEsS1wP40ivwV... to FFOWihz4lzOeDHmNj... (flutter/engine#41795) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from S3gPFEsS1wP4 to FFOWihz4lzOe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/876968833e46...393b5649e7b4 2023-05-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 8695bed2bc58 to d04e8b571819 (1 revision) (flutter/engine#41793) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
林洵锋 authored
Fixes #122139 with engine pr [flutter/engine#40216](https://github.com/flutter/engine/pull/40216)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d9116d94a111...876968833e46 2023-05-06 skia-flutter-autoroll@skia.org Roll Skia from 2e622658996c to e7de10e25736 (1 revision) (flutter/engine#41791) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/332f53219c4c...d9116d94a111 2023-05-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Z3O1yYOsNgkQ6b0o3... to S3gPFEsS1wP40ivwV... (flutter/engine#41790) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from Z3O1yYOsNgkQ to S3gPFEsS1wP4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b7c79b41b9d4...332f53219c4c 2023-05-06 skia-flutter-autoroll@skia.org Roll Skia from bc0197405951 to 2e622658996c (1 revision) (flutter/engine#41789) 2023-05-05 jonahwilliams@google.com [Impeller] remove SDF code paths. (flutter/engine#41754) 2023-05-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jbpFz7qSikrKiRanC... to leCRDVJ8szOS2LsPV... (flutter/engine#41788) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from jbpFz7qSikrK to leCRDVJ8szOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
✨ Alex Li authoredAs preparation for #125945. The PR improves tests itself which allows the `arc` method to be available to check whether corresponding rects are drawn during tests.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/758cbadfac1f...b7c79b41b9d4 2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from aa52cd1afae2 to bc0197405951 (3 revisions) (flutter/engine#41787) 2023-05-05 skia-flutter-autoroll@skia.org Roll Dart SDK from bb9f17a8f0c3 to 8695bed2bc58 (1 revision) (flutter/engine#41786) 2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from d6149a13d696 to aa52cd1afae2 (3 revisions) (flutter/engine#41783) 2023-05-05 zanderso@users.noreply.github.com Roll impeller-cmake-example to 270e648f8c00aa900d2d16ef8a347938652d17fb (flutter/engine#41758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Loïc Sharma authored
Enables running the `layers` example on Linux and Windows. Part of https://github.com/flutter/flutter/issues/126033
-
- 05 May, 2023 8 commits
-
-
Kevin Moore authored
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6b467df16e11...758cbadfac1f 2023-05-05 jason-simmons@users.noreply.github.com [Impeller] Do not free a Vulkan command buffer if its command pool has already been destroyed (flutter/engine#41761) 2023-05-05 dkwingsmt@users.noreply.github.com Remove single window assumption from SceneBuilder (flutter/engine#41559) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Viren Khatri authored
while debugging https://github.com/flutter/flutter/issues/123882 found out that below lines were untested. although they'll change due to the issue above, but the tests will remain. https://github.com/flutter/flutter/blob/e0045d04f7057d91b1701a444f75f2f0458c1d1a/packages/flutter/lib/src/material/scaffold.dart#L3169-L3180
-
Patrick Lindsay authored
This PR adds a month and year mode to the CupertinoDatePicker. The monthYear mode is the date mode without the day of the month. ![monthYearMode](https://user-images.githubusercontent.com/98486346/234749274-794dce24-28c7-4f48-92ab-5ac46ec069d7.png) This feature was added at the request of: [Proposal] CupertinoDatePicker with month and year. #93508 One thing that I was unsure of was the use of the DatePickerDateOrder to determine the monthYear order. It could be considered a workaround since the DatePickerDateOrder is intended to order day, month, and year. This means that a developer could use the DatePickerDateOrder.dmy (day, month, year) or DatePickerDateOrder.mdy (month, day, year) to get the same result. At first I intended to add a DatePickerMonthYearOrder enum to the localizations, in addition to a new parameter for the CupertinoDatePicker for monthYearOrder, but I ended up reverting these changes (https://github.com/flutter/flutter/commit/1c61f1084e63fc4f6e394c3621a1ae626fd631a5) because I had not considered the effects of adding values to the localizations. I decided it may be better to not add an additional parameter (monthYearOrder) that would go mostly unused. I am very open to feedback or ideas on this matter.
-
Qun Cheng authored
-
chunhtai authored
as title
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f3efe11f4449...6b467df16e11 2023-05-05 skia-flutter-autoroll@skia.org Roll Skia from 1a1c7db436e4 to d6149a13d696 (6 revisions) (flutter/engine#41779) 2023-05-05 godofredoc@google.com Replace legacy linux unopt with engine v2. (flutter/engine#41757) 2023-05-05 godofredoc@google.com Allow default out_dir for fuchsia symbols upload. (flutter/engine#41776) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Alberto Azinar authored
This PR removed the non-necessary required Koltin dependency. This is because the Kotlin Gradle adds the dependency on the standard library automatically. Fixes #98212 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy]. *
-