1. 26 May, 2023 1 commit
  2. 22 May, 2023 1 commit
  3. 05 May, 2023 1 commit
  4. 28 Feb, 2023 1 commit
  5. 15 Feb, 2023 1 commit
    • Ian Hickson's avatar
      Improve network resources doctor check (#120417) · d29668dd
      Ian Hickson authored
      ...and various other minor cleanup:
      
      * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.
      
      * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.
      
      * Made the logger delete the slow warning when it's finished.
      
      * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.
      
      * Added a debug toString to ValidationResult for debugging purposes (not used).
      
      * In http_host_validator:
      
        - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
        - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
        - Renamed the check "Network resources".
        - Updated the `slowWarning` of the check to say which hosts are pending.
        - Removed all timeout logic. Timeouts violate our style guide.
        - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
        - Replaced the `_HostValidationResult` class with `String?` for simplicity.
        - Improved the error messages to be more detailed.
        - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
        - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
        - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
        - Replaced a lot of list-filtering logic with just a single for loop to check the results.
        - Replaced code that added a constant to a known-empty list with just returning a constant list.
        - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
      d29668dd
  6. 02 Feb, 2023 1 commit
  7. 01 Feb, 2023 1 commit
  8. 23 Jan, 2023 1 commit
  9. 18 Jun, 2022 1 commit
  10. 15 Jun, 2022 1 commit
  11. 26 Apr, 2022 1 commit
  12. 08 Apr, 2022 1 commit
  13. 10 Jan, 2022 1 commit
  14. 02 Dec, 2021 1 commit
  15. 24 Nov, 2021 1 commit
  16. 11 Nov, 2021 2 commits
  17. 19 Oct, 2021 1 commit
  18. 15 Oct, 2021 2 commits
  19. 07 Oct, 2021 3 commits
  20. 14 Sep, 2021 1 commit
  21. 26 Aug, 2021 1 commit
  22. 28 Jul, 2021 1 commit
    • Greg Spencer's avatar
      Make the startup lock message print to stderr. (#86520) · 0bab3604
      Greg Spencer authored
      This changes the "Waiting for another flutter command to release the startup lock..." message output so that it appears on stderr instead of stdout. When it appears on stdout, it can mess up collection of the output. For instance, if you run flutter --version --machine and you're expecting JSON output, then you'll get non-JSON output even though the lock is released and you eventually would get what you're asking for.
      0bab3604
  23. 01 Jul, 2021 1 commit
  24. 09 Jun, 2021 1 commit
  25. 01 Jun, 2021 1 commit
  26. 12 May, 2021 1 commit
  27. 09 Apr, 2021 1 commit
  28. 06 Apr, 2021 1 commit
  29. 05 Apr, 2021 1 commit
  30. 24 Mar, 2021 1 commit
  31. 05 Mar, 2021 1 commit
  32. 02 Mar, 2021 1 commit
  33. 19 Feb, 2021 1 commit
  34. 17 Feb, 2021 1 commit
  35. 12 Feb, 2021 1 commit
  36. 11 Feb, 2021 1 commit