- 26 May, 2023 1 commit
-
-
Phil Quitslund authored
The newly updated lint will soon flag for-each in collections. See discussion: https://github.com/dart-lang/linter/pull/4383 /cc @goderbauer
-
- 22 May, 2023 1 commit
-
-
- 05 May, 2023 1 commit
-
-
Kevin Moore authored
-
- 28 Feb, 2023 1 commit
-
-
Nabeel Parkar authored
Migrate activation issue template to Github form issues
-
- 15 Feb, 2023 1 commit
-
-
Ian Hickson authored
...and various other minor cleanup: * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing. * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too. * Made the logger delete the slow warning when it's finished. * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'. * Added a debug toString to ValidationResult for debugging purposes (not used). * In http_host_validator: - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev). - Added GitHub as a tested host since when you run `flutter` we hit that immediately. - Renamed the check "Network resources". - Updated the `slowWarning` of the check to say which hosts are pending. - Removed all timeout logic. Timeouts violate our style guide. - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient. - Replaced the `_HostValidationResult` class with `String?` for simplicity. - Improved the error messages to be more detailed. - Removed all checks that dependened on the stringification of exceptions. That's very brittle. - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks). - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result. - Replaced a lot of list-filtering logic with just a single for loop to check the results. - Replaced code that added a constant to a known-empty list with just returning a constant list. - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
-
- 02 Feb, 2023 1 commit
-
-
Jesús S Guerrero authored
-
- 01 Feb, 2023 1 commit
-
-
Alex Li authored
*
Only log warning for storage base url * Add test * Add the link to the test * Remove the test * Remove the extra import
-
- 23 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes * fix after merge conflicts * review
-
- 18 Jun, 2022 1 commit
-
-
Jonah Williams authored
-
- 15 Jun, 2022 1 commit
-
-
Christopher Fujino authored
-
- 26 Apr, 2022 1 commit
-
-
Jonah Williams authored
-
- 08 Apr, 2022 1 commit
-
-
Jesús S Guerrero authored
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
-
- 10 Jan, 2022 1 commit
-
-
Greg Spencer authored
-
- 02 Dec, 2021 1 commit
-
-
Yegor authored
-
- 24 Nov, 2021 1 commit
-
-
Yegor authored
-
- 11 Nov, 2021 2 commits
-
-
Kenzie (Schmoll) Davisson authored
* Add DevTools version to `flutter --version` output. * review comments * fix test * add explanatory comment * dummy commit to kick bots Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
-
Greg Spencer authored
-
- 19 Oct, 2021 1 commit
-
-
Jenn Magder authored
-
- 15 Oct, 2021 2 commits
-
-
Jenn Magder authored
This reverts commit 00658736.
-
Jenn Magder authored
-
- 07 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Mouad Debbar authored
This reverts commit cb378edc.
-
Ian Hickson authored
-
- 14 Sep, 2021 1 commit
-
-
Michael Thomsen authored
-
- 26 Aug, 2021 1 commit
-
-
Jenn Magder authored
-
- 28 Jul, 2021 1 commit
-
-
Greg Spencer authored
This changes the "Waiting for another flutter command to release the startup lock..." message output so that it appears on stderr instead of stdout. When it appears on stdout, it can mess up collection of the output. For instance, if you run flutter --version --machine and you're expecting JSON output, then you'll get non-JSON output even though the lock is released and you eventually would get what you're asking for.
-
- 01 Jul, 2021 1 commit
-
-
Ahmed Ashour authored
-
- 09 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 May, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Apr, 2021 1 commit
-
-
Jonah Williams authored
-
- 06 Apr, 2021 1 commit
-
-
Jonah Williams authored
-
- 05 Apr, 2021 1 commit
-
-
Jonah Williams authored
-
- 24 Mar, 2021 1 commit
-
-
Jonah Williams authored
-
- 05 Mar, 2021 1 commit
-
-
Jenn Magder authored
-
- 02 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 19 Feb, 2021 1 commit
-
-
Jonah Williams authored
-
- 17 Feb, 2021 1 commit
-
-
Jonah Williams authored
-
- 12 Feb, 2021 1 commit
-
-
Hidenori Matsubayashi authored
-
- 11 Feb, 2021 1 commit
-
-
Jonah Williams authored
-