1. 04 Dec, 2023 1 commit
  2. 30 Nov, 2023 1 commit
  3. 29 Nov, 2023 1 commit
  4. 06 Nov, 2023 1 commit
  5. 15 Sep, 2023 1 commit
  6. 10 Sep, 2023 1 commit
    • Daco Harkes's avatar
      Native assets support for MacOS and iOS (#130494) · aa36db1d
      Daco Harkes authored
      Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code.
      
      For more info see:
      
      * https://github.com/flutter/flutter/issues/129757
      
      ### Implementation details for MacOS and iOS.
      
      Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file).
      
      The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target.
      
      The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets.
      
      ### Example vs template
      
      The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: https://github.com/flutter/flutter/issues/131209.
      
      ### Tests
      
      This PR adds new tests to cover the various use cases.
      
      * dev/devicelab/bin/tasks/native_assets_ios.dart
        * Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode.
      * dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
        * Runs an example app with native assets, doing hot reload and hot restart.
      * packages/flutter_tools/test/integration.shard/native_assets_test.dart
        * Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester.
      * packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart
        * Unit tests the new Target in the backend.
      * packages/flutter_tools/test/general.shard/ios/native_assets_test.dart
      * packages/flutter_tools/test/general.shard/macos/native_assets_test.dart
        * Unit tests the native assets being packaged on a iOS/MacOS build.
      
      It also extends various existing tests:
      
      * dev/devicelab/bin/tasks/module_test_ios.dart
         * Exercises the add2app scenario.
      * packages/flutter_tools/test/general.shard/features_test.dart
         * Unit test the new feature flag.
      aa36db1d
  7. 10 Aug, 2023 1 commit
  8. 24 Jul, 2023 1 commit
  9. 14 Jul, 2023 1 commit
  10. 27 Jun, 2023 1 commit
    • Ben Konyi's avatar
      Reland "Fix issue where DevTools would not be immediately available when using... · 5ea2be69
      Ben Konyi authored
      Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (#129368)
      
      **Original Description:**
      
      > Service extensions are unable to handle requests when the isolate they
      were registered on is paused. The DevTools launcher logic was waiting
      for some service extension invocations to complete before advertising
      the already active DevTools instance, but when --start-paused was
      provided these requests would never complete, preventing users from
      using DevTools to resume the paused isolate.
      > 
      > Fixes https://github.com/flutter/flutter/issues/126691
      
      **Additional changes in this PR:**
      
      The failures listed in https://github.com/flutter/flutter/pull/128117
      appear to be related to a shutdown race. It's possible for the test to
      complete while the tool is in the process of starting and advertising
      DevTools, so we need to perform a check of `_shutdown` in
      `FlutterResidentDevtoolsHandler` before advertising DevTools.
      
      Before the original fix, this check was being performed immediately
      after invoking the service extensions, which creates an asynchronous gap
      in execution. With #126698, the callsite of the service extensions was
      moved and the `_shutdown` check wasn't, allowing for the tool to attempt
      to advertise DevTools after the DevTools server had been cleaned up.
      
      ---------
      Co-authored-by: 's avatarZachary Anderson <zanderso@users.noreply.github.com>
      5ea2be69
  11. 20 Jun, 2023 1 commit
    • Lau Ching Jun's avatar
      Use the new `getIsolatePauseEvent` method from VM service to check for pause event. (#128834) · 32917500
      Lau Ching Jun authored
      The `getIsolate` method returns the full list of libraries which can be huge for large apps. Using the more speficic API to only fetch what we need improves hot reload performance.
      
      *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
      
      *List which issues are fixed by this PR. You must list at least one issue.*
      
      *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
      32917500
  12. 16 Jun, 2023 1 commit
  13. 07 Jun, 2023 1 commit
    • Alexander Aprelev's avatar
      Roll engine, patch expression evaluation (#128255) · 09c07067
      Alexander Aprelev authored
      Roll to engine to 4f4486b00be28183b482bbb74bbed25f4db153fe  pick up dart to 3.1.0-169.0.dev.
      Changes since last roll
      ```
      4f4486b00b Roll dart to 3.1.0-169.0.dev (#42602)
      ```
      
      Manual roll since rolling to dart 3.1.0-169.0.dev requires patching to expression evaluation in flutter tools
      09c07067
  14. 02 Jun, 2023 1 commit
    • Zachary Anderson's avatar
      Revert "Fix issue where DevTools would not be immediately available when using... · fdb71de7
      Zachary Anderson authored
      Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (#128117)
      
      Reverts flutter/flutter#126698
      
      There are a bunch of tool crashes on CI that start with this commit. I'm
      not sure this PR is the cause because there is no backtrace from the
      tool on the crashes. The only error message is `Oops; flutter has exited
      unexpectedly: "Null check operator used on a null value`.
      fdb71de7
  15. 01 Jun, 2023 1 commit
  16. 11 May, 2023 1 commit
  17. 22 Mar, 2023 2 commits
  18. 21 Mar, 2023 1 commit
  19. 20 Mar, 2023 1 commit
  20. 17 Mar, 2023 2 commits
  21. 15 Feb, 2023 1 commit
  22. 09 Feb, 2023 1 commit
  23. 06 Feb, 2023 1 commit
  24. 01 Feb, 2023 1 commit
  25. 30 Jan, 2023 1 commit
  26. 27 Jan, 2023 1 commit
  27. 25 Jan, 2023 1 commit
  28. 23 Jan, 2023 1 commit
  29. 10 Jan, 2023 1 commit
  30. 16 Nov, 2022 1 commit
  31. 07 Sep, 2022 1 commit
  32. 24 Aug, 2022 1 commit
  33. 08 Aug, 2022 1 commit
  34. 05 Aug, 2022 1 commit
  35. 29 Jul, 2022 1 commit
  36. 27 Jul, 2022 1 commit
  37. 20 Jul, 2022 1 commit
  38. 18 Jul, 2022 1 commit