Commits · 9cdde86fb3b938ab7e9e02337d0c02b16651777e · abdullh.alsoleman / Front-End

28 Jul, 2023 17 commits

Roll Flutter Engine from 73615d66b2fe to 182e1189873b (2 revisions) (#131492) · 9cdde86f

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/73615d66b2fe...182e1189873b

2023-07-28 dnfield@google.com [Impeller] Avoid culling when the current matrix has perspective. (flutter/engine#44089)
2023-07-28 jacksongardner@google.com Roll Chrome to 115 (flutter/engine#44076)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9cdde86f

Add `CheckedPopupMenuItem‎.labelTextStyle` and update default text style for Material 3 (#131060) · 038ec62b

Taha Tesser authored Jul 28, 2023

fixes [Update `CheckedPopupMenuItemâ` for Material 3](https://github.com/flutter/flutter/issues/128576)

### Description

- This adds the missing ``CheckedPopupMenuItemâ.labelTextStyle` parameter
- Fixes default text style for `CheckedPopupMenuItemâ`. 
It used `ListTile`'s  `bodyLarge` instead of `LabelLarge` similar to `PopupMenuItem`.

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        textTheme: const TextTheme(
          labelLarge: TextStyle(
            fontWeight: FontWeight.bold,
            fontStyle: FontStyle.italic,
            letterSpacing: 5.0,
          ),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
        actions: <Widget>[
          PopupMenuButton<String>(
            icon: const Icon(Icons.more_vert),
            itemBuilder: (BuildContext context) => <PopupMenuEntry<String>>[
              const CheckedPopupMenuItem<String>(
                // labelTextStyle: MaterialStateProperty.resolveWith(
                //     (Set<MaterialState> states) {
                //   if (states.contains(MaterialState.selected)) {
                //     return const TextStyle(
                //       color: Colors.red,
                //       fontStyle: FontStyle.italic,
                //       fontWeight: FontWeight.bold,
                //     );
                //   }

                //   return const TextStyle(
                //     color: Colors.amber,
                //     fontStyle: FontStyle.italic,
                //     fontWeight: FontWeight.bold,
                //   );
                // }),
                child: Text('Mild'),
              ),
              const CheckedPopupMenuItem<String>(
                checked: true,
                // labelTextStyle: MaterialStateProperty.resolveWith(
                //     (Set<MaterialState> states) {
                //   if (states.contains(MaterialState.selected)) {
                //     return const TextStyle(
                //       color: Colors.red,
                //       fontStyle: FontStyle.italic,
                //       fontWeight: FontWeight.bold,
                //     );
                //   }

                //   return const TextStyle(
                //     color: Colors.amber,
                //     fontStyle: FontStyle.italic,
                //     fontWeight: FontWeight.bold,
                //   );
                // }),
                child: Text('Spicy'),
              ),
              const PopupMenuDivider(),
              const PopupMenuItem<String>(
                value: 'Close',
                child: Text('Close'),
              ),
            ],
          )
        ],
      ),
    );
  }
}

``` 
	
</details>

### Customized `textTheme.labelLarge` text theme.
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/2672438d-b2da-479b-a5d3-d239ef646365" /> | <img src="https://github.com/flutter/flutter/assets/48603081/b9f83719-dede-4c2f-8247-18f74e63eb29"  /> |

### New `CheckedPopupMenuItemâ.labelTextStyle` parameter with material states support
<img src="https://github.com/flutter/flutter/assets/48603081/ef0a88aa-9811-42b1-a3aa-53b90c8d43fb" height="450" />

038ec62b

Remove obsolete `complex_layout_ios__compile.dart` test (#131487) · 79033ed8
Chris Yang authored Jul 28, 2023
```
The test is obsolete.
```
79033ed8

Roll Flutter Engine from e97014c71014 to 73615d66b2fe (3 revisions) (#131485) · d822f662

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/e97014c71014...73615d66b2fe

2023-07-28 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b85515a995b to e9bdbe308478 (1 revision) (flutter/engine#44104)
2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from f538575451a8 to c98a755dff8e (1 revision) (flutter/engine#44103)
2023-07-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from e_QdQPRjE5lCfa2Hy... to vTivaP4a62tRMYue1... (flutter/engine#44102)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from e_QdQPRjE5lC to vTivaP4a62tR

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d822f662

Shared state to support multi screen inspection (#129452) · f0163c0c

Daniel Chevalier authored Jul 28, 2023

![](https://media.giphy.com/media/KY2dtJNlGPH08w41FN/giphy.gif)

Fixes https://github.com/flutter/devtools/issues/5931

With Multi View applications on the way, we need to be able to manage
the state of multiple Inspector widgets in a consistent way.

Previously each Widget inspector would manage the state of it's own
inspection. This made for a confusing and inconsistent experience when
clicking on the widget inspector of different views.

This PR changes the state management to the WidgetInspectorService
static instance so that all widget inspectors can share that state.

# Demo


https://github.com/flutter/flutter/assets/1386322/70fd18dc-5827-4dcd-8cb7-ef20e6221291

f0163c0c

Roll Packages from f4ae9336ebb7 to 10aab445d985 (4 revisions) (#131483) · 6b6f5f06

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/packages/compare/f4ae9336ebb7...10aab445d985

2023-07-28 tarrinneal@gmail.com remove unneeded imports (flutter/packages#4579)
2023-07-27 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for image capture, image analysis, and preview (flutter/packages#4523)
2023-07-27 50643541+Mairramer@users.noreply.github.com [camera_android] Provides a default exposure point if null. (flutter/packages#3851)
2023-07-27 engine-flutter-autoroll@skia.org Roll Flutter from 61fd11db to dd9764ec (5 revisions) (flutter/packages#4577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b6f5f06

Move ios_app_with_extensions_test to host only (#131441) · 3c8c3004

Chris Yang authored Jul 28, 2023

`ios_app_with_extensions_test` only builds the artifact, it does not need a device to run.
This PR adds the copies of these tests to run hostonly. When the new tests pass in post submit, we should remove the old ones.

3c8c3004

Update `Card.color` documentation for Material 3 (#131468) · 058f1660

Taha Tesser authored Jul 28, 2023

fixes [Card color parameter not respected while using Material 3](https://github.com/flutter/flutter/issues/122177)

058f1660

Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (#131430) · e81907e0
Jackson Gardner authored Jul 28, 2023
```
Recent changes to binaryen cause us to need to update to Chrome 115 for our wasm benchmarks.
```
e81907e0

Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor`... · 7d89617a

Taha Tesser authored Jul 28, 2023

Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (#131253)

fixes [`TimePicker` color and visual issues](https://github.com/flutter/flutter/issues/127035)

## Description

- fixes default text style for `TimePicker`s  `hourMinuteTextStyle` and added a todo for https://github.com/flutter/flutter/issues/131247
- fixes correct default color not being accessed for  `dayPeriodTextColor`
-  Updates tests

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            showTimePicker(
              context: context,
              orientation: Orientation.portrait,
              initialEntryMode: TimePickerEntryMode.input,
              initialTime: TimeOfDay.now(),
              builder: (BuildContext context, Widget? child) {
                return MediaQuery(
                  data: MediaQuery.of(context)
                      .copyWith(alwaysUse24HourFormat: true),
                  child: child!,
                );
              },
            );
          },
          child: const Text('Open Time Picker'),
        ),
      ),
    );
  }
}

``` 
	
</details>

### Before

![ezgif com-video-to-gif](https://github.com/flutter/flutter/assets/48603081/b791501f-aed3-44f3-8f75-70a1e28038c6)

### After

![ezgif com-video-to-gif (1)](https://github.com/flutter/flutter/assets/48603081/1bb32064-a9b1-416d-8290-7d22b0d4fdb9)

7d89617a

Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (#131477) · e4ce8e05

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/cfa5427dc452...e97014c71014

2023-07-28 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wgkZmRBHTT7DehhUL... to OMmwdXn8XxipooPBo... (flutter/engine#44101)
2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from 8739fd6d422c to f538575451a8 (1 revision) (flutter/engine#44100)
2023-07-28 skia-flutter-autoroll@skia.org Roll ANGLE from 613eefa3a70f to 99f1178a9e81 (1 revision) (flutter/engine#44098)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wgkZmRBHTT7D to OMmwdXn8Xxip

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e4ce8e05

Roll Flutter Engine from dc8618da9eb0 to cfa5427dc452 (3 revisions) (#131464) · 0ff68b8c

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/dc8618da9eb0...cfa5427dc452

2023-07-28 skia-flutter-autoroll@skia.org Roll Dart SDK from aab0233f76b7 to 1b85515a995b (1 revision) (flutter/engine#44096)
2023-07-28 matanlurey@users.noreply.github.com [Impeller] Set 'enable_vulkan_validation_layers' if --unopt and Vulkan is enabled. (flutter/engine#44055)
2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from f2362d22abcf to 8739fd6d422c (1 revision) (flutter/engine#44095)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0ff68b8c

Roll Flutter Engine from b0d97ba45f46 to dc8618da9eb0 (3 revisions) (#131460) · 61752e09

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/b0d97ba45f46...dc8618da9eb0

2023-07-28 skia-flutter-autoroll@skia.org Roll Skia from 5403af73dfef to f2362d22abcf (1 revision) (flutter/engine#44094)
2023-07-28 skia-flutter-autoroll@skia.org Roll ANGLE from 179924cbfaf3 to 613eefa3a70f (1 revision) (flutter/engine#44093)
2023-07-28 skia-flutter-autoroll@skia.org Roll Dart SDK from e851b8e49ade to aab0233f76b7 (2 revisions) (flutter/engine#44092)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61752e09

Updated integration_tests/platform_interaction test_step.dart (#131301) · c61f07cf

Hans Muller authored Jul 28, 2023

Force the line height of the TextStyle used in test_step.dart to be 1.0 for all Text widgets.

The test started failing after https://github.com/flutter/flutter/pull/129724 landed. Assuming that the vertical layout of the test was tight and that the change in the default font's line height is the source of the problem (see https://github.com/flutter/flutter/issues/130732#issuecomment-1639089638).

Fixes https://github.com/flutter/flutter/issues/130732

c61f07cf

Roll Flutter Engine from 0713d91c2e64 to b0d97ba45f46 (1 revision) (#131453) · 04391d85

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/0713d91c2e64...b0d97ba45f46

2023-07-28 36861262+QuncCccccc@users.noreply.github.com Add Expanded/Collapsed state for `SubmenuButton` (flutter/engine#43983)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

04391d85

Roll Flutter Engine from 01bb0a3ef922 to 0713d91c2e64 (2 revisions) (#131451) · 25401037

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/01bb0a3ef922...0713d91c2e64

2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 100d67ed0b61 to 5403af73dfef (4 revisions) (flutter/engine#44088)
2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from d3a7efb77af3 to 100d67ed0b61 (1 revision) (flutter/engine#44086)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

25401037

Roll Flutter Engine from 196474bd96b0 to 01bb0a3ef922 (3 revisions) (#131447) · 10dd50ab

engine-flutter-autoroll authored Jul 28, 2023

https://github.com/flutter/engine/compare/196474bd96b0...01bb0a3ef922

2023-07-27 skia-flutter-autoroll@skia.org Roll ANGLE from d5ddb710e5bd to 179924cbfaf3 (3 revisions) (flutter/engine#44085)
2023-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FwIA6BaHtZg2mRS-0... to wgkZmRBHTT7DehhUL... (flutter/engine#44084)
2023-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from EpwAiaHKf6M6Yejtk... to e_QdQPRjE5lCfa2Hy... (flutter/engine#44083)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from FwIA6BaHtZg2 to wgkZmRBHTT7D
fuchsia/sdk/core/mac-amd64 from EpwAiaHKf6M6 to e_QdQPRjE5lC

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

10dd50ab

27 Jul, 2023 17 commits

Roll Flutter Engine from 284771da323c to 196474bd96b0 (3 revisions) (#131443) · f8afcd5a

engine-flutter-autoroll authored Jul 27, 2023

https://github.com/flutter/engine/compare/284771da323c...196474bd96b0

2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 20108acef7d2 to d3a7efb77af3 (2 revisions) (flutter/engine#44082)
2023-07-27 rmolivares@renzo-olivares.dev [iOS] TextInputPlugin should batch TextEditingDeltas and dispatch on the next runLoop (flutter/engine#43267)
2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from b522808eb0af to 20108acef7d2 (3 revisions) (flutter/engine#44079)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f8afcd5a

[framework] clean up image provider documentation. (#131416) · 46d07401
Jonah Williams authored Jul 27, 2023
```
Fixes https://github.com/flutter/flutter/issues/130524

loadBuffer was superseded by loadImage
```
46d07401
Fix template app documentation (#131125) · 80c7dd72
David authored Jul 27, 2023
```
The PR fixes template app documentation
```
80c7dd72

Roll Flutter Engine from 9a935ecbf73a to 284771da323c (3 revisions) (#131439) · 4a86d6de

engine-flutter-autoroll authored Jul 27, 2023

https://github.com/flutter/engine/compare/9a935ecbf73a...284771da323c

2023-07-27 jonahwilliams@google.com Revert "[engine] disable picture complexity raster caching" (flutter/engine#44026)
2023-07-27 jonahwilliams@google.com [Impeller] Move glyph atlas state from context into lazy glyph atlas. (flutter/engine#43748)
2023-07-27 ian@hixie.ch Hide some log lines from release builds (flutter/engine#44073)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4a86d6de

⚡️ Add `ssh://git@github.com/flutter/flutter.git` as a standard remote (#131333) · 7d64c676
Alex Li authored Jul 27, 2023
```
Resolves #98020.
```
7d64c676

Roll Flutter Engine from f3317dbab388 to 9a935ecbf73a (1 revision) (#131437) · 252973c6

engine-flutter-autoroll authored Jul 27, 2023

https://github.com/flutter/engine/compare/f3317dbab388...9a935ecbf73a

2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 26ec2772960b to b522808eb0af (1 revision) (flutter/engine#44075)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

252973c6

🐛

Only format Dart files for `gen-l10n` (#131232) · eab2087a

Alex Li authored Jul 27, 2023

Improves #119596. The tests remain valid, so no tests were updated in the request.

This does not resolve issue #128932, it's handled by another part of the code.

eab2087a

Roll Flutter Engine from 08050cdecf94 to f3317dbab388 (1 revision) (#131432) · e099d67c

engine-flutter-autoroll authored Jul 27, 2023

https://github.com/flutter/engine/compare/08050cdecf94...f3317dbab388

2023-07-27 skia-flutter-autoroll@skia.org Roll Dart SDK from dcbaffbd09dd to e851b8e49ade (2 revisions) (flutter/engine#44072)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e099d67c

Preliminary PR for engine changes for Expanded/Collapsed Submenu button (#131359) · 16826e06
Qun Cheng authored Jul 27, 2023
```
This PR is to skip some unit tests in order to merging an [engine
change](https://github.com/flutter/engine/pull/43983).
```
16826e06

Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (#131426) · 7e7a0a81

engine-flutter-autoroll authored Jul 27, 2023

https://github.com/flutter/engine/compare/9b14c382eebf...08050cdecf94

2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 90048a938eb5 to 26ec2772960b (2 revisions) (flutter/engine#44070)
2023-07-27 skia-flutter-autoroll@skia.org Roll ANGLE from 8aa3ca9d177c to d5ddb710e5bd (1 revision) (flutter/engine#44069)
2023-07-27 30870216+gaaclarke@users.noreply.github.com [Impeller] trimmed 3 bytes off of each Glyph (flutter/engine#44054)
2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 6571d88db5b3 to 90048a938eb5 (1 revision) (flutter/engine#44066)
2023-07-27 skia-flutter-autoroll@skia.org Roll ANGLE from af5bf5b8245e to 8aa3ca9d177c (1 revision) (flutter/engine#44065)
2023-07-27 skia-flutter-autoroll@skia.org Roll Dart SDK from b6747a06be06 to dcbaffbd09dd (1 revision) (flutter/engine#44064)
2023-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from pgJmG2-qZVMzlMuq8... to EpwAiaHKf6M6Yejtk... (flutter/engine#44063)
2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 26ed0d2ab04c to 6571d88db5b3 (1 revision) (flutter/engine#44062)
2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from e85c64d63787 to 26ed0d2ab04c (3 revisions) (flutter/engine#44061)
2023-07-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from DOxjABQZ-mA_9Lllw... to FwIA6BaHtZg2mRS-0... (flutter/engine#44060)
2023-07-27 jason-simmons@users.noreply.github.com Ignore the NOTICE.fuchsia file in the new license script (flutter/engine#44021)
2023-07-27 dnfield@google.com Embed a license readme in every zip archive (flutter/engine#43974)
2023-07-27 skia-flutter-autoroll@skia.org Roll Skia from 750d7f8ed4d7 to e85c64d63787 (4 revisions) (flutter/engine#44056)
2023-07-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 8961d36eaa0c to b6747a06be06 (1 revision) (flutter/engine#44053)
2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from 451b3c31a1fa to af5bf5b8245e (1 revision) (flutter/engine#44050)
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from fdf224be4f98 to 750d7f8ed4d7 (3 revisions) (flutter/engine#44049)
2023-07-26 skia-flutter-autoroll@skia.org Roll Dart SDK from b5710782b91c to 8961d36eaa0c (1 revision) (flutter/engine#44048)
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from 990aa6016ff6 to fdf224be4f98 (3 revisions) (flutter/engine#44046)
2023-07-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from d6O9t74z-k2svOmvz... to pgJmG2-qZVMzlMuq8... (flutter/engine#44045)
2023-07-26 skia-flutter-autoroll@skia.org Roll ANGLE from 58cb5c8396a3 to 451b3c31a1fa (1 revision) (flutter/engine#44044)
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from d76a9c3bb3fd to 990aa6016ff6 (4 revisions) (flutter/engine#44043)
2023-07-26 skia-flutter-autoroll@skia.org Roll Skia from ca48e45a0262 to d76a9c3bb3fd (1 revision) (flutter/engine#44042)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from DOxjABQZ-mA_ to FwIA6BaHtZg2
fuchsia/sdk/core/mac-amd64 from d6O9t74z-k2s to EpwAiaHKf6M6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7e7a0a81

Roll Packages from a99fc8765de9 to f4ae9336ebb7 (3 revisions) (#131422) · e7cc21a4

engine-flutter-autoroll authored Jul 27, 2023

https://github.com/flutter/packages/compare/a99fc8765de9...f4ae9336ebb7

2023-07-27 engine-flutter-autoroll@skia.org Manual roll Flutter from bae1ac2f to 61fd11db (7 revisions) (flutter/packages#4572)
2023-07-26 engine-flutter-autoroll@skia.org Roll Flutter from 9def8f6b to bae1ac2f (27 revisions) (flutter/packages#4570)
2023-07-26 60025677+sdoshi983@users.noreply.github.com [go_router] fix(docs): improve docs and fix typo (flutter/packages#4414)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e7cc21a4

Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (#131371) · 8a844379
Jason Simmons authored Jul 27, 2023
```
Dart SDK 3.2.x requires a new version of the dart_internal package.
```
8a844379
Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (#131306) · dd9764ec
Seiya Kokushi authored Jul 27, 2023
```
Can configure modal barriers in Flutter's built-in dialogs.
```
dd9764ec
Fix ios_add2app Podfile (#131263) · 4e609f1a
Daco Harkes authored Jul 27, 2023
```
Fixes:

* https://github.com/flutter/flutter/issues/131261
```
4e609f1a
Add DeviceLab build+test separation doc (#131365) · cfafb910
keyonghan authored Jul 27, 2023
```
This PR add instructions to separate DeviceLab tasks to build and test model.
```
cfafb910
IgnoreBaseline widget (#131220) · 48f08e3d
Ian Hickson authored Jul 27, 2023
```
Fixes https://github.com/flutter/flutter/issues/7037
```
48f08e3d

Add 'vm:keep-name' pragmas to platform channel classes (#131271) · 22406493

Chris Evans authored Jul 27, 2023

Pragma will allow future proofing Dart snapshot utilities to work by preserving the names of important classes used in platform channel communication

@Hixie

22406493

26 Jul, 2023 6 commits

Add the 'a: desktop' label to labeler.yml (#130933) · 61fd11db

Loïc Sharma authored Jul 26, 2023

The desktop team uses the [`a: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop) pull requests.

61fd11db

ImageDecoration.lerp (#130533) (#131349) · 33e9fd89

Ian Hickson authored Jul 26, 2023

This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes https://github.com/flutter/flutter/issues/12452

This was first landed in https://github.com/flutter/flutter/pull/130533 and reverted in https://github.com/flutter/flutter/pull/131347.

33e9fd89

Minor adjustments on 2D APIs (#131358) · bb0c3172

Kate Lovett authored Jul 26, 2023

These tweaks came from https://github.com/flutter/packages/pull/4536

- The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0
- The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate

I'd like to cherry pick this so https://github.com/flutter/packages/pull/4536 will not have to wait for it to reach stable.

bb0c3172

Revert "Update Unit Tests for M2/M3" (#131368) · f359d9e2

Loïc Sharma authored Jul 26, 2023

Reverts flutter/flutter#131292

This PR is affected by https://g-issues.skia.org/issues/40045533.

See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076):

> The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.

f359d9e2

Update Unit Tests for M2/M3 (#131292) · 5d76d1a5

Qun Cheng authored Jul 26, 2023

Updated golden tests in 

* ink_sparkle_test.dart
* material_test.dart
* page_test.dart
* progress_indicator_test.dart

to have M2 and M3 versions.

More info in #127064

5d76d1a5

Revert "Run benchmarks with `--omit-type-checks`" (#131353) · 81b0e9f1

Loïc Sharma authored Jul 26, 2023

Reverts flutter/flutter#131102 as it closed the tree due to `Linux web_benchmarks_skwasm` failures. The test seems to be timing out without completing.

Example failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_benchmarks_skwasm/1/overview

81b0e9f1