Skip to content

F
Front-End
Switch branch/tag
  1. 10 Sep, 2023 1 commit
    • Daco Harkes's avatar
      Native assets support for MacOS and iOS (#130494) · aa36db1d
      Daco Harkes authored 
      Support for FFI calls with `@Native external` functions through Native assets on MacOS and iOS. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for MacOS and iOS.

Dylibs are bundled by (1) making them fat binaries if multiple architectures are targeted, (2) code signing these, and (3) copying them to the frameworks folder. These steps are done manual rather than via CocoaPods. CocoaPods would have done the same steps, but (a) needs the dylibs to be there before the `xcodebuild` invocation (we could trick it, by having a minimal dylib in the place and replace it during the build process, that works), and (b) can't deal with having no dylibs to be bundled (we'd have to bundle a dummy dylib or include some dummy C code in the build file).

The dylibs are build as a new target inside flutter assemble, as that is the moment we know what build-mode and architecture to target.

The mapping from asset id to dylib-path is passed in to every kernel compilation path. The interesting case is hot-restart where the initial kernel file is compiled by the "inner" flutter assemble, while after hot restart the "outer" flutter run compiled kernel file is pushed to the device. Both kernel files need to contain the mapping. The "inner" flutter assemble gets its mapping from the NativeAssets target which builds the native assets. The "outer" flutter run get its mapping from a dry-run invocation. Since this hot restart can be used for multiple target devices (`flutter run -d all`) it contains the mapping for all known targets.

### Example vs template

The PR includes a new template that uses the new native assets in a package and has an app importing that. Separate discussion in: https://github.com/flutter/flutter/issues/131209.

### Tests

This PR adds new tests to cover the various use cases.

* dev/devicelab/bin/tasks/native_assets_ios.dart
  * Runs an example app with native assets in all build modes, doing hot reload and hot restart in debug mode.
* dev/devicelab/bin/tasks/native_assets_ios_simulator.dart
  * Runs an example app with native assets, doing hot reload and hot restart.
* packages/flutter_tools/test/integration.shard/native_assets_test.dart
  * Runs (incl hot reload/hot restart), builds, builds frameworks for iOS, MacOS and flutter-tester.
* packages/flutter_tools/test/general.shard/build_system/targets/native_assets_test.dart
  * Unit tests the new Target in the backend.
* packages/flutter_tools/test/general.shard/ios/native_assets_test.dart
* packages/flutter_tools/test/general.shard/macos/native_assets_test.dart
  * Unit tests the native assets being packaged on a iOS/MacOS build.

It also extends various existing tests:

* dev/devicelab/bin/tasks/module_test_ios.dart
   * Exercises the add2app scenario.
* packages/flutter_tools/test/general.shard/features_test.dart
   * Unit test the new feature flag.
      aa36db1d
  3. 07 Sep, 2023 2 commits
  5. 31 Aug, 2023 4 commits
  7. 23 Aug, 2023 1 commit
    • Jackson Gardner's avatar
      Add `--experimental-wasm-type-reflection` and support newer emscripten builds. (#133084) · d8b1e81c
      Jackson Gardner authored 
      This makes two changes to prepare for incoming changes to skwasm in the web engine:
* We will (at least for now) be depending on the `WebAssembly.Function` constructor in `skwasm`, which is hidden behind the `--experimental-wasm-type-reflection` flag. We need to pass that when running skwasm benchmarks.
* We are going to be upgrading the skwasm build to a newer version of emscripten, which exposes the wasm exports via the `wasmExports` property instead of the `asm` property. Make sure to support either, if passed.
      d8b1e81c
  9. 22 Aug, 2023 2 commits
  11. 15 Aug, 2023 1 commit
  13. 14 Aug, 2023 1 commit
    • Jonah Williams's avatar
      [devicelab] boot up benchmarks. (#132148) · f7bd0320
      Jonah Williams authored 
      Enable Impeller benchmarks for drawAtlas/drawVertices on iOS/Metal, Android/GLES, and Android/Vulkan.

Enable impeller tessellation benchmarks on iOS/Metal and Android/Vulkan - not GLES as this is measuring backend agnostic performance.
      f7bd0320
  15. 11 Aug, 2023 1 commit
  17. 09 Aug, 2023 2 commits
  19. 03 Aug, 2023 2 commits
  21. 02 Aug, 2023 1 commit
  23. 31 Jul, 2023 1 commit
    • Jackson Gardner's avatar
      Reland --omit-type-checks for benchmarks. (#131493) · b928b3c1
      Jackson Gardner authored 
      Because the cost of type checks dominate our dart2wasm benchmarks, we've
decided to pass `--omit-type-checks` for now.

This was previously reverted because the skwasm benchmarks were broken
in general for a separate reason, and my getting rid of `bringup: true`
broke the tree. I ended up fixing the benchmarks and getting rid of
`bringup: true` in a separate commit, so this just adds the flag only.
      b928b3c1
  25. 26 Jul, 2023 2 commits
  27. 14 Jul, 2023 1 commit
  29. 07 Jul, 2023 1 commit
  31. 29 Jun, 2023 1 commit
    • Jackson Gardner's avatar
      Skwasm benchmarks. (#129681) · 1b887c72
      Jackson Gardner authored 
      This enables benchmarks for the Skwasm renderer, compiled with
dart2wasm.

Platform views aren't supported in Skwasm yet, so we are skipping those
benchmarks for now.
      1b887c72
  33. 24 Jun, 2023 1 commit
  35. 02 Jun, 2023 1 commit
  37. 31 May, 2023 1 commit
    • Jackson Gardner's avatar
      Improve web benchmarks measurements (#127900) · e8f4d803
      Jackson Gardner authored 
      By default, the browser fuzzes the timer APIs such that they have a granularity of approximately 100 microseconds (this is due to Spectre mitigation techniques). However, many of the thing we are trying to measure actually have a much finer granularity than 100 microseconds. As a result, many of our benchmarks are extremely noisy and don't provide accurate data.

By serving the initial script files with the `Cross-Origin-Opener-Policy: same-origin` and `Cross-Origin-Embedder-Policy: require-corp` HTTP headers, the browser runs the benchmarks in a `crossOriginIsolated` context, which restores the fine granularity of APIs such as `performance.now()` to microsecond precision.

Also, we were considering anything an outlier that was more than one standard deviation away from the mean. In a normal distribution, that means we are only capturing 68% of the data and the rest are considered outliers. This is not ideal. Doing two standard deviations away captures 95% of the data, and the outliers are in the remaining 5%, which seems much more reasonable.
      e8f4d803
  39. 26 May, 2023 1 commit
  41. 23 May, 2023 1 commit
  43. 15 May, 2023 2 commits
  45. 10 May, 2023 1 commit
  47. 03 May, 2023 2 commits
  49. 28 Apr, 2023 1 commit
  51. 24 Apr, 2023 1 commit
  53. 07 Apr, 2023 2 commits
  55. 31 Mar, 2023 2 commits

HIAST - GitLab