1. 27 Mar, 2019 1 commit
  2. 11 Mar, 2019 1 commit
  3. 05 Feb, 2019 1 commit
  4. 19 Jan, 2019 1 commit
    • Ian Hickson's avatar
      [O] Removing all timeouts (mark II) (#26736) · 31a9626c
      Ian Hickson authored
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      31a9626c
  5. 21 Dec, 2018 2 commits
    • Ian Hickson's avatar
      Revert "[O] Remove many timeouts. (#23531)" (#25646) · 8426910a
      Ian Hickson authored
      This reverts commit 76f70810.
      8426910a
    • Ian Hickson's avatar
      [O] Remove many timeouts. (#23531) · 76f70810
      Ian Hickson authored
      * Remove many timeouts.
      
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      
      * Get the attach tests to pass.
      
      * Apply review comments from Todd
      
      * More review comment fixes
      
      * Put back the extended timeouts here now that I know why we have them...
      76f70810
  6. 19 Oct, 2018 3 commits
  7. 11 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Re-land text wrapping/color PR (#22831) · 081d2a7a
      Greg Spencer authored
      This attempts to re-land #22656.
      
      There are two changes from the original:
      
      I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.
      
      I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.
      
      As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.
      
      *     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
          This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
          Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
          Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
          Since wrapping is now turned on, also removed many redundant '\n's in the code.
      081d2a7a
  8. 06 Oct, 2018 2 commits
    • Greg Spencer's avatar
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to... · 2d81adf7
      Greg Spencer authored
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759)
      
      This reverts commit e4386321
      because it breaks 160 benchmarks, and several devicelab tests,
      due to changing the format of the output.
      2d81adf7
    • Greg Spencer's avatar
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor... · e4386321
      Greg Spencer authored
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
      This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
      Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
      Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
      Since wrapping is now turned on, also removed many redundant '\n's in the code.
      e4386321
  9. 05 Oct, 2018 1 commit
  10. 01 Oct, 2018 1 commit
  11. 12 Sep, 2018 1 commit
  12. 06 Sep, 2018 1 commit
  13. 31 Aug, 2018 1 commit
  14. 21 Aug, 2018 1 commit
  15. 20 Aug, 2018 1 commit
    • Ian Hickson's avatar
      `flutter analyze` cleanup (#20490) · ad1eaff4
      Ian Hickson authored
      * `flutter analyze` cleanup
      
      * Make `--dartdocs` work in all modes.
      * Make `analyze-sample-code.dart` more resilient.
      * Add a test for `analyze-sample-code.dart`.
      * Minor cleanup in related code and files.
      
      * Apply review comments
      
      * Fix tests
      ad1eaff4
  16. 01 Aug, 2018 1 commit
  17. 20 Jul, 2018 1 commit
  18. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  19. 08 Jun, 2018 3 commits
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05
    • Chris Bracken's avatar
      Revert "It's time to #deleteDart1 (#18293)" (#18313) · 9495df4b
      Chris Bracken authored
      Several benchmarks started failing during kernel compile:
      1. Timeouts:
         * commands_test
         * hot_mode_dev_cycle__benchmark
         * run_machine_concurrent_hot_reload
         * service_extensions_test
      
      2. Kernel compiler crash:
         * hot_mode_dev_cycle_linux__benchmark
         * routing_test
      
      3. Unexpected termination:
         * hot_mode_dev_cycle_win__benchmark
      
      This reverts commit ed63e708.
      9495df4b
    • Chris Bracken's avatar
      It's time to #deleteDart1 (#18293) · ed63e708
      Chris Bracken authored
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      ed63e708
  20. 05 Jun, 2018 1 commit
  21. 10 May, 2018 2 commits
  22. 20 Apr, 2018 1 commit
  23. 11 Apr, 2018 2 commits
  24. 20 Mar, 2018 1 commit
  25. 15 Feb, 2018 1 commit
  26. 15 Aug, 2017 1 commit
  27. 20 Jul, 2017 1 commit
  28. 19 Jul, 2017 1 commit
    • Dan Rubel's avatar
      Flutter analyze watch improvements (#11143) · e13e7806
      Dan Rubel authored
      * flutter analyze --watch auto detect if in flutter repo
      * move isFlutterLibrary from AnalyzeOnce into AnalyzeBase for use by AnalyzeContinuously
      * pass --flutter-repo to analysis server when analyzing the flutter repository
      * enhance flutter analyze --watch to summarize public members lacking documentation
      e13e7806
  29. 14 Jun, 2017 1 commit
  30. 08 Jun, 2017 1 commit
  31. 19 May, 2017 1 commit
  32. 18 Apr, 2017 1 commit