Commits · 944d6c8fef76b2db7a2c33eeb1653de2b8571fd8 · abdullh.alsoleman / Front-End

14 Jun, 2023 7 commits

Unpin flutter_plugin_android_lifecycle (#128898) · 944d6c8f

gmackall authored Jun 14, 2023

Unpins flutter_plugin_android_lifecycle where it is pinned. I then
1. ran `flutter update-packages --force-upgrade` (but only committed the changes within `dev/integration_tests/gradle_deprecated_settings/`, which is where it had been pinned)
2. followed by `./gradlew :generateLockfiles` from `dev/integration_tests/gradle_deprecated_settings/android/` (the lockfile was what was causing the CI dependency resolution failure, so this second step is the fix for that).

See the reason it was pinned: https://github.com/flutter/flutter/pull/121847#discussion_r1124797112 followed by the PR that pinned it: https://github.com/flutter/flutter/pull/122043

Fixes https://github.com/flutter/flutter/issues/122039

944d6c8f

[web] Migrate framework away from dart:html and package:js (#128580) · 95be76ab
Mouad Debbar authored Jun 14, 2023
```
Use `package:web` and `dart:js_interop` instead.

Part of https://github.com/flutter/flutter/issues/127030
```
95be76ab

Fixed slider value indicator not disappearing after a bit on desktop platform... · 52c4db8d

cruiser-baxter authored Jun 14, 2023

Fixed slider value indicator not disappearing after a bit on desktop platform when slider is clicked not dragged (#128137)

In slider.dart within the _startInteraction method and within the below conditional.

"if (!_active && !hasFocus &&
_state.valueIndicatorController.status == AnimationStatus.completed)"

**Changed to:**

"f (!_active &&
_state.valueIndicatorController.status == AnimationStatus.completed)"
This allows the value indicator to disappear after a bit when clicked instead of dragged on Desktop platform. 

I also added a test in slider_test.dart to detect the bug if it ever returns.

Fixes https://github.com/flutter/flutter/issues/123313

52c4db8d

Inline AbstractNode into SemanticsNode and Layer (#128467) · 16e6be8b
Michael Goderbauer authored Jun 14, 2023

16e6be8b

Roll Flutter Engine from 727b4413fe6f to 2d8d5ecfe4a8 (5 revisions) (#128842) · 40bb615b

engine-flutter-autoroll authored Jun 14, 2023

https://github.com/flutter/engine/compare/727b4413fe6f...2d8d5ecfe4a8

2023-06-13 skia-flutter-autoroll@skia.org Roll Skia from 6bdb0ef30cb6 to 6d5dc31d88e2 (7 revisions) (flutter/engine#42790)
2023-06-13 dnfield@google.com Make validation logs ERROR level (flutter/engine#42825)
2023-06-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from J-zU9HGYXYU5UWJO9... to Cld7-rm6ZmCOO8j-K... (flutter/engine#42824)
2023-06-13 skia-flutter-autoroll@skia.org Manual roll ICU from 1eea59cabae0 to a2961dc659b4 (0 revision) (flutter/engine#42817)
2023-06-13 ychris@google.com Remove some trivial deprecated symbol usages in iOS Embedder (flutter/engine#42711)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from J-zU9HGYXYU5 to Cld7-rm6ZmCO

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

40bb615b

Roll Flutter Engine from 66a5761412f9 to 727b4413fe6f (10 revisions) (#128841) · 4fe84d7a

engine-flutter-autoroll authored Jun 14, 2023

https://github.com/flutter/engine/compare/66a5761412f9...727b4413fe6f

2023-06-13 ychris@google.com Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #42115" (flutter/engine#42823)
2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 41234fa4b22d to 2465228c0c21 (1 revision) (flutter/engine#42822)
2023-06-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Added cache for command buffers in vulkan (flutter/engine#42793)
2023-06-13 47866232+chunhtai@users.noreply.github.com setupDefultFontManager correctly clear out cache (flutter/engine#42178)
2023-06-13 jonahwilliams@google.com [Impeller] Reland attempt Vulkan setup and fallback to GLES. (flutter/engine#42820)
2023-06-13 30870216+gaaclarke@users.noreply.github.com Added CI step for building with validation layers (flutter/engine#42724)
2023-06-13 jason-simmons@users.noreply.github.com [Impeller] Null check for the device holder in the Vulkan context destructor (flutter/engine#42821)
2023-06-13 tamird@google.com Add missing includes (flutter/engine#42812)
2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 4dce1093ad94 to 41234fa4b22d (1 revision) (flutter/engine#42810)
2023-06-13 2539699336@qq.com [iOS][Keyboard] Wait vsync on UI thread and update viewport inset to avoid jitter. (flutter/engine#42312)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4fe84d7a

Roll Flutter Engine from b6bf3a6f1ccd to 66a5761412f9 (1 revision) (#128813) · 7c9193ce

engine-flutter-autoroll authored Jun 14, 2023

https://github.com/flutter/engine/compare/b6bf3a6f1ccd...66a5761412f9

2023-06-13 34871572+gmackall@users.noreply.github.com Capture additional final inset states in ImeSyncDeferringInsetsCallback (flutter/engine#42700)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c9193ce

13 Jun, 2023 18 commits

Fix syntax error in docstring (#128692) · a9f17c87
William Oprandi authored Jun 13, 2023

a9f17c87

Update unit tests in material library for Material 3 (#128725) · a5f8b64e

Qun Cheng authored Jun 13, 2023

Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true.

All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version.

related to #127064

a5f8b64e

[flutter_tools] Suppress git output in flutter channel (#128475) · d4995336
Christopher Fujino authored Jun 13, 2023
```
Fixes https://github.com/flutter/flutter/issues/128025
```
d4995336

Fix ensureVisible and default focus traversal for reversed scrollables (#128756) · a0bfde9b

Kate Lovett authored Jun 13, 2023

Fixes https://github.com/flutter/flutter/issues/128749

The ScrollPositionAlignmentPolicy does not account for AxisDirection, which meant default focus traversal of reversed scrollables did not work. The policy doesn't know about the axis direction, so this is corrected in the ScrollPosition where all the information is available before calling on the viewport for the new target scroll offset.

This fixes that by flipping the policy (unless explicit) so that focus traversal works.

a0bfde9b

Roll Flutter Engine from f9a0a0dafeea to b6bf3a6f1ccd (2 revisions) (#128797) · 79bdc6dd

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/f9a0a0dafeea...b6bf3a6f1ccd

2023-06-13 skia-flutter-autoroll@skia.org Roll ANGLE from 057b8b61b2f2 to 7e075469ff02 (1 revision) (flutter/engine#42809)
2023-06-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from r0hMbc7UJwTJkxjbt... to kQbij6Tvqe7F9-PhR... (flutter/engine#42807)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from r0hMbc7UJwTJ to kQbij6Tvqe7F

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

79bdc6dd

Update rest of the unit tests in material library for Material 3 (#128747) · 130749e4
Qun Cheng authored Jun 13, 2023

130749e4
Update tests in material library for Material 3 by default (#128300) · cea728af
Qun Cheng authored Jun 13, 2023

cea728af
Update misc tests for Material3 (#128712) · ce248e87
Hans Muller authored Jun 13, 2023

ce248e87

Roll Packages from c9865e8c63dc to 050729760b25 (6 revisions) (#128796) · 09b7e561

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/packages/compare/c9865e8c63dc...050729760b25

2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/camera/camera_android_camerax/android (flutter/packages#4195)
2023-06-12 stuartmorgan@google.com [ci] Finish migrating Pigeon tests to LUCI (flutter/packages#3192)
2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.5.7 to 1.6.0 in /packages/local_auth/local_auth_android/android (flutter/packages#4186)
2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4184)
2023-06-12 hashirshoaeb@gmail.com [go_router] Fixes a bug in `debugLogDiagnostics` to support StatefulShellRoute (flutter/packages#4177)
2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter from 3df163ff to 353b8bc8 (10 revisions) (flutter/packages#4198)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

09b7e561

Roll Flutter Engine from 346f051ac062 to f9a0a0dafeea (1 revision) (#128786) · 4e706975

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/346f051ac062...f9a0a0dafeea

2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 7bbe02a4ecc6 to 4dce1093ad94 (1 revision) (flutter/engine#42805)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4e706975

Roll Flutter Engine from 5951f90cbac3 to 346f051ac062 (1 revision) (#128783) · 6d24b193

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/5951f90cbac3...346f051ac062

2023-06-13 skia-flutter-autoroll@skia.org Roll ANGLE from 1e06b31e3863 to 057b8b61b2f2 (1 revision) (flutter/engine#42806)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d24b193

Roll Flutter Engine from 3b70103f53bc to 5951f90cbac3 (1 revision) (#128781) · 9e5e1a8f

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/3b70103f53bc...5951f90cbac3

2023-06-13 skia-flutter-autoroll@skia.org Roll ANGLE from 1572f609c18e to 1e06b31e3863 (1 revision) (flutter/engine#42804)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9e5e1a8f

Roll Flutter Engine from 04ffeb4ab103 to 3b70103f53bc (1 revision) (#128778) · d819fdfa

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/04ffeb4ab103...3b70103f53bc

2023-06-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.6 to 2.13.4 (flutter/engine#42802)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d819fdfa

Roll Flutter Engine from 42ccd12a14c2 to 04ffeb4ab103 (4 revisions) (#128772) · 02fe2188

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/42ccd12a14c2...04ffeb4ab103

2023-06-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.2 to 3.5.3 (flutter/engine#42801)
2023-06-13 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.0.4 to 4.1.0 (flutter/engine#42803)
2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 7bacb78a0db8 to 7bbe02a4ecc6 (1 revision) (flutter/engine#42800)
2023-06-13 godofredoc@google.com Create v2 configuration for emulator tests. (flutter/engine#42652)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

02fe2188

Roll Flutter Engine from aa1693f6aaeb to 42ccd12a14c2 (1 revision) (#128761) · 9287e81d

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/aa1693f6aaeb...42ccd12a14c2

2023-06-13 skia-flutter-autoroll@skia.org Roll ANGLE from 21f16cb16333 to 1572f609c18e (6 revisions) (flutter/engine#42796)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9287e81d

Roll Flutter Engine from d02b15ef34ef to aa1693f6aaeb (3 revisions) (#128759) · ea455905

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/d02b15ef34ef...aa1693f6aaeb

2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 605fd026151b to 7bacb78a0db8 (1 revision) (flutter/engine#42795)
2023-06-13 jonahwilliams@google.com [Impeller] Ensure vulkan offscreen pixelformat is the same as the onscreen format (flutter/engine#42788)
2023-06-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pd1VfyK_WEW6tu8WI... to r0hMbc7UJwTJkxjbt... (flutter/engine#42786)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from pd1VfyK_WEW6 to r0hMbc7UJwTJ

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea455905

Roll Flutter Engine from f67ed35b142e to d02b15ef34ef (2 revisions) (#128754) · 5f8000aa

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/f67ed35b142e...d02b15ef34ef

2023-06-12 jonahwilliams@google.com [Impeller] Fix text jitter on Vulkan. (flutter/engine#42792)
2023-06-12 jmccandless@google.com Predictive back breakage fix (flutter/engine#42789)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f8000aa

Roll Flutter Engine from 1714d73e681b to f67ed35b142e (3 revisions) (#128751) · 8c7c3d3b

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/1714d73e681b...f67ed35b142e

2023-06-12 godofredoc@google.com Reland "Move linux clang tidy to engine_v2."" (flutter/engine#42713)
2023-06-12 godofredoc@google.com Relands "Move clang tidy v2 build to prod."" (flutter/engine#42714)
2023-06-12 skia-flutter-autoroll@skia.org Roll Dart SDK from dbee3c493f5a to 605fd026151b (2 revisions) (flutter/engine#42785)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8c7c3d3b

12 Jun, 2023 13 commits

Roll Flutter Engine from 12def739b1f6 to 1714d73e681b (2 revisions) (#128738) · fc335ea5

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/12def739b1f6...1714d73e681b

2023-06-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
FreETK3TrhkNzCCL-... to J-zU9HGYXYU5UWJO9... (flutter/engine#42784)
2023-06-12 jonahwilliams@google.com [Impeller] allowing enabling
Impeller on macOS. (flutter/engine#42639)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from FreETK3TrhkN to J-zU9HGYXYU5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fc335ea5

Fix paint offset in reverse for 2D (#128724) · 9e0ad4c6

Kate Lovett authored Jun 12, 2023

Fixes https://github.com/flutter/flutter/issues/128723

The paint offset was incorrectly being computed when one or both axis was in the reverse direction. Instead of using the paint extent, the child's size should be used.

9e0ad4c6

[flutter_tools] pass through enable impeller flag to macOS. (#128720) · 9af6bae6
Jonah Williams authored Jun 12, 2023
```
Allow passing through the --enable-impeller flag to macOS.
```
9af6bae6

Roll Flutter Engine from de68fba09338 to 12def739b1f6 (2 revisions) (#128726) · a70f9359

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/de68fba09338...12def739b1f6

2023-06-12 41930132+hellohuanlin@users.noreply.github.com [floating_cursor_selection] a somewhat "design doc" for floating cursor feature (flutter/engine#42173)
2023-06-12 skia-flutter-autoroll@skia.org Roll ANGLE from 43ef50f389e9 to 21f16cb16333 (1 revision) (flutter/engine#42779)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a70f9359

Roll Flutter Engine from 33e06934daed to de68fba09338 (10 revisions) (#128721) · a98a3ce2

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/33e06934daed...de68fba09338

2023-06-12 smartercallum@gmail.com Fix crash with CJK keyboard with emoji at end of text field (flutter/engine#42540)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 658b1d366758 to 6bdb0ef30cb6 (2 revisions) (flutter/engine#42778)
2023-06-12 jonahwilliams@google.com [Impeller] Correct attachment description for offscreen MSAA resolve. (flutter/engine#42753)
2023-06-12 tamird@google.com Remove dependency on memfs (flutter/engine#42773)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 0f974a0f8c10 to 658b1d366758 (1 revision) (flutter/engine#42776)
2023-06-12 skia-flutter-autoroll@skia.org Roll ANGLE from 3abbc4f99970 to 43ef50f389e9 (1 revision) (flutter/engine#42775)
2023-06-12 kjlubick@users.noreply.github.com Remove unnecessary #include of SkPromiseImageTexture (flutter/engine#42770)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 951123096e55 to 0f974a0f8c10 (5 revisions) (flutter/engine#42771)
2023-06-12 jonahwilliams@google.com [Impeller] opt all vertex shader position/uvs into highp (flutter/engine#42746)
2023-06-12 30870216+gaaclarke@users.noreply.github.com [Impeller] added debug info to frame debuggers like AGI (flutter/engine#42717)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a98a3ce2

Roll Flutter Engine from 4b022f4e871f to 33e06934daed (6 revisions) (#128706) · f430c81e

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/4b022f4e871f...33e06934daed

2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 91f5ec62e30b to 951123096e55 (4 revisions) (flutter/engine#42767)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 18bd238c3db9 to 91f5ec62e30b (1 revision) (flutter/engine#42765)
2023-06-12 skia-flutter-autoroll@skia.org Roll Dart SDK from bd05ed6d5258 to dbee3c493f5a (1 revision) (flutter/engine#42763)
2023-06-12 skia-flutter-autoroll@skia.org Roll ANGLE from 10380f4ba473 to 3abbc4f99970 (1 revision) (flutter/engine#42761)
2023-06-12 skia-flutter-autoroll@skia.org Roll Dart SDK from a4611bd71a52 to bd05ed6d5258 (1 revision) (flutter/engine#42759)
2023-06-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from UxuMYdEq-rI5WqUKJ... to FreETK3TrhkNzCCL-... (flutter/engine#42757)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from UxuMYdEq-rI5 to FreETK3TrhkN

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f430c81e

Update button tests for Material 3 by default (#128628) · c5a81d1b
Hans Muller authored Jun 12, 2023

c5a81d1b

Roll Packages from afe2f05c1adb to c9865e8c63dc (6 revisions) (#128701) · 353b8bc8

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/packages/compare/afe2f05c1adb...c9865e8c63dc

2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter from da127f15 to 3df163ff (25 revisions) (flutter/packages#4183)
2023-06-10 stuartmorgan@google.com [image_picker] Add desktop support (flutter/packages#3882)
2023-06-09 tarrinneal@gmail.com [image_picker] getMedia platform changes (flutter/packages#4174)
2023-06-09 stuartmorgan@google.com [image_picker] Add desktop support - implementations (flutter/packages#4172)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter from 6e254a3f to da127f15 (28 revisions) (flutter/packages#4170)
2023-06-09 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Include required and positional query parameters in the location (flutter/packages#4163)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

353b8bc8

Fix RangeSlider notifies start and end twice when participates in gesture arena (#128674) · ad8c9978

nt4f04uNd authored Jun 12, 2023

Fixes https://github.com/flutter/flutter/issues/128433

This PR applies the same fix as we did for Slider https://github.com/flutter/flutter/pull/82152

ad8c9978

Address leak tracker breaking changes. (#128623) · 05d1cde0
Polina Cherkasova authored Jun 12, 2023

05d1cde0

Update `ListTile` text defaults to use `ColorScheme` (#128581) · ca5aa232

Taha Tesser authored Jun 12, 2023

fixes https://github.com/flutter/flutter/issues/128569

<details> 
<summary>code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const ListTileApp());
}

class ListTileApp extends StatelessWidget {
  const ListTileApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        useMaterial3: true,
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith(
          onSurface: Colors.yellow,
          onSurfaceVariant: Colors.green,
        ),
      ),
      home: const Scaffold(
        body: Center(
          child: ListTile(
            title: Text('title'),
            subtitle: Text('subtitle'),
          ),
        ),
      ),
    );
  }
}

``` 
	
</details>

# Description
M3 ListTile couldn't be customized using `ColorScheme` colors. 

- This PR updates the list tile text defaults to `ColorScheme` text color tokens.
- Improved the `ListTile` template to use the token group.
- Update docs and tests.

```dart
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.red).copyWith(
          onSurface: Colors.yellow,
          onSurfaceVariant: Colors.green,
        ),
```

### Before

![Screenshot 2023-06-09 at 17 47 04](https://github.com/flutter/flutter/assets/48603081/c0130371-3c7c-428c-bb57-504822cf64b5)

### After

![Screenshot 2023-06-09 at 17 46 17](https://github.com/flutter/flutter/assets/48603081/3b4d6f8c-7fdd-4546-a6f0-00dd34cb5a96)

ca5aa232

Roll Flutter Engine from effea50196ca to 4b022f4e871f (2 revisions) (#128683) · 6f2118be

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/effea50196ca...4b022f4e871f

2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from 943f70d6f836 to 18bd238c3db9 (2 revisions) (flutter/engine#42755)
2023-06-12 skia-flutter-autoroll@skia.org Roll Skia from c4624cc7135a to 943f70d6f836 (2 revisions) (flutter/engine#42754)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f2118be

Roll Flutter Engine from 9bb0a5907403 to effea50196ca (1 revision) (#128678) · 4f94dee8

engine-flutter-autoroll authored Jun 12, 2023

https://github.com/flutter/engine/compare/9bb0a5907403...effea50196ca

2023-06-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 0c4f3ae7464c to a4611bd71a52 (1 revision) (flutter/engine#42751)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4f94dee8

11 Jun, 2023 2 commits

Roll Flutter Engine from 788437e41ee0 to 9bb0a5907403 (1 revision) (#128673) · 2b1f882e

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/788437e41ee0...9bb0a5907403

2023-06-11 flar@google.com Reland "add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#42584)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2b1f882e

Roll Flutter Engine from 5da44b9aafdd to 788437e41ee0 (2 revisions) (#128672) · 1fccad1b

engine-flutter-autoroll authored Jun 11, 2023

https://github.com/flutter/engine/compare/5da44b9aafdd...788437e41ee0

2023-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 46f3e816d30d to 0c4f3ae7464c (1 revision) (flutter/engine#42745)
2023-06-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from E7gwQ9L15jziMUKha... to UxuMYdEq-rI5WqUKJ... (flutter/engine#42744)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from E7gwQ9L15jzi to UxuMYdEq-rI5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1fccad1b