- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the material library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 27 May, 2023 1 commit
-
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/124884
-
- 11 May, 2023 1 commit
-
-
Qun Cheng authored
Fixes #122250. This PR is to make sure all the MaterialStateProperty defaults are able to correctly resolve different states. * When a widget is pressed, it is also hovered, so we need to put the `MaterialState.pressed` check before `MaterialState.hovered`. * When a widget is focused, the widget should still be able to be hovered, so we should check `MaterialState.hovered` before `MaterialState.focused`. * There are also cases like in _InputDecoratorDefaultsM3, the `MaterialState.disabled` should be checked before `MaterialState.error`. the order should be disabled, (error), pressed, hovered, focused.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 24 Oct, 2022 1 commit
-
-
Pierre-Louis authored
* Use correct semantics for toggle buttons * x
-
- 22 Aug, 2022 1 commit
-
-
Kate Lovett authored
-
- 10 Aug, 2022 1 commit
-
-
Ian Hickson authored
-
- 23 Jun, 2022 1 commit
-
-
Pierre-Louis authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 19 May, 2022 1 commit
-
-
Darren Austin authored
-
- 29 Apr, 2022 1 commit
-
-
Taha Tesser authored
-
- 27 Apr, 2022 1 commit
-
-
Taha Tesser authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 07 Apr, 2022 1 commit
-
-
Kate Lovett authored
This reverts commit 0b216f7a.
-
- 31 Mar, 2022 1 commit
-
-
Taha Tesser authored
-
- 04 Feb, 2022 1 commit
-
-
J-P Nurmi authored
-
- 19 Nov, 2021 1 commit
-
-
Rami authored
-
- 30 Jun, 2021 1 commit
-
-
Anas35 authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Feb, 2021 1 commit
-
-
Hans Muller authored
-
- 14 Jan, 2021 1 commit
-
-
xubaolin authored
-
- 02 Dec, 2020 1 commit
-
-
xubaolin authored
-
- 21 Nov, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 02 Nov, 2020 2 commits
-
-
Greg Spencer authored
-
Michael Goderbauer authored
-
- 30 Oct, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 06 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
* migrate material to nullsafety * address review comments * address review comments * fix build
-
- 05 Oct, 2020 1 commit
-
-
Kratos authored
-
- 13 Jul, 2020 1 commit
-
-
Todd Volkert authored
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 28 May, 2020 1 commit
-
-
Tong Mu authored
* Adds default cursor and/or mouseCursor property to a number of widgets. * Adds `MaterialStateMouseCurrsor`.
-
- 25 Jan, 2020 1 commit
-
-
Hans Muller authored
-
- 22 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
* implicit-casts:false in flutter/lib/src/material * address review comments
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 24 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 13 Sep, 2019 1 commit
-
-
Shi-Hao Hong authored
* Add constraints property, updated default constraints for ToggleButtons to 48x48 * Add kMinInteractiveDimension constant to ToggleButtons
-
- 20 Aug, 2019 1 commit
-
-
Shi-Hao Hong authored
* Add ToggleButtons.textStyle property
-