Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
15a4b009
Unverified
Commit
15a4b009
authored
Oct 24, 2022
by
Pierre-Louis
Committed by
GitHub
Oct 24, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use correct semantics for toggle buttons (#113851)
* Use correct semantics for toggle buttons * x
parent
0b1fbd29
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
8 deletions
+8
-8
toggle_buttons.dart
packages/flutter/lib/src/material/toggle_buttons.dart
+1
-1
toggle_buttons_test.dart
packages/flutter/test/material/toggle_buttons_test.dart
+7
-7
No files found.
packages/flutter/lib/src/material/toggle_buttons.dart
View file @
15a4b009
...
...
@@ -798,7 +798,7 @@ class ToggleButtons extends StatelessWidget {
return
MergeSemantics
(
child:
Semantics
(
container:
true
,
toggl
ed:
isSelected
[
index
],
check
ed:
isSelected
[
index
],
enabled:
onPressed
!=
null
,
child:
_InputPadding
(
minSize:
minPaddingSize
,
...
...
packages/flutter/test/material/toggle_buttons_test.dart
View file @
15a4b009
...
...
@@ -2006,7 +2006,7 @@ void main() {
SemanticsFlag
.
isButton
,
SemanticsFlag
.
isEnabled
,
SemanticsFlag
.
hasEnabledState
,
SemanticsFlag
.
has
Toggl
edState
,
SemanticsFlag
.
has
Check
edState
,
SemanticsFlag
.
isFocusable
,
],
actions:
<
SemanticsAction
>[
...
...
@@ -2019,7 +2019,7 @@ void main() {
SemanticsFlag
.
isButton
,
SemanticsFlag
.
isEnabled
,
SemanticsFlag
.
hasEnabledState
,
SemanticsFlag
.
has
Toggl
edState
,
SemanticsFlag
.
has
Check
edState
,
SemanticsFlag
.
isFocusable
,
],
actions:
<
SemanticsAction
>[
...
...
@@ -2032,7 +2032,7 @@ void main() {
SemanticsFlag
.
isButton
,
SemanticsFlag
.
isEnabled
,
SemanticsFlag
.
hasEnabledState
,
SemanticsFlag
.
has
Toggl
edState
,
SemanticsFlag
.
has
Check
edState
,
SemanticsFlag
.
isFocusable
,
],
actions:
<
SemanticsAction
>[
...
...
@@ -2051,7 +2051,7 @@ void main() {
semantics
.
dispose
();
});
testWidgets
(
'Toggle buttons have correct semantics'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'Toggle buttons have correct semantics'
,
(
WidgetTester
tester
)
async
{
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
await
tester
.
pumpWidget
(
...
...
@@ -2079,7 +2079,7 @@ void main() {
SemanticsFlag
.
isButton
,
SemanticsFlag
.
isEnabled
,
SemanticsFlag
.
hasEnabledState
,
SemanticsFlag
.
has
Toggl
edState
,
SemanticsFlag
.
has
Check
edState
,
SemanticsFlag
.
isFocusable
,
],
actions:
<
SemanticsAction
>[
...
...
@@ -2091,8 +2091,8 @@ void main() {
SemanticsFlag
.
isButton
,
SemanticsFlag
.
isEnabled
,
SemanticsFlag
.
hasEnabledState
,
SemanticsFlag
.
is
Toggl
ed
,
SemanticsFlag
.
has
Toggl
edState
,
SemanticsFlag
.
is
Check
ed
,
SemanticsFlag
.
has
Check
edState
,
SemanticsFlag
.
isFocusable
,
],
actions:
<
SemanticsAction
>[
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment