Commits · 8e431e106e2b9cf1e2570f4cc13f9344c8699534 · abdullh.alsoleman / Front-End

02 Jan, 2024 15 commits

Reverts "Verified input integration test" (#140833) · 8e431e10

auto-submit[bot] authored Jan 02, 2024

Reverts flutter/flutter#140806
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
This is an integration test associated with https://github.com/flutter/engine/pull/49268

8e431e10

Verified input integration test (#140806) · ac9a8eb6
John McCutchan authored Jan 02, 2024
```
This is an integration test associated with
https://github.com/flutter/engine/pull/49268
```
ac9a8eb6

Roll Flutter Engine from 9d89f8727976 to b02d59a2a607 (1 revision) (#140824) · ba578c77

engine-flutter-autoroll authored Jan 02, 2024

https://github.com/flutter/engine/compare/9d89f8727976...b02d59a2a607

2024-01-02 john@johnmccutchan.com Android Platform Views support Verified Input Events (flutter/engine#49268)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba578c77

Roll Flutter Engine from a06926d05d2b to 9d89f8727976 (1 revision) (#140818) · b62bb518

engine-flutter-autoroll authored Jan 02, 2024

https://github.com/flutter/engine/compare/a06926d05d2b...9d89f8727976

2024-01-02 30870216+gaaclarke@users.noreply.github.com [Impeller] new blur: implemented ping ponging (flutter/engine#49252)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b62bb518

Upgrade leak_tracker. (#140758) · 45c611f0
Polina Cherkasova authored Jan 02, 2024

45c611f0

Reverts "Set template and migrate apps to iOS 12 minimum" (#140822) · bd634f32

auto-submit[bot] authored Jan 02, 2024

Reverts flutter/flutter#140478
Initiated by: loic-sharma
This change reverts the following previous change:
Original Description:
1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also https://github.com/flutter/flutter/pull/62902 and https://github.com/flutter/flutter/pull/85174 and https://github.com/flutter/flutter/pull/101963

Fixes https://github.com/flutter/flutter/issues/136060

bd634f32

Reland "Make `TextSpan` hit testing precise." (#140468) (#140621) · 5883a6ca

LongCatIsLooong authored Jan 02, 2024

Fixes https://github.com/flutter/flutter/issues/131435, https://github.com/flutter/flutter/issues/104594, https://github.com/flutter/flutter/issues/43400

Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.

The new TextPaintes method tells you the layout bounds `(width = letterspacing / 2 + x_advance + letterspacing / 2, height = font ascent + font descent)` of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of its character's layout bounds.

Potential issues:

In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.
This is a breaking change.

5883a6ca

Update dependencies with `flutter update-packages --force-upgrade` (#140810) · cb07292f
Elliott Brooks authored Jan 02, 2024

cb07292f

Roll Flutter Engine from 194d90de78cc to a06926d05d2b (3 revisions) (#140815) · babf0865

engine-flutter-autoroll authored Jan 02, 2024

https://github.com/flutter/engine/compare/194d90de78cc...a06926d05d2b

2024-01-02 dnfield@google.com Make sure to finish the suite if all tests are skipped (flutter/engine#49339)
2024-01-02 26625149+0xZOne@users.noreply.github.com Fix NPE when platform plugin delegate is null (flutter/engine#49391)
2024-01-02 26625149+0xZOne@users.noreply.github.com Add try-with-resource support to TraceSection (flutter/engine#49445)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

babf0865

Set template and migrate apps to iOS 12 minimum (#140478) · acdbcadb

Jenn Magder authored Jan 02, 2024

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also https://github.com/flutter/flutter/pull/62902 and https://github.com/flutter/flutter/pull/85174 and https://github.com/flutter/flutter/pull/101963

Fixes https://github.com/flutter/flutter/issues/136060

acdbcadb

improve comment doc in tabs.dart (#140568) · 7249d9ec

shirne authored Jan 02, 2024

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

7249d9ec

Revert "[Impeller] Plumb through the impeller-force-gl flag." (#140535) · bfdc32fc
Dan Field authored Jan 02, 2024
```
Reverts flutter/flutter#123828

Fixes https://github.com/flutter/flutter/issues/140523
```
bfdc32fc
Rename MemoryAllocations to FlutterMemoryAllocations. (#140623) · f667376c
Polina Cherkasova authored Jan 02, 2024
```
Contributes to https://github.com/flutter/flutter/issues/140622
```
f667376c
Add command line parameter that turns on leak tracking. (#138653) · 59242b75
Polina Cherkasova authored Jan 02, 2024

59242b75

Roll Flutter Engine from 9e03a57cde8a to 194d90de78cc (1 revision) (#140792) · c56bea32

engine-flutter-autoroll authored Jan 02, 2024

https://github.com/flutter/engine/compare/9e03a57cde8a...194d90de78cc

2024-01-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 54ae19428139 to 014514e3e5b9 (1 revision) (flutter/engine#49458)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c56bea32

29 Dec, 2023 7 commits

Roll Flutter Engine from ea4fb2cb94c8 to 9e03a57cde8a (1 revision) (#140740) · 3df4e735

engine-flutter-autoroll authored Dec 29, 2023

https://github.com/flutter/engine/compare/ea4fb2cb94c8...9e03a57cde8a

2023-12-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 4b2415d82948 to 54ae19428139 (1 revision) (flutter/engine#49423)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3df4e735

Roll Flutter Engine from d69663ee2c14 to ea4fb2cb94c8 (1 revision) (#140735) · 7c9c1705

engine-flutter-autoroll authored Dec 29, 2023

https://github.com/flutter/engine/compare/d69663ee2c14...ea4fb2cb94c8

2023-12-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 4d83ab20df11 to 4b2415d82948 (1 revision) (flutter/engine#49421)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c9c1705

Roll Flutter Engine from 7a7ddc53cd77 to d69663ee2c14 (1 revision) (#140725) · eb78553b

engine-flutter-autoroll authored Dec 29, 2023

https://github.com/flutter/engine/compare/7a7ddc53cd77...d69663ee2c14

2023-12-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 69ef0e9b3570 to 4d83ab20df11 (1 revision) (flutter/engine#49420)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eb78553b

Update README.md (#140661) · 420f18be
林洵锋 authored Dec 29, 2023
```
Fix the dashboard user guide link.
```
420f18be

Roll Flutter Engine from cee9e9e26315 to 7a7ddc53cd77 (1 revision) (#140722) · c184c809

engine-flutter-autoroll authored Dec 29, 2023

https://github.com/flutter/engine/compare/cee9e9e26315...7a7ddc53cd77

2023-12-29 skia-flutter-autoroll@skia.org Roll Dart SDK from c7442b492d15 to 69ef0e9b3570 (1 revision) (flutter/engine#49419)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c184c809

Show width and height in inspector overlay (#140709) · 186659dc

Daniel Chevalier authored Dec 29, 2023

![](https://media.giphy.com/media/SX71qs3TDxVkvbLJ4o/giphy-downsized.gif)

Fixes https://github.com/flutter/devtools/issues/6871

Add the width and height to the inspector overlay. 1 decimal precision is used since that matches the way Devtools displays the values.

## Examples
<img width="442" alt="Screenshot 2023-12-28 at 2 39 49â¯PM" src="https://github.com/flutter/flutter/assets/1386322/2de40092-de15-4ada-a954-e911e6bef217">

<img width="645" alt="Screenshot 2023-12-28 at 2 39 42â¯PM" src="https://github.com/flutter/flutter/assets/1386322/8f53dad5-1aba-43d9-9419-ca93cd894624">
<img width="149" alt="Screenshot 2023-12-28 at 2 39 37â¯PM" src="https://github.com/flutter/flutter/assets/1386322/bbed74b7-c962-4c20-80d8-48e5eaa14de6">

186659dc

Roll Flutter Engine from afd214dcccaf to cee9e9e26315 (1 revision) (#140716) · 396a5304

engine-flutter-autoroll authored Dec 29, 2023

https://github.com/flutter/engine/compare/afd214dcccaf...cee9e9e26315

2023-12-29 skia-flutter-autoroll@skia.org Roll Dart SDK from be080de22019 to c7442b492d15 (5 revisions) (flutter/engine#49417)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

396a5304

28 Dec, 2023 3 commits

More helpful test.dart output (#140175) · 11119cff

Ian Hickson authored Dec 28, 2023

Each error section is numbered, so you can all be sure you're talking about the same one.
A message is printed at the very end telling you how to find the error blocks in the verbose logs.

11119cff

expose didExceedMaxLines from RenderParagraph (#139962) · b0b0e423

hhh authored Dec 28, 2023

I want to build a widget that adds some extra functionality when the inner text overflow. So the problem occurred, I can't find an elegant way to determine if the text is overflowing. 
So i expose `didExceedMaxLines` from `RenderParagraph`, I think it can make sense. Have there some advice?

b0b0e423

Roll Flutter Engine from 437abd662da2 to afd214dcccaf (1 revision) (#140682) · b481f9c6

engine-flutter-autoroll authored Dec 28, 2023

https://github.com/flutter/engine/compare/437abd662da2...afd214dcccaf

2023-12-27 737941+loic-sharma@users.noreply.github.com [Windows] Move DWM flush to Windows proc table for mocking (flutter/engine#49398)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b481f9c6

27 Dec, 2023 9 commits

Roll Flutter Engine from 8256eeb7386d to 437abd662da2 (1 revision) (#140680) · d17c25c0

engine-flutter-autoroll authored Dec 27, 2023

https://github.com/flutter/engine/compare/8256eeb7386d...437abd662da2

2023-12-27 skia-flutter-autoroll@skia.org Roll Dart SDK from a95d7384db93 to be080de22019 (1 revision) (flutter/engine#49407)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d17c25c0

[web] Re-enable text field test now that fix has landed in engine (#140678) · 13feba58

Harry Terkelsen authored Dec 27, 2023

Re-enables skipped flaky test now that the underlying cause of flakiness (GPU memory leak) has been fixed in the engine and the fix has rolled into the framework.

The fix is here: https://github.com/flutter/engine/pull/49336

Fixes https://github.com/flutter/flutter/issues/137669

13feba58

Marks Linux_pixel_7pro integration_ui_keyboard_resize to be flaky (#140646) · 30c23468

Flutter GitHub Bot authored Dec 27, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro integration_ui_keyboard_resize"
}
-->
Issue link: https://github.com/flutter/flutter/issues/140645

30c23468

Makes the flutter tool retry on a bad gateway network error from gradle (#140670) · ddb8d1f6
Zachary Anderson authored Dec 27, 2023
```
Seen in https://github.com/flutter/flutter/issues/140643
```
ddb8d1f6

Add custom system-wide text selection toolbar buttons on Android (#139738) · 89f0c69e

Bruno Leroux authored Dec 27, 2023

## Description

This PR adds custom system-wide text selection toolbar buttons on Android.
~~This is a WIP until https://github.com/flutter/flutter/pull/139479 is merged (potential conflicts).~~

## Related Issue

Fixes https://github.com/flutter/flutter/issues/139361

## Tests

Adds 5 tests.

89f0c69e

Disable random test order in asset_bundle_test.dart (#140666) · 6664dfec
Zachary Anderson authored Dec 27, 2023
```
For https://github.com/flutter/flutter/issues/140665
```
6664dfec

Roll Flutter Engine from 2c04f3e2af11 to 8256eeb7386d (1 revision) (#140638) · 54db730e

engine-flutter-autoroll authored Dec 27, 2023

https://github.com/flutter/engine/compare/2c04f3e2af11...8256eeb7386d

2023-12-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 5084fdc1d98a to a95d7384db93 (1 revision) (flutter/engine#49401)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

54db730e

Roll Flutter Engine from 9c73cad6ae1a to 2c04f3e2af11 (1 revision) (#140633) · f15364ef

engine-flutter-autoroll authored Dec 27, 2023

https://github.com/flutter/engine/compare/9c73cad6ae1a...2c04f3e2af11

2023-12-27 skia-flutter-autoroll@skia.org Roll Dart SDK from add161c68e6d to 5084fdc1d98a (1 revision) (flutter/engine#49399)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f15364ef

Roll Flutter Engine from 38b9f3f96ff6 to 9c73cad6ae1a (1 revision) (#140630) · 0be1c490

engine-flutter-autoroll authored Dec 27, 2023

https://github.com/flutter/engine/compare/38b9f3f96ff6...9c73cad6ae1a

2023-12-26 737941+loic-sharma@users.noreply.github.com [Windows] Move DWM composition status to Windows proc table for mocking (flutter/engine#49397)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0be1c490

26 Dec, 2023 3 commits

Roll Flutter Engine from bdf261b536bd to 38b9f3f96ff6 (1 revision) (#140625) · 90c42182

engine-flutter-autoroll authored Dec 26, 2023

https://github.com/flutter/engine/compare/bdf261b536bd...38b9f3f96ff6

2023-12-26 737941+loic-sharma@users.noreply.github.com [Windows] Remove `PlatformWindow` and `RenderTarget` abstractions (flutter/engine#49312)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90c42182

Roll Packages from 23d2d9c01366 to fa74d3e1e71a (1 revision) (#140619) · 6c1e11ec

engine-flutter-autoroll authored Dec 26, 2023

https://github.com/flutter/packages/compare/23d2d9c01366...fa74d3e1e71a

2023-12-26 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.9.21 to 1.9.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#5747)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6c1e11ec

Roll Flutter Engine from 8b839eda79d4 to bdf261b536bd (1 revision) (#140611) · a86e91f3

engine-flutter-autoroll authored Dec 26, 2023

https://github.com/flutter/engine/compare/8b839eda79d4...bdf261b536bd

2023-12-26 skia-flutter-autoroll@skia.org Roll Dart SDK from cf2d9652297b to add161c68e6d (1 revision) (flutter/engine#49390)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a86e91f3

23 Dec, 2023 2 commits

Roll Flutter Engine from deac5607d000 to 8b839eda79d4 (1 revision) (#140570) · 02d1d64e

engine-flutter-autoroll authored Dec 23, 2023

https://github.com/flutter/engine/compare/deac5607d000...8b839eda79d4

2023-12-23 skia-flutter-autoroll@skia.org Roll Dart SDK from c1f9520b30d7 to cf2d9652297b (1 revision) (flutter/engine#49382)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

02d1d64e

Roll Flutter Engine from 5981a3c68e70 to deac5607d000 (1 revision) (#140555) · cd718db7

engine-flutter-autoroll authored Dec 23, 2023

https://github.com/flutter/engine/compare/5981a3c68e70...deac5607d000

2023-12-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 25961234c1bc to c1f9520b30d7 (1 revision) (flutter/engine#49376)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cd718db7

22 Dec, 2023 1 commit

Roll Flutter Engine from 0476141a016f to 5981a3c68e70 (1 revision) (#140552) · 29d42dde

engine-flutter-autoroll authored Dec 22, 2023

https://github.com/flutter/engine/compare/0476141a016f...5981a3c68e70

2023-12-22 skia-flutter-autoroll@skia.org Roll Dart SDK from eec6568c209f to 25961234c1bc (1 revision) (flutter/engine#49373)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

29d42dde