1. 27 Oct, 2023 2 commits
  2. 09 Oct, 2023 1 commit
  3. 07 Sep, 2023 1 commit
    • Taha Tesser's avatar
      Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with... · 75797a8a
      Taha Tesser authored
      Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with default text style (#134138)
      
      fixes [Inconsistent text color on DataTable in different platforms](https://github.com/flutter/flutter/issues/114470)
      
      ### Code sample
      
      <details>
      <summary>expand to view the code sample</summary> 
      
      ```dart
      import 'package:flutter/material.dart';
      
      /// Flutter code sample for [DataTable].
      
      void main() => runApp(const DataTableExampleApp());
      
      class DataTableExampleApp extends StatelessWidget {
        const DataTableExampleApp({super.key});
      
        @override
        Widget build(BuildContext context) {
          return MaterialApp(
            themeMode: ThemeMode.dark,
            theme: ThemeData(),
            darkTheme: ThemeData.dark(),
            home: Scaffold(
              appBar: AppBar(title: const Text('DataTable Sample')),
              body: const DataTableExample(),
            ),
          );
        }
      }
      
      class DataTableExample extends StatelessWidget {
        const DataTableExample({super.key});
      
        @override
        Widget build(BuildContext context) {
          return DataTable(
            headingTextStyle: const TextStyle(),
            dataTextStyle: const TextStyle(),
            columns: const <DataColumn>[
              DataColumn(
                label: Expanded(
                  child: Text(
                    'Name',
                    style: TextStyle(fontStyle: FontStyle.italic),
                  ),
                ),
              ),
              DataColumn(
                label: Expanded(
                  child: Text(
                    'Age',
                    style: TextStyle(fontStyle: FontStyle.italic),
                  ),
                ),
              ),
              DataColumn(
                label: Expanded(
                  child: Text(
                    'Role',
                    style: TextStyle(fontStyle: FontStyle.italic),
                  ),
                ),
              ),
            ],
            rows: const <DataRow>[
              DataRow(
                cells: <DataCell>[
                  DataCell(Text('Sarah')),
                  DataCell(Text('19')),
                  DataCell(Text('Student')),
                ],
              ),
              DataRow(
                cells: <DataCell>[
                  DataCell(Text('Janine')),
                  DataCell(Text('43')),
                  DataCell(Text('Professor')),
                ],
              ),
              DataRow(
                cells: <DataCell>[
                  DataCell(Text('William')),
                  DataCell(Text('27')),
                  DataCell(Text('Associate Professor')),
                ],
              ),
            ],
          );
        }
      }
      
      ```
      
      </details>
      
      ### Before
      
      | Desktop | Mobile |
      | --------------- | --------------- |
      | <img src="https://github.com/flutter/flutter/assets/48603081/19c3908d-6b6a-4408-9c6b-da83c8efaa4a"  /> | <img src="https://github.com/flutter/flutter/assets/48603081/efda08fb-05f9-437e-be5c-6b6861babe19" width="350"  /> |
      
      ### After
      
      | Desktop | Mobile |
      | --------------- | --------------- |
      | <img src="https://github.com/flutter/flutter/assets/48603081/6bd3433f-d61f-4f35-8a2a-f7539a74f93e" /> | <img src="https://github.com/flutter/flutter/assets/48603081/5123a79b-6c2a-4bea-9fbc-64ed3e599826" width="350" /> |
      75797a8a
  4. 17 Aug, 2023 1 commit
    • Bernardo Ferrari's avatar
      Improve and optimize non-uniform Borders. (#124417) · b7046b32
      Bernardo Ferrari authored
      ~~Using the same priority order as a Border without borderRadius, it is possible to draw them on top of each other. This is better than the current behavior (crash!) and would work well for a "one color on top, another on bottom" scenario.~~
      
      ~~With this, if approved, we move the current number of possible exceptions from 4 to 1 (`BoxShape.circle` + `borderRadius`).~~
      
      ~~It is kind of odd how `borderRadius.zero` to `borderRadius != BorderRadius.zero` change, but I think it is better than crashing. Alternatively, we just remove the "original function" and see if any goldens are affected.~~
      
      <img width="448" alt="image" src="https://user-images.githubusercontent.com/351125/236550350-7499d758-5b44-40e6-9105-32671eb21998.png">
      
      Another one for @gspencergoog. If this works, we could make the paint method public and re-use in the InputBorder PR (if that's also approved). Single line fix.
      b7046b32
  5. 15 Aug, 2023 1 commit
    • Ian Hickson's avatar
      PaginatedDataTable improvements (#131374) · ccdf8264
      Ian Hickson authored
      - slightly improved assert message when row cell counts don't match column count.
      - more breadcrumbs in API documentation. more documentation in general.
      - added more documentation for the direction of the "ascending" arrow.
      - two samples for PaginatedDataTable.
      - make PaginatedDataTable support hot reloading across changes to the number of columns.
      - introduce matrix3MoreOrLessEquals. An earlier version of this PR used it in tests, but eventually it was not needed. The function seems useful to keep though.
      ccdf8264
  6. 14 Aug, 2023 1 commit
  7. 07 Aug, 2023 1 commit
  8. 22 Jul, 2023 1 commit
  9. 13 Jun, 2023 1 commit
    • Qun Cheng's avatar
      Update unit tests in material library for Material 3 (#128725) · a5f8b64e
      Qun Cheng authored
      Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true.
      
      All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version.
      
      related to #127064
      a5f8b64e
  10. 31 Mar, 2023 1 commit
  11. 24 Mar, 2023 2 commits
  12. 23 Feb, 2023 1 commit
    • David Neuy's avatar
      Fix DataCell overflows when cell height is large by adding dataRowMinHeight,... · 3681b27a
      David Neuy authored
      Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. (#114338)
      
      * Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props.
      
      * Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props - add tests.
      
      * Fix analysis errors
      
      * Review changes.
      
      * Add asserts for dataRowMinHeight and dataRowMaxHeight
      
      * Add asserts for dataRowMinHeight and dataRowMaxHeight
      
      * Make dataRowHeight a computed getter
      
      * Remove get only dataRowHeight from hashCode...
      
      * Update deprecated after
      
      * Add new line at end of AUTHORS
      
      * Apply suggestions from code review
      
      * Update packages/flutter/test/material/data_table_test.dart
      
      ---------
      Co-authored-by: 's avatarKate Lovett <katelovett@google.com>
      3681b27a
  13. 21 Dec, 2022 1 commit
  14. 31 Oct, 2022 1 commit
  15. 25 Oct, 2022 1 commit
  16. 03 Jun, 2022 2 commits
  17. 25 May, 2022 1 commit
  18. 20 May, 2022 1 commit
  19. 19 May, 2022 1 commit
  20. 19 Apr, 2022 1 commit
  21. 26 Mar, 2022 1 commit
  22. 25 Mar, 2022 2 commits
  23. 21 Jan, 2022 1 commit
  24. 05 Jan, 2022 1 commit
  25. 04 Jan, 2022 1 commit
  26. 01 Nov, 2021 1 commit
  27. 08 Oct, 2021 3 commits
  28. 21 Sep, 2021 1 commit
    • Bonsai11's avatar
      Adding onLongPress for DataRow (#87172) · 6d2d9b2f
      Bonsai11 authored
      * Adding onLongPress for DataRow
      
      Useful to be able to e.g. start a selection mode of rows or show a drop down menu.
      
      * Test for onLongPress
      
      * Changed parameter
      6d2d9b2f
  29. 19 Aug, 2021 1 commit
  30. 18 Aug, 2021 2 commits
  31. 17 Aug, 2021 1 commit
  32. 28 Apr, 2021 1 commit
  33. 20 Apr, 2021 1 commit