- 27 Oct, 2023 2 commits
-
-
Taha Tesser authored
This reverts commit 64f31b2f. *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Taha Tesser authored
This updates one of them M3 test to use golden test from https://github.com/flutter/flutter/pull/135901 Keeping it consistent with this [update](https://github.com/flutter/flutter/pull/136809#discussion_r1365053630)
-
- 09 Oct, 2023 1 commit
-
-
Taha Tesser authored
Updated unit tests for `CircleAvatar` & `DataTable` to have M2 and M3 versions. More info in #127064
-
- 07 Sep, 2023 1 commit
-
-
Taha Tesser authored
Fix `DataTable`'s `headingTextStyle` & `dataTextStyle` are not merged with default text style (#134138) fixes [Inconsistent text color on DataTable in different platforms](https://github.com/flutter/flutter/issues/114470) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; /// Flutter code sample for [DataTable]. void main() => runApp(const DataTableExampleApp()); class DataTableExampleApp extends StatelessWidget { const DataTableExampleApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( themeMode: ThemeMode.dark, theme: ThemeData(), darkTheme: ThemeData.dark(), home: Scaffold( appBar: AppBar(title: const Text('DataTable Sample')), body: const DataTableExample(), ), ); } } class DataTableExample extends StatelessWidget { const DataTableExample({super.key}); @override Widget build(BuildContext context) { return DataTable( headingTextStyle: const TextStyle(), dataTextStyle: const TextStyle(), columns: const <DataColumn>[ DataColumn( label: Expanded( child: Text( 'Name', style: TextStyle(fontStyle: FontStyle.italic), ), ), ), DataColumn( label: Expanded( child: Text( 'Age', style: TextStyle(fontStyle: FontStyle.italic), ), ), ), DataColumn( label: Expanded( child: Text( 'Role', style: TextStyle(fontStyle: FontStyle.italic), ), ), ), ], rows: const <DataRow>[ DataRow( cells: <DataCell>[ DataCell(Text('Sarah')), DataCell(Text('19')), DataCell(Text('Student')), ], ), DataRow( cells: <DataCell>[ DataCell(Text('Janine')), DataCell(Text('43')), DataCell(Text('Professor')), ], ), DataRow( cells: <DataCell>[ DataCell(Text('William')), DataCell(Text('27')), DataCell(Text('Associate Professor')), ], ), ], ); } } ``` </details> ### Before | Desktop | Mobile | | --------------- | --------------- | | <img src="https://github.com/flutter/flutter/assets/48603081/19c3908d-6b6a-4408-9c6b-da83c8efaa4a" /> | <img src="https://github.com/flutter/flutter/assets/48603081/efda08fb-05f9-437e-be5c-6b6861babe19" width="350" /> | ### After | Desktop | Mobile | | --------------- | --------------- | | <img src="https://github.com/flutter/flutter/assets/48603081/6bd3433f-d61f-4f35-8a2a-f7539a74f93e" /> | <img src="https://github.com/flutter/flutter/assets/48603081/5123a79b-6c2a-4bea-9fbc-64ed3e599826" width="350" /> |
-
- 17 Aug, 2023 1 commit
-
-
Bernardo Ferrari authored
~~Using the same priority order as a Border without borderRadius, it is possible to draw them on top of each other. This is better than the current behavior (crash!) and would work well for a "one color on top, another on bottom" scenario.~~ ~~With this, if approved, we move the current number of possible exceptions from 4 to 1 (`BoxShape.circle` + `borderRadius`).~~ ~~It is kind of odd how `borderRadius.zero` to `borderRadius != BorderRadius.zero` change, but I think it is better than crashing. Alternatively, we just remove the "original function" and see if any goldens are affected.~~ <img width="448" alt="image" src="https://user-images.githubusercontent.com/351125/236550350-7499d758-5b44-40e6-9105-32671eb21998.png"> Another one for @gspencergoog. If this works, we could make the paint method public and re-use in the InputBorder PR (if that's also approved). Single line fix.
-
- 15 Aug, 2023 1 commit
-
-
Ian Hickson authored
- slightly improved assert message when row cell counts don't match column count. - more breadcrumbs in API documentation. more documentation in general. - added more documentation for the direction of the "ascending" arrow. - two samples for PaginatedDataTable. - make PaginatedDataTable support hot reloading across changes to the number of columns. - introduce matrix3MoreOrLessEquals. An earlier version of this PR used it in tests, but eventually it was not needed. The function seems useful to keep though.
-
- 14 Aug, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 07 Aug, 2023 1 commit
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/59413 This relocates `mock_canvas.dart` and `recording_canvas.dart` from `flutter/test/rendering` to `flutter_test`. The testing functionality afforded by mock_canvas should be available to everyone, not just the framework. :) mock_canvas.dart needed a bit of cleanup - things like formatting and super parameters.
-
- 22 Jul, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 13 Jun, 2023 1 commit
-
-
Qun Cheng authored
Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true. All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version. related to #127064
-
- 31 Mar, 2023 1 commit
-
-
Justin McCandless authored
Added new parameters onSecondaryTap and onSecondaryTapDown
-
- 24 Mar, 2023 2 commits
-
-
Bernardo Ferrari authored
Add Non-Uniform Border to Border.
-
Taha Tesser authored
-
- 23 Feb, 2023 1 commit
-
-
David Neuy authored
Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. (#114338) * Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props. * Fix DataCell overflows when cell height is large by adding dataRowMinHeight, dataRowMaxHeight props - add tests. * Fix analysis errors * Review changes. * Add asserts for dataRowMinHeight and dataRowMaxHeight * Add asserts for dataRowMinHeight and dataRowMaxHeight * Make dataRowHeight a computed getter * Remove get only dataRowHeight from hashCode... * Update deprecated after * Add new line at end of AUTHORS * Apply suggestions from code review * Update packages/flutter/test/material/data_table_test.dart --------- Co-authored-by: Kate Lovett <katelovett@google.com>
-
- 21 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 31 Oct, 2022 1 commit
-
-
Greg Spencer authored
-
- 25 Oct, 2022 1 commit
-
-
Taha Tesser authored
-
- 03 Jun, 2022 2 commits
-
-
Taha Tesser authored
-
Taha Tesser authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `material` * include test/material * add back removed comments
-
- 20 May, 2022 1 commit
-
-
Tong Mu authored
-
- 19 May, 2022 1 commit
-
-
Darren Austin authored
-
- 19 Apr, 2022 1 commit
-
-
xubaolin authored
-
- 26 Mar, 2022 1 commit
-
-
Alex Li authored
-
- 25 Mar, 2022 2 commits
-
-
-
Alex Li authored
-
- 21 Jan, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 05 Jan, 2022 1 commit
-
-
Markus Aksli authored
-
- 04 Jan, 2022 1 commit
-
-
Will Lockwood authored
-
- 01 Nov, 2021 1 commit
-
-
Dheeraj Verma authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 21 Sep, 2021 1 commit
-
-
Bonsai11 authored
* Adding onLongPress for DataRow Useful to be able to e.g. start a selection mode of rows or show a drop down menu. * Test for onLongPress * Changed parameter
-
- 19 Aug, 2021 1 commit
-
-
Hans Muller authored
-
- 18 Aug, 2021 2 commits
-
-
Jenn Magder authored
This reverts commit a1ae4fea.
- 17 Aug, 2021 1 commit
-
-
Alex Li authored
-
- 28 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 20 Apr, 2021 1 commit
-
-
Chinmoy authored
This change prevents DataRow from being enabled when onSelectChanged is null.
-