1. 18 Aug, 2023 1 commit
  2. 08 Aug, 2023 1 commit
  3. 23 May, 2023 1 commit
    • Ian Hickson's avatar
      Give channel descriptions in `flutter channel`, use branch instead of upstream... · 9c7a9e77
      Ian Hickson authored
      Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (#126936)
      
      ## How we determine the channel name
      
      Historically, we used the current branch's upstream to figure out the current channel name. I have no idea why. I traced it back to https://github.com/flutter/flutter/pull/446/files where @abarth implement this and I reviewed that PR and left no comment on it at the time.
      
      I think this is confusing. You can be on a branch and it tells you that your channel is different. That seems weird.
      
      This PR changes the logic to uses the current branch as the channel name.
      
      ## How we display channels
      
      The main reason this PR exists is to add channel descriptions to the `flutter channel` list:
      
      ```
      ianh@burmese:~/dev/flutter/packages/flutter_tools$ flutter channel
      Flutter channels:
        master (tip of tree, for contributors)
        main (tip of tree, follows master channel)
        beta (updated monthly, recommended for experienced users)
        stable (updated quarterly, for new users and for production app releases)
      * foo_bar
      
      Currently not on an official channel.
      ianh@burmese:~/dev/flutter/packages/flutter_tools$
      ```
      
      ## Other changes
      
      I made a few other changes while I was at it:
      
      * If you're not on an official channel, we used to imply `--show-all`, but now we don't, we just show the official channels plus yours. This avoids flooding the screen in the case the user is on a weird channel and just wants to know what channel they're on.
      * I made the tool more consistent about how it handles unofficial branches. Now it's always `[user branch]`.
      * I slightly adjusted how unknown versions are rendered so it's clearer the version is unknown rather than just having the word "Unknown" floating in the output without context.
      * Simplified some of the code.
      * Made some of the tests more strict (checking all output rather than just some aspects of it).
      * Changed the MockFlutterVersion to implement the FlutterVersion API more strictly.
      * I made sure we escape the output to `.metadata` to avoid potential injection bugs (previously we just inlined the version and channel name verbatim with no escaping, which is super sketchy).
      * Tweaked the help text for the `downgrade` command to be clearer.
      * Removed some misleading text in some error messages.
      * Made the `.metadata` generator consistent with the template file.
      * Removed some obsolete code to do with the `dev` branch.
      
      ## Reviewer notes
      
      I'm worried that there are implications to some of these changes that I am not aware of, so please don't assume I know what I'm doing when reviewing this code. :-)
      9c7a9e77
  4. 25 Jan, 2023 1 commit
  5. 23 Jan, 2023 1 commit
  6. 06 Jan, 2023 1 commit
  7. 16 Nov, 2022 1 commit
    • hellohuanlin's avatar
      [tools]build ipa validate template icon files (#114841) · dcae4247
      hellohuanlin authored
      * [tools]build ipa validate template icon files
      
      * use the same box for both validations, and added some unit test, and some nits
      
      * add unit test for templateImageDirectory
      
      * use fs.path.join intead of raw path
      
      * use the correct filesystem
      
      * lint
      
      * use absolute path for flutter_template_images
      
      * fix rebase
      
      * update indentation
      dcae4247
  8. 25 May, 2022 1 commit
  9. 27 Apr, 2022 1 commit
  10. 26 Apr, 2022 1 commit
  11. 22 Feb, 2022 1 commit
  12. 04 Nov, 2021 1 commit
  13. 01 Nov, 2021 1 commit
  14. 02 Aug, 2021 1 commit
  15. 15 Jul, 2021 2 commits
  16. 28 Jun, 2021 1 commit
  17. 08 Apr, 2021 1 commit
  18. 24 Mar, 2021 1 commit
  19. 16 Mar, 2021 1 commit
  20. 27 Jan, 2021 1 commit
  21. 11 Nov, 2020 1 commit
  22. 26 Oct, 2020 1 commit
    • Jonah Williams's avatar
      [flutter_tools] implement safe file copy with multiple fallbacks (#69000) · 2e54c4a8
      Jonah Williams authored
      The tool observes a large number of unhandled exceptions during the file copy portion of flutter create. it is difficult to tell whether the permission issue is caused by the source/destination, or whether it is due to a bug in dart:io.
      
      To work around this, implement a permission check for both the source and dest files. If either fails, the tool can exit with a more specific message.
      
      If these checks pass, then perform the actual copy. If the copy fails, fallback to manually copying the bytes
      2e54c4a8
  23. 30 Sep, 2020 1 commit
  24. 17 Sep, 2020 1 commit
    • Jonah Williams's avatar
      [flutter_tools] use flutter tool handler for dwds resources and precache tool... · 3e838da9
      Jonah Williams authored
      [flutter_tools] use flutter tool handler for dwds resources and precache tool pub dependencies (#65814)
      
      If the tool is downloaded from a precompiled snapshot, or if the backing source files in the pub cache are deleted, the dwds debugging functionality will break as the client.js file cannot be located. Instead use the PackageConfig to verify that package location, downloading if it is missing.
      
      Override the dwds middleware to avoid Isolate.resolvePackageUri
      
      Fixes #53644
      Fixes #65475
      3e838da9
  25. 21 Aug, 2020 1 commit
  26. 28 Jul, 2020 1 commit
  27. 15 Jul, 2020 1 commit
    • Jonah Williams's avatar
      [flutter_tools] generate a synthetic flutter_gen package on pub get (#61261) · d8b6fa15
      Jonah Williams authored
      Allow configuring the flutter_manifest to support a synthetic package, this is done through flutter: generate: true.
      
      When running pub get, insert a flutter_gen entry into the packages if it does not already exist. This points to .dart_tool/flutter_gen, which can be updated to contain the generated intl sources (But doesn't currently)
      
      Adds an integration test that verifies this code can be run and imported when enabled.
      
      Part of #60914
      d8b6fa15
  28. 24 Jun, 2020 2 commits
  29. 14 May, 2020 1 commit
  30. 28 Apr, 2020 1 commit
  31. 22 Apr, 2020 1 commit
  32. 23 Mar, 2020 1 commit
    • stuartmorgan's avatar
      Add pre-stable support for create on Windows (#51895) · 685e9d1e
      stuartmorgan authored
      Adds initial support for flutter create of apps and plugins. This is derived from the current FDE example app and sample plugin, adding template values where relevant.
      
      Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the create output about the fact that it won't be stable.
      
      Plugins don't currently have a version marker since in practice this is not a significant problem for plugins yet the way it is for runners; we can add it later if that changes.
      
      Fixes #30704
      685e9d1e
  33. 03 Mar, 2020 1 commit
    • stuartmorgan's avatar
      Add pre-stable support for create on Linux (#51832) · 8d8439f8
      stuartmorgan authored
      Adds initial support for `flutter create` of apps and plugins. This is derived from the current FDE example app and sample plugin, with a few changes:
      - Added template values where it makes sense.
      - Moved some likely-to-change values into separate files for now, to simplify the delete/recreate cycle that will be necessary until it's stable.
      - Added some minor Makefile flag handling improvements
      
      Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the `create` output about the fact that it won't be stable.
      8d8439f8
  34. 27 Feb, 2020 1 commit
  35. 07 Jan, 2020 1 commit
  36. 06 Jan, 2020 1 commit
  37. 27 Nov, 2019 1 commit
    • Ian Hickson's avatar
      License update (#45373) · 449f4a66
      Ian Hickson authored
      * Update project.pbxproj files to say Flutter rather than Chromium
      
      Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
      
      * Update the copyright notice checker to require a standard notice on all files
      
      * Update copyrights on Dart files. (This was a mechanical commit.)
      
      * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
      
      Some were already marked "The Flutter Authors", not clear why. Their
      dates have been normalized. Some were missing the blank line after the
      license. Some were randomly different in trivial ways for no apparent
      reason (e.g. missing the trailing period).
      
      * Clean up the copyrights in non-Dart files. (Manual edits.)
      
      Also, make sure templates don't have copyrights.
      
      * Fix some more ORGANIZATIONNAMEs
      449f4a66
  38. 19 Nov, 2019 1 commit