Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
57dc071f
Unverified
Commit
57dc071f
authored
Jan 06, 2023
by
gmackall
Committed by
GitHub
Jan 06, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adding 'is' to list of kotlin reserved keywords (#116299)
Co-authored-by:
Gray Mackall
<
mackall@google.com
>
parent
de2a4249
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
template.dart
packages/flutter_tools/lib/src/template.dart
+1
-1
template_test.dart
...utter_tools/test/general.shard/android/template_test.dart
+2
-2
No files found.
packages/flutter_tools/lib/src/template.dart
View file @
57dc071f
...
...
@@ -17,7 +17,7 @@ import 'dart/package_map.dart';
/// They are escaped in Kotlin files.
///
/// https://kotlinlang.org/docs/keyword-reference.html
const
List
<
String
>
kReservedKotlinKeywords
=
<
String
>[
'when'
,
'in'
];
const
List
<
String
>
kReservedKotlinKeywords
=
<
String
>[
'when'
,
'in'
,
'is'
];
/// Expands templates in a directory to a destination. All files that must
/// undergo template expansion should end with the '.tmpl' extension. All files
...
...
packages/flutter_tools/test/general.shard/android/template_test.dart
View file @
57dc071f
...
...
@@ -36,12 +36,12 @@ void main() {
);
final
Map
<
String
,
Object
>
context
=
<
String
,
Object
>{
'androidIdentifier'
:
'in.when.there'
,
'androidIdentifier'
:
'i
s.i
n.when.there'
,
};
template
.
render
(
destination
,
context
);
final
File
destinationFile
=
destination
.
childFile
(
outputClass
);
expect
(
destinationFile
.
readAsStringSync
(),
equals
(
'package `in`.`when`.there;'
));
expect
(
destinationFile
.
readAsStringSync
(),
equals
(
'package `i
s`.`i
n`.`when`.there;'
));
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment