- 13 Jun, 2023 1 commit
-
-
Kate Lovett authored
Fixes https://github.com/flutter/flutter/issues/128749 The ScrollPositionAlignmentPolicy does not account for AxisDirection, which meant default focus traversal of reversed scrollables did not work. The policy doesn't know about the axis direction, so this is corrected in the ScrollPosition where all the information is available before calling on the viewport for the new target scroll offset. This fixes that by flipping the policy (unless explicit) so that focus traversal works.
-
- 24 May, 2023 1 commit
-
-
Bruno Leroux authored
## Description This PR fixes a precision error in ~~`ClampingScrollPhysics`~~ `ScrollPosition` that leads to `StretchingOverscrollIndicator` stretching its content unexpectedly in some devices (see https://github.com/flutter/flutter/issues/126561 where this is visible in `TabBarView` and the test added in this PR where it reproduces with a `PageView`). ~~This PR also contains a change to `nested_scroll_view.dart` because the first change (the one in `ClampingScrollPhysics`) breaks the precision error test added by https://github.com/flutter/flutter/pull/87801.~~ ## Related Issue Fixes https://github.com/flutter/flutter/issues/126561 ## Tests Adds 1 test.
-
- 15 May, 2023 1 commit
-
-
Kate Lovett authored
Add ScrollController.onAttach & onDetach, samples/docs on listening/getting scrolling info (#124823) This PR does a couple of things! https://user-images.githubusercontent.com/16964204/231897483-416287f9-50ce-468d-a714-2a4bc0f2e011.mov ![Screenshot 2023-04-13 at 3 24 28 PM](https://user-images.githubusercontent.com/16964204/231897497-f5bee17d-43ed-46e5-acd7-e1bd64768274.png) Fixes #20819 Fixes #41910 Fixes #121419 ### Adds ScrollController.onAttach and ScrollController.onDetach This resolves a long held pain point for developers. When using a scroll controller, there is not scroll position until the scrollable widget is built, and almost all methods of notification are only triggered when scrolling happens. Adding these two methods will help developers gain access to the scroll position when it is created. A common workaround for this was using a post frame callback to access controller.position after the first frame, but this is ripe for issues such as having multiple positions attached to the controller, or the scrollable no longer existing after that post frame callback. I think this can also be helpful for folks to debug cases when the scroll controller has multiple positions attached. In particular, this also resolves this commented case: https://github.com/flutter/flutter/issues/20819#issuecomment-417784218 The isScrollingNotifier is hard for developers to access. ### Docs & samples I was surprised we did not have samples on scroll notification or scroll controller, so I overhauled it and added a lot of docs on all the different ways to access scrolling information, when it is available and how they differ.
-
- 11 May, 2023 1 commit
-
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/126454. In certain situations (see linked bug) the Scrollable needs access to the DPR of the View it is drawn into during disposal. Since inherited widget lookups are not allowed during disposal, we cannot look up the DPR dynamically in these situations. Instead, we have to cache the DPR when lookups are still allowed.
-
- 05 May, 2023 1 commit
-
-
Ian Hickson authored
This PR contains a series of minor changes to address issues that I happened to run into: - Pretty-print errors triggered when handling events that are pending because of having locked event handling. Previously these were just dumped to the console. - Add more documentation for `debugPaintPadding`. - Add documentation to `Tween` saying how to implement it. - Slight formatting changes in the scrollbar code to align some expressions. - Since we convert ScrollMetricsNotifications to ScrollNotifications in various places, provide an explicit API to do this. This will make the behaviour consistent throughout, and makes the code easier to understand. Added a test for this. - Clarifications to some of the BindingBase and SchedulerBinding documentation. - Clarified some documentation in `flutter_test`'s `Finder` class.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 24 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 03 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
This reverts commit c956121a.
-
- 27 Dec, 2022 1 commit
-
-
Xilai Zhang authored
This reverts commit 999356b7.
-
- 22 Dec, 2022 1 commit
-
-
Michael Goderbauer authored
* Remove single-view assumption from ScrollPhysics * fix scrollable_dispose_test.dart * add deprecated method back
-
- 31 Oct, 2022 1 commit
-
-
Greg Spencer authored
-
- 24 Oct, 2022 1 commit
-
-
Kate Lovett authored
-
- 26 Jul, 2022 1 commit
-
-
Polina Cherkasova authored
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 18 May, 2022 1 commit
-
-
gaaclarke authored
-
- 12 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 06 Apr, 2022 1 commit
-
-
Dwayne Slater authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 15 Oct, 2021 1 commit
-
-
Ian Hickson authored
-
- 04 Oct, 2021 1 commit
-
-
Greg Spencer authored
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder. I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed. I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
-
- 25 Aug, 2021 1 commit
-
-
Greg Spencer authored
This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
-
- 18 Aug, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 09 Aug, 2021 1 commit
-
- 04 Aug, 2021 1 commit
-
-
Kate Lovett authored
This reverts commit 52bf9dbb.
-
- 03 Aug, 2021 1 commit
-
-
xubaolin authored
-
- 28 Jul, 2021 1 commit
-
-
xubaolin authored
-
- 15 Jul, 2021 1 commit
-
- 14 Jul, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 31de052e.
-
Ian Hickson authored
-
- 13 Jul, 2021 2 commits
-
-
Ian Hickson authored
This reverts commit e2490f29.
-
Ian Hickson authored
-
- 28 Jun, 2021 1 commit
-
-
Angjie Li authored
-
- 25 Jun, 2021 1 commit
-
-
xubaolin authored
-
- 19 May, 2021 1 commit
-
-
Hattomo (TomohiroHattori) authored
-
- 18 May, 2021 1 commit
-
-
xubaolin authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 19 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 05 Jan, 2021 1 commit
-
-
Sam Rawlins authored
-
- 02 Nov, 2020 1 commit
-
-
YeungKC authored
-