1. 27 Aug, 2019 1 commit
  2. 15 Aug, 2019 1 commit
  3. 19 Jul, 2019 1 commit
  4. 13 Jul, 2019 1 commit
  5. 15 Apr, 2019 1 commit
  6. 21 Feb, 2019 1 commit
  7. 15 Nov, 2018 2 commits
  8. 11 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Re-land text wrapping/color PR (#22831) · 081d2a7a
      Greg Spencer authored
      This attempts to re-land #22656.
      
      There are two changes from the original:
      
      I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.
      
      I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.
      
      As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.
      
      *     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
          This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
          Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
          Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
          Since wrapping is now turned on, also removed many redundant '\n's in the code.
      081d2a7a
  9. 06 Oct, 2018 2 commits
    • Greg Spencer's avatar
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to... · 2d81adf7
      Greg Spencer authored
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759)
      
      This reverts commit e4386321
      because it breaks 160 benchmarks, and several devicelab tests,
      due to changing the format of the output.
      2d81adf7
    • Greg Spencer's avatar
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor... · e4386321
      Greg Spencer authored
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
      This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
      Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
      Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
      Since wrapping is now turned on, also removed many redundant '\n's in the code.
      e4386321
  10. 12 Sep, 2018 1 commit
  11. 04 Sep, 2018 1 commit
    • Chris Bracken's avatar
      Eliminate --preview-dart-2 flag (#21304) · 041ff621
      Chris Bracken authored
      This patch eliminates the --preview-dart-2/--no-preview-dart-2 flag,
      hardcoding all uses to true. It also defaults all previewDart2 method
      parameters to true, where they hadn't yet been.
      
      A series of subsequent patches will eliminate all previewDart2
      parameters and the associated code from within the codebase.
      041ff621
  12. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  13. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  14. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  15. 08 Jun, 2018 3 commits
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05
    • Chris Bracken's avatar
      Revert "It's time to #deleteDart1 (#18293)" (#18313) · 9495df4b
      Chris Bracken authored
      Several benchmarks started failing during kernel compile:
      1. Timeouts:
         * commands_test
         * hot_mode_dev_cycle__benchmark
         * run_machine_concurrent_hot_reload
         * service_extensions_test
      
      2. Kernel compiler crash:
         * hot_mode_dev_cycle_linux__benchmark
         * routing_test
      
      3. Unexpected termination:
         * hot_mode_dev_cycle_win__benchmark
      
      This reverts commit ed63e708.
      9495df4b
    • Chris Bracken's avatar
      It's time to #deleteDart1 (#18293) · ed63e708
      Chris Bracken authored
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      ed63e708
  16. 24 Feb, 2018 1 commit
  17. 19 Dec, 2017 1 commit
    • Alan Russian's avatar
      Change async stubbing to use thenAnswer. (#13521) · 30720bd1
      Alan Russian authored
      * Change async stubbing to use thenAnswer.
      
      Mockito now prohibits calling thenReturn with Futures and Streams. dart-lang/mockito#79
      
      * Update all Mockito deps to 3.0.0.
      
      * Revert "Update all Mockito deps to 3.0.0."
      
      This reverts commit e8ab9d37c33d3d7fe384abde64ea5b4d72623c75.
      
      I did not correctly update the mockito dep, and there's no easy way to update to 3.0 alpha right now.
      
      * Change thenAnswer((_) => to thenAnswer((invocation) =>
      
      * Add Invocation type to thenAnswer lambdas
      30720bd1
  18. 26 Sep, 2017 1 commit
    • Todd Volkert's avatar
      Run command validation on all commands. (#12246) · a08b5e00
      Todd Volkert authored
      This makes command validation happen as part of `verifyThenRunCommand()`,
      using a newly introduced protected method (`validateCommand()`) rather than
      a `commandValidator` property (that subclasses were responsible for manually
      invoking).
      a08b5e00
  19. 16 Jun, 2017 1 commit
  20. 12 May, 2017 1 commit
  21. 26 Apr, 2017 1 commit
  22. 20 Apr, 2017 1 commit
  23. 15 Mar, 2017 1 commit
  24. 10 Mar, 2017 2 commits
  25. 04 Mar, 2017 1 commit
  26. 28 Feb, 2017 1 commit
  27. 21 Feb, 2017 1 commit
  28. 18 Feb, 2017 1 commit
  29. 14 Feb, 2017 1 commit
  30. 06 Feb, 2017 1 commit
  31. 27 Jan, 2017 1 commit
  32. 23 Jan, 2017 1 commit
  33. 09 Jan, 2017 1 commit
  34. 07 Jan, 2017 1 commit
    • Todd Volkert's avatar
      Update flutter_tools to use package:file throughout (#7385) · 8bb27034
      Todd Volkert authored
      This removes direct file access from within flutter_tools
      in favor of using `package:file` via a `FileSystem` that's
      accessed via the `ApplicationContext`.
      
      This lays the groundwork for us to be able to easily swap
      out the underlying file system when running Flutter tools,
      which will be used to provide a record/replay file system,
      analogous to what we have for process invocations.
      8bb27034
  35. 06 Jan, 2017 1 commit