- 20 Jun, 2023 12 commits
-
-
Swaroop S authored
This PR is to add **controller** property to the **Stepper** widget, so that user has the flexibility to control the scroll offset for various purposes(especially in case of scroll animations)! Fixes #61207 Co-authored-by: Taha Tesser <tessertaha@gmail.com>
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/59d93d64cb83...6e1918fa166c 2023-06-19 ychris@google.com [all] Update UIViewControllerBasedStatusBarAppearance to true (flutter/packages#4225) 2023-06-17 31859944+LongCatIsLooong@users.noreply.github.com Add missing ignores for `textScaleFactor` deprecation (flutter/packages#4239) 2023-06-17 goderbauer@google.com [url_launcher] Remove deprecated onPlatformMessage calls (flutter/packages#4233) 2023-06-17 stuartmorgan@google.com [ci] Add LUCI version of build-all for web (flutter/packages#4232) 2023-06-16 stuartmorgan@google.com [ci] Introduce LUCI version of Linux build-all-packages tests (flutter/packages#4229) 2023-06-16 engine-flutter-autoroll@skia.org Roll Flutter from b0188cd1 to fc8856eb (14 revisions) (flutter/packages#4231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Tae Hyung Kim authored
The file was becoming harder to deal with as it manually sets up a /lib/l10n directory with a `MemoryFileSystem` in every single test. This PR wraps this process in a helper function `setupLocalizations` and also provides a helper function `getGeneratedFileContent` which helps fetch the respective output file given the locale string.
-
Kevin Chisholm authored
Add a design doc issue template to streamline the proposal flow.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bd6d3fc90462...4444ede34a9c 2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 1d6ca884ed77 to 6823d03cf2b2 (1 revision) (flutter/engine#42998) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/73c4ba4240cc...bd6d3fc90462 2023-06-20 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JewrT71vAzyDs8qRt... to fdtK_FqpscIVvbb_j... (flutter/engine#42997) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from JewrT71vAzyD to fdtK_FqpscIV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7ee874792067...73c4ba4240cc 2023-06-20 skia-flutter-autoroll@skia.org Roll Dart SDK from d87670619414 to dc6691ef755c (1 revision) (flutter/engine#42996) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6a6c8fb591f5...7ee874792067 2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from 60385192e512 to 1d6ca884ed77 (3 revisions) (flutter/engine#42995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Leigha Jarett authored
Fixes https://github.com/flutter/flutter/issues/128028. It seems pretty straightforward so don't think it warrants the effort to add more samples.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a91bb3f566b9...6a6c8fb591f5 2023-06-20 skia-flutter-autoroll@skia.org Roll Skia from abcc292f8afe to 60385192e512 (1 revision) (flutter/engine#42993) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e0d456d9251b...a91bb3f566b9 2023-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lG2K667BLaS_haUZg... to jzCJwD297aRZtdakZ... (flutter/engine#42990) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lG2K667BLaS_ to jzCJwD297aRZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/55418e648958...e0d456d9251b 2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from 9c2148cd1c82 to abcc292f8afe (1 revision) (flutter/engine#42989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 19 Jun, 2023 9 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/84ecaa053ec6...55418e648958 2023-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gX0QkT_dMBCTbiAHY... to JewrT71vAzyDs8qRt... (flutter/engine#42988) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from gX0QkT_dMBCT to JewrT71vAzyD If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/23a2c246600f...84ecaa053ec6 2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from 41689ff01f97 to 9c2148cd1c82 (1 revision) (flutter/engine#42987) 2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 60adb12ffc30 to d87670619414 (1 revision) (flutter/engine#42986) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes https://github.com/flutter/flutter/issues/115827 fixes https://github.com/flutter/flutter/issues/101325 ### Description 1. This PR adds a new MaterialState `color` property to all the chips (this makes it possible to customize chips in all states from the M3 specs). 2. Updated defaults to use the new MaterialState `color` property. 3. Updated and added new tests to all the chip test classes. <details> <summary>code sample</summary> ```dart import 'package:flutter/material.dart'; const Color disabledColor = Colors.black26; const Color backgroundColor = Colors.cyan; final Color disabledSelectedColor = Colors.red.shade100; const Color selectedColor = Colors.amber; final MaterialStateProperty<Color> color = MaterialStateProperty.resolveWith((Set<MaterialState> states) { if (states.contains(MaterialState.disabled) && states.contains(MaterialState.selected)) { return disabledSelectedColor; } if (states.contains(MaterialState.disabled)) { return disabledColor; } if (states.contains(MaterialState.selected)) { return selectedColor; } return backgroundColor; }); void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData( useMaterial3: true, // chipTheme: ChipThemeData(color: color), ), home: const Example(), ); } } class Example extends StatefulWidget { const Example({super.key}); @override State<Example> createState() => _ExampleState(); } class _ExampleState extends State<Example> { bool enabled = false; bool selected = true; @override Widget build(BuildContext context) { const Widget verticalSpace = SizedBox(height: 20); return Scaffold( body: Center( child: Column( children: <Widget>[ const SizedBox(height: 25), Row( mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: <Widget>[ const Card( elevation: 0.0, color: disabledColor, child: Padding( padding: EdgeInsets.all(8.0), child: Text('disabledColor'), ), ), const Card( elevation: 0.0, color: backgroundColor, child: Padding( padding: EdgeInsets.all(8.0), child: Text('backgroundColor'), ), ), Card( elevation: 0.0, color: disabledSelectedColor, child: const Padding( padding: EdgeInsets.all(8.0), child: Text('disabledSelectedColor'), ), ), const Card( elevation: 0.0, color: selectedColor, child: Padding( padding: EdgeInsets.all(8.0), child: Text('selectedColor'), ), ), ], ), const Spacer(), Row( mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: <Widget>[ Column( mainAxisSize: MainAxisSize.min, mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ RawChip( selected: selected, selectedColor: selectedColor, color: color, label: const Text('RawChip'), isEnabled: enabled, onSelected: enabled ? (bool value) {} : null, ), verticalSpace, InputChip( isEnabled: enabled, selected: selected, selectedColor: selectedColor, color: color, label: const Text('InputChip'), onSelected: enabled ? (bool value) {} : null, ), ], ), Column( mainAxisSize: MainAxisSize.min, children: <Widget>[ FilterChip( selected: selected, selectedColor: selectedColor, color: color, label: const Text('FilterChip'), onSelected: enabled ? (bool value) {} : null, ), verticalSpace, FilterChip.elevated( selected: selected, selectedColor: selectedColor, color: color, label: const Text('FilterChip.elevated'), onSelected: enabled ? (bool value) {} : null, ), ], ), Column( mainAxisSize: MainAxisSize.min, children: <Widget>[ ChoiceChip( selected: selected, selectedColor: selectedColor, color: color, label: const Text('ChoiceChip'), onSelected: enabled ? (bool value) {} : null, ), verticalSpace, ChoiceChip.elevated( selected: selected, selectedColor: selectedColor, color: color, label: const Text('ChoiceChip.elevated'), onSelected: enabled ? (bool value) {} : null, ), ], ), ], ), const Spacer(), Row( children: <Widget>[ Flexible( child: SwitchListTile( title: const Text('Enabled'), value: enabled, onChanged: (bool value) { setState(() => enabled = value); }, ), ), Flexible( child: SwitchListTile( title: const Text('Selected'), value: selected, onChanged: (bool value) { setState(() => selected = value); }, ), ), ], ) ], ), ), ); } } ``` </details> ### Before (not possible to customize disabled and selected chips) ![Screenshot 2023-06-13 at 16 27 13](https://github.com/flutter/flutter/assets/48603081/633f09f7-16a1-469e-b326-b9cc0ed59242) ### After (using disabled and selected chips using the new MaterialState `color` property) ![Screenshot 2023-06-13 at 16 26 53](https://github.com/flutter/flutter/assets/48603081/7f5dffb7-4074-4268-87c0-c059c2da67a8)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/280491d4cc21...23a2c246600f 2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from 455d7306b951 to 41689ff01f97 (1 revision) (flutter/engine#42983) 2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d07173415e8 to 60adb12ffc30 (1 revision) (flutter/engine#42982) 2023-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fgS2avQGq4x_sbZHU... to lG2K667BLaS_haUZg... (flutter/engine#42981) 2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from c90c7dec5c18 to 455d7306b951 (1 revision) (flutter/engine#42980) 2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from d182b694a670 to c90c7dec5c18 (1 revision) (flutter/engine#42979) 2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from b2ec326cc4f3 to 3d07173415e8 (1 revision) (flutter/engine#42978) 2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from 24f2336d87f2 to d182b694a670 (2 revisions) (flutter/engine#42977) 2023-06-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from BuzniDS9u_hdghV5f... to gX0QkT_dMBCTbiAHY... (flutter/engine#42976) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from fgS2avQGq4x_ to lG2K667BLaS_ fuchsia/sdk/core/mac-amd64 from BuzniDS9u_hd to gX0QkT_dMBCT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jason Simmons authored
Cache.flutterRoot is set within testUsingContext and will be uninitialized the first time test suite setup is invoked.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/164c6b49dfb5...280491d4cc21 2023-06-19 skia-flutter-autoroll@skia.org Roll Skia from f489be63a30a to 24f2336d87f2 (1 revision) (flutter/engine#42975) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes [`InputDecoration.applyDefaults` ignores some properties](https://github.com/flutter/flutter/issues/127330) <details> <summary>code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData(useMaterial3: true), home: const Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @override Widget build(BuildContext context) { const TextStyle textStyle = TextStyle(color: Color(0xFF00FFFF)); const Color color = Color(0xFF00FF00); const InputBorder inputBorder = OutlineInputBorder( borderSide: BorderSide( color: Color(0xFF0000FF), ), ); final InputDecoration appliedDefaults = const InputDecoration().applyDefaults( const InputDecorationTheme( labelStyle: textStyle, floatingLabelStyle: textStyle, helperStyle: textStyle, helperMaxLines: 2, hintStyle: textStyle, errorStyle: textStyle, errorMaxLines: 2, floatingLabelBehavior: FloatingLabelBehavior.never, floatingLabelAlignment: FloatingLabelAlignment.center, isDense: true, contentPadding: EdgeInsets.all(1.0), iconColor: color, prefixStyle: textStyle, prefixIconColor: color, suffixStyle: textStyle, suffixIconColor: color, counterStyle: textStyle, filled: true, fillColor: color, focusColor: color, hoverColor: color, errorBorder: inputBorder, focusedBorder: inputBorder, focusedErrorBorder: inputBorder, disabledBorder: inputBorder, enabledBorder: inputBorder, border: InputBorder.none, alignLabelWithHint: true, constraints: BoxConstraints( minWidth: 10, maxWidth: 20, minHeight: 30, maxHeight: 40), ), ); return Scaffold( appBar: AppBar( title: const Text('InputDecoration().applyDefaults'), ), // Centered FilledButton. body: Center( child: SingleChildScrollView( child: Column( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ ColoredBox( color: appliedDefaults.labelStyle.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.labelStyle.toString()), ), ColoredBox( color: appliedDefaults.floatingLabelStyle .toString() .contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.floatingLabelStyle.toString()), ), ColoredBox( color: appliedDefaults.helperStyle.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.helperStyle.toString()), ), ColoredBox( color: appliedDefaults.hintStyle.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.hintStyle.toString()), ), ColoredBox( color: appliedDefaults.errorStyle.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.errorStyle.toString()), ), ColoredBox( color: appliedDefaults.iconColor.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.iconColor.toString()), ), ColoredBox( color: appliedDefaults.prefixStyle.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.prefixStyle.toString()), ), ColoredBox( color: appliedDefaults.prefixIconColor.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.prefixIconColor.toString()), ), ColoredBox( color: appliedDefaults.suffixStyle.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.suffixStyle.toString()), ), ColoredBox( color: appliedDefaults.suffixIconColor.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.suffixIconColor.toString()), ), ColoredBox( color: appliedDefaults.counterStyle.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.counterStyle.toString()), ), ColoredBox( color: appliedDefaults.fillColor.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.fillColor.toString()), ), ColoredBox( color: appliedDefaults.focusColor.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.focusColor.toString()), ), ColoredBox( color: appliedDefaults.hoverColor.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.hoverColor.toString()), ), ColoredBox( color: appliedDefaults.errorBorder.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.errorBorder.toString()), ), ColoredBox( color: appliedDefaults.focusedBorder.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.focusedBorder.toString()), ), ColoredBox( color: appliedDefaults.focusedErrorBorder .toString() .contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.focusedErrorBorder.toString()), ), ColoredBox( color: appliedDefaults.disabledBorder.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.disabledBorder.toString()), ), ColoredBox( color: appliedDefaults.enabledBorder.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.enabledBorder.toString()), ), ColoredBox( color: appliedDefaults.border.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.border.toString()), ), ColoredBox( color: appliedDefaults.constraints.toString().contains('null') ? Colors.red : Colors.green, child: Text(appliedDefaults.constraints.toString()), ), ], ), ), ), ); } } ``` </details> ### Before ![before screenshot](https://github.com/flutter/flutter/assets/48603081/ae564e15-4029-4feb-810f-e46b9312a257) ### After ![after screenshot](https://github.com/flutter/flutter/assets/48603081/8924a1d8-ffde-494b-bf44-66dab4d28845)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d298f0bf720c...164c6b49dfb5 2023-06-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 5a9e97eebbed to b2ec326cc4f3 (1 revision) (flutter/engine#42974) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7ffa1355f718...d298f0bf720c 2023-06-18 jonahwilliams@google.com Fix prefer_final_in_foreach analysis errors (flutter/engine#42971) 2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from xS5RzQLfpMEK1rNEd... to fgS2avQGq4x_sbZHU... (flutter/engine#42973) 2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from aBEyk5N2HlwOqvpwo... to BuzniDS9u_hdghV5f... (flutter/engine#42970) 2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from dc2e0ebbd045 to f489be63a30a (1 revision) (flutter/engine#42968) 2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from 85b4788bc3f1 to dc2e0ebbd045 (1 revision) (flutter/engine#42967) 2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -PsA0LDB2FdS_4_vK... to xS5RzQLfpMEK1rNEd... (flutter/engine#42966) 2023-06-18 bdero@google.com [Impeller] Use 32 bit for positional stuff in the rrect blur (flutter/engine#42797) 2023-06-18 jonahwilliams@google.com Revert "[Impeller] correct default PSO pixel format and sample count." (flutter/engine#42962) 2023-06-18 jonahwilliams@google.com [Impeller] dont use concurrent runner to decode images on Android. (flutter/engine#42944) 2023-06-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from I1G8Ll0KcxmAoMT8u... to aBEyk5N2HlwOqvpwo... (flutter/engine#42964) 2023-06-18 skia-flutter-autoroll@skia.org Roll Skia from c56f38d79fe0 to 85b4788bc3f1 (2 revisions) (flutter/engine#42963) 2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Au1gd3XLMuSt1Z4oh... to -PsA0LDB2FdS_4_vK... (flutter/engine#42959) 2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d1faf69c8253 to 5a9e97eebbed (1 revision) (flutter/engine#42958) 2023-06-17 skia-flutter-autoroll@skia.org Roll Skia from 2a9e11fd9d37 to c56f38d79fe0 (1 revision) (flutter/engine#42955) 2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JMStJe6efcLuWMT_I... to I1G8Ll0KcxmAoMT8u... (flutter/engine#42954) 2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 1a04f451a934 to d1faf69c8253 (1 revision) (flutter/engine#42953) 2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from b3bcbdf7de8d to 1a04f451a934 (1 revision) (flutter/engine#42951) 2023-06-17 skia-flutter-autoroll@skia.org Roll Skia from dc11c7ddb33f to 2a9e11fd9d37 (1 revision) (flutter/engine#42950) 2023-06-17 bdero@google.com [Impeller] Print malioc errors on CI (flutter/engine#42906) 2023-06-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 8eaed3382237 to b3bcbdf7de8d (10 revisions) (flutter/engine#42949) 2023-06-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -NW1eatBbmjvLaIcV... to Au1gd3XLMuSt1Z4oh... (flutter/engine#42948) 2023-06-17 a-siva@users.noreply.github.com Fix analyzer warnings (prefer_final_in_for_each is now the default) (flutter/engine#42943) 2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fXVcR5tdj5wSd_OUz... to JMStJe6efcLuWMT_I... (flutter/engine#42942) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 64fa632d3b01 to dc11c7ddb33f (3 revisions) (flutter/engine#42939) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from -NW1eatBbmjv to fgS2avQGq4x_ fuchsia/sdk/core/mac-amd64 from fXVcR5tdj5wS to BuzniDS9u_hd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 17 Jun, 2023 1 commit
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7483c8a533e3...7ffa1355f718 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 01f3be45e0d6 to 64fa632d3b01 (3 revisions) (flutter/engine#42937) 2023-06-16 110993981+htoor3@users.noreply.github.com [web] Fix for Safari autofill flickering bug (flutter/engine#42830) 2023-06-16 jonahwilliams@google.com [Impeller] correct default PSO pixel format and sample count. (flutter/engine#42902) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 16 Jun, 2023 13 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/54990ac1bf95...7483c8a533e3 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 90dae91b2242 to 01f3be45e0d6 (4 revisions) (flutter/engine#42934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/28dc0c40ea54...54990ac1bf95 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 20e9cc928715 to 90dae91b2242 (5 revisions) (flutter/engine#42932) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/aefe104cd067...28dc0c40ea54 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from a4ad5b369313 to 20e9cc928715 (3 revisions) (flutter/engine#42926) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fb5fed432e59...aefe104cd067 2023-06-16 30870216+gaaclarke@users.noreply.github.com Revert "Add deprecations to PlatformMessage stuff" (flutter/engine#42921) 2023-06-16 jakemac@google.com add dart_internal override where necessary (flutter/engine#42920) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from d43262e90f25 to a4ad5b369313 (3 revisions) (flutter/engine#42919) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 9ab04a53b7be to d43262e90f25 (5 revisions) (flutter/engine#42918) 2023-06-16 mdebbar@google.com [web] Move webOnlyAssetManager to `dart:ui_web` (flutter/engine#42642) 2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from E5G7PwYbRA-u-ZJ9F... to -NW1eatBbmjvLaIcV... (flutter/engine#42915) 2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from FJPPnZP9EcGLQ0OZa... to fXVcR5tdj5wSd_OUz... (flutter/engine#42912) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from c29ecbe7fba7 to 9ab04a53b7be (1 revision) (flutter/engine#42910) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 504a26e85fc6 to c29ecbe7fba7 (1 revision) (flutter/engine#42909) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from f0410a265d2b to 504a26e85fc6 (1 revision) (flutter/engine#42907) 2023-06-16 godofredoc@google.com Set xcode explicitly on mac builds with release_build. (flutter/engine#42898) 2023-06-16 scheglov@google.com Fix prefer_final_in_for_each (flutter/engine#42899) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from abfa3505db23 to f0410a265d2b (1 revision) (flutter/engine#42904) 2023-06-16 godofredoc@google.com Remove release_build from clang_tidy build. (flutter/engine#42900) 2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 53EjCyuRu91oFTBf2... to E5G7PwYbRA-u-ZJ9F... (flutter/engine#42897) 2023-06-15 chillers@google.com Revert "Roll Clang from 6d667d4b261e to 7f374b6902fa" (flutter/engine#42896) 2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 2ab2678058a3 to abfa3505db23 (1 revision) (flutter/engine#42894) 2023-06-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from P7QA6bfO_Ij5dre7B... to FJPPnZP9EcGLQ0OZa... (flutter/engine#42892) 2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 794b6f9240a8 to 2ab2678058a3 (6 revisions) (flutter/engine#42889) 2023-06-15 goderbauer@google.com Add deprecations to PlatformMessage stuff (flutter/engine#42580) 2023-06-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Joined obligatory vulkan swapchain submits (flutter/engine#42865) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 53EjCyuRu91o to -NW1eatBbmjv fuchsia/sdk/core/mac-amd64 from P7QA6bfO_Ij5 to fXVcR5tdj5wS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
Prerequisite for https://github.com/flutter/devtools/pull/5918
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/f9314a3b833a...59d93d64cb83 2023-06-16 stuartmorgan@google.com [tool] Add command aliases (flutter/packages#4207) 2023-06-16 stuartmorgan@google.com [google_map_flutter] Fix map object regression due to async changes (flutter/packages#4171) 2023-06-16 goderbauer@google.com [url_launcher] Add ignores for deprecated member to test (flutter/packages#4220) 2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter from 95be76ab to b0188cd1 (10 revisions) (flutter/packages#4221) 2023-06-15 34871572+gmackall@users.noreply.github.com [camera_android] Upgrading roboelectric from 4.5 to 4.10.3 (flutter/packages#4018) 2023-06-15 47866232+chunhtai@users.noreply.github.com [go_router] Fixes bug that GoRouterState in top level redirect doesn'⦠(flutter/packages#4173) 2023-06-15 47866232+chunhtai@users.noreply.github.com [go_router]Updates documentations around GoRouter.of, GoRouter.maybeOf, and BuildContext extension. (flutter/packages#4176) 2023-06-15 stuartmorgan@google.com [tool] Support code excerpts for any .md file (flutter/packages#4212) 2023-06-15 baptiste.dupuch@gmail.com [webview_flutter] Add support for limitsNavigationsToAppBoundDomains (flutter/packages#4026) 2023-06-15 yk3372@gmail.com [webview_flutter][webview_flutter_android] Add android support for handling geolocation permissions (flutter/packages#3795) 2023-06-15 tarrinneal@gmail.com [image_picker] add getMedia method (flutter/packages#3892) 2023-06-15 tarrinneal@gmail.com [image_picker] getMedia platform implementations (flutter/packages#4175) 2023-06-14 31859944+LongCatIsLooong@users.noreply.github.com Ignore `textScaleFactor` deprecation (flutter/packages#4209) 2023-06-14 stuartmorgan@google.com [pigeon] Enable Obj-C integration tests in CI (flutter/packages#4215) 2023-06-14 63286031+ahmednfwela@users.noreply.github.com [flutter_adaptive_scaffold] Support RTL (flutter/packages#4204) 2023-06-14 engine-flutter-autoroll@skia.org Manual roll Flutter from 09b7e561 to 95be76ab (14 revisions) (flutter/packages#4214) 2023-06-14 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 682aa387cfe4 to 796c8ef79279 (5 revisions) (flutter/packages#4213) 2023-06-14 engine-flutter-autoroll@skia.org Roll Flutter from 353b8bc8 to 09b7e561 (17 revisions) (flutter/packages#4206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
Danny Tuppeny authored
When building the new SDK DAPs, this functionality was missed from the Flutter adapter (but added to the Dart CLI adapter). As well as passing a VM Service URI directly, we support passing a file that can be polled for it. This uses the same mechanism we use to obtain the VM Service URI from a Dart debug session (we run `dart --write-service-info=foo.json my_file.dart` and then poll that file which the VM will write) and is useful for users that have their own mechanism for launching an app (for example using custom Flutter embedders - see https://github.com/Dart-Code/Dart-Code/issues/3353) to provide a VM Service URI once the app is up and running. Fixes https://github.com/Dart-Code/Dart-Code/issues/4577.
-
Polina Cherkasova authored
-
Michael Goderbauer authored
It's time to say good bye to an old friend. It has outlived its usefulness. Farewell, AbstractNode! ð«¡
-
Mouad Debbar authored
Previously, when the code contained `const HtmlElementView()` it would break even if it's guarded by `if (kIsWeb)`. This PR makes it such that `const HtmlElementView()` is allowed but it still throws if it gets inserted into the widget tree by mistake on non-web platforms. One improvement we can make in the future is to have a conditional import: - `_html_element_view_web.dart` that contains the real `HtmlElementView` that can only be instantiated on web. - `_html_element_view_io.dart` that contains a stub with an unimplemented `build()` method. Fixes https://github.com/flutter/flutter/issues/43532
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/050729760b25...f9314a3b833a 2023-06-14 stuartmorgan@google.com [tool] Support running main.dart (flutter/packages#4208) 2023-06-13 stuartmorgan@google.com [tool] Allow running from anywhere (flutter/packages#4199) 2023-06-13 62033170+Khalidm98@users.noreply.github.com [go_router] #127016 preserved route name case when caching `_nameToPath` (flutter/packages#4196) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
-
- 15 Jun, 2023 5 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/48e0b4e66422...fb5fed432e59 2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 2d531d020c26 to 794b6f9240a8 (3 revisions) (flutter/engine#42888) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Dery Rahman Ahaddienata authored
Command instruction for clearing dart pub cache is somewhat wrong. Instead of `clear`, `clean` is the correct one. Ref: https://dart.dev/tools/pub/cmd/pub-cache Fixes https://github.com/flutter/flutter/issues/128663 (Edited by @andrewkolos. Changed "related to" issue to "fixes" to link this PR to the issue).
-
Christopher Fujino authored
Part of https://github.com/flutter/flutter/issues/127135
-
Christopher Fujino authored
Improve debugging for https://github.com/flutter/flutter/issues/128680 In the linked issue, I cannot explain how we are getting a type error. However, this refactor eliminates the null check operator (by iterating over `MapEntries` rather than the keys) in hopes that there will be a more descriptive error in the future. The correctness of this change is verified by the existing tests in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/license_collector_test.dart
-
Qun Cheng authored
Fixes #127863 This PR is to set `Semantics.button` to true for date widget in `DatePicker`. https://github.com/flutter/flutter/assets/36861262/b366f25a-6bf3-4e3f-b944-ab71197b73e5
-