1. 28 Feb, 2024 1 commit
  2. 02 Feb, 2024 1 commit
    • Lau Ching Jun's avatar
      Avoid depending on files from build_system/targets other than from top level... · ac7879e2
      Lau Ching Jun authored
      Avoid depending on files from build_system/targets other than from top level entrypoints in flutter_tools. (#142760)
      
      Add a new `BuildTargets` class that provides commonly used build targets. And avoid importing files from `build_system/targets` except from the top level entrypoints or from top level commands.
      
      Also move `scene_importer.dart` and `shader_compiler.dart` into `build_system/tools` because they are not `Target` classes, but wrapper for certain tools.
      
      With this change, we can ignore all files in `build_system/targets` internally and make PR #142709 easier to land internally. See cl/603434066 for the corresponding internal change.
      
      Related to:
      https://github.com/flutter/flutter/pull/142709
      https://github.com/flutter/flutter/issues/142041
      
      Also note that I have opted to add a new variable in `globals.dart` for `BuildTargets` in this PR, but I know that we are trying to get rid of globals. Several alternatives that I was considering:
      
      1. Add a new field in `BuildSystem` that returns a `BuildTargets` instance. Since `BuildSystem` is already in `globals`, we can access build targets using `globals.buildSystem.buildTargets` without adding a new global variable.
      2. Properly inject the `BuildTargetsImpl` instance from the top level `executable.dart` and top level commands.
      
      Let me know if you want me to do one of the above instead. Thanks!
      ac7879e2
  3. 31 Jan, 2024 1 commit
    • Dan Field's avatar
      Refactor ShaderTarget to not explicitly mention impeller or Skia (#141460) · c417c462
      Dan Field authored
      Refactors `ShaderTarget` to make it opaque as to whether it's using Impeller or SkSL and instead has it focus on the target platform it's generating for.
      
      ImpellerC includes SkSL right now whether you ask for it or not. 
      
      The tester target also might need SkSL or Vulkan depending on whether `--enable-impeller` is passed.
      c417c462
  4. 20 Dec, 2023 1 commit
  5. 29 Sep, 2023 1 commit
  6. 24 Aug, 2023 1 commit
  7. 06 Jul, 2023 1 commit
  8. 14 Apr, 2023 1 commit
  9. 28 Mar, 2023 1 commit
  10. 22 Mar, 2023 1 commit
  11. 21 Mar, 2023 1 commit
  12. 11 Aug, 2022 1 commit
  13. 27 Jul, 2022 1 commit
  14. 25 Jul, 2022 1 commit
  15. 18 Jun, 2022 1 commit
  16. 03 Jun, 2022 1 commit
  17. 25 May, 2022 1 commit
  18. 27 Apr, 2022 1 commit
  19. 08 Oct, 2021 3 commits
  20. 04 Oct, 2021 1 commit
  21. 08 Jul, 2021 1 commit
  22. 01 Jul, 2021 1 commit
  23. 01 Jun, 2021 1 commit
  24. 18 May, 2021 1 commit
  25. 13 May, 2021 1 commit
  26. 21 Apr, 2021 1 commit
  27. 20 Apr, 2021 1 commit
  28. 18 Apr, 2021 1 commit
  29. 17 Apr, 2021 1 commit
  30. 18 Feb, 2021 1 commit
  31. 11 Feb, 2021 1 commit
  32. 02 Feb, 2021 1 commit
  33. 27 Jan, 2021 1 commit
  34. 13 Jan, 2021 3 commits
  35. 14 Dec, 2020 1 commit
  36. 05 Dec, 2020 1 commit