Commits · 7fb35db62fa575757fd66b0c3e865be1741db206 · abdullh.alsoleman / Front-End

22 Mar, 2024 8 commits

Intensive `if` chain refactoring (#145194) · 7fb35db6

Nate authored Mar 22, 2024

This pull request refactors if-statements into switch expressions, as part of the effort to solve issue #144903.

Making changes beyond just swapping syntax is more difficult (and also more difficult to review, I apologize), but much more satisfying too.

7fb35db6

Adds numpad navigation shortcuts for Linux (#145464) · 859eb2ed

Bruno Leroux authored Mar 22, 2024

## Description

This PR adds shortcuts related to numpad keys on Linux.

## Related Issue

Linux side for https://github.com/flutter/flutter/issues/144936

## Tests

Adds 2 tests.

859eb2ed

Roll Flutter Engine from 5a12de1beab7 to f9a34ae0b14f (1 revision) (#145581) · 5fab92f0

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/5a12de1beab7...f9a34ae0b14f

2024-03-22 26625149+0xZOne@users.noreply.github.com [Android] Fix the issue of blank or frozen pages in shared engine scenarios (flutter/engine#50947)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5fab92f0

Roll Flutter Engine from e2f324beac3b to 5a12de1beab7 (1 revision) (#145578) · 5058c268

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/e2f324beac3b...5a12de1beab7

2024-03-21 41930132+hellohuanlin@users.noreply.github.com [ios][platform_view][performance] overlay intersection (flutter/engine#50637)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5058c268

Replace `RenderBox.compute*` with `RenderBox.get*` and add `@visibleForOverriding` (#145503) · d755bc22

LongCatIsLooong authored Mar 22, 2024

`@visibleForOverriding` + `@protected` unfortunately does not catch the case where a `compute*` method was overridden in a subtype and the overide was called in that same type's implementation.

I did not add a `flutter_ignore` for this because it doesn't seem there will be false positives.

d755bc22

Add some cross references in the docs, move an example to a dartpad example (#145571) · 0f685f88

Greg Spencer authored Mar 22, 2024

## Description

This adds some "See also" links to some docs for `TweenAnimationBuilder` and `ValueListenableBuilder`.

Also, moved a "snippet" example in `ValueListenableBuilder` into the examples directory as a Dartpad example.

## Tests
 - Added test for the example.

0f685f88

Fix `BorderSide.none` requiring explicit transparent color for `UnderlineInputBorder` (#145329) · 784f19c4

Bernardo Ferrari authored Mar 22, 2024

Fix could have been "paint transparent when Border none" but, following other Borders, we will just not paint anything.

Fix https://github.com/flutter/flutter/issues/143746

784f19c4

Roll Flutter Engine from a46a7b273a5b to e2f324beac3b (1 revision) (#145576) · e1c64454

engine-flutter-autoroll authored Mar 22, 2024

https://github.com/flutter/engine/compare/a46a7b273a5b...e2f324beac3b

2024-03-21 34871572+gmackall@users.noreply.github.com Make the et feature request link properly add the github label (flutter/engine#51594)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1c64454

21 Mar, 2024 25 commits

Fix nullability of getFullHeightForCaret (#145554) · 11c034f0

Michael Goderbauer authored Mar 21, 2024

Fixes https://github.com/flutter/flutter/issues/145507.

Looks like this was accidentally migrated to nullable all the way back when we switched to NNBD.

11c034f0

Add a `--no-gradle-generation` mode to the `generate_gradle_lockfiles.dart` script (#145568) · 3b390c52

Gray Mackall authored Mar 21, 2024

The script currently overwrites existing `settings.gradle`, `build.gradle`, and `gradle-wrapper.properties` files in the directories it processes. This mode makes it not do that, and just generate the lockfiles themselves.

Related to https://github.com/flutter/flutter/pull/145564#r1371888460

3b390c52

Roll Flutter Engine from 1b842ae58b3d to a46a7b273a5b (2 revisions) (#145569) · a36569d1

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/1b842ae58b3d...a46a7b273a5b

2024-03-21 737941+loic-sharma@users.noreply.github.com [Fuchsia] Assert renders are only to the implicit view (flutter/engine#51559)
2024-03-21 737941+loic-sharma@users.noreply.github.com [Embedder API] Fix test helper's present callback registration (flutter/engine#51560)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a36569d1

Fixed race condition in PollingDeviceDiscovery. (#145506) · c759c22e

Lau Ching Jun authored Mar 21, 2024

There are two issues in the previous implementation:
1. `_populateDevices` will return the devices from `deviceNotifier` if it had been initialized, assuming that once it's initialized, it has been properly populated. That assumption is not true because calling getters like `onAdded` would initialize `deviceNotifier` without populating it.
2. `deviceNotifier` instance might be replaced in some cases, causing `onAdded` subscribers to lose any future updates.

To fix (1), this commit added the `isPopulated` field in `deviceNotifier` as a more accurate flag to determine if we need to populate it.

To fix (2), this commit made `deviceNotifier` a final member in `PolingDeviceDiscovery`.

c759c22e

Roll Flutter Engine from a2ed373fa70f to 1b842ae58b3d (1 revision) (#145565) · d69833ce

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/a2ed373fa70f...1b842ae58b3d

2024-03-21 ian@hixie.ch Add a breadcrumb from FlutterView to PlatformDispatcher. (flutter/engine#51504)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d69833ce

Clarify AutomaticKeepAliveClientMixin semantics in build method (#145297) · afe01503
Ian Hickson authored Mar 21, 2024
```
This should help folks who trace the code before reading the documentation.
```
afe01503
Eliminate more window singleton usages (#145560) · eaf509aa
Michael Goderbauer authored Mar 21, 2024
```
These usages in strings slipped through the initial clean-up.
```
eaf509aa

`flutter test --wasm` support (#145347) · 31209d04

Jackson Gardner authored Mar 21, 2024

* Adds support for `flutter test --wasm`.
  * The test compilation flow is a bit different now, so that it supports compilers other than DDC. Specifically, when we run a set of unit tests, we generate a "switchboard" main function that imports each unit test and runs the main function for a specific one based off of a value set by the JS bootstrapping code. This way, there is one compile step and the same compile output is invoked for each unit test file.
* Also, removes all references to `dart:html` from flutter/flutter.
* Adds CI steps for running the framework unit tests with dart2wasm+skwasm
  * These steps are marked as `bringup: true`, so we don't know what kind of failures they will result in. Any failures they have will not block the tree at all yet while we're still in `bringup: true`. Once this PR is merged, I plan on looking at any failures and either fixing them or disabling them so we can get these CI steps running on presubmit.

This fixes https://github.com/flutter/flutter/issues/126692

31209d04

Roll Flutter Engine from eb262e9c34db to a2ed373fa70f (2 revisions) (#145556) · 98d10b62

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/eb262e9c34db...a2ed373fa70f

2024-03-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 5724c0dc7846 to b89d2de510d1 (1 revision) (flutter/engine#51584)
2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 72875d47dbc3 to 14c5a8540691 (1 revision) (flutter/engine#51583)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

98d10b62

Roll Flutter Engine from bad4a30e1c75 to eb262e9c34db (1 revision) (#145555) · 06466008

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/bad4a30e1c75...eb262e9c34db

2024-03-21 jason-simmons@users.noreply.github.com Move //buildtools to //flutter/buildtools (flutter/engine#51526)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06466008

Roll Flutter Engine from 7cdb240c4a16 to bad4a30e1c75 (2 revisions) (#145551) · 18340ea1

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/7cdb240c4a16...bad4a30e1c75

2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 2ed0d31938e3 to 72875d47dbc3 (1 revision) (flutter/engine#51582)
2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 5f32b063a869 to 2ed0d31938e3 (1 revision) (flutter/engine#51581)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18340ea1

Roll Packages from 23e56af4a622 to b7fbe68d4ec2 (3 revisions) (#145547) · dbf06373

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/packages/compare/23e56af4a622...b7fbe68d4ec2

2024-03-21 38110731+aliasgar4558@users.noreply.github.com [adaptive_scaffold] : ð #141938 - Drawer stays open even on destination tap. (flutter/packages#6289)
2024-03-20 43054281+camsim99@users.noreply.github.com [camera_android] Update README to encourage users to use CameraX implementation (flutter/packages#6353)
2024-03-20 engine-flutter-autoroll@skia.org Roll Flutter from d31a85ba to b96c13d1 (19 revisions) (flutter/packages#6359)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbf06373

Add WidgetsApp.debugShowWidgetInspectorOverride again (deprecated) (#145334) · 4bbe6d59

Pascal Welsch authored Mar 21, 2024

`WidgetsApp.debugShowWidgetInspectorOverride` was replaced with ` WidgetsBinding.instance.debugShowWidgetInspectorOverrideNotifier` in https://github.com/flutter/flutter/pull/144029.

The old API was removed, not deprecated.

It is used by some [open-source projects](https://github.com/search?q=WidgetsApp.debugShowWidgetInspectorOverride&type=code), thus I'm making the effort of bringing the API back as deprecated.

Fixes https://github.com/flutter/flutter/issues/145333

4bbe6d59

Reverts "Roll pub packages (#145509)" (#145550) · fd18e5ce

auto-submit[bot] authored Mar 21, 2024

Reverts: flutter/flutter#145509
Initiated by: yusuf-goog
Reason for reverting: Failing builds, blocking tree.
Original PR Author: flutter-pub-roller-bot

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
This PR was generated by `flutter update-packages --force-upgrade`.

fd18e5ce

Roll pub packages (#145509) · 5545c95d
flutter-pub-roller-bot authored Mar 21, 2024
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
5545c95d

Roll Flutter Engine from 14b67475cf80 to 7cdb240c4a16 (1 revision) (#145533) · 33380c6b

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/14b67475cf80...7cdb240c4a16

2024-03-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e825c7fcf59 to 5724c0dc7846 (1 revision) (flutter/engine#51580)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33380c6b

Roll Flutter Engine from 6de3d9b6196a to 14b67475cf80 (1 revision) (#145529) · 3bfa8291

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/6de3d9b6196a...14b67475cf80

2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 9c0e0b553c02 to 5f32b063a869 (1 revision) (flutter/engine#51579)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3bfa8291

Roll Flutter Engine from c0d3ac3178fa to 6de3d9b6196a (1 revision) (#145520) · 61657425

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/c0d3ac3178fa...6de3d9b6196a

2024-03-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 43662466cee8 to 5e825c7fcf59 (2 revisions) (flutter/engine#51577)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61657425

Roll Flutter Engine from 23dc0cacc4db to c0d3ac3178fa (1 revision) (#145519) · 4b046f10

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/23dc0cacc4db...c0d3ac3178fa

2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 1d0a90ac5a64 to 9c0e0b553c02 (2 revisions) (flutter/engine#51578)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4b046f10

Roll Flutter Engine from a73e01364de0 to 23dc0cacc4db (2 revisions) (#145517) · e077e157

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/a73e01364de0...23dc0cacc4db

2024-03-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uINhDrQ3fkTE08_he... to AW70sjrQKy2sSXpUA... (flutter/engine#51575)
2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 300e58020707 to 1d0a90ac5a64 (1 revision) (flutter/engine#51576)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uINhDrQ3fkTE to AW70sjrQKy2s

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e077e157

Roll Flutter Engine from 45ed36c17bb7 to a73e01364de0 (1 revision) (#145516) · 0e268b50

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/45ed36c17bb7...a73e01364de0

2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 0091e089fb24 to 300e58020707 (3 revisions) (flutter/engine#51574)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0e268b50

Roll Flutter Engine from 34b304a27f73 to 45ed36c17bb7 (1 revision) (#145513) · b88810d3

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/34b304a27f73...45ed36c17bb7

2024-03-21 skia-flutter-autoroll@skia.org Roll Skia from 3ffa395f8fbc to 0091e089fb24 (2 revisions) (flutter/engine#51564)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b88810d3

Roll Flutter Engine from 912c61f30512 to 34b304a27f73 (1 revision) (#145511) · 416a4b85

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/912c61f30512...34b304a27f73

2024-03-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 0f00e7188e0e to 43662466cee8 (1 revision) (flutter/engine#51572)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

416a4b85

Roll Flutter Engine from 98cfd9213332 to 912c61f30512 (1 revision) (#145504) · e95df006

engine-flutter-autoroll authored Mar 21, 2024

https://github.com/flutter/engine/compare/98cfd9213332...912c61f30512

2024-03-20 30870216+gaaclarke@users.noreply.github.com [golden_test_harvester]: Put back sending the dimensions to the SkiaGoldClient (flutter/engine#51536)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e95df006

Roll pub packages (#145476) · 61b3f975
flutter-pub-roller-bot authored Mar 21, 2024
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
61b3f975

20 Mar, 2024 7 commits

Roll Flutter Engine from fe6927c79dc3 to 98cfd9213332 (1 revision) (#145498) · 274152fc

engine-flutter-autoroll authored Mar 20, 2024

https://github.com/flutter/engine/compare/fe6927c79dc3...98cfd9213332

2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 715a74e907d7 to 3ffa395f8fbc (3 revisions) (flutter/engine#51563)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

274152fc

Roll Flutter Engine from d1fe8994dedf to fe6927c79dc3 (1 revision) (#145493) · a04b5571

engine-flutter-autoroll authored Mar 20, 2024

https://github.com/flutter/engine/compare/d1fe8994dedf...fe6927c79dc3

2024-03-20 jason-simmons@users.noreply.github.com Add the platform isolate API to the files included in the sky_engine package (flutter/engine#51538)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a04b5571

Add helper widget parameter to InputDecoration (#145157) · 01fc13d9

Vatsal Bhesaniya authored Mar 20, 2024

This pull request introduces a new field named `helper` to the InputDecoration class. This field allows for specifying a widget containing contextual information about the InputDecorator.child's value. Unlike `helperText`, which accepts a plain string, `helper` supports widgets, enabling functionalities like tappable links for further explanation. This change aligns with the established pattern of `error`, `label`, `prefix`, and `suffix`.

fixes [#145163](https://github.com/flutter/flutter/issues/145163)

01fc13d9

Remove embedding v1 code in framework (#144726) · 39bdff16

Gray Mackall authored Mar 20, 2024

Pre work for https://github.com/flutter/engine/pull/51229. Removes a lot of code referencing v1 of the android embedding, though not necessarily all of it (I may have missed some, it is hard to know).

Will hopefully make landing that PR less painful (or maybe painless?)

39bdff16

Roll Flutter Engine from 1b52f57ca07c to d1fe8994dedf (8 revisions) (#145491) · f9f77a48

engine-flutter-autoroll authored Mar 20, 2024

https://github.com/flutter/engine/compare/1b52f57ca07c...d1fe8994dedf

2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from ecfbdc3df797 to 715a74e907d7 (2 revisions) (flutter/engine#51557)
2024-03-20 kjlubick@users.noreply.github.com Migrate use of deprecated GrDirectContext::MakeMetal (flutter/engine#51537)
2024-03-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 1fec62355504 to 0f00e7188e0e (1 revision) (flutter/engine#51556)
2024-03-20 jonahwilliams@google.com [Impeller] add test that demonstrates that VVL failures are fatal. (flutter/engine#51525)
2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 4543913c6243 to ecfbdc3df797 (2 revisions) (flutter/engine#51555)
2024-03-20 34871572+gmackall@users.noreply.github.com Upgrade to gradle 8.3 (flutter/engine#51422)
2024-03-20 34871572+gmackall@users.noreply.github.com Add even more logging for UnsatisfiedLinkError (flutter/engine#51554)
2024-03-20 skia-flutter-autoroll@skia.org Roll Skia from 80e713052b7a to 4543913c6243 (2 revisions) (flutter/engine#51553)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f9f77a48

Roll Flutter Engine from f803f2adec54 to 1b52f57ca07c (1 revision) (#145479) · f6fea45b

engine-flutter-autoroll authored Mar 20, 2024

https://github.com/flutter/engine/compare/f803f2adec54...1b52f57ca07c

2024-03-20 34871572+gmackall@users.noreply.github.com Add more logging for UnsatisfiedLinkError (flutter/engine#51534)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f6fea45b

Reverts "Reland #128236 "Improve build output for all platforms" (#145376)" (#145487) · a01eac78

auto-submit[bot] authored Mar 20, 2024

Reverts: flutter/flutter#145376
Initiated by: loic-sharma
Reason for reverting: It caused the following post-submit failures:

1. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752928710548811665/+/u/run_run_release_test_windows/stdout
2. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752927564747697169/+/u/run_run_release_test_windows/stdout
Original PR Author: guidezpl

Reviewed By: {loic-sharma}

This change reverts the following previous change:
Reland #128236, reverted in https://github.com/flutter/flutter/pull/143125 and https://github.com/flutter/flutter/pull/145261.

This PR contains 3 additional commits, fixing post-submit tests on Android and Windows.

## Original description

Improves the build output:

1. Gives confirmation that the build succeeded, in green
1. Gives the path to the built executable, without a trailing period to make it slightly easier to cmd/ctrl+open
1. Gives the size of the built executable (when the built executable is self contained) 

### `apk`, `appbundle` 

<img width="607" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ecc52abe-cd2e-4116-b22a-8385ae3e980d">

<img width="634" alt="image" src="https://github.com/flutter/flutter/assets/6655696/8af8bd33-c0bd-4215-9a06-9652ee019436">

### `macos`, `ios`, `ipa`
Build executables are self-contained and use a newly introduced `OperatingSystemUtils.getDirectorySize`.

<img width="514" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b5918a69-3959-4417-9205-4f501d185257">

<img width="581" alt="image" src="https://github.com/flutter/flutter/assets/6655696/d72fd420-18cf-4470-9e4b-b6ac10fbcd50">

<img width="616" alt="image" src="https://github.com/flutter/flutter/assets/6655696/5f235ce1-252a-4c13-898f-139f6c7bc698">

### `windows`, `linux`, and `web`
Build executables aren't self-contained, and folder size can sometimes overestimate distribution size, therefore their size isn't mentioned (see discussion below).

<img width="647" alt="image" src="https://github.com/flutter/flutter/assets/6655696/7179e771-1eb7-48f6-b770-975bc073437b">

<img width="658" alt="image" src="https://github.com/flutter/flutter/assets/6655696/a6801cab-7b5a-4975-a406-f4c9fa44d7a2">

<img width="608" alt="image" src="https://github.com/flutter/flutter/assets/6655696/ee7c4125-a273-4a65-95d7-ab441edf8ac5">

### Size reporting
When applicable, the printed size matches the OS reported size.

- macOS
    <img width="391" alt="image" src="https://github.com/flutter/flutter/assets/6655696/881cbfb1-d355-444b-ab44-c1a6343190ce">
- Windows
    <img width="338" alt="image" src="https://github.com/flutter/flutter/assets/6655696/3b806def-3d15-48a9-8a25-df200d6feef7">
- Linux   
    <img width="320" alt="image" src="https://github.com/flutter/flutter/assets/6655696/89a4aa3d-2148-4f3b-b231-f93a057fee2b">

## Related issues
Part of #120127
Fixes https://github.com/flutter/flutter/issues/121401

a01eac78