Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
eaf509aa
Unverified
Commit
eaf509aa
authored
Mar 21, 2024
by
Michael Goderbauer
Committed by
GitHub
Mar 21, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Eliminate more window singleton usages (#145560)
These usages in strings slipped through the initial clean-up.
parent
31209d04
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
main
dev/integration_tests/ios_host_app/flutterapp/lib/main
+2
-2
break_on_framework_exceptions_test.dart
...integration.shard/break_on_framework_exceptions_test.dart
+1
-1
No files found.
dev/integration_tests/ios_host_app/flutterapp/lib/main
View file @
eaf509aa
...
@@ -36,12 +36,12 @@ void main() {
...
@@ -36,12 +36,12 @@ void main() {
// will be made to let us know when we should be changing the app state.
// will be made to let us know when we should be changing the app state.
_kReloadChannel.setMessageHandler(run);
_kReloadChannel.setMessageHandler(run);
// Start off with whatever the initial route is supposed to be.
// Start off with whatever the initial route is supposed to be.
run(ui.
window
.defaultRouteName);
run(ui.
PlatformDispatcher.instance
.defaultRouteName);
}
}
Future<String> run(String? name) async {
Future<String> run(String? name) async {
// The platform-specific component will call [setInitialRoute] on the Flutter
// The platform-specific component will call [setInitialRoute] on the Flutter
// view (or view controller for iOS) to set [ui.
window
.defaultRouteName].
// view (or view controller for iOS) to set [ui.
PlatformDispatcher
.defaultRouteName].
// We then dispatch based on the route names to show different Flutter
// We then dispatch based on the route names to show different Flutter
// widgets.
// widgets.
// Since we don't really care about Flutter-side navigation in this app, we're
// Since we don't really care about Flutter-side navigation in this app, we're
...
...
packages/flutter_tools/test/integration.shard/break_on_framework_exceptions_test.dart
View file @
eaf509aa
...
@@ -359,7 +359,7 @@ void main() {
...
@@ -359,7 +359,7 @@ void main() {
SchedulerBinding.instance!.addTimingsCallback((List<FrameTiming> timings) {
SchedulerBinding.instance!.addTimingsCallback((List<FrameTiming> timings) {
throw '
TimingsCallback
';
throw '
TimingsCallback
';
});
});
ui.
window
.onReportTimings!(<FrameTiming>[]);
ui.
PlatformDispatcher.instance
.onReportTimings!(<FrameTiming>[]);
'''
'''
);
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment