1. 15 Jun, 2018 1 commit
  2. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  3. 08 Jun, 2018 3 commits
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05
    • Chris Bracken's avatar
      Revert "It's time to #deleteDart1 (#18293)" (#18313) · 9495df4b
      Chris Bracken authored
      Several benchmarks started failing during kernel compile:
      1. Timeouts:
         * commands_test
         * hot_mode_dev_cycle__benchmark
         * run_machine_concurrent_hot_reload
         * service_extensions_test
      
      2. Kernel compiler crash:
         * hot_mode_dev_cycle_linux__benchmark
         * routing_test
      
      3. Unexpected termination:
         * hot_mode_dev_cycle_win__benchmark
      
      This reverts commit ed63e708.
      9495df4b
    • Chris Bracken's avatar
      It's time to #deleteDart1 (#18293) · ed63e708
      Chris Bracken authored
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      ed63e708
  4. 05 Jun, 2018 1 commit
  5. 24 May, 2018 1 commit
  6. 14 May, 2018 1 commit
  7. 09 May, 2018 1 commit
    • Chris Bracken's avatar
      Add caching for kernel compiles during AOT builds (#17439) · 5d8d14b7
      Chris Bracken authored
      We've always cached kernel compiles during bundle builds. This adds
      caching for kernel compiles during AOT builds by moving caching into the
      KernelCompiler.compile() method rather than around each invocation of it.
      
      This also filters buildbot paths included by the kernel compile that are
      not present on the local machine at paths /b/build/slave/Linux_Engine/...
      The kernel compiler should probably include an option to not emit these
      paths in the depfile, since these are used both by Gradle and the
      Fingerprinter class.
      5d8d14b7
  8. 08 May, 2018 1 commit
    • Chris Bracken's avatar
      Update kernel compile log message (#17390) · 671489ff
      Chris Bracken authored
      Updates the message emitted when a kernel compile is skipped in the
      build bundle action. Since we now use fingerprinting to enable
      performance of script snapshots, AOT snapshots, and kernel compiles,
      this helps a bit with debugging.
      
      Also switches to trace level logging.
      671489ff
  9. 04 May, 2018 1 commit
    • Chris Bracken's avatar
      Add Fingerprinter class (#17255) · 66c7b6a9
      Chris Bracken authored
      Adds a Fingerprinter utility class that can be used to compute unique
      fingerprints for a set of input paths and build options, compare to the
      output of a previous run, and skip the build action if no inputs or
      options have changed. The existing Fingerprint class still does all the
      heavy lifting. Fingerprinter adds common operations such as
      reading/writing/comparing fingerprints and parsing depfiles.
      
      This migrates existing uses of Fingerprint over to Fingerprinter.
      
      This also adds better fingerprinting to AOT snapshotting, which
      previously failed to include several options in its fingerprint
      (--preview-dart-2, --prefer-shared-library).
      66c7b6a9
  10. 01 May, 2018 1 commit
  11. 24 Apr, 2018 2 commits
  12. 12 Apr, 2018 3 commits
  13. 17 Mar, 2018 3 commits
  14. 16 Mar, 2018 2 commits
  15. 02 Mar, 2018 1 commit
  16. 14 Feb, 2018 2 commits
  17. 12 Feb, 2018 1 commit
  18. 08 Feb, 2018 1 commit
  19. 29 Jan, 2018 1 commit
    • Todd Volkert's avatar
      Extensibility improvements to flutter_tools (#14299) · 1859e82a
      Todd Volkert authored
      * Make the current command injected into the AppContext, allowing
        other classes to inject the current command.
      * Introduce `AssetBundleFactory`, an injected factory class for
        spawning instances of `AssetBundle`. This allows other run contexts
        to use custom asset bundling logic.
      * Clean up RunCommand by removing a 'packages' argument that duplicated
        a global argument by the same name (and for the same purpose).
        Duplicate arguments are confusing and error-prone.
      1859e82a
  20. 12 Jan, 2018 1 commit
  21. 11 Jan, 2018 4 commits
  22. 04 Jan, 2018 1 commit
    • Siva's avatar
      support for --strong option (#13859) · 426d6b06
      Siva authored
      * Plumb a --strong option through to the front end server and the engine
      so that we can run flutter apps in preview-dart-2 and strong mode
      
      * - Address analyzer lint issues
      *- correctly set up strong mode option in the case of AOT builds
      426d6b06
  23. 14 Dec, 2017 1 commit
  24. 10 Nov, 2017 1 commit
  25. 31 Aug, 2017 1 commit
  26. 29 Aug, 2017 1 commit
    • Chris Bracken's avatar
      Extract snapshotting logic to Snapshotter class (#11820) · 27d3e8a4
      Chris Bracken authored
      Extract a Snapshotter class that can be shared between FLX snapshotting,
      AOT snapshotting, and assembly AOT snapshotting. Allows for better
      testability of snapshotting logic.
      
      * Extracts script snapshotting used in FLX build.
      * Adds tests for snapshot checksumming, build invalidation/skipping.
      
      Remaining work: disentangle + extract AOT snapshotting and Assembly AOT
      snapshotting logic from build_aot.dart.
      27d3e8a4
  27. 28 Aug, 2017 1 commit
    • Chris Bracken's avatar
      Avoid rebuilding snapshots if no change to source (#11551) (#11793) · 1ee94001
      Chris Bracken authored
      This change re-introduces skipping AOT snapshot builds if input sources
      and outputs have not changed since the last snapshot build, assuming a
      build for the same platform in the same build mode.
      
      This reverts commit 3d5afb5a.
      It includes the following changes relative to the original:
        1. Include the entrypoint source in the checksums
        2. include the build mode in the checksums
        3. include the target platform in the checksums
      1ee94001
  28. 25 Aug, 2017 1 commit
    • Chris Bracken's avatar
      Add version, build mode to the snapshot checksums (#11787) · fd54bd4c
      Chris Bracken authored
      This change ensures that snapshot build checksums used to avoid
      duplicate builds are invalidated by a change to framework revision
      (in case gen_snapshot is updated), as well as by build mode.
      
      Currently, only FLX snapshotting uses checksums to avoid duplicate
      builds. FLX snapshotting is always done with BuildMode.debug, so didn't
      include build mode in the checksum file.
      fd54bd4c