1. 30 Oct, 2018 1 commit
  2. 24 Oct, 2018 2 commits
  3. 19 Oct, 2018 1 commit
    • Danny Tuppeny's avatar
      Switch to URIs for breakpoints and unskip tests on Windows (#22510) · f87a2a32
      Danny Tuppeny authored
      * Switch to URIs for breakpoints and unskip tests on Windows
      
      addBreakpointWithScriptUri expects Uris. By coincidence, FS paths work on Mac/Linux but they fail on Windows. One of the issues in the skip comment is fixed, the other one seems not relevant here.
      
      * Apply symlink resolution to all integration tests
      
      The default temp folders we get include symlinks which breaks breakpoints.
      
      * Save :rolling_eyes:
      
      * Fix typo
      f87a2a32
  4. 02 Oct, 2018 1 commit
  5. 01 Oct, 2018 1 commit
  6. 12 Sep, 2018 1 commit
  7. 06 Sep, 2018 2 commits
  8. 05 Sep, 2018 1 commit
  9. 31 Aug, 2018 1 commit
  10. 28 Aug, 2018 1 commit
    • Danny Tuppeny's avatar
      Don't time out if process terminates when told to stop (#21103) · 8b0227b4
      Danny Tuppeny authored
      * Don't time out if process terminates when told to stop but response was not processed
      
      While trying to reproduce #20822 I found a condition where the app may quit before the `app.stop` response is received but this code (which is called in integration test teardown) would sit around waiting and time out. With this change, the process exit is considered a valid response to the stop request.
      
      * Add process exit to log for better errors in failures
      
      This log can be turned on for debugging but is also dumped when a test fails (in certain conditions). With this in the log, it'll be clear if the timeout is because we're waiting for an event but the process quit.
      8b0227b4
  11. 22 Aug, 2018 2 commits
  12. 21 Aug, 2018 1 commit
  13. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  14. 02 Aug, 2018 1 commit
  15. 31 Jul, 2018 1 commit
  16. 27 Jul, 2018 1 commit
  17. 25 Jul, 2018 1 commit
  18. 23 Jul, 2018 1 commit
  19. 20 Jul, 2018 1 commit
  20. 19 Jul, 2018 2 commits
    • Danny Tuppeny's avatar
      Add `--machine` support for `flutter attach` (#19077) · ed9afbbc
      Danny Tuppeny authored
      * Extract some of startApp into a reusable method
      
      * Get basic attach --machine working
      
      * Attach --machine tweaks
      
      Move validation to validate method and create daemon early so we get the startup event before trying to get a connection.
      
      * Bump daemon version so we know whether it's valid to flutter attach
      
      * Tweak output text
      
      * Swap package imports for relative
      
      * Review tweaks (naming, formatting, typedefs)
      
      * Separate arguments from process spawning
      
      This will make calling attach easier
      
      * Add a basic test for flutter attach --machine
      
      * Fix crash if port unforward modifies the list of forwarded ports
      
      * Add a no-op port forwarder for flutter-tester
      
      * Switch to using BasicProject instead of our own inline code
      
      * Fix expectation in test now we have a portForwarder
      
      * Remove stale TODO (this is done)
      
      * Tweak formatting
      
      * Change some Completers to void to fix Dart 2 issues
      ed9afbbc
    • Danny Tuppeny's avatar
      Make cleanup of flutter processes in tests more reliable (#19307) · 442fc3cf
      Danny Tuppeny authored
      * Make cleanup of flutter processes in tests more reliable
      
      * Fix quit signals
      
      I confused SigInt&SigTerm for SigTerm&SigKill when I first did this. SigTerm can be blocked and doesn't guarantee the process will be terminated.
      
      * Don't use deprecated constants
      
      * Fix typo
      
      * Add some additional info to debug buffer
      
      * Fix return types on Futures
      442fc3cf
  21. 16 Jul, 2018 2 commits
  22. 12 Jul, 2018 3 commits
    • Danny Tuppeny's avatar
      Ensure timeouts in flutter_tools integration tests include all messages received (#19253) · 1363bd17
      Danny Tuppeny authored
      * Allow a longer timeout for app launches
      
      * Include timings in errors when waiting for events
      
      * Extract a helper that adds a timeout and includes message logging
      
      * Ensure all timeouts include messages
      
      * Ensure logs are set up before we invoke actions
      
      * Ensure all messages are logged during timeout periods
      
      This adds a new stream _allMessages that collects all output (as routed through debugPrint) and updates _timeoutWithMessages to use that instead of stdin/out of only the flutter run process (since that was missing stdin - the sends, and both input/output to the VM service).
      1363bd17
    • Alexander Aprelev's avatar
      Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart... · cc122f16
      Alexander Aprelev authored
      Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)
      
      This reverts commit 700cb767 as it
      breaks Windows tests.
      cc122f16
    • Alexander Aprelev's avatar
      Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277) · 700cb767
      Alexander Aprelev authored
      * Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)"
      
      This reverts commit cf932490 as it also
      includes fix for type error that broke tests.
      
      * Add type cast for dart2 type checks.
      
      * Move up to latest goldens
      
      * Make inDirectory() type-parameterized.
      
      * Add typecasting to transitions_perf_test.dart and microbenchmarks.
      
      * Add boolean flag initialization in save_catalog_screenshots.dart
      
      * Add type conversion to gallery transition test
      700cb767
  23. 11 Jul, 2018 2 commits
  24. 10 Jul, 2018 1 commit
    • Danny Tuppeny's avatar
      Improve flutter tools integration tests (#18865) · b931640c
      Danny Tuppeny authored
      * Rename util -> test_utils
      
      * Rename flutter_test_driver -> test_driver
      
      * Switch testWithContext -> test
      
      * Remove unused import
      
      * Move test project into a class to make it easier to have multiple of these
      
      Each "TestProject" class can contain its files and things like named breakpoint locations.
      
      * Split expression evaluation tests into own file
      
      * Include last response in error messages
      
      * Update expectations based on current bugs
      
      * Fix async-ness in tests
      
      * Fix incorrect expectation in test
      
      * Fix incorrect evaluations
      
      * Remove skips for tests that are now passing on master
      
      * Expect pass on Linux
      
      :shrug:‍♂️
      
      * Call the code
      
      * Skip expression evaluation tests on Windows
      
      * Skip whole group, not just one test
      
      * Remove duplicated method from merge
      
      * Fix misplaced close of group
      
      * Remove code that was duplicated from test we copied
      
      Not sure how this ended up in here?
      
      * Re-fix typo
      b931640c
  25. 09 Jul, 2018 1 commit
  26. 27 Jun, 2018 1 commit